[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

modocache updated this revision to Diff 214370. modocache added a comment. Thanks for the review, @vsk! Sorry it took me so long to update this diff. In the mailing list discussion, http://lists.llvm.org/pipermail/llvm-dev/2018-March/121925.html, you mentioned that I should use an allow-list of

[PATCH] D65149: [Format] Add test demonstrating PR42722

modocache added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5184 + "c++;\n" + "d++\n" + " });\n" MyDeveloperDay wrote: > modocache wrote: > > This is a passing test that demonstrates that t

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL368675: [CodeGen] Disable UBSan for coroutine functions (authored by modocache, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

modocache added a comment. Thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44672/new/ https://reviews.llvm.org/D44672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache added a comment. Thanks @rsmith for the guidance here! I appreciate it very much. One snag I ran into after following your suggestion, though, is that when I modify `ASTDeclReader::findExisting` to return Sema's existing implicit std namespace, I run into an assertion later on, when t

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache updated this revision to Diff 199708. modocache added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Thanks for the help, @rsmith! Your suggestions were spot-on. (It took me a little while to figure out why, even using the `LazyDeclPtr` directly, I was

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache updated this revision to Diff 199709. modocache added a comment. Oops, sent the patch from the wrong repository. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58920/new/ https://reviews.llvm.org/D58920 Files: lib/Serialization/ASTReaderDecl.cpp tes

[PATCH] D62035: [AST] const-ify ObjC inherited class search

modocache created this revision. modocache added a reviewer: rjmccall. Herald added a project: clang. When writing an AST matcher to find inherited Objective-C classes, I noticed the returned `ObjCInterfaceDecl*` was mutable. It doesn't seem like it needs to be mutable, so this patch makes it cons

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache updated this revision to Diff 200518. modocache added a comment. Hmm... alright, I'm not really sure how I could implement a test that fails without this, but I added a check in the FindExistingResult destructor. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache added a comment. @rsmith, what do you think of the patch as-is? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58920/new/ https://reviews.llvm.org/D58920 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda

modocache created this revision. modocache added reviewers: GorNishanov, EricWF, lewissbaker, tks2103. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=41909 describes an issue in which a generic lambda that takes a dependent argument `auto set` causes the template instantiatio

[PATCH] D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size

modocache created this revision. modocache added reviewers: GorNishanov, lewissbaker, tks2103. Herald added subscribers: cfe-commits, kristina, EricWF. This commit implements a proposed addendum to the C++ Coroutines TS that would allow users to query, at compile time, the maximum potential size o

[PATCH] D56271: [SemaCXX] Fix ICE for unexpanded parameter pack

modocache created this revision. modocache added a reviewer: rsmith. The documentation for RecursiveASTVisitor::TraverseDecl states that the Decl being traversed may be null. In fact, this is the case when a CXXCatchStmt with no exception decl is traversed. Because the visitor for diagnosing unexp

[PATCH] D56271: [SemaCXX] Fix ICE for unexpanded parameter pack

This revision was automatically updated to reflect the committed changes. Closed by commit rL350501: [SemaCXX] Fix ICE for unexpanded parameter pack (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D56271: [SemaCXX] Fix ICE for unexpanded parameter pack

modocache added a comment. Thank you for the review! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56271/new/ https://reviews.llvm.org/D56271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D56509: [AST] Remove ASTContext from getThisType (NFC)

modocache created this revision. modocache added reviewers: akyrtzi, mikael. Herald added subscribers: dexonsmith, mehdi_amini. https://reviews.llvm.org/D54862 removed the usages of `ASTContext&` from within the `CXXMethodDecl::getThisType` method. Remove the parameter altogether, as well as all u

[PATCH] D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size

modocache updated this revision to Diff 180903. modocache added a comment. Thanks for the offline review @GorNishanov! This revision allows constexpr usages of __builtin_coro_frame_max_size. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56243/new/ https://review

[PATCH] D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size

modocache updated this revision to Diff 180905. modocache added a comment. Remove obsoleted code I accidentally included. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56243/new/ https://reviews.llvm.org/D56243 Files: include/clang/AST/ASTContext.h include/c

[PATCH] D56509: [AST] Remove ASTContext from getThisType (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rC350914: [AST] Remove ASTContext from getThisType (NFC) (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D56509?vs=180893&id=181200#toc Repository: rC Clang C

[PATCH] D65043: [Format] Add C++20 standard to style options

modocache abandoned this revision. modocache added a comment. Oh, thank you! Yes, I had been meaning to abandon this and my other patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65043/new/ https://reviews.llvm.org/D65043 ___

[PATCH] D65044: [Format] Add option to enable coroutines keywords

modocache abandoned this revision. modocache added a comment. I work on a C++17 codebase with coroutines enabled, but yes just formatting the codebase as if it were C++20 seems fine. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65044/new/

[PATCH] D45860: [Coroutines] Catch exceptions in await_resume

modocache created this revision. modocache added reviewers: GorNishanov, EricWF. http://wg21.link/P0664r2 section "Evolution/Core Issues 24" describes a proposed change to Coroutines TS that would have any exceptions thrown after the initial suspend point of a coroutine be caught by the handler sp

[PATCH] D41980: Add tests for llvm-bcanalyzer stream types

modocache updated this revision to Diff 143458. modocache added a comment. Herald added a reviewer: george.karpenkov. Added `-fmodule-format=raw`. Repository: rC Clang https://reviews.llvm.org/D41980 Files: test/Misc/serialized-diags-bcanalyzer.c test/PCH/include-stream-type.cpp Index:

[PATCH] D41980: Add tests for llvm-bcanalyzer stream types

This revision was automatically updated to reflect the committed changes. Closed by commit rC330530: Add tests for llvm-bcanalyzer stream types (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D41980?vs=143458&id=143464#toc Repository: rC Clang https

[PATCH] D45860: [Coroutines] Catch exceptions in await_resume

modocache updated this revision to Diff 144908. modocache added a comment. Thanks for the review, @GorNishanov. Here's a more correct solution: an i1 is used to keep track of whether await_resume threw. If it did, the coroutine body is skipped, and we go straight to the final suspend point. Othe

[PATCH] D45860: [Coroutines] Catch exceptions in await_resume

modocache updated this revision to Diff 144961. modocache added a comment. Oops, thanks for testing on release mode, @GorNishanov. Turns out I had a dangling pointer. With this update the tests pass on both release and debug. Repository: rC Clang https://reviews.llvm.org/D45860 Files: lib

[PATCH] D45860: [Coroutines] Catch exceptions in await_resume

This revision was automatically updated to reflect the committed changes. Closed by commit rC331519: [Coroutines] Catch exceptions in await_resume (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D45860?vs=144961&id=145188#toc Repository: rC Clang ht

[PATCH] D45860: [Coroutines] Catch exceptions in await_resume

modocache added a comment. Thanks again for all the reviews, @GorNishanov! Very much appreciated. Comment at: lib/CodeGen/CGCoroutine.cpp:220 CGF.EmitBlock(ReadyBlock); + CXXTryStmt *TryStmt = nullptr; + if (Coro.ExceptionHandler && Kind == AwaitKind::Init) { -

[PATCH] D48863: [Sema] Explain coroutine_traits template in diag

modocache created this revision. modocache added reviewers: GorNishanov, EricWF. If a user defines a coroutine_traits type that takes an incorrect number of template parameters, or for some reason they include such a type in their program, they receive a cryptic error message: "too few template ar

[PATCH] D48863: [Sema] Explain coroutine_traits template in diag

modocache updated this revision to Diff 153956. modocache added a comment. Oops, apologies, I included a line I shouldn't have in the previous diff. Repository: rC Clang https://reviews.llvm.org/D48863 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/Se

[PATCH] D48863: [Sema] Explain coroutine_traits template in diag

modocache added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9053 "a coroutine">; +def note_coroutine_types_for_traits_here : Note< + "the coroutine traits class template is being instantiated using the return " GorNishanov wrote: >

[PATCH] D48981: Add caching when looking up coroutine_traits

modocache resigned from this revision. modocache added a comment. This LGTM but I'll just wait for @GorNishanov to accept the patch, just in case I'm missing something. I'd be happy to commit this for you once Gor accepts! :) Repository: rC Clang https://reviews.llvm.org/D48981 __

[PATCH] D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Excellent, thanks! Repository: rC Clang https://reviews.llvm.org/D49099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug

modocache added a comment. If you don't have commit access, let me know here if you'd like me to commit this on your behalf. Repository: rC Clang https://reviews.llvm.org/D49099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug

This revision was automatically updated to reflect the committed changes. Closed by commit rC336748: Remove qualtype qualifier in coroutine error to prevent assert in debug (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D49099?vs=154692&id=154910#toc

[PATCH] D48981: Add caching when looking up coroutine_traits

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Yup, LGTM! I'll land this now. Repository: rC Clang https://reviews.llvm.org/D48981 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D48981: Add caching when looking up coroutine_traits

This revision was automatically updated to reflect the committed changes. Closed by commit rL337103: Add caching when looking up coroutine_traits (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48981 Files: cfe/t

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

modocache added a subscriber: lewissbaker. modocache added a comment. > Is that maybe intentional, and is the code not intended to compile? It looks like it should work to me, but maybe @lewissbaker or @GorNishanov can answer definitively. Comment at: cfe/trunk/lib/Sema/SemaC

[PATCH] D69144: [Format] Add format check for throwing negative numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f704320b058: [Format] Add format check for throwing negative numbers (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69144/new/ http

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Excellent, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/ https://reviews.llvm.org/D82928 __

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.org/D82986 __

[PATCH] D83788: Removed unused variable in clang

modocache added a comment. This LGTM! Looks like the last time this variable was touched was in 2010 as part of a mechanical renaming, https://github.com/llvm/llvm-project/commit/a771f46c82d7. At that point it was used, as a parameter to the static function `MakeObjCStringLiteralFixItHint`. Th

[PATCH] D83788: Removed unused variable in clang

modocache added a comment. By the way, I tried to accept this diff and leave the following inline comment on `SemaExpr.cpp:15799`: > I guess this assert was never capable of being hit previously, since the > `FixItHint::isNull` would always return true? I wonder if we'll now see some > genuine

[PATCH] D83788: Removed unused variable in clang

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. No problem, thanks for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-comm

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

modocache added a reviewer: junparser. modocache added a subscriber: junparser. modocache added a comment. Excellent, thank you! The test failures on the diff appear to be legitimate, they reproduce for me when I apply this patch to my local checkout and run `ninja check-clang`. Could you take a

[PATCH] D81885: [Coroutines] Return false on error of buildSuspends

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. I don't have a preference as to whether `Sema::ActOnCoroutineBodyStart` returns `true` or `false` to indicate failure, although I think returning `true` for failures is a bit o

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Sweet! Thanks for the reviews/responses, LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/ https://reviews.llvm.org/D82029

[PATCH] D82332: [Coroutines] Handle dependent promise types for final_suspend non-throw check

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82332/new/ https://reviews.llvm.org/D82332 ___

[PATCH] D36492: [RFC][time-report] Add preprocessor timer

modocache created this revision. `gcc -ftime-report` provides a breakdown of how much time GCC spends doing preprocessing, parsing, template instantiation, and more: g++ -ftime-report foo.cpp Execution times (seconds) phase setup : 0.00 ( 0%) usr 0.00 ( 0%) sys 0.00 ( 0%)

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

modocache created this revision. Add documentation for `clang::ParseAST` parameters `PrintStats` and `SkipFunctionBodies`. Also, remove a tiny bit of trailing whitespace. https://reviews.llvm.org/D36530 Files: include/clang/Parse/ParseAST.h Index: include/clang/Parse/ParseAST.h

[PATCH] D36531: [Parse] Document Parser::SkipFunctionBodies

modocache created this revision. https://reviews.llvm.org/D36531 Files: include/clang/Parse/Parser.h Index: include/clang/Parse/Parser.h === --- include/clang/Parse/Parser.h +++ include/clang/Parse/Parser.h @@ -253,6 +253,10 @@

[PATCH] D36492: [RFC][time-report] Add preprocessor timer

modocache added a reviewer: vsk. modocache planned changes to this revision. modocache added a comment. Thanks for the feedback, @vsk, I really appreciate it! I have some other work done for this on my local checkout, but I was going a little bonkers working on it without knowing whether people

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

modocache added a comment. Oops, sorry. I couldn't find anyone recent in the commit history. I hope no one minds if I just go ahead and commit this. https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

This revision was automatically updated to reflect the committed changes. Closed by commit rL310609: [Parse] Document PrintStats, SkipFunctionBodies (authored by modocache). Repository: rL LLVM https://reviews.llvm.org/D36530 Files: cfe/trunk/include/clang/Parse/ParseAST.h Index: cfe/trun

[PATCH] D36531: [Parse] Document Parser::SkipFunctionBodies

This revision was automatically updated to reflect the committed changes. Closed by commit rL310627: [Parse] Document Parser::SkipFunctionBodies (authored by modocache). Repository: rL LLVM https://reviews.llvm.org/D36531 Files: cfe/trunk/include/clang/Parse/Parser.h Index: cfe/trunk/incl

[PATCH] D36492: [time-report] Add preprocessor timer

modocache updated this revision to Diff 95. modocache retitled this revision from "[RFC][time-report] Add preprocessor timer" to "[time-report] Add preprocessor timer". modocache edited the summary of this revision. modocache removed subscribers: vsk, mzolotukhin. modocache added a comment. A

[PATCH] D36492: [time-report] Add preprocessor timer

modocache added subscribers: vsk, mzolotukhin. modocache added a comment. Oops, sorry, didn't mean to remove the subscribers. `arc diff --verbatim` strikes again. https://reviews.llvm.org/D36492 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D36492: [time-report] Add preprocessor timer

modocache added a comment. Friendly ping! I think this is ready to be reviewed. It adds an additional row, `Preprocessing`, to the `Miscellaneous Ungrouped Timers` section of the `clang -ftime-report` output: ===-===

[PATCH] D36492: [time-report] Add preprocessor timer

modocache planned changes to this revision. modocache added inline comments. Comment at: lib/Lex/Preprocessor.cpp:746 void Preprocessor::Lex(Token &Result) { + llvm::TimeRegion(PPOpts->getTimer()); + erik.pilkington wrote: > Doesn't this just start a timer and

[PATCH] D36848: [CodeGen] Use RefCntTimer to time IR generation

modocache created this revision. Use the reference-counted timer abstraction from https://reviews.llvm.org/D36847 instead of manually keeping track of the number of times `startTimer()` and `stopTimer()` should be called. Test plan: Run `clang -ftime-report` and confirm the time measurements are

[PATCH] D36492: [time-report] Add preprocessor timer

modocache added inline comments. Comment at: include/clang/Lex/PreprocessorOptions.h:165 public: - PreprocessorOptions() : UsePredefines(true), DetailedRecord(false), + PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"), + UsePredefines(t

[PATCH] D36848: [CodeGen] Use reentrant methods to time IR gen

modocache updated this revision to Diff 112187. modocache retitled this revision from "[CodeGen] Use RefCntTimer to time IR generation" to "[CodeGen] Use reentrant methods to time IR gen". modocache edited the summary of this revision. modocache added a comment. Use `startReentrantTimer` and `sto

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache marked an inline comment as done. modocache added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass())); + MPM.addPass(createModuleToFunctionPassAdaptor(CoroElidePas

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache planned changes to this revision. modocache marked 2 inline comments as done and an inline comment as not done. modocache added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitP

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache added a comment. I'm currently working on ensuring that CGSCC optimizations are rerun to optimize coroutine funclets -- the primary feedback I received on this and on D71899 -- but I just realized I didn't respond to one comment on this set of reviews

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236245. modocache removed a subscriber: wenlei. modocache added a comment. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Thanks for the reviews. Based on my latest revision of D71899 , the coro-split di

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236889. modocache added a comment. Update tests -- we now re-run the SCC pass, but don't insert the coroutine funclets into the SCC, so we no longer see the funclets in the output being tested here. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236967. modocache added a comment. Initialize PipelineTuningOptions properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: clang/lib/CodeGen/BackendUtil.c

[PATCH] D70555: [coroutines] Don't build promise init with no args

modocache added a comment. Of course, your approval is very welcome! 😄 I'll go ahead and land this today, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://reviews.llvm.org/D70555 __

[PATCH] D70555: [coroutines] Don't build promise init with no args

This revision was automatically updated to reflect the committed changes. Closed by commit rG627e01feb718: [coroutines] Don't build promise init with no args (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://r

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG048239e46e49: [Coroutines][6/6] Clang schedules new passes (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache created this revision. modocache added reviewers: rsmith, RKSimon, aaron.ballman, wenlei. Herald added a project: clang. A closed-source C++ codebase I help maintain began hitting a Clang ICE with a stack trace that referenced `clang::OverloadCandidate::getNumParams`: https://gist.github

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache marked an inline comment as done. modocache added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:7371 return; } @rsmith I'd definitely appreciate any pointers here -- if initializing `IsSurrogate` with a value as I do in this pa

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache updated this revision to Diff 227808. modocache added a comment. Rebasing onto the monorepo. @rsmith, I confirmed the test cases that this diff adds still fail on trunk, and that the Clang source changes made in this diff fix the test case failures. Tomorrow I plan on poking around to

[PATCH] D70555: [coroutines] Don't build promise init with no args

modocache created this revision. modocache added reviewers: GorNishanov, rsmith, lewissbaker. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. modocache edited the summary of this revision. In the case of a coroutine that takes no arguments, `Sema::buildCoroutinePromis

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. Sorry for the slow response here, @junparser! The test case you came up with here is great! I can see the issue is that `ScopeInfo->CoroutineParameterMoves` are built up when C

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache created this revision. modocache added reviewers: GorNishanov, rsmith, lewissbaker. Herald added a subscriber: EricWF. Herald added a project: clang. In https://reviews.llvm.org/D62550 @rsmith pointed out that there are many situations in which a coroutine body statement may be transform

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. LGTM, thanks! Please let me know if you'd like me to commit this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022

[PATCH] D62035: [AST] const-ify ObjC inherited class search

modocache abandoned this revision. modocache added a comment. I'm not super interested in this patch anymore, someone else feel free to work on this! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62035/new/ https://reviews.llvm.org/D62035 _

[PATCH] D59765: [Lex] Warn about invisible Hangul whitespace

modocache abandoned this revision. modocache added a comment. I'm not super interested in this patch anymore, someone else feel free to work on this! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59765/new/ https://reviews.llvm.org/D59765 _

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. LGTM! Let me know if you'd like me to commit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69180/new/ https://reviews.llvm.or

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b3d1d1348da: [coroutines] Remove assert on CoroutineParameterMoves in Sema… (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache added a comment. Thanks again for the patch @junparser! And sorry the review took so long! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 ___ cfe-com

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8682d29a2877: [Format] Add format check for coroutine keywords with negative numbers (authored by modocache). Changed prior to commit: https://reviews.llvm.org/D69180?vs=225672&id=231596#toc Repository

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

modocache added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1761 + tok::kw_case, tok::at, tok::l_brace, tok::kw_throw, + tok::kw_co_return, tok_kw_co_yield)) return TT_UnaryOperator;

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache added a comment. @GorNishanov, @rsmith, friendly ping! @rsmith this patch addresses your requests from https://reviews.llvm.org/D62550. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://reviews.llvm.org/D70579 _

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

modocache added a comment. This seems like a outright improvement, but as mentioned above it would be nice to get @rsmith's take on it since I'm not an expert. Two nitpicks, though: 1. Could you please run clang-format on the lines you added/modified? 2. Could you apply these changes on top of t

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

This revision was automatically updated to reflect the committed changes. Closed by commit rG376cf43729c8: [coroutines][PR41909] Generalize fix from D62550 (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://rev

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache added a comment. Thanks for the review! Much appreciated :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://reviews.llvm.org/D70579 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D71542: [coroutines][PR41909] don't build dependent coroutine statements if the coroutine still has a dependent promise type

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. Great minds think alike! This looks like the patch I sent in November, D70579 . I only just committed it two days ago in rG376cf43

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

modocache requested changes to this revision. modocache added subscribers: jroelofs, echristo. modocache added a comment. This revision now requires changes to proceed. Grepping for "dump-tokens", I can see one regression test that exercises this option: clang/test/Lexer/dollar-idents.c. "dump-co

[PATCH] D71731: [Format] fix dereference of pointers in co_yeld and co_return statements

modocache added a comment. Nice! Thanks for this. This looks good to me, but I'll defer to the other reviewers you specified, since I think they're more familiar with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71731/new/ https://r

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

modocache added a subscriber: mehdi_amini. modocache added a comment. Ah, I'm sorry I wasn't clear -- instead of changing a lot of tests to use the new names exclusively, my suggestion was to change one or two tests to use the new canonical name, and have the remaining tests keep using the alias

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache created this revision. modocache added reviewers: GorNishanov, lewissbaker, chandlerc, junparser. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. Depends on https://reviews.llvm.org/D71902. The last in a series of six patches that ports the LLVM coroutines

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache added a comment. Friendly ping! `OverloadCandidate` has uninitialized members and so can cause UB if used incorrectly in another part of the compiler, so I feel this is a fairly straightforward patch: prevent UB by initializing all members. But I'd like some review to confirm. @rsmith

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache abandoned this revision. modocache added a comment. Awesome, thanks! > Alternatively, I considered modifying the `clang::OverloadCandidate` > constructor to initialize `IsSurrogate` with a false value. I feel doing so > would be safer, but I stuck with what appears to be the conventio

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

modocache added a comment. I may be wrong, but I believe this breaks `check-llvm` when run with the following configuration: `cmake -DLLVM_BINUTILS_INCDIR=/path/to/binutils/include`: Failing Tests (6): LLVM :: tools/gold/X86/common_thinlto.ll LLVM :: tools/gold/X86/emit-llvm.ll

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

modocache added a comment. Awesome, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 244566. modocache added a comment. Clean up coroutine intrinsics as part of the ThinLTO pre-link pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: cl

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 245054. modocache removed a reviewer: wenlei. modocache removed subscribers: wenlei, hiraditya. modocache removed a project: LLVM. modocache added a comment. Rebase on top of the latest version of D71902 . Repository: rG

<    1   2   3   >