modocache updated this revision to Diff 31376.
modocache added a comment.
Rebase onto master.
http://reviews.llvm.org/D2916
Files:
bindings/python/tests/cindex/test_index.py
bindings/python/tests/cindex/test_translation_unit.py
bindings/python/tests/cindex/util.py
Index: bindings/python/
Author: modocache
Date: Sat May 19 04:46:58 2018
New Revision: 332804
URL: http://llvm.org/viewvc/llvm-project?rev=332804&view=rev
Log:
[Driver] Loosen test for LLVM findNearest
Summary:
When https://reviews.llvm.org/D46776 landed to improve the behavior of
`llvm::OptTable::findNearest`, a PS4 bu
Author: modocache
Date: Sat May 19 05:44:02 2018
New Revision: 332806
URL: http://llvm.org/viewvc/llvm-project?rev=332806&view=rev
Log:
[Driver] Temporarily remove test for LLVM findNearest
Summary:
This fixes a failure caused by the revert of https://reviews.llvm.org/rL332805.
Modified:
cf
Author: modocache
Date: Mon Sep 3 09:55:02 2018
New Revision: 341327
URL: http://llvm.org/viewvc/llvm-project?rev=341327&view=rev
Log:
Removing -debug-info-macros from option suggestions test
Summary:
https://reviews.llvm.org/D46776 added better support for prefixes for the
"did you mean ...?" c
Author: modocache
Date: Thu Feb 15 12:09:25 2018
New Revision: 325288
URL: http://llvm.org/viewvc/llvm-project?rev=325288&view=rev
Log:
[Sema] Toggle diags when finding allocators (NFCI)
Summary:
Many methods in Sema take a `bool Diagnose` parameter. Examples of such
methods include `Sema::FindDe
Author: modocache
Date: Thu Feb 15 12:37:22 2018
New Revision: 325291
URL: http://llvm.org/viewvc/llvm-project?rev=325291&view=rev
Log:
[Coroutines] Use allocator overload when available
Summary:
Depends on https://reviews.llvm.org/D42605.
An implementation of the behavior described in `[dcl.fct
> tools/clang/test/SemaCXX/coroutines.cpp:838): candidate function not
> viable: requires 4 arguments, but 1 was provided
> 8 errors generated.
>
> Can you take a look?
>
> Douglas Yung
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commi
Ah I'm sorry, I've reproduced this with a `-triple armeb-none-eabi`
argument. Douglas, do you mind if I fix forward?
- Brian
On Fri, Feb 16, 2018 at 8:55 AM, Brian Gesiak wrote:
> Hi Douglas, thanks for letting me know. I'm looking into this now.
>
> At first these erro
Author: modocache
Date: Fri Feb 16 06:11:27 2018
New Revision: 325342
URL: http://llvm.org/viewvc/llvm-project?rev=325342&view=rev
Log:
[Coroutines] Use target-agnostic size_t in test
Summary:
Fix a test failure on ARM hosts that was caused by a difference in the type of
size_t, by using a target
This should be fixed in https://reviews.llvm.org/rL325342. Thanks for your
help!
- Brian
On Fri, Feb 16, 2018 at 9:07 AM, Brian Gesiak wrote:
> Ah I'm sorry, I've reproduced this with a `-triple armeb-none-eabi`
> argument. Douglas, do you mind if I fix forward?
>
> - Br
Author: modocache
Date: Thu Jun 22 21:38:45 2017
New Revision: 306079
URL: http://llvm.org/viewvc/llvm-project?rev=306079&view=rev
Log:
[Frontend] 'Show hotness' can be used with a sampling profile
Summary:
Prior to this change, using `-fdiagnostics-show-hotness` with a sampling
profile specified
Author: modocache
Date: Fri Jan 5 16:25:40 2018
New Revision: 321917
URL: http://llvm.org/viewvc/llvm-project?rev=321917&view=rev
Log:
[Driver] Suggest correctly spelled driver options
Summary:
Depends on https://reviews.llvm.org/D41732.
Utilities such as `opt`, when invoked with arguments that
Author: modocache
Date: Tue Jan 9 13:26:47 2018
New Revision: 322118
URL: http://llvm.org/viewvc/llvm-project?rev=322118&view=rev
Log:
[Frontend] Remove unused FileMgr in pp arg parse
Summary:
A FIXME added 8 years ago (2010) in https://reviews.llvm.org/rL118203
mentioned that a FileManager shou
Author: modocache
Date: Wed Jan 10 12:23:45 2018
New Revision: 30
URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev
Log:
[Driver] Test for correct '--version' suggestion
Summary:
The `llvm::OptTable::findNearest` bug fixed in
https://reviews.llvm.org/D41873 manifested itself as the
Author: modocache
Date: Sat Jun 23 11:01:02 2018
New Revision: 335420
URL: http://llvm.org/viewvc/llvm-project?rev=335420&view=rev
Log:
[Sema] isValidCoroutineContext FIXME and citations
Summary:
Add citations to the Coroutines TS to the `isValidCoroutineContext`
function, as well as a FIXME and
Author: modocache
Date: Sat Jun 23 11:57:26 2018
New Revision: 335422
URL: http://llvm.org/viewvc/llvm-project?rev=335422&view=rev
Log:
[Coroutines] Less IR for noexcept await_resume
Summary:
In his review of https://reviews.llvm.org/D45860, @GorNishanov suggested
avoiding generating additional e
Author: modocache
Date: Thu Jan 10 18:12:31 2019
New Revision: 350916
URL: http://llvm.org/viewvc/llvm-project?rev=350916&view=rev
Log:
Adapt to CXXMethodDecl::getThisType change (NFC)
Summary:
https://reviews.llvm.org/D56509 changed the API of the
CXXMethodDecl::getThisType method. Adapt to the
Author: modocache
Date: Sat Nov 3 15:35:17 2018
New Revision: 346074
URL: http://llvm.org/viewvc/llvm-project?rev=346074&view=rev
Log:
[coroutines] Fix fallthrough warning on try/catch
Summary:
The test case added in this diff would incorrectly warn that control
flow may fall through without ret
Author: modocache
Date: Fri Mar 15 13:25:49 2019
New Revision: 356296
URL: http://llvm.org/viewvc/llvm-project?rev=356296&view=rev
Log:
[coroutines][PR40978] Emit error for co_yield within catch block
Summary:
As reported in https://bugs.llvm.org/show_bug.cgi?id=40978, it's an
error to use the `c
Author: modocache
Date: Fri Mar 22 09:08:29 2019
New Revision: 356774
URL: http://llvm.org/viewvc/llvm-project?rev=356774&view=rev
Log:
Revert "[coroutines][PR40978] Emit error for co_yield within catch block"
The commit https://reviews.llvm.org/rC356296 is causing a regression in nested
catch sc
Author: modocache
Date: Sun Mar 24 17:53:10 2019
New Revision: 356865
URL: http://llvm.org/viewvc/llvm-project?rev=356865&view=rev
Log:
Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Summary:
https://reviews.llvm.org/D59076 added a new coroutine error that
prevented
Author: modocache
Date: Sun Oct 7 20:08:39 2018
New Revision: 343949
URL: http://llvm.org/viewvc/llvm-project?rev=343949&view=rev
Log:
[coro]Pass rvalue reference for named local variable to return_value
Summary:
Addressing https://bugs.llvm.org/show_bug.cgi?id=37265.
Implements [class.copy]/33
Author: modocache
Date: Thu Jan 31 19:30:29 2019
New Revision: 352831
URL: http://llvm.org/viewvc/llvm-project?rev=352831&view=rev
Log:
[SemaCXX] Param diagnostic matches overload logic
Summary:
Given the following test program:
```
class C {
public:
int A(int a, int& b);
};
int C::A(const in
Author: modocache
Date: Sun Jun 2 17:47:32 2019
New Revision: 362348
URL: http://llvm.org/viewvc/llvm-project?rev=362348&view=rev
Log:
[coroutines][PR41909] Don't build dependent coroutine statements for generic
lambda
Summary:
https://bugs.llvm.org/show_bug.cgi?id=41909 describes an issue in w
Author: modocache
Date: Tue Aug 13 05:02:25 2019
New Revision: 368675
URL: http://llvm.org/viewvc/llvm-project?rev=368675&view=rev
Log:
[CodeGen] Disable UBSan for coroutine functions
Summary:
As explained in http://lists.llvm.org/pipermail/llvm-dev/2018-March/121924.html,
the LLVM coroutines tra
Author: modocache
Date: Sun Jan 6 19:25:59 2019
New Revision: 350501
URL: http://llvm.org/viewvc/llvm-project?rev=350501&view=rev
Log:
[SemaCXX] Fix ICE for unexpanded parameter pack
Summary:
The documentation for RecursiveASTVisitor::TraverseDecl states that the
Decl being traversed may be null
Author: modocache
Date: Thu Jan 10 17:54:53 2019
New Revision: 350914
URL: http://llvm.org/viewvc/llvm-project?rev=350914&view=rev
Log:
[AST] Remove ASTContext from getThisType (NFC)
Summary:
https://reviews.llvm.org/D54862 removed the usages of `ASTContext&` from
within the `CXXMethodDecl::getTh
Author: modocache
Date: Sat Apr 21 17:04:35 2018
New Revision: 330530
URL: http://llvm.org/viewvc/llvm-project?rev=330530&view=rev
Log:
Add tests for llvm-bcanalyzer stream types
Summary:
Add tests for the improved stream type detection added to
`llvm-bcanalyzer` in https://reviews.llvm.org/D4197
Author: modocache
Date: Fri May 4 07:02:37 2018
New Revision: 331519
URL: http://llvm.org/viewvc/llvm-project?rev=331519&view=rev
Log:
[Coroutines] Catch exceptions in await_resume
Summary:
http://wg21.link/P0664r2 section "Evolution/Core Issues 24" describes a
proposed change to Coroutines TS t
Author: modocache
Date: Tue Jun 26 13:05:18 2018
New Revision: 335655
URL: http://llvm.org/viewvc/llvm-project?rev=335655&view=rev
Log:
[AST] Fix typo in LazyOffsetPtr::get docs (NFC)
Modified:
cfe/trunk/include/clang/AST/ExternalASTSource.h
Modified: cfe/trunk/include/clang/AST/ExternalAST
Author: modocache
Date: Tue Jul 10 17:45:48 2018
New Revision: 336748
URL: http://llvm.org/viewvc/llvm-project?rev=336748&view=rev
Log:
Remove qualtype qualifier in coroutine error to prevent assert in debug
Summary:
A forward-declared coroutine_traits should trip an error; we need
a complete typ
Author: modocache
Date: Tue Jul 10 18:00:53 2018
New Revision: 336750
URL: http://llvm.org/viewvc/llvm-project?rev=336750&view=rev
Log:
[SemaCXX] Remove comment from coroutines test, NFC
Summary:
The file name was accidentally included when the test file was added.
Test Plan: check-clang
Modif
Author: modocache
Date: Sat Jul 14 11:21:44 2018
New Revision: 337103
URL: http://llvm.org/viewvc/llvm-project?rev=337103&view=rev
Log:
Add caching when looking up coroutine_traits
Summary:
Currently clang looks up the coroutine_traits ClassTemplateDecl
everytime it looks up the promise type. Thi
Author: modocache
Date: Fri Oct 18 09:59:02 2019
New Revision: 375258
URL: http://llvm.org/viewvc/llvm-project?rev=375258&view=rev
Log:
[Format] Add format check for throwing negative numbers
Summary:
The code `throw -1;` is currently formatted by clang-format as
`throw - 1;`. This diff adds a fi
Author: modocache
Date: Thu Aug 10 08:30:35 2017
New Revision: 310609
URL: http://llvm.org/viewvc/llvm-project?rev=310609&view=rev
Log:
[Parse] Document PrintStats, SkipFunctionBodies
Summary:
Add documentation for `clang::ParseAST` parameters `PrintStats` and
`SkipFunctionBodies`. Also, remove a
Author: modocache
Date: Thu Aug 10 10:02:04 2017
New Revision: 310627
URL: http://llvm.org/viewvc/llvm-project?rev=310627&view=rev
Log:
[Parse] Document Parser::SkipFunctionBodies
Reviewers: erikjv, doug.gregor
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D36531
Mod
Author: modocache
Date: Mon Aug 14 07:29:11 2017
New Revision: 310838
URL: http://llvm.org/viewvc/llvm-project?rev=310838&view=rev
Log:
[Parse] Fix typo in header docs (NFC)
Summary:
Fix typo "delcarations", added in rL310609 and rL310627.
Modified:
cfe/trunk/include/clang/Parse/ParseAST.h
Author: Brian Gesiak
Date: 2020-04-02T21:44:54-04:00
New Revision: 627e01feb718dd1aa8e184545976b7229de312a2
URL:
https://github.com/llvm/llvm-project/commit/627e01feb718dd1aa8e184545976b7229de312a2
DIFF:
https://github.com/llvm/llvm-project/commit/627e01feb718dd1aa8e184545976b7229de312a2.diff
Author: Brian Gesiak
Date: 2020-02-19T01:03:28-05:00
New Revision: 048239e46e490d441f21f3e26073ec38f19e8a10
URL:
https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10
DIFF:
https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10.diff
Author: Brian Gesiak
Date: 2019-11-22T11:39:13-05:00
New Revision: 0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f
URL:
https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f
DIFF:
https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f.diff
Author: Brian Gesiak
Date: 2019-11-30T15:47:58-05:00
New Revision: 8682d29a28772bab0283a141b8701bfaea8881a6
URL:
https://github.com/llvm/llvm-project/commit/8682d29a28772bab0283a141b8701bfaea8881a6
DIFF:
https://github.com/llvm/llvm-project/commit/8682d29a28772bab0283a141b8701bfaea8881a6.diff
Author: Brian Gesiak
Date: 2019-12-16T17:43:04-05:00
New Revision: 376cf43729c8025eecbd2969522c5687f2a3919f
URL:
https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f
DIFF:
https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f.diff
Author: modocache
Date: Sun Apr 1 15:59:22 2018
New Revision: 328949
URL: http://llvm.org/viewvc/llvm-project?rev=328949&view=rev
Log:
[Coroutines] Find custom allocators in class scope
Summary:
https://reviews.llvm.org/rL325291 implemented Coroutines TS N4723
section [dcl.fct.def.coroutine]/7,
Author: modocache
Date: Sun Apr 1 16:55:21 2018
New Revision: 328951
URL: http://llvm.org/viewvc/llvm-project?rev=328951&view=rev
Log:
[Coroutines] Schedule coro-split before asan
Summary:
The docs for the LLVM coroutines intrinsic `@llvm.coro.id` state that
"The second argument, if not null, de
Author: modocache
Date: Fri Jun 30 12:37:11 2017
New Revision: 306862
URL: http://llvm.org/viewvc/llvm-project?rev=306862&view=rev
Log:
[ORE] Use LLVM's "diagnostics hotness" spelling
Summary:
Depends on https://reviews.llvm.org/D34864.
To unify Clang and LLVM's spelling of "diagnostic[s] hotnes
Author: modocache
Date: Fri Jun 30 21:44:38 2017
New Revision: 306945
URL: http://llvm.org/viewvc/llvm-project?rev=306945&view=rev
Log:
[Driver] Add -fdiagnostics-hotness-threshold
Summary:
Depends on https://reviews.llvm.org/D34867.
Add a Clang frontend option to enable optimization remark hotn
Author: modocache
Date: Fri Jun 30 21:54:53 2017
New Revision: 306946
URL: http://llvm.org/viewvc/llvm-project?rev=306946&view=rev
Log:
Revert "[Driver] Add -fdiagnostics-hotness-threshold"
Summary:
The commit caused a documentation breakage.
Modified:
cfe/trunk/docs/UsersManual.rst
cfe
Author: modocache
Date: Fri Jun 30 22:45:26 2017
New Revision: 306948
URL: http://llvm.org/viewvc/llvm-project?rev=306948&view=rev
Log:
Un-revert "[Driver] Add -fdiagnostics-hotness-threshold"
Summary:
Un-revert https://reviews.llvm.org/D34868, but with a slight tweak to the
documentation to fix
Author: modocache
Date: Wed Jul 5 12:55:51 2017
New Revision: 307193
URL: http://llvm.org/viewvc/llvm-project?rev=307193&view=rev
Log:
Add docs for -foptimization-record-file=
Summary: The Clang option was previously not included in the User's Manual.
Reviewers: anemet, davidxl, hfinkel
Review
Author: modocache
Date: Mon Jul 17 12:22:57 2017
New Revision: 308205
URL: http://llvm.org/viewvc/llvm-project?rev=308205&view=rev
Log:
[Basic] Detect Git submodule version in CMake
Summary:
When searching for Git version control information, libBasic's CMake
checks for the path '.git/logs/HEAD'.
Author: modocache
Date: Sat Jan 13 09:09:11 2018
New Revision: 322445
URL: http://llvm.org/viewvc/llvm-project?rev=322445&view=rev
Log:
[Driver] Add "did you mean?" suggestions to -cc1as
Summary:
In https://reviews.llvm.org/D41733, the driver was modified such that,
when a user provided a mispell
Author: modocache
Date: Sat Jan 13 10:34:07 2018
New Revision: 322447
URL: http://llvm.org/viewvc/llvm-project?rev=322447&view=rev
Log:
[docs] Use monospace for PCH option flags
Summary:
Use monospace for option flags in the PCH section, instead of the
italics that were being used previously.
I
Author: modocache
Date: Mon Jan 15 13:05:40 2018
New Revision: 322517
URL: http://llvm.org/viewvc/llvm-project?rev=322517&view=rev
Log:
[Driver] Suggest valid integrated tools
Summary:
There are only two valid integrated Clang driver tools: `-cc1` and
`-cc1as`. If a user asks for an unknown tool,
Author: modocache
Date: Wed Jan 24 14:15:42 2018
New Revision: 323381
URL: http://llvm.org/viewvc/llvm-project?rev=323381&view=rev
Log:
[coroutines] Pass coro func args to promise ctor
Summary:
Use corutine function arguments to initialize a promise type, but only
if the promise type defines a co
modocache added a comment.
Because I happen to know what these kinds are! ;)
But I agree--they should all be documented. I can look into what the other
kinds mean and add appropriate documentation for those as well. Maybe in
another commit?
http://reviews.llvm.org/D11773
__
modocache added a comment.
I do! Thanks, @compnerd!
http://reviews.llvm.org/D11772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
modocache created this revision.
modocache added a reviewer: cfe-commits.
The tests that verify that accessing a property without using the result
emits a warning were needlessly complicated. Remove several layers of
abstraction to make the tests much simpler to read and reason about.
http://revi
modocache created this revision.
modocache added a reviewer: cfe-commits.
Depends on http://reviews.llvm.org/D12047.
Add a unit test which demonstrates the bug reported in
https://llvm.org/bugs/show_bug.cgi?id=24404.
If the macro is enclosed within parentheses, the warning is reported as
expecte
modocache created this revision.
modocache added a subscriber: cfe-commits.
r159483 changed the canonical name of the Clang test target from
'clang-test' to 'check-clang'. Although the old name is still a valid
alias, update the documentation to use the new, canonical target name.
http://reviews.
modocache added a comment.
> Why do you think it's a cruft? Seems it's a bit more verbose than it should be
The verbosity is the cruft, in my opinion. Why spend thirty lines of code to
demonstrate behavior that could be demonstrated in just five?
> but what is missing in your test is inheritan
modocache added a comment.
Cool, thanks @compnerd!
http://reviews.llvm.org/D11772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
modocache added a reviewer: ddunbar.
modocache added a subscriber: ddunbar.
modocache added a comment.
Adding @ddunbar, who added the original FIXME, as a reviewer.
http://reviews.llvm.org/D2916
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
modocache added a subscriber: modocache.
Comment at: bindings/python/clang/cindex.py:1875
@@ -1873,1 +1874,3 @@
+def getElabaratedTypeUnderlyingType(self):
+"""
Awesome, thanks for updating the Python bindings as well!
As with the C function, I beli
modocache accepted this revision.
modocache added a reviewer: modocache.
modocache added a comment.
This revision is now accepted and ready to land.
Looks good to me! I don't have commit access, though, so you'll probably have
to find a committer to review/commit for you, @skalinichev.
http://r
modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.
I don't have access to the PS4 SDK, but this is the most plausible explanation
I've seen for why I was experiencing issues on these platforms. Thanks for this!
Do you have commit access
modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.
Great! Thanks @GorNishanov!
https://reviews.llvm.org/D47454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
modocache added subscribers: aaron.ballman, erikjv, modocache.
modocache added reviewers: aaron.ballman, erikjv.
modocache added a comment.
This looks good to me, but maybe some people who've modified this part of the
codebase before could review this as well? @aaron.ballman added a fix-it for
a
modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.
Thanks! I'll land https://reviews.llvm.org/D50410, then this, and monitor the
buildbots to see what happens. If they fail again I may revert this once again.
Thanks again for looking int
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341327: Removing -debug-info-macros from option suggestions
test (authored by modocache, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50410
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341329: Re-push "[Option] Fix PR37006 prefix choice in
findNearest" (authored by modocache, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50
modocache added a comment.
Excellent, I think pushing this along with https://reviews.llvm.org/D50410
revealed the true error, as an MSAN buildbot tells use there's a use of an
uninitialized value:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/23176/steps/check-clang%20ms
modocache updated this revision to Diff 133129.
modocache added a comment.
Prevent coroutine parameter stores from being moved, rely on
https://reviews.llvm.org/D43000 instead.
Repository:
rC Clang
https://reviews.llvm.org/D42606
Files:
lib/Sema/SemaCoroutine.cpp
test/CodeGenCoroutines/
modocache updated this revision to Diff 133154.
modocache added a comment.
Update the tests to work with scalar parameter copies.
Repository:
rC Clang
https://reviews.llvm.org/D42606
Files:
lib/Sema/SemaCoroutine.cpp
test/CodeGenCoroutines/coro-alloc.cpp
test/CodeGenCoroutines/coro-gro
modocache abandoned this revision.
modocache added inline comments.
Comment at: include/clang/Lex/PreprocessorOptions.h:165
public:
- PreprocessorOptions() : UsePredefines(true), DetailedRecord(false),
+ PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"),
+
modocache updated this revision to Diff 134304.
modocache added a comment.
Thanks for the review, @GorNishanov, and for pointing out that part of the
standard! I added a reference to the implicit object parameter, as well as some
tests for that behavior. And thanks for pointing out the flaw in
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325288: [Sema] Toggle diags when finding allocators (NFCI)
(authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42605?vs=131728&id=134489#toc
Repository:
rC Clan
modocache added a comment.
Thanks again, @GorNishanov, for all the reviews!
Repository:
rC Clang
https://reviews.llvm.org/D42605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325291: [Coroutines] Use allocator overload when available
(authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42606?vs=134304&id=134495#toc
Repository:
rC Clan
modocache added a comment.
Hooray, `[dcl.fct.def.coroutine]/7` is *in!*
Thank you for all the reviews, @GorNishanov!
Repository:
rC Clang
https://reviews.llvm.org/D42606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
modocache created this revision.
Prior to this change, using `-fdiagnostics-show-hotness` with a sampling
profile specified via `-fprofile-sample-use=` would result in the Clang
frontend emitting a warning: "argument '-fdiagnostics-show-hotness' requires
profile-guided optimization information". O
modocache added inline comments.
Comment at: test/Frontend/optimization-remark-with-hotness.c:32
+// RUN: -Rpass-analysis=inline -fdiagnostics-show-hotness 2>&1 |
FileCheck \
+// RUN: -check-prefix=PGO_ENABLED %s
+// RUN: %clang_cc1 -triple x86_64-apple-macosx10.9 -main
modocache updated this revision to Diff 102153.
modocache added a comment.
Thanks for the suggestions! I moved the sampling test close to the instrumented
one, and adjusted bar and foo entry count in the hopes og getting the remarks
to include hotness. No luck, however -- the test currently fail
modocache updated this revision to Diff 103647.
modocache added a comment.
Update the sampling profile text so that it produces the hotness expected by
the test. This is ready to go :)
https://reviews.llvm.org/D34082
Files:
lib/Frontend/CompilerInvocation.cpp
test/Frontend/Inputs/optimizat
modocache created this revision.
modocache added reviewers: yamaguchi, v.g.vassilev, teemperor, ruiu.
Depends on https://reviews.llvm.org/D41732.
Utilities such as `opt`, when invoked with arguments that are very
nearly spelled correctly, suggest the correctly spelled options:
bin/opt -hel
o
modocache added a comment.
Thank you, @bruno! Good idea, I'll add a `-cc1` invocation test.
Comment at: lib/Driver/Driver.cpp:191
if (A->getOption().hasFlag(options::Unsupported)) {
- Diag(diag::err_drv_unsupported_opt) << A->getAsString(Args);
- ContainsError |=
modocache updated this revision to Diff 128681.
modocache added a comment.
Add 'did you mean' suggestions for -cc1 invocations as well.
Repository:
rC Clang
https://reviews.llvm.org/D41733
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/Driver.cpp
lib/Frontend/CompilerIn
modocache updated this revision to Diff 128736.
modocache added a comment.
Test -Xclang as well. Thanks, @v.g.vassilev!
Repository:
rC Clang
https://reviews.llvm.org/D41733
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/Driver.cpp
lib/Frontend/CompilerInvocation.cpp
t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321917: [Driver] Suggest correctly spelled driver options
(authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41733?vs=128736&id=128824#toc
Repository:
rC Clang
modocache created this revision.
modocache added reviewers: rsmith, GorNishanov, eric_niebler.
Herald added a subscriber: EricWF.
Use corutine function arguments to initialize a promise type, but only
if the promise type defines a constructor that takes those arguments.
Otherwise, fall back to the
modocache created this revision.
modocache added a reviewer: v.g.vassilev.
A FIXME added 8 years ago (2010) in https://reviews.llvm.org/rL118203
mentioned that a FileManager should not need to be used when parsing
preprocessor arguments. In fact, its only use was removed 6 years ago
(2012), in htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322118: [Frontend] Remove unused FileMgr in pp arg parse
(authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41867?vs=129089&id=129152#toc
Repository:
rC Clang
modocache added a comment.
Great, thanks for the review, @v.g.vassilev!
Repository:
rC Clang
https://reviews.llvm.org/D41867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
modocache created this revision.
modocache added reviewers: v.g.vassilev, teemperor, ruiu, jroelofs, yamaguchi.
The `llvm::OptTable::findNearest` bug fixed in
https://reviews.llvm.org/D41873 manifested itself as the following
erroneous message when invoking Clang:
clang -version
clang-6.0: er
This revision was automatically updated to reflect the committed changes.
Closed by commit rC30: [Driver] Test for correct '--version'
suggestion (authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41912?vs=129314&id=129321#toc
Repository:
rC Clang
modocache added a comment.
Thanks, will do next time :)
Repository:
rC Clang
https://reviews.llvm.org/D41912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
modocache created this revision.
modocache added reviewers: GorNishanov, lewissbaker, EricWF.
The docs for the LLVM coroutines intrinsic `@llvm.coro.id` state that
"The second argument, if not null, designates a particular alloca instruction
to be a coroutine promise."
However, if the address san
modocache added a comment.
I wasn't sure what the best way to test this would be. The assertion occurs in
LLVM, but Clang is responsible for scheduling the passes. If anyone has any
suggestions, I'd greatly appreciate them!
Repository:
rC Clang
https://reviews.llvm.org/D43927
___
modocache created this revision.
modocache added reviewers: GorNishanov, eric_niebler, lewissbaker.
Herald added a subscriber: EricWF.
https://reviews.llvm.org/rL325291 implemented Coroutines TS N4723
section [dcl.fct.def.coroutine]/7, but it performed lookup of allocator
functions within both the
modocache created this revision.
modocache added reviewers: GorNishanov, vsk, eric_niebler, lewissbaker.
As explained in http://lists.llvm.org/pipermail/llvm-dev/2018-March/121924.html,
the LLVM coroutines transforms are not yet able to move the
instructions for UBSan null checking past coroutine
modocache created this revision.
modocache added reviewers: GorNishanov, EricWF.
Herald added a subscriber: cfe-commits.
In his review of https://reviews.llvm.org/D45860, @GorNishanov suggested
avoiding generating additional exception-handling IR in the case that
the resume function was marked as
1 - 100 of 304 matches
Mail list logo
