[PATCH] D48515: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.

brad created this revision. brad added reviewers: sdardis, atanasyan. Herald added a subscriber: srhines. Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el. Repository: rC Clang https://reviews.llvm.org/D48515 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/openbsd.c Index:

[PATCH] D48515: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.

brad updated this revision to Diff 152580. brad added a comment. Sorry wrong revision of the diff. https://reviews.llvm.org/D48515 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/openbsd.c Index: test/Driver/openbsd.c === --

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

brad added a comment. IMHO it would be best to try and deal with as many known / exposed issues with the N32 support and then just enable IAS across the board. Then tackle any remaining issues as they come up. Repository: rC Clang https://reviews.llvm.org/D52418 _

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

brad added a comment. How is it going with regard to N32 fixes / testing? Repository: rC Clang https://reviews.llvm.org/D52418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

brad added a comment. Simon? Repository: rC Clang https://reviews.llvm.org/D52418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

brad added a comment. George, look at adding some appropriate entries to test/Driver/frame-pointer-elim.c Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60335/new/ https://reviews.llvm.org/D60335 ___ cfe-commits mail

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

brad added a comment. Simon, and what about lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp? Repository: rC Clang https://reviews.llvm.org/D52418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

brad added a comment. I've been told there is no desire to make gnu the default on OpenBSD. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 ___ cfe-commits mailing list cfe-co

[PATCH] D48515: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.

This revision was automatically updated to reflect the committed changes. Closed by commit rC336004: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el. (authored by brad, committed by ). Changed prior to commit: https://reviews.llvm.org/D48515?vs=152580&id=153550#toc Repo

[PATCH] D79588: [llvm][Support] Use std::atomic for llvm::call_once

brad added a comment. OpenBSD 6.7 is just wrapping up and will be released in a few days. We have switched to Clang for our PowerPC system compiler and thus libc++. It should be Ok to remove OpenBSD from that bit of code. The original issue as far as I remember is that because we don't have TLS

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

brad added a comment. You can close this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. In D154396#4655494 , @ADKaster wrote: > @MaskRay @phosek Daniel and I have updated the patch set, Would you rather I > update the phab patch series, or re-upload the set as GitHub PRs? Update the phab patch series. Repository:

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. Make use of the concat macro with the various header and library paths. https://github.com/llvm/llvm-project/commit/1d0cc510516d50c459f78896a0375fadb13a2b45 Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:78 + + if (Output.isFilename()) { +CmdArg

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. You also have to add Serenity to clang/lib/Lex/InitHeaderSearch.cpp InitHeaderSearch::ShouldAddDefaultIncludePaths(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 ___

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.h:81 + + unsigned GetDefaultDwarfVersion() const override { return 5; } + This just overrides the default DWARF version anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:202 + addSystemInclude(DriverArgs, CC1Args, + concat(D.SysRoot, "/usr/local/include")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, "/usr/include")); ---

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. But the rest LGTM as a start. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:147 + } + + if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs, Add in here.. ``` // Silence warnings when linking C code with a C++ '-stdlib' argument. Ar

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:110 +assert(!Inputs.empty() && "Must have at least one input."); +addLTOOptions(TC, Args, CmdArgs, Output, Inputs[0], + D.getLTOMode() == LTOK_Thin); https:/

[PATCH] D123097: [RISCV] Remove redundant enabling of IAS for Clang

brad created this revision. brad added a reviewer: kito-cheng. brad added a project: clang. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rog

[PATCH] D123097: [RISCV] Remove redundant enabling of IAS for Clang, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG4875ff1dc90b: [RISCV] Remove redundant enabling of IAS for Clang, NFC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123097/new/ https://

[PATCH] D123431: [CSKY] Remove redundant enabling of IAS for Clang, NFC

brad created this revision. brad added a reviewer: zixuan-wu. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Generic_GCC::IsIntegratedAssemblerDefault() already takes care of CSKY. Repository: rG LLVM Github

[PATCH] D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault

brad created this revision. brad added reviewers: bcain, kparzysz, simoll. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Move enabling of IAS back to Generic_GCC::IsIntegratedAssemblerDefault(). Repository:

[PATCH] D123431: [CSKY] Remove redundant enabling of IAS for Clang, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee4c235386a3: [CSKY] Remove redundant enabling of IAS for Clang, NFC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault

brad updated this revision to Diff 422125. brad added a comment. Update after CSKy addition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123438/new/ https://reviews.llvm.org/D123438 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver

[PATCH] D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG71d88b4ba8b0: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC… (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123438/new/ https://r

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Move enabling of IAS back to Generic_GCC::IsIntegratedAssemblerDefault(). Repository: rG LLVM Git

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5206c2c167ed: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault… (authored by brad). Repository: rG LLVM Github Monore

[PATCH] D119071: [Driver][OpenBSD] -r: imply -nostdlib like GCC

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. brad requested review of this revision. Similar to D116843 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119071 Files: clang/lib/Driver/ToolChains/Op

[PATCH] D119071: [Driver][OpenBSD] -r: imply -nostdlib like GCC

brad updated this revision to Diff 406236. brad added a comment. formating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119071/new/ https://reviews.llvm.org/D119071 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Driver/openbsd.c

[PATCH] D119071: [Driver][OpenBSD] -r: imply -nostdlib like GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rG1831cbd9d417: [Driver][OpenBSD] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119071/new/ https://reviews.l

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

brad created this revision. brad added a reviewer: MaskRay. brad requested review of this revision. Herald added a project: clang. Similar to D116843 for Gnu.cpp Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119655 Files: clang/lib/Driver/

[PATCH] D119656: [Driver][DragonFly] -r: imply -nostdlib like GCC

brad created this revision. brad added a reviewer: MaskRay. brad requested review of this revision. Herald added a project: clang. Similar to D116843 for Gnu.cpp Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119656 Files: clang/lib/Driver/

[PATCH] D119656: [Driver][DragonFly] -r: imply -nostdlib like GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd9d136ef81: [Driver][DragonFly] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119656/new/ https://reviews

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd241ce0f97e4: [Driver][NetBSD] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

brad created this revision. brad added reviewers: sammccall, kadircet. brad added a project: clang. Herald added subscribers: usaxena95, arphaman, krytarowski. brad requested review of this revision. Herald added subscribers: llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM, clang-

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

brad updated this revision to Diff 409445. brad added a comment. Remove a file I did not mean to include as part of the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119989/new/ https://reviews.llvm.org/D119989 Files: clang-tools-extra/cla

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

brad added a comment. In D119989#3329413 , @kadircet wrote: > thanks Yes, I will do so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119989/new/ https://reviews.llvm.org/D119989

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGf374c8ddf2dd: [clangd] Fix building SerializationTests unit test on OpenBSD (authored by brad). Changed prior to commit: https://reviews.llvm.org/D119989?vs=409445&id=409689#toc Repository: rG LLVM G

[PATCH] D124356: [Driver][Solaris] -r: imply -nostdlib like GCC

brad created this revision. brad added reviewers: MaskRay, ro. brad added a project: clang. Herald added subscribers: StephenFan, fedor.sergeev. Herald added a project: All. brad requested review of this revision. Similar to D116843 for Gnu.cpp Repository: rG

[PATCH] D124356: [Driver][Solaris] -r: imply -nostdlib like GCC

brad updated this revision to Diff 424835. brad added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124356/new/ https://reviews.llvm.org/D124356 Files: clang/lib/Driver/ToolChains/Solaris.cpp clang/test/Driver/solaris-ld

[PATCH] D124356: [Driver][Solaris] -r: imply -nostdlib like GCC

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:168 } - CmdArgs.push_back(Args.MakeArgString(getToolChain().GetFilePath("crtn.o"))); MaskRay wrote: > This appears to fix another bug. > This appears to fix another bug. It app

[PATCH] D124356: [Driver][Solaris] -r: imply -nostdlib like GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d7da810e4a6: [Driver][Solaris] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

brad created this revision. brad added reviewers: MaskRay, zhmu. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Similar to D116843 for Gnu.cpp Repository: rG LLVM Github

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

brad added inline comments. Comment at: clang/test/Driver/ananas.c:20 +// -r suppresses default -l and crt*.o like -nostdlib. +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o \ +// RUN: --target=x86_64-unknown-ananas -r 2>&1 \ MaskRay wrote: > Delete -n

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

brad updated this revision to Diff 426327. brad added a comment. Updated with feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124729/new/ https://reviews.llvm.org/D124729 Files: clang/lib/Driver/ToolChains/Ananas.cpp clang/test/Driver/

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa132e527f251: [Driver][Ananas] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad created this revision. brad added reviewers: MaskRay, emaste, zhmu, mgorny, phosek. brad added a project: clang. Herald added subscribers: abrachet, StephenFan. Herald added a project: All. brad requested review of this revision. As mentioned in commit 57e43ebc42d4e572cab1e84532115c364d5db92a

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. There is already the initial --sysroot test in test/Driver/openbsd.c. It would be preferable to modify what is there. For FreeBSD a test should be added to test/Driver/freebsd.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad added a comment. In D129714#3650371 , @MaskRay wrote: > Thanks! This is trivially correct but consider giving folks one day to > respond. Sure thing. No problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. In D129654#3650412 , @3405691582 wrote: > Tested change on OpenBSD resolves downstream issues. What issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad added a comment. One question, should the backends be passing -pie when using -r? I had adjusted the tests but cannot remember why I had changed the logic of the backend before submitting the diff. I had originally had -pie disabled with -r for Ananas and NetBSD. I noticed Fuchsia had...

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad updated this revision to Diff 444791. brad added a comment. Disable -pie when using -r. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/ https://reviews.llvm.org/D129714 Files: clang/lib/Driver/ToolChains/Ananas.cpp clang/lib/Dri

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. In D129654#3650590 , @3405691582 wrote: > As mentioned, this replicates https://reviews.llvm.org/D126289 for OpenBSD > which fixes #28283. That particular issue caused a build problem in Swift's > use of VFS in which I verified th

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. Also -stdlib=libc++ is the default on OpenBSD and FreeBSD so you can probably leave that out and I think you can remove --gcc-toolchain="". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews.llvm.org/D1

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabc8f2b7245f: [Driver] Don't passs --dynamic-linker in -r mode (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157896: Clang: Define macro _MIPS_SPFPSET

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f02e3bd6a5: Clang: Define macro _MIPS_SPFPSET (authored by brad). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

brad added a comment. Looks reasonable. I'm a little surprised I don't see this in the FreeBSD driver. What about FreeBSD, NetBSD and DragonFly? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86412/new/ https://reviews.llvm.org/D86412 ___ cfe

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

brad accepted this revision. brad added a comment. This revision is now accepted and ready to land. I was wondering why we had not seen any issues like this but your followup post clarified the situation. Thank you. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86412/new/ https

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b37174b9a5d: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport… (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > efriedma wrote: > > Do we want to make sparc and sp

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

brad added a comment. @efriedma Eli? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90329/new/ https://reviews.llvm.org/D90329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG018984ae6833: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets (authored by kernigh, committed by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D109349: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb588f5d665aa: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD. (authored by fcambus, committed by brad). Rep

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

brad added a comment. Oh, and you would have to use chomp to eliminate the newline character. Never mind. That's kind of ugly. Maybe it is better to go back to the original diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 ___

[PATCH] D113361: [clang][Sparc] Disable SjLj lowering.

brad created this revision. brad added reviewers: dcederman, LemonBoy, jyknight. brad added a project: clang. Herald added subscribers: jrtc27, fedor.sergeev. brad requested review of this revision. Disable SjLj lowering. The builtin SjLj support has been removed. https://reviews.llvm.org/rG0c05

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

brad added a comment. I do not immediately see why the other tests are failing, but at a bare minimum the following test from clang/test/Preprocessor/predefined-arch-macros.c will have to be updated.. // RUN: %clang -mcpu=v9 -E -dM %s -o - 2>&1 \ // RUN: -target sparc-unknown-linux \

[PATCH] D108901: [Sparc] Create an error when `__builtin_longjmp` is used

This revision was automatically updated to reflect the committed changes. Closed by commit rGeeb4266f8137: [Sparc] Create an error when `__builtin_longjmp` is used (authored by xtkoba, committed by brad). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D140657: [Clang] Move AMDGPU IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

brad updated this revision to Diff 485218. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140657/new/ https://reviews.llvm.org/D140657 Files: clang/lib/Driver/ToolChains/AMDGPU.

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad created this revision. brad added reviewers: 0x59616e, myhsu, efriedma, glaubitz. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D140657: [Clang] Move AMDGPU IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG14b42f21a25c: [Clang] Move AMDGPU IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault… (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad added a comment. How come the Clang M68k backend defaults to 68000? GCC defaults to 68020 for all targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 ___

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad updated this revision to Diff 485582. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 Files: clang/lib/Basic/Targets/M68k.cpp clang/test/Preprocessor/predefined-arch-macros.c Index: clang/test/Pr

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2784b243e38f: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macro

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad created this revision. brad added reviewers: kparzysz, kaz7, simoll, aheejin, luke. brad added a project: clang. Herald added subscribers: pmatos, asb, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: All. brad requested review of this revision. Define __GCC_HAV

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad updated this revision to Diff 485607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140757/new/ https://reviews.llvm.org/D140757 Files: clang/lib/Basic/Targets/Hexagon.cpp clang/lib/Basic/Targets/VE.cpp clang/lib/Basic/Targets/WebAssembly

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad updated this revision to Diff 485743. brad added a comment. Remove some whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140757/new/ https://reviews.llvm.org/D140757 Files: clang/lib/Basic/Targets/Hexagon.cpp clang/lib/Basic/Targ

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

brad created this revision. brad added reviewers: MaskRay, mgorny, krytarowski. brad added a project: clang. Herald added subscribers: StephenFan, ormris, arichardson, emaste. Herald added a project: All. brad requested review of this revision. This matches OpenBSD and FreeBSD. Repository: rG

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:4337 +// RUN: %clang -E -dM %s -o - 2>&1 \ +// RUN: -target hexagon-unknown-linux \ +// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_HEXAGON_ATOMICS MaskRa

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGd227c3b68cf5: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros (authored by brad). Changed prior to commit: https://reviews.llvm.org/D140757?vs=485743&id=486501#toc Repository:

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

brad updated this revision to Diff 486505. brad added a comment. Tweak test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140817/new/ https://reviews.llvm.org/D140817 Files: clang/lib/Driver/ToolChains/NetBSD.cpp clang/lib/Driver/ToolChains/N

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe449e1dff9f8: [Driver] move NetBSD header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad created this revision. brad added reviewers: MaskRay, SixWeining, gonglingqin. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros Repository: rG LLVM Github

[PATCH] D141073: [Driver] move Fuchsia header search path management to the driver

brad created this revision. brad added reviewers: MaskRay, abrachet, phosek. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Fuchsia already implements AddClangSystemIncludeArgs(). So it looks like we just ha

[PATCH] D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad added a comment. In D141070#4030069 , @MaskRay wrote: > Wait for LoongArch folks:) Np :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141070/new/ https://reviews.llvm.org/D141070 __

[PATCH] D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf70d17fc2c10: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D141073: [Driver] move Fuchsia header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fd279f7d369: [Driver] move Fuchsia header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I

brad created this revision. brad added a reviewer: atanasyan. brad added a project: clang. Herald added subscribers: jrtc27, arichardson, sdardis. Herald added a project: All. brad requested review of this revision. Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I Repository: r

[PATCH] D138254: [llvm] Remove LLVM_VERSION_SUFFIX from created shared library names

brad created this revision. brad added reviewers: thieta, tstellar, beanz. brad added a project: LLVM. Herald added a subscriber: krytarowski. Herald added a project: All. brad requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes buil

[PATCH] D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c9a51bf456: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

brad added a comment. I was just looking at the same diff for OpenBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127393/new/ https://reviews.llvm.org/D127393 ___ cfe-commits mailing list cfe-commits@

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, krytarowski, arichardson. H

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad added a comment. I will add a test. Comment at: clang/lib/Driver/ToolChains/OpenBSD.cpp:159 + if (ToolChain.getArch() == llvm::Triple::riscv64) +CmdArgs.push_back("-X"); MaskRay wrote: > isRISCV > > If OpenBSD gets riscv32, it'd need -X, too. There

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad updated this revision to Diff 438070. brad added a comment. Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128109/new/ https://reviews.llvm.org/D128109 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Driver/openbsd.c

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad updated this revision to Diff 438071. brad added a comment. Minus the new white space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128109/new/ https://reviews.llvm.org/D128109 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Dr

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad updated this revision to Diff 438075. brad added a comment. Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128109/new/ https://reviews.llvm.org/D128109 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Driver/openbsd.

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad added inline comments. Comment at: clang/test/Driver/openbsd.c:133 +// RUN: | FileCheck -check-prefix=CHECK-RISCV64-FLAGS %s +// CHECK-RISCV64-FLAGS: "-X" MaskRay wrote: > It's useful to check other values like the `-m` emulation and the dynamic > linker.

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG119a13199a91: [Driver] Pass -X to ld for riscv64-openbsd (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: luke957, StephenFan, s.egerton, simoncook, fedor.sergeev. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: pcwang-thead. Have the drive

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

brad updated this revision to Diff 438160. brad added a comment. Update tests to conform to recent style changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128127/new/ https://reviews.llvm.org/D128127 Files: clang/lib/Driver/ToolChains/OpenB

  1   2   3   >