r333316 - Support Swift calling convention for PPC64 targets

Author: bwilson Date: Fri May 25 14:26:03 2018 New Revision: 16 URL: http://llvm.org/viewvc/llvm-project?rev=16&view=rev Log: Support Swift calling convention for PPC64 targets This adds basic support for the Swift calling convention with PPC64 targets. Patch provided by Atul Sowani in bu

r310622 - Add a getName accessor for ModuleMacros.

Author: bwilson Date: Thu Aug 10 09:42:46 2017 New Revision: 310622 URL: http://llvm.org/viewvc/llvm-project?rev=310622&view=rev Log: Add a getName accessor for ModuleMacros. Swift would like to be able to access the name of a ModuleMacro. There was some discussion of this in https://github.com/a

Re: r284265 - [Sema] Refactor context checking for availability diagnostics

Hi Erik, This change does not work with one of the headers from the AVFoundation framework in tvOS 10.0. We can try to get a fix into the tvOS SDK, but it will probably be a while before we could release an SDK with that change. In the meantime, this is kind of disruptive. Can you find a way to

Re: r284265 - [Sema] Refactor context checking for availability diagnostics

Yes. I filed rdar://problem/28812809 to report that problem in the SDK. I also filed rdar://problem/28825862 to remind us to restore the more strict checking after we release a version of the tvOS SDK with a fix. Thanks, Erik! > On Oct 18, 2016, at 9:46 AM, Erik Pilkington > wrote: > > >

r285428 - Add missing newline at EOF to avoid -Wnewline-eof warnings.

Author: bwilson Date: Fri Oct 28 13:55:50 2016 New Revision: 285428 URL: http://llvm.org/viewvc/llvm-project?rev=285428&view=rev Log: Add missing newline at EOF to avoid -Wnewline-eof warnings. Modified: cfe/trunk/include/clang/Basic/OpenCLImageTypes.def Modified: cfe/trunk/include/clang/Bas

Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

bob.wilson added a comment. On Darwin platforms, the libc++ headers are expected to be installed alongside clang. If you're not doing that, then you're building it wrong. Adding more fallback options for finding the headers just makes things worse, because instead of a clear failure, you're mor

Re: [PATCH] D13113: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

bob.wilson accepted this revision. bob.wilson added a comment. This revision is now accepted and ready to land. Good idea. The patch looks good. It will need to be coordinated with a change to compiler_rt build cc_kext_ios.a, though. Thanks for cleaning this up. http://reviews.llvm.org/D13113

r248975 - Fix printing of parameterized Objective-C interfaces.

Author: bwilson Date: Wed Sep 30 19:53:13 2015 New Revision: 248975 URL: http://llvm.org/viewvc/llvm-project?rev=248975&view=rev Log: Fix printing of parameterized Objective-C interfaces. This change was accidentally omitted from Doug's change in r241541. Modified: cfe/trunk/lib/AST/DeclPrin

r249116 - Be slightly more permissive when checking for type-erased blocks.

Author: bwilson Date: Thu Oct 1 20:05:29 2015 New Revision: 249116 URL: http://llvm.org/viewvc/llvm-project?rev=249116&view=rev Log: Be slightly more permissive when checking for type-erased blocks. This is a patch from Doug that was inadvertently omitted from r241543. Modified: cfe/trunk/l

r275905 - Allow iOS and tvOS version numbers with 2-digit major version numbers.

Author: bwilson Date: Mon Jul 18 15:29:14 2016 New Revision: 275905 URL: http://llvm.org/viewvc/llvm-project?rev=275905&view=rev Log: Allow iOS and tvOS version numbers with 2-digit major version numbers. rdar://problem/26921601 Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Dri

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

> On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits > wrote: > > silvas added a comment. > > In http://reviews.llvm.org/D15829#333902, @davidxl wrote: > >> For the longer term, one possible solution is to make FE based >> instrumentation only used for coverage testing which can be turne

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

> On Feb 3, 2016, at 12:23 PM, Xinliang David Li wrote: > > On Tue, Feb 2, 2016 at 1:31 PM, Bob Wilson > wrote: >> >>> On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits >>> wrote: >>> >>> silvas added a comment. >>> >>> In http://reviews.llvm.org/D15829#3

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

> On Feb 10, 2016, at 12:59 PM, Tim Northover wrote: > > On 10 February 2016 at 12:52, Eric Fiselier wrote: >> @Tim Are these tests in the clang test suite? > > Yep, at http://llvm.org/git/test-suite.git. > >> Marshall and I were just talking about removing all together. >> Could you explai

[PATCH] D17166: [Sema] More changes to fix Objective-C fallout from r249995.

bob.wilson created this revision. bob.wilson added reviewers: cfe-commits, george.burgess.iv, doug.gregor, rsmith. Herald added a subscriber: mcrosier. This is a follow-up to PR26085. That was fixed in r257710 but the testcase there was incomplete. There is a related issue where the overload reso

r260787 - [Sema] More changes to fix Objective-C fallout from r249995.

Author: bwilson Date: Fri Feb 12 19:41:41 2016 New Revision: 260787 URL: http://llvm.org/viewvc/llvm-project?rev=260787&view=rev Log: [Sema] More changes to fix Objective-C fallout from r249995. This is a follow-up to PR26085. That was fixed in r257710 but the testcase there was incomplete. There

Re: [PATCH] D17166: [Sema] More changes to fix Objective-C fallout from r249995.

bob.wilson closed this revision. bob.wilson marked an inline comment as done. bob.wilson added a comment. Committed in r260787. I had previously missed a regression in one of the existing ovl-check.m tests. The testTakesCFTypeRef function was checking that the CFTypeRef overload was selected. H

r261762 - Fix typo in test/CodeGen/object-size.c CHECK line.

Author: bwilson Date: Wed Feb 24 12:38:35 2016 New Revision: 261762 URL: http://llvm.org/viewvc/llvm-project?rev=261762&view=rev Log: Fix typo in test/CodeGen/object-size.c CHECK line. Modified: cfe/trunk/test/CodeGen/object-size.c Modified: cfe/trunk/test/CodeGen/object-size.c URL: http://

r266938 - Remove the (ignored) -Wreceived-is-weak diagnostic.

Author: bwilson Date: Wed Apr 20 19:11:24 2016 New Revision: 266938 URL: http://llvm.org/viewvc/llvm-project?rev=266938&view=rev Log: Remove the (ignored) -Wreceived-is-weak diagnostic. We kept this around for a while since Xcode 6 and earlier had a build setting for this warning. It was removed

r270391 - Fix typo in documentation comment.

Author: bwilson Date: Sun May 22 20:52:50 2016 New Revision: 270391 URL: http://llvm.org/viewvc/llvm-project?rev=270391&view=rev Log: Fix typo in documentation comment. Modified: cfe/trunk/include/clang/Lex/ModuleMap.h Modified: cfe/trunk/include/clang/Lex/ModuleMap.h URL: http://llvm.org/v

[PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for Objective-C properties marked with the IBOutlet attribute. Those properties are supposed to be weak but they are only accessed from the main thread so there is no risk of asynchronous updates setting them to nil. That combin

Re: [PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

> On May 24, 2016, at 11:21 AM, Manman wrote: > > >> On May 23, 2016, at 8:15 PM, Bob Wilson wrote: >> >> Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for >> Objective-C properties marked with the IBOutlet attribute. Those properties >> are supposed to be weak but the

r270666 - Rename a variable to avoid shadowing function parameter. NFC.

Author: bwilson Date: Wed May 25 00:42:00 2016 New Revision: 270666 URL: http://llvm.org/viewvc/llvm-project?rev=270666&view=rev Log: Rename a variable to avoid shadowing function parameter. NFC. Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp Modified: cfe/trunk/lib/Sema/AnalysisBase

r270665 - arc-repeated-use-of-weak should not warn about IBOutlet properties

Author: bwilson Date: Wed May 25 00:41:57 2016 New Revision: 270665 URL: http://llvm.org/viewvc/llvm-project?rev=270665&view=rev Log: arc-repeated-use-of-weak should not warn about IBOutlet properties Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for Objective-C properties m

Re: [PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

> On May 24, 2016, at 11:46 AM, Manman Ren wrote: > >> >> On May 24, 2016, at 11:42 AM, Bob Wilson > > wrote: >> >>> >>> On May 24, 2016, at 11:21 AM, Manman >> > wrote: >>> >>> On May 23, 2016, at 8:15 PM, Bob Wilson >>>

[PATCH] D17941: add fix-its for format-security warnings

bob.wilson created this revision. bob.wilson added reviewers: bcraig, rjmccall, dblaikie. bob.wilson added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. The format-security warning is a special case of format-nonliteral that applies when there are no arguments besides the format

Re: [PATCH] D17941: add fix-its for format-security warnings

bob.wilson added a comment. In http://reviews.llvm.org/D17941#369698, @bcraig wrote: > What about wprintf? Do we currently warn for wprintf(str)? If so, then the > fixit probably needs to involve L"%ls". Darwin does not mark wprintf functions with an attribute. Linux (at least the version I

Re: [PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

bob.wilson added a comment. > I do like the explicit nature of this approach, but I'm worried about it > being too novel. For instance, would this compel GCC to implement a similar > parsing feature since they also support the deprecated attribute, that sort > of thing. Also, it feels like a bi

r263299 - Add fix-it for format-security warnings.

Author: bwilson Date: Fri Mar 11 15:55:37 2016 New Revision: 263299 URL: http://llvm.org/viewvc/llvm-project?rev=263299&view=rev Log: Add fix-it for format-security warnings. Added: cfe/trunk/test/SemaObjC/format-strings-objc-fixit.m Modified: cfe/trunk/lib/Sema/SemaChecking.cpp cfe/t

Re: [PATCH] D17941: add fix-its for format-security warnings

bob.wilson accepted this revision. bob.wilson added a reviewer: bob.wilson. bob.wilson added a comment. This revision is now accepted and ready to land. Thanks Ben. Committed in r263299 http://reviews.llvm.org/D17941 ___ cfe-commits mailing list cfe

Re: r263299 - Add fix-it for format-security warnings.

hints > <http://clang.llvm.org/docs/InternalsManual.html#fix-it-hints> says that if a > fixit is on a warning, then clang should process the code as if the fixit had > been applied. That's not the case here, so I think the fixit should be on a > note instead. > > On F

Re: r263299 - Add fix-it for format-security warnings.

OK. I will do that. > On Mar 11, 2016, at 4:15 PM, David Blaikie wrote: > > > > On Fri, Mar 11, 2016 at 4:14 PM, Bob Wilson via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > I’m not sure how to interpret that. It says: "Clang must recover from err

r263584 - Move the fixit for -Wformat-security to a note.

Author: bwilson Date: Tue Mar 15 15:56:38 2016 New Revision: 263584 URL: http://llvm.org/viewvc/llvm-project?rev=263584&view=rev Log: Move the fixit for -Wformat-security to a note. r263299 added a fixit for the -Wformat-security warning, but that runs into complications with our guideline that e

Re: r263299 - Add fix-it for format-security warnings.

I think r263584 does what you suggest. Let me know if not. > On Mar 11, 2016, at 4:53 PM, Bob Wilson via cfe-commits > wrote: > > OK. I will do that. > >> On Mar 11, 2016, at 4:15 PM, David Blaikie > <mailto:dblai...@gmail.com>> wrote: >> >>

Re: [PATCH] D18088: Add a new warning to notify users of mismatched SDK and deployment target

bob.wilson added a comment. This is a good idea overall. See comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:198 @@ -197,2 +197,3 @@ InGroup>; +def warn_incompatible_sdk : Warning<"using SDK for '%0' but deploying to '%1'">; def warn_debug_compression_una

Re: [PATCH] D18088: Add a new warning to notify users of mismatched SDK and deployment target

bob.wilson added a comment. Yes, in its current usage this warning is only used for Apple's SDKs, but how does it help to put "apple" in the name of the diagnostic? Are you concerned about a name conflict with a similar diagnostic for non-Apple SDKs? http://reviews.llvm.org/D18088 _

r264519 - Check if a path is already absolute before trying to make it so.

Author: bwilson Date: Sat Mar 26 13:55:13 2016 New Revision: 264519 URL: http://llvm.org/viewvc/llvm-project?rev=264519&view=rev Log: Check if a path is already absolute before trying to make it so. The FileSystem::makeAbsolute function has been calculating the current working directory unconditi

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

bob.wilson accepted this revision. bob.wilson added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for working on this! http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

bob.wilson accepted this revision. bob.wilson added a reviewer: bob.wilson. bob.wilson added a comment. This revision is now accepted and ready to land. I applied a Darwin-specific change for this to clang in r256026. http://reviews.llvm.org/D15455

Re: r249995 - [Sema] Allow C conversions in C overload logic

George, This change caused a serious regression for Objective-C method lookup. See PR26085 (http://llvm.org/pr26085). For the test case in that PR, Sema::SelectBestMethod looks at the two candidate "test" methods. It will match the second one, but in the process of considering the first candid

r257556 - Generalize r256026 to apply to all MachO targets, not just Darwin targets.

Author: bwilson Date: Tue Jan 12 19:19:02 2016 New Revision: 257556 URL: http://llvm.org/viewvc/llvm-project?rev=257556&view=rev Log: Generalize r256026 to apply to all MachO targets, not just Darwin targets. The PIC default is set for the MachO toolchain, not just the Darwin toolchain, so this t

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

bob.wilson added a comment. Regarding the FIXME in lib/Frontend/CompilerInvocation.cpp: I agree with Hal that you can remove that. We used to complain about unsupported -fno-builtin-* options (and until now they have *all* been unsupported), but in r191434, Rafael changed clang to silently igno

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

bob.wilson added a subscriber: bob.wilson. bob.wilson added a comment. There has been a long-standing convention in both gcc and clang for Darwin that -static changes the default for PIC. Changing that convention is breaking stuff for us. The commit message for r245667 says "This new behavior al

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Nov 12, 2015, at 2:19 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Thu Nov 12 16:19:45 2015 > New Revision: 252960 > > URL: http://llvm.org/viewvc/llvm-project?rev=252960&view=rev > Log: > [modules] Simplify and generalize the existing rule for finding hidden > de

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

> On Dec 17, 2015, at 10:16 AM, Joerg Sonnenberger via cfe-commits > wrote: > > On Wed, Dec 16, 2015 at 11:59:10PM +, Bob Wilson via cfe-commits wrote: >> We can change this to be Darwin-specific if you prefer, but we should >> maintain compatibility with GCC and pr

r256026 - PIC should not be enabled by default on Darwin with -static.

Author: bwilson Date: Fri Dec 18 14:37:54 2015 New Revision: 256026 URL: http://llvm.org/viewvc/llvm-project?rev=256026&view=rev Log: PIC should not be enabled by default on Darwin with -static. r245667 changed -static so that it doesn't override an explicit -fPIC option, but -static should still

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

> On Dec 17, 2015, at 10:59 AM, Bob Wilson via cfe-commits > wrote: > > >> On Dec 17, 2015, at 10:16 AM, Joerg Sonnenberger via cfe-commits >> wrote: >> >> On Wed, Dec 16, 2015 at 11:59:10PM +, Bob Wilson via cfe-commits wrote: >>> We can ch