[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3555 AfterFunctionDefinitionName(false), AfterIfMacros(false), - AfterOverloadedOperator(false), AfterRequiresInClause(false), - AfterRequiresInExpression(false)

[PATCH] D128496: [clang-format] Further improve requires clause detection

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D128496: [clang-format] Further improve requires clause detection

HazardyKnusperkeks updated this revision to Diff 439689. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128496/new/ https://reviews.llvm.org/D128496 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/TokenAnnotatorTest.cpp Index: clang/unittests/Format/TokenAnnot

[PATCH] D128496: [clang-format] Further improve requires clause detection

HazardyKnusperkeks marked 4 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3185-3188 - default: -// It's an expression. -parseRequiresExpression(RequiresToken); -return false; c

[PATCH] D128496: [clang-format] Further improve requires clause detection

This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rGb3aeca3962bb: [clang-format] Further improve requires clause detection (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

HazardyKnusperkeks added a comment. In D127873#3610106 , @jackhong12 wrote: > Hi. I passed the unit tests on my computer. But the build status here is > failed. The build log only shows the issue is related to `git reset --hard`. > So, I don't know whe

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

HazardyKnusperkeks added a comment. But for now you should wait for @MyDeveloperDay that he at least removes the changes needed, or state what you have to change, or even better accept it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 _

[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

HazardyKnusperkeks added a comment. In D126132#3533033 , @owenpan wrote: > @HazardyKnusperkeks I think you know this better than any of us as you added > the assertion to `setType()`. Does this look ok to you? This looks good. One should define what is

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:118-119 TokenType NextLBracesType = TT_Unknown, + bool *HasDoWhile = nullptr, bool *HasLabel = n

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:118-119 TokenType NextLBracesType = TT_Unknown, + bool *HasDoWhile = nullptr,

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1889 TokenCount = Line->Tokens.size(); - if (TokenCount == 1 || - (TokenCount == 2 && Line->Tokens.front().Tok->is(tok::comment))) { Why did you re

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:138 TYPE(CSharpGenericTypeConstraintComma) \ + TYPE(VerilogNumberBase) /* for the base in a number literal, not including \ +

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Can there be a test case, not related to Verilog? Or do we need to wait until you pump up the support for that? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:1121 + const char *Start = Lex->getBufferLocation(); + if (!VerilogToken.match(StringRef(Start, Lex->getBuffer().end() - Start), + &Matches)) Ad

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3498 +/// \endcode +bool AfterPlacementNew; /// If ``true``, put a space between operator overloading and opening Please sort after `AfterOver...` here and all

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

HazardyKnusperkeks added a comment. If you limit it to `Never` I don't see any value in the differentiation. You could just always use `Custom` (by dropping the custom and only having the nested options). But I think having at least the `Always` option would be nice. If you want **always** to

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///true: false: +///__attribute__(( noreturn

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks updated this revision to Diff 541959. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineParser.cpp cl

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. D155529#inline-1505573 But what does `clang-format` without this patch format? I just want to make sure, that

[PATCH] D155783: [clang-format] Fix variable lacks of blank when previous operator is star

HazardyKnusperkeks added a comment. Please provide a diff with the full context (`-U99` will do the trick). And another context is needed, just `x * y` will never be (meaningful) be formatted. At least a `;` is missing, and I'd argue if your example is just ... something ... x * y; ..

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added a comment. Apart from that I'm okay. Comment at: clang/lib/Format/WhitespaceManager.cpp:1428 + // case, it is allowed if there is a replacement for the empty range + // between 2 tokens and another non-empty range at the start of the second +

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

HazardyKnusperkeks added a comment. Everything is fine, I just need to know how the attribute stuff is formatted with plain LLVM style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/ https://reviews.llvm.org/D155239 ___

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

HazardyKnusperkeks added a comment. In D155239#4520081 , @gedare wrote: > In D155239#4520067 , > @HazardyKnusperkeks wrote: > >> Everything is fine, I just need to know how the attribute stuff is formatted >> wi

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Nice work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/ https://reviews.llvm.org/D155239 _

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/ConfigParseTest.cpp:220 CHECK_PARSE_NESTED_BOOL(SpaceBeforeParensOptions, BeforeNonEmptyParentheses); + CHE

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added a comment. For the replacement part, I refer to @owenpan and/or @MyDeveloperDay hoping they have more insight. The rest look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D1

[PATCH] D156065: [clang-format] Insert namespace comments with leading spaces

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:29 +FormatStyle S = Style; +S.SpacesBeforeTrailingComments = 0; tooling::Replacements Replaces = I'd rather fix all the tests. Repository

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. All of those variants are fine by me, but I'd stick with the current version, because it is linked to `AllowShortCaseLabelsOnASingleLine`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/ https://re

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks updated this revision to Diff 543918. HazardyKnusperkeks marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineParser.cpp cl

[PATCH] D156228: [clang-format][NFCish] Obey debug settings

HazardyKnusperkeks created this revision. HazardyKnusperkeks added a reviewer: klimek. HazardyKnusperkeks added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks requested r

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:263 State.StartOfStringLiteral = 0; + State.NoLineBreak = false; State.StartOfLineLevel = 0; Was this uninitialized? Comment at: clang/lib/Fo

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:263 State.StartOfStringLiteral = 0; + State.NoLineBreak = false; State.StartOfLineLevel = 0; jp4a50 wrote: > HazardyKnusperkeks wrote: > > Was this uninitialize

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#4535269 , @MyDeveloperDay wrote: > In D138263#3936536 , > @HazardyKnusperkeks wrote: > >> In D138263#3936007 , @owenpan >

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

HazardyKnusperkeks added a comment. You need some tests to show that the new options really apply like intended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156360/new/ https://reviews.llvm.org/D156360 ___

[PATCH] D156370: [clang-format] Fix bug with parsing of function/variable names.

HazardyKnusperkeks added a comment. Does this result in a different annotation? Could you add a test for that? Comment at: clang/lib/Format/TokenAnnotator.cpp:2211-2212 if (PreviousNotConst->is(tok::r_paren) && -PreviousNotConst->is(TT_TypeDeclarationParen)) { +

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16786 verifyFormat("SomeType *__attribute__( ( attr ) ) *a = NULL;", Spaces); - verifyFormat("void __attribute__( ( naked ) ) foo( int bar )", Spaces); + verifyFormat("void __attribut

[PATCH] D156370: [clang-format] Fix bug with parsing of function/variable names.

HazardyKnusperkeks added a comment. In D156370#4537033 , @gedare wrote: > In D156370#4536793 , > @HazardyKnusperkeks wrote: > >> Does this result in a different annotation? Could you add a test for that? > > If I

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:664-666 +if ((Style.Language == FormatStyle::LK_Cpp || + Style.Language == FormatStyle::LK_ObjC) && +!Current.is(tok::comment) && PrevNonComment &&

[PATCH] D157568: [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:177 llvm::Regex("^/[/*] *(end (of )?)? *(anonymous|unnamed)? *" -

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:3103 + if (!Next) +return Next; + if (Next->is(tok::comment)) Is a bit clea

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

HazardyKnusperkeks added a comment. Please upload the patch with the full context. And add a test case. (From your issue.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363

[PATCH] D158505: [clang-format] Fix weird handling of AfterColon

HazardyKnusperkeks created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks requested review of this revision. This fixes https://github.com/llvm/llvm-project/issues/6

[PATCH] D158505: [clang-format] Fix weird handling of AfterColon

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7995 verifyFormat("Constructor(aa ,\n" - "aa ) :\n" - "aa(aaa

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

HazardyKnusperkeks added a comment. In D158363#4606159 , @d0nc1h0t wrote: > In D158363#4604468 , > @HazardyKnusperkeks wrote: > >> Please upload the patch with the full context. > > I'm creating a patch via 'git

[PATCH] D158505: [clang-format] Fix weird handling of AfterColon

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Will be fixed on commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158505/new/ https://reviews.llvm.org/D158505 __

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2964-2965 if (FormatTok->is(tok::l_brace)) { +FormatToken *LBrace = FormatTok; +LBrace->setFinalizedType(TT_NamespaceLBra

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:657-666 + bool DisallowLineBreaksOnThisLine = [&Style = this->Style, &Current] { +// Deal with lambda arguments in C++. The aim here is to ensure that we +// don't over-indent

[PATCH] D156705: [clang-format] Fix braced initializer formatting with templated base class initializer

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13461 " A() : a{} {}\n" + " A() : Base{} {}\n" " A(int b) : b(b) {}\n" Please also add nested templates. CHANGES SINCE LAST ACTION https://review

[PATCH] D156228: [clang-format][NFCish] Obey debug settings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c3b12b5418f: [clang-format][NFCish] Obey debug settings (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rG77a38f43b168: [clang-format] Supress aligning of trailing namespace comments (authored by Hazard

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added a comment. In D156259#4558570 , @jp4a50 wrote: > @HazardyKnusperkeks could you merge this for me assuming the build is green > please? I don't have merge rights. Thanks. That will have to wait, but if no one else stepped in, I'l

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:223 - if (SpaceOffset != 0) -return BreakableToken::Split(SpaceOffset + 1, 0); + if (NewLine != 0) +return BreakableToken::Split(NewLine, 0); What if the new lin

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added a comment. I'd really prefer you put what you need to modify `mutable` instead of removing the `const` from everything else. But that's just my opinion. Comment at: clang/include/clang/Format/Format.h:1905 + /// + /// In C: /// \code -

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

HazardyKnusperkeks added a comment. Give the author some time is okay, but I think we can and should commandeer at some point and abandon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89918/new/ https://reviews.llvm.org/D89918 __

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added a comment. In D154093#4466597 , @sstwcw wrote: > In D154093#4466246 , > @HazardyKnusperkeks wrote: > >> I'd really prefer you put what you need to modify `mutable` instead of >> removing

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25808 +TEST_F(FormatTest, RemoveParentheses) { + FormatStyle Style = getLLVMStyle(); Should check for `__attribute((what ever))__`. Repository: rG LLVM Github Monor

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. In D151761#4474136 , @galenelias wrote: > I re-wrote the alignment to stop using AlignTokens so that I can now handle > all the edge cases that came up. Specifically: > > - Allowing empty case labels (implicit fall t

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:595-599 +IO.enumCase(Value, "Never", FormatStyle::SWFLS_Never); +IO.enumCase(Value, "false", FormatStyle::SWFLS_Never); +IO.enumCase(Value, "NonEmpty", FormatStyle::SWFLS_NonEmpty); +

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Please wait for other opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154550/new/ https://reviews.llvm.org/D1545

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25808 +TEST_F(FormatTest, RemoveParentheses) { + FormatStyle Style = getLLVMStyle(); owenpan wrote: > HazardyKnusperkeks wrote: > > Should check for `__attribute((what

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:380 +} +bool operator!=(const ShortCaseStatementsAlignmentStyle &R) const { + return !(*this == R); I'd drop that. We don't have it for any other struct. And w

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks for the patience, I'm really looking forward to use this. But please wait for other opinions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D154484#4483659 , @sstwcw wrote: > Did you forget about GNU statement expressions? > > if (({ > foo(); > bar(); > })) { > } I wouldn't haven forgo

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC` or refactoring, adding documentation etc..) Add your unit tests in `c

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1116ed2beb1c: [clang-format] Correctly count a tab's width in a comment (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rGce7356f08194: [clang-format] Don't eat two semicolons after namespace (authored by HazardyKnuspe

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

HazardyKnusperkeks added a comment. Can you mark this change as closed? If you'd put "Differential Revision: https://reviews.llvm.org/D153589"; in your commit message this would have happened automatically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2247 bool DryRun, bool Strict) { - std::unique_ptr Token = + std::unique_ptr Token = createBreakableToken(Current, State, AllowBrea

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4220 /// \version 3.7 bool SpacesInParentheses; The deprecated options should be removed from the struct, see `AllowAllConstructorInitializersOnNextLine` for an exa

[PATCH] D158505: [clang-format] Fix weird handling of AfterColon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e77ba6c1e4d: [clang-format] Fix weird handling of AfterColon (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D158805: [clang-format][NFC] Remove extraneous newlines at end of test cases

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:24187 // Newlines are important here. + verifyFormat("FOO(1+2 )", Style); This. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ReleaseNotes.rst:169 all arguments being able to fit on the same line. +- Avoid unnecessarily aggressive line-breaking when using + ``LambdaBodyIndentation: OuterScope`` with argument bin-packing.

[PATCH] D158945: [clang-format] Handle Template Arguments with AlignConsecutiveXX

HazardyKnusperkeks created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks requested review of this revision. This fixes https://github.com/llvm/llvm-project/issues/6

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

HazardyKnusperkeks added a subscriber: kadircet. HazardyKnusperkeks added a comment. @kadircet shouldn't you at least say why it got reverted? Even better state your problem and give a chance to fix before you revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. But please wait for other opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148131/new/ https://reviews.llvm.org/D

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#3936007 , @owenpan wrote: > I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, > then wouldn't it be better to do that? But the `r_brace` has no `MatchingParen`, and I didn't want t

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#3936536 , @HazardyKnusperkeks wrote: > In D138263#3936007 , @owenpan wrote: > >> I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, >> then

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added a comment. Working on the annotation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263

[PATCH] D138354: [clang-format][NFC] Remove unneeded braces

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, rymiel, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138357: [clang-format][NFC] Don't add a load of 0es

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138358: [clang-format] Match all block braces

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks updated this revision to Diff 476722. HazardyKnusperkeks added a comment. Now with the annotated paren. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLine

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. Closing because of the long silence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22505/new/ https://reviews.llvm.org/D22505 _

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D138371#3939682 , @rymiel wrote: > Oops, nevermind, I misunderstood the loop To understand this is really a tough one. Took

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#3938593 , @owenpan wrote: > Something like the following: > > diff --git a/clang/lib/Format/FormatToken.h b/clang/lib/Format/FormatToken.h > index 87515372046d..3dc5e411df55 100644 > --- a/clang/lib/For

[PATCH] D138385: [clang-format][NFC] Removed unused include

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:1434-1436 + if (Style.UseTab == FormatStyle::UT_Never) { +ReplacementText.append(Spaces, ' '); + } else { owenpan wrote: > Doing this would lose some of

[PATCH] D138354: [clang-format][NFC] Remove unneeded braces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaff838fb8f1d: [clang-format][NFC] Remove unneeded braces (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138357: [clang-format][NFC] Don't add a load of 0es

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e00909b00f9: [clang-format][NFC] Don't add a load of 0es (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D138356: [clang-format][NFC] Format lambda in conditional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc89d2fd596ce: [clang-format][NFC] Format lambda in conditional (authored by HazardyKnusperkeks). Herald added a project: clang. Herald added a subscr

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks added a comment. In D138402#3940981 , @rymiel wrote: > The behaviour of tabs still doesn't match that of spaces, but at least this > makes it idempotent. I did initially looked into that, but then asked do we want to treat tabs equal

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Full disclaimer: I have no idea what sphinx really is or how any of this stuff works, I still generate HTML from doxygen. But I think the solution looks nice in code.

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

HazardyKnusperkeks added a comment. Another point, when looking at that code: All options have the version badge, and any new option should have it too. Maybe the script should just fail if `self.version` is not `true`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } owenpan

[PATCH] D119138: [clang-format] Further improve support for requires expressions

HazardyKnusperkeks added a comment. In D119138#3951749 , @klimek wrote: > Generally, why do we need to have that much information? I.e. why do we need > to know the exact type of the "requires" keyword? > I do understand we need to know the brace type, b

[PATCH] D119138: [clang-format] Further improve support for requires expressions

HazardyKnusperkeks added a comment. In D119138#3951850 , @klimek wrote: > I changed it in 49aca00d63e14df8bc68fc4329e6cbc9c9805eb8 > . > > "We" is the people working on clang-format :)

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

HazardyKnusperkeks added a comment. Can you please add a test with more than one newline? Comment at: clang/unittests/Format/FormatTestComments.cpp:3065-3075 + EXPECT_EQ("// do not touch\n" +"int a; // any comments\n\n" +" // comment\n" +

<    2   3   4   5   6   7   8   9   10   11   >