bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Thanks!
http://reviews.llvm.org/D21290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: d0k
Date: Wed Jun 15 09:20:56 2016
New Revision: 272789
URL: http://llvm.org/viewvc/llvm-project?rev=272789&view=rev
Log:
Apply some suggestions from clang-tidy's performance-unnecessary-value-param.
No functionality change intended.
Modified:
cfe/trunk/lib/AST/ASTDiagnostic.cpp
Author: d0k
Date: Wed Jun 15 10:46:10 2016
New Revision: 272795
URL: http://llvm.org/viewvc/llvm-project?rev=272795&view=rev
Log:
Apply performance-unnecessary-value-param to clang-tidy.
With minor manual tweaks. No functionality change intended.
Modified:
clang-tools-extra/trunk/clang-tidy/
Author: d0k
Date: Wed Jun 15 11:51:04 2016
New Revision: 272803
URL: http://llvm.org/viewvc/llvm-project?rev=272803&view=rev
Log:
[clang-tidy] Remove dead code. NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertUtils.cpp
clang-tools-extra/trunk/clang-tidy/modernize/Lo
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
If there's no more executable size bloat this seems fine to me.
http://reviews.llvm.org/D20382
___
cfe-commits mailing list
cfe-commits@lists.l
Author: d0k
Date: Thu Jun 30 04:17:46 2016
New Revision: 274221
URL: http://llvm.org/viewvc/llvm-project?rev=274221&view=rev
Log:
Enable opencl driver tests, which never ran.
Then mark it as XFAIL because it always fails. I'll let OpenCL people
figure this out.
Modified:
cfe/trunk/test/Drive
The opencl.cl test never ran due to a lit misconfiguration (see
r274221). Now that's fixed but the test doesn't pass, so I marked it
as XFAIL. Can you take a look?
On Wed, Jun 29, 2016 at 9:39 PM, Yaxun Liu via cfe-commits
wrote:
> Author: yaxunl
> Date: Wed Jun 29 14:39:32 2016
> New Revision: 2
On Tue, Mar 22, 2016 at 1:09 AM, Justin Lebar via cfe-commits
wrote:
> Author: jlebar
> Date: Mon Mar 21 19:09:25 2016
> New Revision: 264008
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264008&view=rev
> Log:
> [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.
>
> Summary: NFC
Author: d0k
Date: Sat Jul 2 06:41:41 2016
New Revision: 274432
URL: http://llvm.org/viewvc/llvm-project?rev=274432&view=rev
Log:
Use arrays or initializer lists to feed ArrayRefs instead of SmallVector where
possible.
No functionality change intended
Modified:
cfe/trunk/include/clang/Sema/
Author: d0k
Date: Sat Jul 2 07:03:57 2016
New Revision: 274433
URL: http://llvm.org/viewvc/llvm-project?rev=274433&view=rev
Log:
[CUDA] Move argument type lists to the stack. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGCUDANV.cpp
Modified: cfe/trunk/lib/CodeGen/CGCUDANV.cpp
URL:
http://llvm.org
bkramer added inline comments.
Comment at: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp:16
@@ -15,2 +15,3 @@
const HeaderMapCollector::HeaderMap *getSTLPostfixHeaderMap() {
static const HeaderMapCollector::HeaderMap STLPostfixHeaderMap = {
+ {"include/__stddef_m
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
If the regex construction turns out to be too slow we can fix it later. LGTM
for now.
http://reviews.llvm.org/D21787
___
cfe-commits mailing l
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Thanks. Do you have commit access?
http://reviews.llvm.org/D21974
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: d0k
Date: Mon Jul 4 11:47:17 2016
New Revision: 274511
URL: http://llvm.org/viewvc/llvm-project?rev=274511&view=rev
Log:
[clang-include-fixer] fix PEP8 warnings
This fixes PEP8 E231, E225, E226, E302 warnings.
Patch by Kirill Bobyrev!
Differential revision: http://reviews.llvm.org/D219
bkramer added a comment.
In the future I'd prefer to have patches like this split up in a part that
refactors and a part that contains the actual change. Having that in one patch
makes it really hard to review.
Comment at: include-fixer/IncludeFixer.cpp:73
@@ -72,2 +72,3 @@
bkramer accepted this revision.
bkramer added a reviewer: bkramer.
bkramer added a comment.
This revision is now accepted and ready to land.
I think this can go in now.
http://reviews.llvm.org/D21603
___
cfe-commits mailing list
cfe-commits@lists.ll
bkramer added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:39
@@ -38,3 +38,2 @@
#include "llvm/Support/Host.h"
-#include
#include
This looks unrelated.
Comment at: clang-rename/tool/clang-rename.py:14
@@ +13,3 @@
+
+All you
bkramer added a comment.
In http://reviews.llvm.org/D21814#475322, @klimek wrote:
> I think we really want 2 tools:
> a) one that is optimized for oldname->newname renames, and supports the
> multi-TU case really well
> b) one that is meant to be integrated with editors and works mainly off of
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
looks good. Still no commit access? ;)
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
bkramer added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:39
@@ -38,3 +38,2 @@
#include "llvm/Support/Host.h"
-#include
#include
omtcyf0 wrote:
> bkramer wrote:
> > This looks unrelated.
> Right, but I'm not sure one-line patches are welcome
Author: d0k
Date: Thu Jul 7 09:35:32 2016
New Revision: 274759
URL: http://llvm.org/viewvc/llvm-project?rev=274759&view=rev
Log:
[clang-rename] add basic vim integration
This patch introduces basic Vim integration for clang-rename tool.
For setup reference see clang-rename/tool/clang-rename.py
bkramer added inline comments.
Comment at: clang-rename/USRLocFinder.h:38
@@ -37,2 +37,2 @@
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
In LLVM we usually have only one space be
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This looks like the right thing to do to me.
http://reviews.llvm.org/D22127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Author: d0k
Date: Sat Jul 9 06:16:56 2016
New Revision: 274974
URL: http://llvm.org/viewvc/llvm-project?rev=274974&view=rev
Log:
[analyzer] Rewrite manual erase loop using remove_if.
No functionality change intended.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChec
Author: d0k
Date: Sat Jul 9 07:16:58 2016
New Revision: 274975
URL: http://llvm.org/viewvc/llvm-project?rev=274975&view=rev
Log:
[analyzer] Older version of GCC 4.7 crash on lambdas in default arguments.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp
Modif
bkramer added inline comments.
Comment at: docs/clang-rename.rst:17
@@ +16,3 @@
+
+The tool development is in very early stage, so you might encounter bugs and
+crashes. Submitting reports with information about how to reproduce the issue
maybe 'is in a very early
bkramer added inline comments.
Comment at: include-fixer/IncludeFixerContext.cpp:54
@@ +53,3 @@
+llvm::StringRef Name, llvm::StringRef ScopeQualifiers,
+const std::vector Symbols,
+tooling::Range Range)
Drop the const ...
Comment at:
bkramer added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+assert(!HeaderInfos.empty());
+// Only accept an unique header.
+bool IsUniqueHeader = std::equal(
In that case adjacent_find was the right choice, bu
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
One nit, LGTM.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:277
@@ +276,3 @@
+//
+// Check whether all elements in HeaderInfos have the qualified name.
+
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D22129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
bkramer added inline comments.
Comment at: include-fixer/IncludeFixerContext.cpp:46
@@ +45,3 @@
+ bool HasScopedQualifiersPrefix =
+ FullyQualifiedName.find(SymbolScopedQualifiers) == 0;
+ if (!HasScopedQualifiersPrefix)
StringRef(FullyQualifiedName).starts
bkramer added a comment.
on it ...
http://reviews.llvm.org/D22091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Thu Jul 14 04:46:07 2016
New Revision: 275388
URL: http://llvm.org/viewvc/llvm-project?rev=275388&view=rev
Log:
[clang-rename] add documentation
clang-rename needs at least to have a minimum documentation to provide a
small introduction for new users
Patch by Kirill Bobyrev!
D
Author: d0k
Date: Thu Jul 14 04:46:03 2016
New Revision: 275387
URL: http://llvm.org/viewvc/llvm-project?rev=275387&view=rev
Log:
[clang-rename] exit code-related bugfix and code cleanup
This patch does the following:
* enforces proper formatting for few files (i.e. deals with 80 linewidth
viol
Author: d0k
Date: Thu Jul 14 07:56:21 2016
New Revision: 275405
URL: http://llvm.org/viewvc/llvm-project?rev=275405&view=rev
Log:
[OpenCL] Actually activate Frontend/opencl.cl test and fix test bugs
rL275318 added the test Frontend/opencl.cl test, but that test was never
actually run because Fro
bkramer added a subscriber: bkramer.
bkramer accepted this revision.
bkramer added a reviewer: bkramer.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D22310
___
cfe-commits mailing list
cfe-com
Author: d0k
Date: Thu Jul 14 08:15:37 2016
New Revision: 275409
URL: http://llvm.org/viewvc/llvm-project?rev=275409&view=rev
Log:
Upgrade all the .arcconfigs to https.
Modified:
cfe/trunk/.arcconfig
Modified: cfe/trunk/.arcconfig
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/.arcconfig
Author: d0k
Date: Thu Jul 14 08:15:37 2016
New Revision: 275409
URL: http://llvm.org/viewvc/llvm-project?rev=275409&view=rev
Log:
Upgrade all the .arcconfigs to https.
Modified:
clang-tools-extra/trunk/.arcconfig
Modified: clang-tools-extra/trunk/.arcconfig
URL:
http://llvm.org/viewvc/llvm-
Author: d0k
Date: Thu Jul 14 10:06:57 2016
New Revision: 275428
URL: http://llvm.org/viewvc/llvm-project?rev=275428&view=rev
Log:
[OpenCL] In test/Driver/opencl.cl, don't require name of Clang binary to
contain "clang"
The test currently fails if the name of the Clang binary doesn't contain
"cl
bkramer added a comment.
I'm not entirely sure if jumping cursors are a good user interface. It will
completely throw the user out of context, which is exactly what we want to
avoid with include-fixer.
https://reviews.llvm.org/D22351
___
cfe-commi
bkramer accepted this revision.
This revision is now accepted and ready to land.
Comment at: include-fixer/IncludeFixerContext.cpp:54
@@ -49,2 +53,3 @@
- return FullyQualifiedName;
+ auto FullySymbolQualifiers = SplitQualifiers(FullyQualifiedName);
+ auto ScopedQualifiers = S
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm now
https://reviews.llvm.org/D22351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
bkramer added a comment.
This doesn't have a test case. Also I don't understand why this is the correct
fix. If someone is calling one of those method with a file SourceLocation (as
opposed to a macro SourceLocation) they should stop doing that.
Repository:
rL LLVM
http://reviews.llvm.org/D
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
This is a sad workaround for the lack of plugin support in libclang. Depends
on D17807, a tools-extra change that also contains the test case.
This is designed to be easy to remove again if l
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
This doesn't really do much at the moment. You can load it via libclang
and set the -checks via an extra command line argument as illustrated in
the test case. Support for other options (inclu
several have been with LLVM)) or
> because they're project specific (either stylistically, or because they're
> about some project specific API))
>
> On Wed, Mar 2, 2016 at 6:47 AM, Benjamin Kramer via cfe-commits
> wrote:
>>
>> bkramer created this revision.
&
Author: d0k
Date: Thu Mar 3 02:58:12 2016
New Revision: 262595
URL: http://llvm.org/viewvc/llvm-project?rev=262595&view=rev
Log:
[clang-tidy] Add "clang-tidy as a clang plugin" skeleton.
This doesn't really do much at the moment. You can load it via libclang
and set the -checks via an extra comm
Author: d0k
Date: Thu Mar 3 02:58:18 2016
New Revision: 262596
URL: http://llvm.org/viewvc/llvm-project?rev=262596&view=rev
Log:
[libclang] Link clang-tidy plugin into libclang if present.
This is a sad workaround for the lack of plugin support in libclang. Depends
on D17807, a tools-extra chang
bkramer added a comment.
This doesn't look right to me. Aborting tree transform on a bad source location
seems just wrong. Where is the invalid source location coming from? Also the
backtrace seems related to typo correction, maybe the bug is there?
Repository:
rL LLVM
http://reviews.llvm.o
Author: d0k
Date: Fri Mar 4 08:18:52 2016
New Revision: 262716
URL: http://llvm.org/viewvc/llvm-project?rev=262716&view=rev
Log:
Move class into anonymous namespace. NFC.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Check
bkramer added a comment.
I'm still not sure if this is the right way to fix it. Maybe @rsmith has an
opinion?
http://reviews.llvm.org/D17762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
bkramer created this revision.
bkramer added reviewers: rsmith, rjmccall.
bkramer added a subscriber: cfe-commits.
Also thread -f(no-)delete-null-pointer-checks through to CodeGen and
make it disable this behavior. It's not a full implementation of that
flag but it would be good to stay compatible
bkramer added a comment.
GCC 6 is already doing this and people are already annotating their builds with
-fno-delete-null-pointer-checks. Putting it under a different flag will break
compatibility there :(
http://reviews.llvm.org/D17993
___
cfe-co
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Patch looks good, only one cosmetic comment.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:232
@@ +231,3 @@
+ if (!getMacroAndArgLocations(StartLoc, ImmediateMar
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D18141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: d0k
Date: Mon Mar 14 08:23:58 2016
New Revision: 263429
URL: http://llvm.org/viewvc/llvm-project?rev=263429&view=rev
Log:
[Frontend] Disable value name discarding for all sanitizers.
ASan also relies on names on allocas and will emit unhelpful output if
they're not present. Just force-ena
Author: d0k
Date: Mon Mar 14 09:58:28 2016
New Revision: 263436
URL: http://llvm.org/viewvc/llvm-project?rev=263436&view=rev
Log:
Revert "Recommitted r261634 "Supporting all entities declared in lexical scope
in LLVM debug info." After fixing PR26715 at r263379."
This reverts commit r263425. Bre
e using debug info
>> instead of alloca names for this, and I really thought that they had
>> implemented this... Is that not the case?
>>
>> It is really bad that the sanitizers are relying on this stuff...
>>
>> On Mon, Mar 14, 2016 at 2:28 PM Benjamin Kramer v
Author: d0k
Date: Tue Mar 15 04:41:39 2016
New Revision: 263541
URL: http://llvm.org/viewvc/llvm-project?rev=263541&view=rev
Log:
Restrict the hack from r263429 to asan and msan.
The other sanitizers don't have backend passes that rely on value names.
Avoid paying the compile time cost of names t
On Mon, Mar 14, 2016 at 5:50 PM, Richard Smith wrote:
> On 14 Mar 2016 6:28 a.m., "Benjamin Kramer via cfe-commits"
> wrote:
>>
>> Author: d0k
>> Date: Mon Mar 14 08:23:58 2016
>> New Revision: 263429
>>
>> URL: http://llvm.org/viewvc/l
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This looks fine to me.
Repository:
rL LLVM
http://reviews.llvm.org/D17959
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
bkramer accepted this revision.
bkramer added a comment.
This looks good, thanks for the patch. When this goes in please watch the
windows buildbots as plugin support on windows is somewhat broken and we may
have to disable tests there.
Also, while this is a strict improvement and should go in
Author: d0k
Date: Thu Mar 17 11:19:51 2016
New Revision: 263718
URL: http://llvm.org/viewvc/llvm-project?rev=263718&view=rev
Log:
Use a simpler set of mock headers for the vfs+modules crash recovery tests.
The System/ mock is large and too complex for this test. It can cause
the tests to fail in
On Fri, Mar 18, 2016 at 5:10 PM, David Blaikie wrote:
>
>
> On Fri, Mar 18, 2016 at 6:31 AM, Benjamin Kramer via cfe-commits
> wrote:
>>
>> Author: d0k
>> Date: Fri Mar 18 08:31:00 2016
>> New Revision: 263785
>>
>> URL: http://llvm.org/viewvc/
Author: d0k
Date: Fri Mar 18 08:31:00 2016
New Revision: 263785
URL: http://llvm.org/viewvc/llvm-project?rev=263785&view=rev
Log:
Make LookupResult movable again.
We lost copy semantics in r263730, because it only worked for a few very
specific cases. Move semantics don't have this issue. Sadly t
On Sun, Mar 20, 2016 at 3:08 AM, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Sat Mar 19 21:08:48 2016
> New Revision: 263893
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263893&view=rev
> Log:
> Reapply [2] [VFS] Add 'overlay-relative' field to YAML files
>
> This reappl
Author: d0k
Date: Sun Mar 20 09:24:49 2016
New Revision: 263900
URL: http://llvm.org/viewvc/llvm-project?rev=263900&view=rev
Log:
[clang-tidy] Update check for API change in r263895.
for range stmts now have split begin and ends, just apply OR to the
condition. Should unbreak the build.
Modified
On Tue, Dec 29, 2015 at 5:14 PM, Alexander Kornienko via cfe-commits
wrote:
> Author: alexfh
> Date: Tue Dec 29 10:14:38 2015
> New Revision: 256562
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256562&view=rev
> Log:
> [clang-tidy] Fix a use-after-free bug found by asan
>
> Modified:
>
>
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix!
Comment at: tools/libclang/CIndexInclusionStack.cpp:32
@@ -36,13 +31,3 @@
SmallVector InclusionStack;
- unsigned n = SM.local_sloc_entry_size(
On Sat, Jan 9, 2016 at 4:56 PM, Daniel Jasper via cfe-commits
wrote:
> Author: djasper
> Date: Sat Jan 9 09:56:57 2016
> New Revision: 257259
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257259&view=rev
> Log:
> Make clang::format::reformat work with non 0-terminated strings.
>
> Modified:
>
Author: d0k
Date: Sat Jan 9 10:33:16 2016
New Revision: 257260
URL: http://llvm.org/viewvc/llvm-project?rev=257260&view=rev
Log:
[vfs] Normalize working directory if requested.
FixedCompilationDatabase sets the working dir to "." by default. For
chdir(".") this is a noop but this lead to InMemor
Author: d0k
Date: Sun Jan 10 04:36:59 2016
New Revision: 257286
URL: http://llvm.org/viewvc/llvm-project?rev=257286&view=rev
Log:
Make test work on windows by turning \ in paths back into /.
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/Basic/Vir
Author: d0k
Date: Sun Jan 10 04:45:19 2016
New Revision: 257287
URL: http://llvm.org/viewvc/llvm-project?rev=257287&view=rev
Log:
Simplify test code with initializer lists.
No functional change intended.
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unitt
Fixed in r257286, sorry for the breakage.
On Sun, Jan 10, 2016 at 7:59 AM, Ismail Donmez wrote:
> Hi,
>
>> + NormalizedFS.setCurrentWorkingDirectory("/b/c");
>> + NormalizedFS.setCurrentWorkingDirectory(".");
>> + ASSERT_EQ("/b/c", NormalizedFS.getCurrentWorkingDirectory().get());
>> + Normal
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This looks good. getAsTemplateOrTemplatePattern mirrors the existing switch in
TreeTransform.
http://reviews.llvm.org/D15743
___
cfe-commits m
bkramer created this revision.
bkramer added a reviewer: djasper.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
As soon as a comment had whitespace changes inside of the token, we
couldn't identify the whole comment as a trailing comment anymore and
alignment stopped
bkramer updated this revision to Diff 44472.
bkramer added a comment.
Why not both?
http://reviews.llvm.org/D16058
Files:
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
bkramer updated this revision to Diff 44508.
bkramer added a comment.
- Renamed flag to IsInsideToken and enabled it for all in-token replacements.
- TokenLength now gets updated to contain all changes on the same line if
they're in the same token.
http://reviews.llvm.org/D16058
Files:
lib/F
bkramer updated this revision to Diff 44513.
bkramer added a comment.
- Moved newline check into replaceWhitespaceInToken
- Removed duplicated TokenLength computation
http://reviews.llvm.org/D16058
Files:
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager.h
unittests/Format/For
Author: d0k
Date: Mon Jan 11 10:27:16 2016
New Revision: 257341
URL: http://llvm.org/viewvc/llvm-project?rev=257341&view=rev
Log:
[clang-format] Fix comment aligning when there are changes within the comment
As soon as a comment had whitespace changes inside of the token, we
couldn't identify the
On Mon, Jan 11, 2016 at 8:08 PM, Owen Anderson wrote:
>
>> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote:
>>
>>
>>
>> On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits
>> wrote:
>> resistor created this revision.
>> resistor added reviewers: chandlerc, bkramer, klimek.
>> resis
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
After pondering this patch for a while I couldn't come up with a case where
this would cause problems, but it provides great improvements for editing
headers in an interactive setup. So LGTM
On Fri, Jan 15, 2016 at 11:52 PM, David Blaikie via cfe-commits
wrote:
>
>
> On Fri, Jan 15, 2016 at 2:29 PM, Joerg Sonnenberger via cfe-commits
> wrote:
>>
>> Author: joerg
>> Date: Fri Jan 15 16:29:34 2016
>> New Revision: 257947
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=257947&view=re
Author: d0k
Date: Mon Jan 25 04:34:06 2016
New Revision: 258679
URL: http://llvm.org/viewvc/llvm-project?rev=258679&view=rev
Log:
Fix printing of types in initializers with suppressed tags.
Tag and specifier printing can be suppressed in Decl::printGroup, but these
suppressions leak into the ini
bkramer accepted this revision.
bkramer added a reviewer: bkramer.
bkramer added a comment.
This revision is now accepted and ready to land.
Looks good to me, but I don't really now CUDA.
http://reviews.llvm.org/D16559
___
cfe-commits mailing list
c
Author: d0k
Date: Wed Jan 27 04:01:30 2016
New Revision: 258918
URL: http://llvm.org/viewvc/llvm-project?rev=258918&view=rev
Log:
Update for LLVM change.
Modified:
cfe/trunk/lib/Parse/ParseStmtAsm.cpp
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp
UR
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This can be used as a way to modify argv[0] for a clang tool.
http://reviews.llvm.org/D16718
Files:
include/clang/Tooling/Tooling.h
lib/Tooling/Tooling
bkramer updated this revision to Diff 46370.
bkramer added a comment.
Fix comment.
http://reviews.llvm.org/D16718
Files:
include/clang/Tooling/Tooling.h
lib/Tooling/Tooling.cpp
unittests/ASTMatchers/ASTMatchersTest.h
Index: unittests/ASTMatchers/ASTMatchersTest.h
Author: d0k
Date: Fri Jan 29 05:29:02 2016
New Revision: 259187
URL: http://llvm.org/viewvc/llvm-project?rev=259187&view=rev
Log:
Add an optional ToolName argument to
runToolOnCodeWithArgs/buildASTFromCodeWithArgs.
This can be used as a way to modify argv[0] for a clang tool.
Differential Revis
bkramer added a subscriber: bkramer.
bkramer added a comment.
Why are you re-adding all those Makefiles?
http://reviews.llvm.org/D16529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: d0k
Date: Sat Jan 30 06:16:23 2016
New Revision: 259304
URL: http://llvm.org/viewvc/llvm-project?rev=259304&view=rev
Log:
[AST] Pull simple method inline.
Modified:
cfe/trunk/include/clang/AST/ASTTypeTraits.h
cfe/trunk/lib/AST/ASTTypeTraits.cpp
Modified: cfe/trunk/include/clang/A
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
This provides both a more uniform interface and makes libclang behave like
clang tooling wrt relative paths against argv[0]. This is necessary for
finding paths to a c++ standard library relat
bkramer updated this revision to Diff 40269.
bkramer added a comment.
- Add a test case to make sure argv[0] handling actually works.
- Clarify comments a bit.
http://reviews.llvm.org/D14695
Files:
include/clang-c/Index.h
lib/Frontend/CreateInvocationFromCommandLine.cpp
tools/diagtool/Sho
Author: d0k
Date: Wed Nov 18 10:14:27 2015
New Revision: 253466
URL: http://llvm.org/viewvc/llvm-project?rev=253466&view=rev
Log:
[libclang] Add entry points that take a full command line including argv[0].
This provides both a more uniform interface and makes libclang behave like
clang tooling w
Author: d0k
Date: Fri Nov 20 01:57:46 2015
New Revision: 253654
URL: http://llvm.org/viewvc/llvm-project?rev=253654&view=rev
Log:
Regenerate ASTMatchersReference without CRLF.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersReference.html
URL:
ht
Author: d0k
Date: Tue Dec 1 13:42:07 2015
New Revision: 254446
URL: http://llvm.org/viewvc/llvm-project?rev=254446&view=rev
Log:
Avoid picking up system headers in unittest by providing a fake libstdc++ with
a ridiculously high version number.
The host libstdc++ may be horribly broken and we wa
bkramer created this revision.
bkramer added reviewers: djasper, klimek.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
/* a
* a*/
Now becomes
/*
* a a*/
instead of
/*
* a
* a*/
This is implemented by glueing the next line on while f
bkramer created this revision.
bkramer added reviewers: doug.gregor, klimek.
bkramer added a subscriber: cfe-commits.
The current default is to create the preamble on the first reparse, aka
second parse. This is useful for clients that do not want to block when
opening a file because serializing t
bkramer updated this revision to Diff 42749.
bkramer added a comment.
Add test case.
http://reviews.llvm.org/D15490
Files:
include/clang-c/Index.h
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
test/Index/complete-preamble.cpp
tools/c-index-test/c-index-test.c
tools/libcl
Author: d0k
Date: Tue Dec 15 03:30:31 2015
New Revision: 255635
URL: http://llvm.org/viewvc/llvm-project?rev=255635&view=rev
Log:
[libclang] Add a flag to create the precompiled preamble on the first parse.
Summary:
The current default is to create the preamble on the first reparse, aka
second pa
801 - 900 of 936 matches
Mail list logo
