Author: d0k
Date: Mon Oct 5 08:55:20 2015
New Revision: 249316
URL: http://llvm.org/viewvc/llvm-project?rev=249316&view=rev
Log:
[VFS] Add working directories to every virtual file system.
For RealFileSystem this is getcwd()/chdir(), the synthetic file systems can
make up one for themselves. Ove
Author: d0k
Date: Mon Oct 5 08:55:14 2015
New Revision: 249315
URL: http://llvm.org/viewvc/llvm-project?rev=249315&view=rev
Log:
[VFS] Add an in-memory file system implementation.
This is a simple file system tree of memory buffers that can be filled by a
client. In conjunction with an OverlayFS
Author: d0k
Date: Mon Oct 5 09:02:15 2015
New Revision: 249318
URL: http://llvm.org/viewvc/llvm-project?rev=249318&view=rev
Log:
[VFS] Fix compilation on systems where time_t is not int64_t.
No functional change intended.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modified: cfe/tr
Author: d0k
Date: Mon Oct 5 09:06:36 2015
New Revision: 249319
URL: http://llvm.org/viewvc/llvm-project?rev=249319&view=rev
Log:
[VFS] Fix the windows build by including the right headers.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cp
Author: d0k
Date: Mon Oct 5 16:20:19 2015
New Revision: 249355
URL: http://llvm.org/viewvc/llvm-project?rev=249355&view=rev
Log:
Remove duplicated default arguments. NFC.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp
URL:
http://llv
On Mon, Oct 5, 2015 at 11:13 PM, Richard Smith
wrote:
> On Mon, Oct 5, 2015 at 6:55 AM, Benjamin Kramer via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: d0k
>> Date: Mon Oct 5 08:55:09 2015
>> New Revision: 249314
>>
>> URL: http:/
Author: d0k
Date: Tue Oct 6 05:04:08 2015
New Revision: 249385
URL: http://llvm.org/viewvc/llvm-project?rev=249385&view=rev
Log:
[VFS] Transition clang-format to use an in-memory FS.
Apart from being cleaner this also means that clang-format no longer has
access to the host file system. This isn
Author: d0k
Date: Tue Oct 6 05:23:17 2015
New Revision: 249388
URL: http://llvm.org/viewvc/llvm-project?rev=249388&view=rev
Log:
[VFS] Port applyAllReplacements to InMemoryFileSystem.
Modified:
cfe/trunk/lib/Tooling/Core/Replacement.cpp
Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp
U
Author: d0k
Date: Tue Oct 6 05:23:34 2015
New Revision: 249389
URL: http://llvm.org/viewvc/llvm-project?rev=249389&view=rev
Log:
[VFS] Port SimpleFormatContext to InMemoryFileSystem.
Modified:
cfe/trunk/lib/Index/SimpleFormatContext.h
Modified: cfe/trunk/lib/Index/SimpleFormatContext.h
URL:
Author: d0k
Date: Tue Oct 6 09:45:20 2015
New Revision: 249410
URL: http://llvm.org/viewvc/llvm-project?rev=249410&view=rev
Log:
[Tooling] Reuse FileManager in ASTUnit.
ASTUnit was creating multiple FileManagers and throwing them away. Reuse
the one from Tooling. No functionality change now but
Author: d0k
Date: Tue Oct 6 09:45:16 2015
New Revision: 249409
URL: http://llvm.org/viewvc/llvm-project?rev=249409&view=rev
Log:
[VFS] Put the incoming name in the file status to make InMemoryFS behave more
like a real FS.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
cfe/trunk/un
Author: d0k
Date: Tue Oct 6 09:45:13 2015
New Revision: 249408
URL: http://llvm.org/viewvc/llvm-project?rev=249408&view=rev
Log:
[Tooling] Remove dead code.
It took me some time to figure out why this is not working as expected:
std:error_code converts to true if there is an error. This means we
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This means file remappings can now be managed by ClangTool (or a
ToolInvocation user) instead of by ToolInvocation itself. The
ToolInvocation remapping is st
Author: d0k
Date: Tue Oct 6 10:04:13 2015
New Revision: 249413
URL: http://llvm.org/viewvc/llvm-project?rev=249413&view=rev
Log:
[Tooling] Don't run a tool invocation without a FileManager.
Fixes a crash regression from r249410.
Modified:
cfe/trunk/lib/Tooling/Tooling.cpp
Modified: cfe/tru
bkramer updated this revision to Diff 36632.
bkramer added a comment.
- Don't rebuild VFS for every compile command
- Still have to guard against multiple runs of one Tool,
ClangToolTest.ArgumentAdjusters does that.
http://reviews.llvm.org/D13474
Files:
include/clang/Tooling/Tooling.h
lib/
Author: d0k
Date: Wed Oct 7 03:32:50 2015
New Revision: 249525
URL: http://llvm.org/viewvc/llvm-project?rev=249525&view=rev
Log:
[VFS] Also drop '.' when adding files to an in-memory FS.
Otherwise we won't be able to find them later.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
c
Author: d0k
Date: Wed Oct 7 03:35:23 2015
New Revision: 249526
URL: http://llvm.org/viewvc/llvm-project?rev=249526&view=rev
Log:
[VFS] Switch clang-tidy tests to use an in-memory fs.
Again, this is both cleaner and completely removes any depedency on the
host file system.
Modified:
clang-to
Author: d0k
Date: Wed Oct 7 05:05:44 2015
New Revision: 249532
URL: http://llvm.org/viewvc/llvm-project?rev=249532&view=rev
Log:
[VFS] Refactor VFSFromYAML a bit.
- Rename it to RedirectingFileSystem. This is what it does, YAML is just a
serialization format for it.
- Consistently use unique_p
Author: d0k
Date: Wed Oct 7 10:48:01 2015
New Revision: 249556
URL: http://llvm.org/viewvc/llvm-project?rev=249556&view=rev
Log:
[VFS] Port driver tool chains to VFS.
There are still some loose ends here but it's sufficient so we can detect
GCC headers that are inside of a VFS.
Added:
cfe/t
Author: d0k
Date: Tue Aug 18 03:10:39 2015
New Revision: 245271
URL: http://llvm.org/viewvc/llvm-project?rev=245271&view=rev
Log:
[TreeTransform] Simplify code. No functionality change.
Modified:
cfe/trunk/lib/Sema/TreeTransform.h
Modified: cfe/trunk/lib/Sema/TreeTransform.h
URL:
http://llv
Author: d0k
Date: Thu Aug 20 04:47:06 2015
New Revision: 245548
URL: http://llvm.org/viewvc/llvm-project?rev=245548&view=rev
Log:
[clang-tidy] Fold the meat of the UseNullPtrCheck into an anonymous namespace.
While convenient, RecursiveASTVisitor generates a ridiculous amount of dead
template cod
bkramer added a subscriber: bkramer.
bkramer added a comment.
Is this tested? I'd expect a crash when constructing a StringRef implicitly
from nullptr.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:341
@@ -340,3 +340,3 @@
SourceMgr.getFileID(Range.getEnd()))
-
bkramer added a comment.
In http://reviews.llvm.org/D12186#228702, @angelgarcia wrote:
> It is allowed as long as you specify that the length is 0.
I meant the code before your change, which calls `StringRef(const char *Str)`
and completely disallows nullptr. In other words: this change is mis
bkramer accepted this revision.
bkramer added a reviewer: bkramer.
bkramer added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D12186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: d0k
Date: Fri Aug 21 07:51:01 2015
New Revision: 245700
URL: http://llvm.org/viewvc/llvm-project?rev=245700&view=rev
Log:
[RecordLayoutBuilder] Remove duplicated diagnostic argument. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/AST/RecordLayout
Author: d0k
Date: Fri Aug 21 07:29:47 2015
New Revision: 245698
URL: http://llvm.org/viewvc/llvm-project?rev=245698&view=rev
Log:
Remove unused diagnostic.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL:
http
bkramer added a subscriber: bkramer.
bkramer added a comment.
Won't this do the wrong thing for embedded '\0' in a std::string?
std::string("hello\0world", 11).compare("hello")
should not return 0.
http://reviews.llvm.org/D12355
___
cfe-commits
Author: d0k
Date: Sun Aug 30 10:12:28 2015
New Revision: 246384
URL: http://llvm.org/viewvc/llvm-project?rev=246384&view=rev
Log:
[OpenMP] Make the filetered clause iterator a real iterator and type safe.
This replaces the filtered generic iterator with a type-specfic one based
on dyn_cast instea
Author: d0k
Date: Mon Aug 31 11:45:35 2015
New Revision: 246452
URL: http://llvm.org/viewvc/llvm-project?rev=246452&view=rev
Log:
[OpenMP] base specific_clause_iterator on iterator_adaptor_base.
Removes some boilerplate code. No functionality change intended.
Modified:
cfe/trunk/include/clan
r_adaptor_base seems to be doing the right thing even
when ++ is overridden.
- Ben
> On Sun, Aug 30, 2015 at 8:12 AM, Benjamin Kramer via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: d0k
>> Date: Sun Aug 30 10:12:28 2015
>> New Revision: 246384
>
> On 02.09.2015, at 02:12, Eric Christopher via cfe-commits
> wrote:
>
> Author: echristo
> Date: Tue Sep 1 19:12:02 2015
> New Revision: 246610
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246610&view=rev
> Log:
> Migrate the target attribute parsing code into an extension off of
> the m
Author: d0k
Date: Wed Sep 2 10:31:05 2015
New Revision: 246657
URL: http://llvm.org/viewvc/llvm-project?rev=246657&view=rev
Log:
[OpenMP] Make helper functoin static. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL:
http://ll
Author: d0k
Date: Wed Oct 7 15:19:25 2015
New Revision: 249608
URL: http://llvm.org/viewvc/llvm-project?rev=249608&view=rev
Log:
Fix a shared CMake build by linking with libclangBasic.
Patch by Jan Vesely!
Modified:
cfe/trunk/unittests/Driver/CMakeLists.txt
Modified: cfe/trunk/unittests/Dr
:DiagnosticConsumer::HandleDiagnostic(clang::DiagnosticsEngine::Level,
> clang::Diagnostic const&)'
> collect2: error: ld returned 1 exit status
>
> using Diagnostics requires linking to libclangBasic. Please consider the
> attached patch.
r249608. Thanks!
- Ben
>
> O
Author: d0k
Date: Thu Oct 8 05:31:17 2015
New Revision: 249676
URL: http://llvm.org/viewvc/llvm-project?rev=249676&view=rev
Log:
[Driver] Use Twine instead of itostr. NFC.
No need to construct temporary std::strings here.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Dri
Author: d0k
Date: Thu Oct 8 09:20:14 2015
New Revision: 249693
URL: http://llvm.org/viewvc/llvm-project?rev=249693&view=rev
Log:
[VFS] Use VFS instead of virtual files in PPCallbacks test.
Modified:
cfe/trunk/unittests/Lex/PPCallbacksTest.cpp
Modified: cfe/trunk/unittests/Lex/PPCallbacksTes
Author: d0k
Date: Fri Oct 9 04:54:37 2015
New Revision: 249815
URL: http://llvm.org/viewvc/llvm-project?rev=249815&view=rev
Log:
[VFS] Port tooling to use the in-memory file system.
This means file remappings can now be managed by ClangTool (or a
ToolInvocation user) instead of by ToolInvocation
Author: d0k
Date: Fri Oct 9 08:03:22 2015
New Revision: 249830
URL: http://llvm.org/viewvc/llvm-project?rev=249830&view=rev
Log:
[VFS] Just normalize away .. and . in paths for in-memory file systems.
This simplifies the code and gets us support for .. for free.
Modified:
cfe/trunk/include/
Author: d0k
Date: Fri Oct 9 08:03:25 2015
New Revision: 249831
URL: http://llvm.org/viewvc/llvm-project?rev=249831&view=rev
Log:
[VFS] Wire up driver VFS through tooling.
Sadly I don't currently have a way to tests this as the driver is always
initialized with the default triple and finding syst
Author: d0k
Date: Fri Oct 9 08:03:18 2015
New Revision: 249829
URL: http://llvm.org/viewvc/llvm-project?rev=249829&view=rev
Log:
[VFS] Wire up multilib toolchain code to the VFS.
This lets a VFSified driver actually validate the GCC paths.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
c
Author: d0k
Date: Fri Oct 9 08:28:13 2015
New Revision: 249832
URL: http://llvm.org/viewvc/llvm-project?rev=249832&view=rev
Log:
[VFS] Rename RedirectingFS internals to avoid collisions with public clang
classes
Hopefully fixes the MSVC build. NFC intended.
Modified:
cfe/trunk/lib/Basic/Vi
Author: d0k
Date: Mon Oct 12 04:22:07 2015
New Revision: 250021
URL: http://llvm.org/viewvc/llvm-project?rev=250021&view=rev
Log:
[VFS] remove handling of '..' for now.
This can fail badly if we're overlaying a real file system and there are
symlinks there. Just keep the path as-is for now.
This
Author: d0k
Date: Mon Oct 12 08:30:38 2015
New Revision: 250036
URL: http://llvm.org/viewvc/llvm-project?rev=250036&view=rev
Log:
[VFS] Don't try to be heroic with '.' in paths.
Actually the only special path we have to handle is ./foo, the rest is
tricky to get right so do the same thing as the
Author: d0k
Date: Mon Oct 12 08:39:33 2015
New Revision: 250037
URL: http://llvm.org/viewvc/llvm-project?rev=250037&view=rev
Log:
[VFS] Unbreak test.
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
URL:
http://llvm.
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
This is a more principled version of what I did earlier. Path
normalization is generally a good thing, but may break users in strange
environments, e. g. using lots of symlinks. Let the user c
bkramer updated this revision to Diff 37124.
bkramer added a comment.
Addressed review comments.
http://reviews.llvm.org/D13658
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
unittests/Basic/VirtualFileSystemTest.cpp
Index: unittests/Basic/VirtualFileSyste
Author: d0k
Date: Mon Oct 12 11:16:39 2015
New Revision: 250060
URL: http://llvm.org/viewvc/llvm-project?rev=250060&view=rev
Log:
[VFS] Let the user decide if they want path normalization.
This is a more principled version of what I did earlier. Path
normalization is generally a good thing, but m
Author: d0k
Date: Tue Oct 13 05:10:03 2015
New Revision: 250155
URL: http://llvm.org/viewvc/llvm-project?rev=250155&view=rev
Log:
Remove unused diagnostic. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL:
Author: d0k
Date: Tue Oct 13 10:19:32 2015
New Revision: 250164
URL: http://llvm.org/viewvc/llvm-project?rev=250164&view=rev
Log:
[Driver] Use the parent_path of the clang executable as the default InstalledDir
This is what most people want anyways. Clang -cc1's main() will override
this but for
Author: d0k
Date: Thu Oct 15 10:29:40 2015
New Revision: 250418
URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev
Log:
[CodeGen] Remove dead code. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/CodeGen/CGCleanup.cpp
cfe
Author: d0k
Date: Thu Oct 15 11:46:25 2015
New Revision: 250428
URL: http://llvm.org/viewvc/llvm-project?rev=250428&view=rev
Log:
Put back doxygen comment accidentally dropped in r250418.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.h
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.h
URL:
http:/
On Thu, Oct 15, 2015 at 6:12 PM, Adrian Prantl wrote:
>
>> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits
>> wrote:
>>
>> Author: d0k
>> Date: Thu Oct 15 10:29:40 2015
>> New Revision: 250418
>>
>> URL: http://llvm.org/viewvc/l
Author: d0k
Date: Fri Oct 16 06:14:30 2015
New Revision: 250507
URL: http://llvm.org/viewvc/llvm-project?rev=250507&view=rev
Log:
Remove a long-standing __has_include hack.
This was put in to get libc++ building without libcxxabi. We now have
macros that show that we are building against libcxxab
Author: d0k
Date: Fri Oct 16 06:26:26 2015
New Revision: 250508
URL: http://llvm.org/viewvc/llvm-project?rev=250508&view=rev
Log:
Fix an unfortunate yet old typo that never got attention before r250507.
Should fix the xcode libc++ build.
Modified:
libcxx/trunk/src/stdexcept.cpp
Modified: li
Author: d0k
Date: Fri Oct 16 07:11:15 2015
New Revision: 250510
URL: http://llvm.org/viewvc/llvm-project?rev=250510&view=rev
Log:
Empty undefined static variable -> local variable.
Resolves a -Wundefined-internal warning from clang.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagn
bkramer added a subscriber: bkramer.
bkramer added a comment.
Is there a way to unittest this?
http://reviews.llvm.org/D13810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a reviewer: bkramer.
bkramer added a comment.
test looks good too, thanks!
http://reviews.llvm.org/D13810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: d0k
Date: Tue Oct 20 02:50:21 2015
New Revision: 250803
URL: http://llvm.org/viewvc/llvm-project?rev=250803&view=rev
Log:
Put back dead code that's used out-of-tree.
Partially reverts r250418.
Modified:
cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp
cfe/trunk/lib/Tooling/Core/CMakeLis
Author: d0k
Date: Tue Oct 20 02:53:14 2015
New Revision: 250804
URL: http://llvm.org/viewvc/llvm-project?rev=250804&view=rev
Log:
Revert accidental commit. This isn't ready yet.
Modified:
cfe/trunk/lib/Tooling/Core/CMakeLists.txt
cfe/trunk/unittests/Tooling/CMakeLists.txt
Modified: cfe/t
PM, Michael Gottesman via cfe-commits
>> wrote:
>>
>>
>> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits
>> wrote:
>>
>> Author: d0k
>> Date: Thu Oct 15 10:29:40 2015
>> New Revision: 250418
>>
>> URL: http://llvm.org/
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Looks good with one comment.
Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:141-143
@@ -140,5 +141,1 @@
-MemRegionManager::~MemRegionManager() {
- // All regions and the
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg with comments.
Comment at: lib/tsan/rtl/tsan_mutex.cc:130
@@ -129,3 @@
-InternalDeadlockDetector::InternalDeadlockDetector() {
- // Rely on zero initialization because s
bkramer added a comment.
feel free to submit
http://reviews.llvm.org/D13890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer created this revision.
bkramer added reviewers: klimek, sbenza.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Firstly this changes the type of parent map to be keyed on DynTypedNode to
simplify the following changes. This comes with a DenseMapInfo for
DynTyped
Author: d0k
Date: Tue Oct 20 10:08:46 2015
New Revision: 250831
URL: http://llvm.org/viewvc/llvm-project?rev=250831&view=rev
Log:
[AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.
Firstly this changes the type of parent map to be keyed on DynTypedNode to
simplify the following ch
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
One problem in clang-tidy and other clang tools face is that there is no
way to lookup an arbitrary name in the AST, that's buried deep inside Sema
and might
Author: d0k
Date: Wed Oct 21 05:07:26 2015
New Revision: 250889
URL: http://llvm.org/viewvc/llvm-project?rev=250889&view=rev
Log:
Revert "[AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap."
Putting DynTypedNode in the ParentMap bloats its memory foot print.
Before the void* key ha
is means, this change is effectively
> increasing the parent map by 10x and it was already large to begin with.
>
> Please revert and lets come up with a different solution.
>
> On Tue, Oct 20, 2015 at 5:08 PM, Benjamin Kramer via cfe-commits
> wrote:
>>
>> Author:
bkramer created this revision.
bkramer added a reviewer: sbenza.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The MemoizationData cache was introduced to avoid a series of enum
compares at the cost of making DynTypedNode bigger. This change reverts
to using an enum c
bkramer updated this revision to Diff 38023.
bkramer added a comment.
Update casts to avoid potential undefined behavior. Now every pointer goes
through const void*.
http://reviews.llvm.org/D13946
Files:
include/clang/AST/ASTTypeTraits.h
unittests/ASTMatchers/Dynamic/RegistryTest.cpp
Inde
Author: d0k
Date: Wed Oct 21 11:33:15 2015
New Revision: 250905
URL: http://llvm.org/viewvc/llvm-project?rev=250905&view=rev
Log:
Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).
The MemoizationData cache was introduced to avoid a series of enum
compares at the cost of making D
bkramer created this revision.
bkramer added reviewers: klimek, djasper.
bkramer added a subscriber: cfe-commits.
These are by far the most common types to be parents in the AST so it makes
sense to optimize for them. Put them directly into the value of the map.
This currently saves 32 bytes per p
Author: d0k
Date: Thu Oct 22 06:21:40 2015
New Revision: 251008
URL: http://llvm.org/viewvc/llvm-project?rev=251008&view=rev
Log:
[AST] Store Decl* and Stmt* directly into the ParentMap.
These are by far the most common types to be parents in the AST so it makes
sense to optimize for them. Put th
Author: d0k
Date: Thu Oct 22 06:26:35 2015
New Revision: 251009
URL: http://llvm.org/viewvc/llvm-project?rev=251009&view=rev
Log:
[AST] Remove redundant template keywords.
GCC complains about them, clang does not.
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
Modified: cfe/trunk/lib/AST/ASTCon
bkramer updated this revision to Diff 38117.
bkramer added a comment.
- Removed "fully qualified" in favor of just "qualified" to clarify that the
name should be qualified but the leading "::" is not necessary.
- Renamed isNameSpecifierGlobal
- Removed always true conditional from test
http://r
bkramer updated this revision to Diff 38122.
bkramer added a comment.
Add more comments and polish test cases.
http://reviews.llvm.org/D13931
Files:
include/clang/Tooling/Core/Lookup.h
lib/Tooling/Core/CMakeLists.txt
lib/Tooling/Core/Lookup.cpp
unittests/Tooling/CMakeLists.txt
unittes
bkramer updated this revision to Diff 38130.
bkramer added a comment.
Enforce :: at the beginning of the new name.
http://reviews.llvm.org/D13931
Files:
include/clang/Tooling/Core/Lookup.h
lib/Tooling/Core/CMakeLists.txt
lib/Tooling/Core/Lookup.cpp
unittests/Tooling/CMakeLists.txt
uni
Author: d0k
Date: Thu Oct 22 10:04:10 2015
New Revision: 251022
URL: http://llvm.org/viewvc/llvm-project?rev=251022&view=rev
Log:
[Tooling] Add a utility function to replace one nested name with another.
One problem in clang-tidy and other clang tools face is that there is no
way to lookup an arb
Author: d0k
Date: Thu Oct 22 10:45:54 2015
New Revision: 251026
URL: http://llvm.org/viewvc/llvm-project?rev=251026&view=rev
Log:
Unbreak the shared cmake build. libToolingCore now depends on libAST.
Modified:
cfe/trunk/lib/Tooling/Core/CMakeLists.txt
Modified: cfe/trunk/lib/Tooling/Core/CMa
bkramer created this revision.
bkramer added reviewers: klimek, djasper.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This relands r250831 after some fixes to shrink the ParentMap overall
with one addtional tweak: nodes with pointer identity (e.g. Decl* and
friends)
Author: d0k
Date: Fri Oct 23 04:04:55 2015
New Revision: 251101
URL: http://llvm.org/viewvc/llvm-project?rev=251101&view=rev
Log:
[AST] Re-add TypeLocs and NestedNameSpecifierLocs to the ParentMap.
This relands r250831 after some fixes to shrink the ParentMap overall
with one addtional tweak: nod
Author: d0k
Date: Fri Oct 23 08:24:18 2015
New Revision: 251110
URL: http://llvm.org/viewvc/llvm-project?rev=251110&view=rev
Log:
[AST] Plug a memory leak when promoting a single ParentMap entry to a vector.
Found by asan!
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
Modified: cfe/trunk/lib/A
Author: d0k
Date: Sun Oct 25 17:03:00 2015
New Revision: 251265
URL: http://llvm.org/viewvc/llvm-project?rev=251265&view=rev
Log:
assert(false) -> llvm_unreachable.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
Modified:
clang-tools-extra/trunk/clang-tid
Author: d0k
Date: Mon Oct 26 04:57:00 2015
New Revision: 251279
URL: http://llvm.org/viewvc/llvm-project?rev=251279&view=rev
Log:
Drop dead return after llvm_unreachable. NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
Modified:
clang-tools-extra/trun
Some high level style comments:
1. Please convert the file to LLVM style for the things that
clang-format doesn't change. In particular PascalCase for all
variables and cameCase for all function names.
2. We don't do author attribution in file comments, sorry.
3. Try to avoid commented out/#if 0'd
Author: d0k
Date: Tue Oct 27 13:34:47 2015
New Revision: 251432
URL: http://llvm.org/viewvc/llvm-project?rev=251432&view=rev
Log:
Remove unused diagnostic. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL:
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This should be fine. Sorry for the breakage.
http://reviews.llvm.org/D13920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Two minor comments, otherwise looks good:
1. beware of the GCC 4.7 issues and trivial class initializer issues we hit
with this kind of changes earlier.
2. I prefer to leave utils/unittest/g
Author: d0k
Date: Wed Oct 28 00:16:37 2015
New Revision: 251499
URL: http://llvm.org/viewvc/llvm-project?rev=251499&view=rev
Log:
[tidy] Remove stray iostream include from test.
It is unused and we cannot rely on standard headers being present while
executing tests.
Modified:
clang-tools-ext
Author: d0k
Date: Wed Oct 28 08:54:16 2015
New Revision: 251514
URL: http://llvm.org/viewvc/llvm-project?rev=251514&view=rev
Log:
Put global classes into the appropriate namespace.
Most of the cases belong into an anonymous namespace. No functionality
change intended.
Modified:
cfe/trunk/inc
Author: d0k
Date: Wed Oct 28 12:16:26 2015
New Revision: 251528
URL: http://llvm.org/viewvc/llvm-project?rev=251528&view=rev
Log:
Move global classes into anonymous namespaces. NFC.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/AST/
bkramer accepted this revision.
bkramer added a comment.
Looks good to me too, do you have commit access?
http://reviews.llvm.org/D13844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
bkramer added a comment.
Can you try setting up the virtual files with the vfs::InMemoryFileSystem
stuff? There are some examples how to set up with OverlayFileSystem in tree.
InMemoryFileSystem was written with windows path separators in mind, I just
never tried to run it on windows :)
http:
Author: d0k
Date: Mon Jul 18 14:21:22 2016
New Revision: 275886
URL: http://llvm.org/viewvc/llvm-project?rev=275886&view=rev
Log:
Unbreak extra tools build post r275882.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer
Author: d0k
Date: Wed Jul 20 04:12:19 2016
New Revision: 276098
URL: http://llvm.org/viewvc/llvm-project?rev=276098&view=rev
Log:
[include-fixer] Make error messages a bit prettier and make sure to
include a newline at the end.
Modified:
clang-tools-extra/trunk/include-fixer/tool/ClangInclude
bkramer added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:246
@@ +245,3 @@
+if (!QuerySymbolInfos.empty()) {
+ if (ScopedQualifiers.str() == QuerySymbolInfos.front().ScopedQualifiers
&&
+ Query.str() == QuerySymbolInfos.front().RawIdentifier) {
-
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D22567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: d0k
Date: Thu Jul 21 09:13:45 2016
New Revision: 276282
URL: http://llvm.org/viewvc/llvm-project?rev=276282&view=rev
Log:
[clang-tidy] Avoid duplicated DenseMap lookup.
The std::string is still constructed on demand. No functionality change
intended.
Modified:
clang-tools-extra/trunk
Author: d0k
Date: Thu Jul 21 10:06:51 2016
New Revision: 276292
URL: http://llvm.org/viewvc/llvm-project?rev=276292&view=rev
Log:
Move some IntrusiveRefCntPtrs instead of copying.
No functionality change intended.
Modified:
cfe/trunk/include/clang/Basic/Diagnostic.h
cfe/trunk/lib/ASTMatc
Author: d0k
Date: Fri Jul 22 04:07:16 2016
New Revision: 276400
URL: http://llvm.org/viewvc/llvm-project?rev=276400&view=rev
Log:
[include-fixer] Fix faulty sort predicate.
Note the == on the last line, this isn't a strict-weak ordering.
Modified:
clang-tools-extra/trunk/include-fixer/Includ
501 - 600 of 936 matches
Mail list logo
