[PATCH] D33395: [clangd] Split clangd into library+executable (mainly for unit tests).

2017-05-22 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good to me https://reviews.llvm.org/D33395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D33397: Allow to use vfs::FileSystem for file accesses inside ASTUnit.

2017-05-23 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D33397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-23 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:118 + llvm::SmallString<128> TmpDir2; + llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, TmpDir2); + We should delete those when we're done, otherwise the unit test will

[PATCH] D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references

2021-12-20 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116037/new/ https://reviews.llvm.org/D116037 ___

[PATCH] D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references

2021-12-20 Thread Benjamin Kramer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcff192739bb6: [clang-include-fixer] Fix incorrect ranking because of dangling references (authored by danlark, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

2021-03-19 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer created this revision. bkramer added reviewers: rupprecht, rjmccall, rsmith. bkramer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This looks like an oversight from a875721d8a2d

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

2021-03-19 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added a comment. Landing this as it's a pretty bad crasher. Feel free to point out all my mistakes in post-commit review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98980/new/ https://reviews.llvm.org/D98980 _

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

2021-03-19 Thread Benjamin Kramer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19d2c65ddd75: [CodeGen] Don't crash on for loops with cond variables and no increment (authored by bkramer). Repository: rG LLVM Github Monorepo

[PATCH] D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable.

2021-03-19 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added a comment. Invalid IR generation should be addressed by 19d2c65ddd757997785163709800f837857f686d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98816/new/ https://

<    1   2   3