[PATCH] D74412: Fix SFINAE in CFG.cpp.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74412/new/ https://reviews.llvm.org/D74412 ___

[PATCH] D74414: Use std::foo_t rather than std::foo in clang.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74414/new/ https://reviews.llvm.org/D74414 ___

[PATCH] D74423: Use C++14-style return type deduction in clang.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74423/new/ https://reviews.llvm.org/D74423 ___

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I wouldn't say that this is more maintainable, but I'm not the maintainer of clang-format. Repository: rC Clang https://reviews.llvm.org/D44695 ___

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good. Sorry for the long wait, do you have commit access? https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D39498: [clang-format] Make parseUnaryOperator non-recursive, NFCI

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/TokenAnnotator.cpp:1671 +parse(PrecedenceArrowAndPeriod); +for (size_t I = 0, E = Tokens.size(); I < E; ++I) + // The actual preceden

[PATCH] D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'

bkramer added a comment. Can we just write out the modified string comparison function instead of keeping both versions of the string around in memory? I'd prefer less state. https://reviews.llvm.org/D39549 ___ cfe-commits mailing list cfe-commits@

[PATCH] D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, thanks! https://reviews.llvm.org/D39549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D39786: [clang-format] Sort using declarations by splitting on '::'

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D39786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D39806: [clang-format] Support python-style comments in text protos

bkramer added inline comments. Comment at: lib/Format/BreakableToken.cpp:48 + static const SmallVector KnownTextProtoPrefixes{"//", "#"}; + const SmallVectorImpl &KnownPrefixes = + (Style.Language == FormatStyle::LK_TextProto) ? KnownTextProtoPrefixes Thes

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I can't really check if all the tests are equivalent to the old ones, but not having to install nose is a major usability improvement. Let's ship this. We should totally fix the existing fai

[PATCH] D40140: [VirtualFileSystem] Support creating directories then adding files inside

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Basic/VirtualFileSystem.cpp:535 ResolvedPerms); -Dir->addChild(Name, llvm::make_unique( -std

[PATCH] D144911: adding bf16 support to NVPTX

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I don't have much knowledge about the PTX ABI, but everything here makes perfect sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D138792: [AArch64] Improve TargetParser API

bkramer added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:115-118 + ArchInfo(const ArchInfo &) = delete; + ArchInfo(const ArchInfo &&) = delete; + ArchInfo &operator=(const ArchInfo &rhs) = delete; + ArchInfo &&operator=(const ArchInfo &&rhs)

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

bkramer added a comment. Mind moving the test case from `llvm/test/CodeGen/AArch64` to `llvm/test/CodeGen/Hexagon`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 ___

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks. Let's land this now to unbreak things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/

[PATCH] D27920: [find-all-symbols] Index partial template specializations.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The reason why we disallowed specializations is that there are type-trait classes that get specialized all over the place (DenseMapInfo in LLVM is one example). I think we can get away with

[PATCH] D30675: [clangd] Fix not being able to attach a debugger on macOS

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, do you have commit access? https://reviews.llvm.org/D30675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D31019: [clangd] [RFC] Use libclang and CXTranslationUnit instead of ASTUnit

bkramer resigned from this revision. bkramer added a comment. It's not. the goal is to get rid of ASTUnit inside of clangd in the long term as it's a big problem for extensibility. libclang is just a wrapper for ASTUnit, with even more problems. If you want to get completion running, just call

[PATCH] D31019: [clangd] [RFC] Use libclang and CXTranslationUnit instead of ASTUnit

bkramer added a comment. libclang is supposed to be used for bindings to other languages (it's a pure C interface) and its stable. ASTUnit is the C++ side of libclang, libclang is just a thin wrapper around ASTUnit. ASTUnit itself suffers from lots of technical debt because clang changed since

[PATCH] D31288: [libclang] Bury dead TemporaryFiles

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. kill it with fire https://reviews.llvm.org/D31288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D31328: [clangd] Add code completion support

bkramer added inline comments. Comment at: clangd/ASTManager.cpp:264 +assert(CCS->getTypedText()); +Item.label = llvm::yaml::escape(CCS->getTypedText()); +if (CCS->getBriefComment()) CompletionItem::unparse should do the escaping. It's wei

[PATCH] D30248: [libclang] Fix crash in member access code completion with implicit base

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Let's fix those crashes one at a time. This patch looks good, only minor comments below. Comment at: lib/Sema/SemaOverload.cpp:6311 + if (isa(FD) && !cast(FD)->isStat

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D31328: [clangd] Add code completion support

bkramer accepted this revision. bkramer added a comment. lg https://reviews.llvm.org/D31328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28144: clang support for Mageia 6 distro

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D28144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D28334: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks useful to me. https://reviews.llvm.org/D28334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D28941: Remove 'RUN: false' from Driver/response-file.c

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg. I assume the test passes with the RUN: false removed? https://reviews.llvm.org/D28941 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D28974: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rL LLVM https://reviews.llvm.org/D28974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D29176: [change-namespace] add leading '::' to references in new namespace when name conflict is possible.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Only nits below. Comment at: change-namespace/ChangeNamespace.cpp:232 +auto &DeclNsTop = DeclNsSplitted.front(); +for (auto &Ns : NsNameSplitted) + if (Ns == D

[PATCH] D29182: [change-namespace] correctly shorten namespace when references have leading '::'

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29303: In VirtualCallChecker, handle indirect calls

bkramer added a comment. Your test case is fine, it crashes with assertions enabled. https://reviews.llvm.org/D29303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29303: In VirtualCallChecker, handle indirect calls

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29451: Add a prototype for clangd v0.1

bkramer created this revision. Herald added a subscriber: mgorny. clangd is a language server protocol implementation based on clang. It's supposed to provide editor integration while not suffering from the confined ABI of libclang. This implementation is limited to the bare minimum functionality

[PATCH] D29447: [change-namespace] check using shadow decl correctly when shortening namespace specifiers.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29460: [change-namespace] fix unscoped enum constant references.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29451: Add a prototype for clangd v0.1

bkramer marked 19 inline comments as done. bkramer added a comment. In https://reviews.llvm.org/D29451#667606, @arphaman wrote: > This might be a bad question, but is there any particular reason why you > didn't use the YAML Traits API for parsing instead of the raw YAML Stream > API? In my exp

[PATCH] D29451: Add a prototype for clangd v0.1

bkramer updated this revision to Diff 87226. bkramer marked 8 inline comments as done. bkramer added a comment. Address review comments. Make test actually run (missing cmake file) https://reviews.llvm.org/D29451 Files: CMakeLists.txt clangd/CMakeLists.txt clangd/ClangDMain.cpp clangd/D

[PATCH] D35203: Avoid white spaces in file names. NFC

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This is fine. We should fix phab though. https://reviews.llvm.org/D35203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D35617: [clangd] Allow specifying -resource-dir

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D35617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D35828: Fix incorrect use of current directory to find moved paths in ASTReader.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D35828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D42004: [Driver] Suggest valid integrated tools

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The -cc1 stuff isn't exactly user-facing, so we didn't put so much emphasis on providing great error messages there. This change LGTM. Repository: rC Clang https://reviews.llvm.org/D4200

[PATCH] D42071: [Sema] Add a callback in VisibleDeclConsumer allowing client to know which DeclContext is going to visit.

bkramer added a comment. We should have a unit test for this, otherwise it's dead code. Comment at: include/clang/Sema/Lookup.h:791 + /// \param Ctx the context which Sema begins to visit. + virtual void BeginVisitContext(DeclContext *Ctx) {}; }; ilya-biryuk

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

bkramer added inline comments. Comment at: clangd/Compiler.h:39 +/// be consumed by the FrontendAction as it will have a pointer to the MainFile +/// buffer that will only be deleted if BeginSourceFile is called. std::unique_ptr prepareCompilerInstance( This com

[PATCH] D42098: [clang-format] Reorganize RawStringFormat based on language

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This should be fine. https://reviews.llvm.org/D41788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1454 +// found. +static StringRef getEnclosingFunctionName(const FormatToken& Current) { + // Look for: 'function(' or 'function(' before Current. This function doesn't look clang-for

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

bkramer added inline comments. Comment at: clangd/ClangdServer.h:107 +/// A simple fixed-size thread pool implementation. +class SimpleThreadPool { public: What's so simple about it? Why not `clangd::ThreadPool`? Also there's `llvm::ThreadPool`, what's the diff

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D42167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

bkramer requested changes to this revision. bkramer added a comment. dump_ast_matchers.py should be working again now. Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D42189: [clang-format] Replace unordered_set with an array

bkramer added inline comments. Comment at: lib/Format/Format.cpp:1424 const AdditionalKeywords &Keywords) { -static const std::unordered_set FoundationIdentifiers = { +static const llvm::ArrayRef FoundationIdentifiers = { "CGFloat", ---

[PATCH] D42189: [clang-format] Replace unordered_set with an array

bkramer accepted this revision. bkramer added a comment. lgtm Repository: rC Clang https://reviews.llvm.org/D42189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42187: [clang-format] Adds a canonical delimiter to raw string formatting

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/ContinuationIndenter.cpp:1336 + unsigned OldSuffixSize = 2 + OldDelimiter.size(); + std::string RawText = + Current.TokenText.substr(OldPre

[PATCH] D42298: [clang-format] Fix shortening blocks in macros causing merged next line

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Format/UnwrappedLineFormatter.cpp:310 +MergedLines = tryMergeSimpleBlock(I - 1, E, Limit); +// If we managed to merge the block, discar

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer added inline comments. Comment at: lib/Tooling/Tooling.cpp:404 if (CompileCommandsForFile.empty()) { // FIXME: There are two use cases here: doing a fuzzy // "find . -name '*.cc' |xargs tool" match, where as a user I don't care This com

[PATCH] D42241: [CodeComplete] Fix completion in the middle of idents in macro calls

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think we can go ahead with this. I expect code completion in the middle of a token not to be used much though, so there might be more broken cases. Repository: rC Clang https://reviews

[PATCH] D42577: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch.

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Lex/HeaderSearch.h:708 + /// + /// \param WorkingDir If non-empty, this will be prepend to search directory + /// paths that are relative.

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer added inline comments. Comment at: lib/Tooling/Tooling.cpp:404 if (CompileCommandsForFile.empty()) { // FIXME: There are two use cases here: doing a fuzzy // "find . -name '*.cc' |xargs tool" match, where as a user I don't care ioeric w

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Removing FIXME seems right to me. Repository: rC Clang https://reviews.llvm.org/D42361 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

bkramer created this revision. Herald added a subscriber: mgorny. This requires an accessible compilation database. The parsing is done asynchronously on a separate thread. https://reviews.llvm.org/D29886 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/CMakeLists.txt clangd/Clan

[PATCH] D29899: [clang-tidy] Add support for NOLINTNEXTLINE.

bkramer created this revision. Herald added a subscriber: JDevlieghere. https://reviews.llvm.org/D29899 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp test/clang-tidy/nolintnextline.cpp Index: test/clang-tidy/nolintnextline.cpp

[PATCH] D29899: [clang-tidy] Add support for NOLINTNEXTLINE.

bkramer updated this revision to Diff 88352. bkramer added a comment. - Simplify code by not worrying about \r - Don't allow blank lines between NOLINTNEXTLINE and the warning https://reviews.llvm.org/D29899 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp test/clang-tidy/nolintnextline.cp

[PATCH] D29755: Cache FileID when translating diagnostics in PCH files

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

bkramer updated this revision to Diff 88515. bkramer marked 16 inline comments as done. bkramer added a comment. - Address review comments. https://reviews.llvm.org/D29886 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/CMakeLists.txt clangd/ClangDMain.cpp clangd/DocumentStore

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

bkramer added inline comments. Comment at: clangd/ASTManager.cpp:21 +using namespace clang; +using namespace clangd; + ioeric wrote: > Any reason not to wrap code in namespaces instead? I don't really have an opinion one way or the other, but this seems to be the

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

bkramer updated this revision to Diff 88522. bkramer added a comment. - Do not lock while running DocumentStore callbacks - Replace fake queue with a real queue (but it still has at most one element. https://reviews.llvm.org/D29886 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/C

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

bkramer updated this revision to Diff 88523. bkramer added a comment. - Inline the request struct again. https://reviews.llvm.org/D29886 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/CMakeLists.txt clangd/ClangDMain.cpp clangd/DocumentStore.h test/clangd/diagnostics.test

[PATCH] D29990: [clangd] Implement format on type

bkramer added inline comments. Comment at: clangd/ProtocolHandlers.cpp:117 + // starting from there. + StringRef Code = Store.getDocument(DOTFP->textDocument.uri); + size_t CursorPos = positionToOffset(Code, DOTFP->position); This should be a std::string in tr

[PATCH] D29990: [clangd] Implement format on type

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D30191: [clang-tidy] Reword the "code outside header guard" warning.

bkramer created this revision. Herald added a subscriber: JDevlieghere. The check doesn't really know if the code it is warning about came before or after the header guard, so phrase it more neutral instead of complaining about code before the header guard. The location for the warning is still no

[PATCH] D30399: clang-format: [JS] whitespace after async in arrow functions.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, but I don't really know JS ;) https://reviews.llvm.org/D30399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

bkramer accepted this revision. bkramer added a comment. lg Comment at: include-fixer/SymbolIndexManager.cpp:156 + for (const auto &SymAndSig : MatchedSymbols) +Res.push_back(SymAndSig.Symbol); + return Res; std::move Comment at: includ

[PATCH] D30498: [clangd] Add support for FixIts.

bkramer created this revision. This uses CodeActions to show 'apply fix' actions when code actions are requested for a location. The actions themselves make use of a clangd.applyFix command which has to be implemented on the editor side. I included an implementation for vscode. This also adds a -

[PATCH] D30498: [clangd] Add support for FixIts.

bkramer updated this revision to Diff 90181. bkramer added a comment. - Use typedef instead of decltype() - Rename local variable not to shadow member. - Give FixIts their own mutex - Use const instead of let in typescript https://reviews.llvm.org/D30498 Files: clangd/ASTManager.cpp clangd/

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

bkramer added a comment. I assume this is fine but I don't really understand what's going on. A test case would be great. https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D30675: [clangd] Fix not being able to attach a debugger on macOS

bkramer added a comment. Generally makes sense. Is there any reason for the #ifdef? Windows has errno and EINTR too. Repository: rL LLVM https://reviews.llvm.org/D30675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D30685: [include-fixer] Remove line number from Symbol identity

bkramer accepted this revision. bkramer added a comment. lg https://reviews.llvm.org/D30685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

bkramer accepted this revision. bkramer added a comment. lg as a prototype. https://reviews.llvm.org/D30720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27132: Do not do raw name replacement when FromDecl is a class forward-declaration.

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: lib/Tooling/Core/Lookup.cpp:131 + // still considered as referring to the original definition given the nature + // of forward-declarations, so we can't d

[PATCH] D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good to me. We can add finer-grained desugaring later if it's really needed. https://reviews.llvm.org/D27207 ___ cfe-commits mailin

[PATCH] D27504: Compilation database test: don't try to output to CWD

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Annoying. This test really shouldn't generate binary object files. Can we check in this patch now to unblock stuff and then look into how to do a dry run with -MJ? Usually driver tests use `

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer updated this revision to Diff 80574. bkramer marked 9 inline comments as done. bkramer added a comment. Herald added a subscriber: JDevlieghere. - Moved external linkage check to matcher - added msvcrt entry point check - fixed comment typos. https://reviews.llvm.org/D23130 Files: cla

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added inline comments. Comment at: clang-tidy/google/GlobalNamesCheck.cpp:90 +// extern "C" globals need to be in the global namespace. +if (VDecl->isExternC()) + return; alexfh wrote: > Is this already filtered-out by the matcher? Nope. ==

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: change-namespace/ChangeNamespace.cpp:331 + // Using shadow declarations in classes always refers to base class, which + // does not need to be qualified s

[PATCH] D26887: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I believe this is fine. https://reviews.llvm.org/D26887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D32238: [Clangd] Failed to decode params using 1.x-compatible request message

bkramer added a comment. A test case would be nice. Repository: rL LLVM https://reviews.llvm.org/D32238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32234: [Clangd] Support Authority-less URIs

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This is fine. Test case would be nice though. Repository: rL LLVM https://reviews.llvm.org/D32234 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D32238: [Clangd] Failed to decode params using 1.x-compatible request message

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D32238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources

bkramer added a comment. lg from my side. It would be good to wait until Manuel is back though, I think he had plans for extending this interface at some point. https://reviews.llvm.org/D32351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32234: [Clangd] Support Authority-less URIs

bkramer added a comment. Still looking good. Will commit this soon. https://reviews.llvm.org/D32234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

bkramer added a comment. Can you please run clang-format on this change? There are pieces that don't follow the style. Also the mutable state in PrintingPolicy is really really ugly, is there no better way for this? :( https://reviews.llvm.org/D30946 ___

[PATCH] D33103: [clang-tidy] TwineLocalCheck: add param # checking

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good, thanks! https://reviews.llvm.org/D33103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D33047: [ClangD] Refactor clangd into separate components

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I believe this is good enough now. https://reviews.llvm.org/D33047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D33273: Recommit "[include-fixer] Don't throw exception when parsing unknown ar… …guments in vim script."

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good, thanks! https://reviews.llvm.org/D33273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D33270: [Frontend] Remove unused TemporaryFiles

bkramer accepted this revision. bkramer added a comment. Kill it :) https://reviews.llvm.org/D33270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33350: [clangd] Switch to incomplete translation units

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D33350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D33042: [libclang] Allow to suspend a translation unit.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This makes sense to me. Comment at: lib/Frontend/ASTUnit.cpp:2089 +void ASTUnit::ResetForParse() +{ + SavedMainFileBuffer.reset(); Put the `{` on the same

<    1   2   3   >