[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

benhamilton created this revision. benhamilton added a reviewer: MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. benhamilton requested review of this revision. This adds to the Obj

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

benhamilton updated this revision to Diff 526151. benhamilton added a comment. Fix auto-complete-o. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151578/new/ https://reviews.llvm.org/D151578 Files: clang/lib/Format/Format.cpp clang/test/Format

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

benhamilton updated this revision to Diff 526154. benhamilton added a comment. Add `FOUNDATION_EXTERN` alias for `FOUNDATION_EXPORT` (Apple `#define`s the former to the latter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151578/new/ https://rev

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

This revision was automatically updated to reflect the committed changes. Closed by commit rG85670ac86813: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC… (authored by benhamilton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton created this revision. benhamilton added reviewers: jolesiak, krasimir. Herald added subscribers: cfe-commits, klimek. This improves upon the previous Objective-C header guessing heuristic from https://reviews.llvm.org/rC320479. Now, we run the lexer on C++ header files and look for O

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130041. benhamilton added a comment. - Move tests to FormatTestObjC.cpp Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130042. benhamilton added a comment. - Tidy up Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp =

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130044. benhamilton added a comment. - Last cleanup for tests Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp ==

[PATCH] D41074: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style

benhamilton added a comment. Any way we can get an accept on this one? Repository: rC Clang https://reviews.llvm.org/D41074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130192. benhamilton added a comment. - Remove unused variable. Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp =

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130202. benhamilton added a comment. Use unordered_set, consolidate at-token checks Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

This revision was automatically updated to reflect the committed changes. Closed by commit rL322690: [Format] Improve ObjC header guessing heuristic (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42135 Files:

[PATCH] D42189: [clang-format] Replace unordered_set with an array

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Thanks, this is smarter. Repository: rC Clang https://reviews.llvm.org/D42189 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D42189: [clang-format] Replace unordered_set with an array

benhamilton added inline comments. Comment at: lib/Format/Format.cpp:1424 const AdditionalKeywords &Keywords) { -static const std::unordered_set FoundationIdentifiers = { +static constexpr llvm::StringLiteral FoundationIdentifiers[] = {

[PATCH] D41074: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style

This revision was automatically updated to reflect the committed changes. Closed by commit rC322873: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D41074?vs=126806&id=13044

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

benhamilton created this revision. benhamilton added reviewers: Wizard, hokein, klimek. Herald added a subscriber: cfe-commits. We were missing some pretty common acronyms in the camelCase property name check objc-property-declaration. This expands the list and sorts it lexicographically, so we c

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

benhamilton updated this revision to Diff 130478. benhamilton added a comment. - Added comment about prefixes and suffixes. - Updated list of acronyms. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42253 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/c

[PATCH] D42261: [clang-tidy objc-property-declaration] New option AdditionalAcronyms

benhamilton created this revision. benhamilton added reviewers: Wizard, hokein, klimek. Herald added a subscriber: cfe-commits. The existing option objc-property-declaration.Acronyms replaces the built-in set of acronyms. While this behavior is OK for clients that don't want the default behavior,

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rL322886: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.o

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322886: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42253?vs=130478&id=130480#toc

[PATCH] D42261: [clang-tidy objc-property-declaration] New option AdditionalAcronyms

benhamilton added a comment. Thanks, fixed. Comment at: clang-tidy/objc/PropertyDeclarationCheck.h:38 const std::vector SpecialAcronyms; +const std::vector AdditionalAcronyms; }; hokein wrote: > nit: code indent Ah, the previous one was wrong, I see.

[PATCH] D42261: [clang-tidy objc-property-declaration] New option AdditionalAcronyms

benhamilton updated this revision to Diff 130657. benhamilton marked 2 inline comments as done. benhamilton added a comment. - Switch to IncludeDefaultAcronyms option (defaults to 1). - Use array for default acronyms, since we no longer need to parse it. - Don't regex-escape default acronyms, sinc

[PATCH] D42261: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

benhamilton updated this revision to Diff 130661. benhamilton added a comment. - Remove debugging code Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42261 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp clang-tidy/objc/PropertyDeclarationCheck.h docs/clang-tidy/check

[PATCH] D42261: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rL323130: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D42261: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323130: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42261?vs=130661&id=130899#

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton created this revision. benhamilton added reviewers: jolesiak, krasimir. Herald added a subscriber: cfe-commits. `clang-format -dump-config path/to/file.h` never passed anything for the Code parameter to clang::format::getStyle(). This meant the logic to guess Objective-C from the cont

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton updated this revision to Diff 130970. benhamilton added a comment. - Support AssumeFileName with stdin. Repository: rC Clang https://reviews.llvm.org/D42395 Files: test/Format/dump-config-cxx.h test/Format/dump-config-objc.h test/Format/lit.local.cfg tools/clang-format/Cl

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

benhamilton added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:52 /// FIXME: provide fix for snake_case to snakeCase -FixItHint generateFixItHint(const ObjCPropertyDecl *Decl) { - if (isupper(Decl->getName()[0])) { -auto NewName = Decl->getName(

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton updated this revision to Diff 131470. benhamilton added a comment. - Add more extensions. Repository: rC Clang https://reviews.llvm.org/D42395 Files: test/Format/dump-config-cxx.h test/Format/dump-config-objc.h test/Format/lit.local.cfg tools/clang-format/ClangFormat.cpp

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton marked an inline comment as done. benhamilton added inline comments. Comment at: test/Format/lit.local.cfg:2-3 +# Suffixes supported by clang-format. +config.suffixes = ['.cpp', '.h', '.m', '.mm', '.java', '.js', '.ts', '.proto', + '.protodevel', '.p

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton requested review of this revision. benhamilton marked 2 inline comments as done. benhamilton added inline comments. Comment at: test/Format/lit.local.cfg:1 +# Suffixes supported by clang-format. +config.suffixes = ['.c', '.cc', '.cpp', '.h', '.m', '.mm', '.java', '.js

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/TokenAnnotator.cpp:419 StartsObjCMethodExpr = true; + Left->ParameterCount = 0; Contexts.back().ColonIsObj

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:419 StartsObjCMethodExpr = true; + Left->ParameterCount = 0; Contexts.back().ColonIsObjCMethodExpr = true; jolesiak wrote: > benhamilton wrote: > > What do

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

This revision was automatically updated to reflect the committed changes. benhamilton marked an inline comment as done. Closed by commit rC323668: [clang-format] Fix bug where -dump-config failed on ObjC header (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.l

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

benhamilton requested changes to this revision. benhamilton added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:115 + +bool prefixedPropertyNameMatches(const llvm::StringRef &PropertyName, +

[PATCH] D42649: [clang-format] Add more tests for ObjC protocol list formatting behavior

benhamilton created this revision. benhamilton added reviewers: krasimir, jolesiak. Herald added subscribers: cfe-commits, klimek. The existing unit tests in FormatTestObjC.cpp didn't fully cover all the cases for protocol confirmance list formatting. This extends the unit tests to more cases of

[PATCH] D42650: [clang-format] New format param BinPackObjCProtocolList

benhamilton created this revision. benhamilton added reviewers: krasimir, jolesiak, stephanemoore. This is an alternative approach to https://reviews.llvm.org/D42014 after some investigation by stephanemoore@ and myself. Previously, the format parameter `BinPackParameters` controlled both C funct

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

benhamilton added a comment. Check out https://reviews.llvm.org/D42650 for an alternative approach. https://reviews.llvm.org/D42014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

benhamilton accepted this revision. benhamilton added a comment. shipit Repository: rC Clang https://reviews.llvm.org/D42493 ___ cfe-commits mailing

[PATCH] D42649: [clang-format] Add more tests for ObjC protocol list formatting behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL323684: [clang-format] Add more tests for ObjC protocol list formatting behavior (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.l

[PATCH] D42649: [clang-format] Add more tests for ObjC protocol list formatting behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rC323684: [clang-format] Add more tests for ObjC protocol list formatting behavior (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42649?vs=131821&id=131840#to

[PATCH] D42650: [clang-format] New format param BinPackObjCProtocolList

benhamilton updated this revision to Diff 131841. benhamilton added a comment. Rebase Repository: rC Clang https://reviews.llvm.org/D42650 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unitte

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:123 + size_t Start = PropertyName.find_first_of('_'); + assert(Start != llvm::StringRef::npos); + au

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

benhamilton accepted this revision. benhamilton added a comment. Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D42704: [clang-format] Do not break Objective-C string literals inside array literals

benhamilton created this revision. benhamilton added reviewers: jolesiak, stephanemoore, djasper. Herald added subscribers: cfe-commits, klimek. Concatenating Objective-C string literals inside an array literal raises the warning -Wobjc-string-concatenation (which is enabled by default). clang-fo

[PATCH] D42650: [clang-format] New format param BinPackObjCProtocolList

benhamilton updated this revision to Diff 132046. benhamilton added a comment. Move Google style changes out. Use clearer name for local variable. Repository: rC Clang https://reviews.llvm.org/D42650 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Fo

[PATCH] D42650: [clang-format] New format param BinPackObjCProtocolList

benhamilton marked 3 inline comments as done. benhamilton added a comment. Thanks for the review! Comment at: lib/Format/Format.cpp:765 GoogleStyle.ColumnLimit = 100; +GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never; } stephanemoore wro

[PATCH] D42708: [clang-format] Set BinPackObjCProtocolList to Never for google style

benhamilton created this revision. benhamilton added reviewers: krasimir, jolesiak, stephanemoore. This is split off from https://reviews.llvm.org/D42650, and sets BinPackObjCProtocolList to Never for the google style. Depends On https://reviews.llvm.org/D42650 Test Plan: New tests added. make

[PATCH] D42708: [clang-format] Set BinPackObjCProtocolList to Never for google style

benhamilton updated this revision to Diff 132185. benhamilton added a comment. Move to general property section Repository: rC Clang https://reviews.llvm.org/D42708 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp =

[PATCH] D42708: [clang-format] Set BinPackObjCProtocolList to Never for google style

benhamilton marked an inline comment as done. benhamilton added inline comments. Comment at: lib/Format/Format.cpp:765 GoogleStyle.ColumnLimit = 100; +GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never; } jolesiak wrote: > If I understand co

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton updated this revision to Diff 132187. benhamilton marked 2 inline comments as done. benhamilton added a comment. - BinPackObjCProtocolList -> ObjCBinPackProtocolList Repository: rC Clang https://reviews.llvm.org/D42650 Files: include/clang/Format/Format.h lib/Format/Continuat

[PATCH] D42708: [clang-format] Set ObjCBinPackProtocolList to Never for google style

benhamilton added inline comments. Comment at: lib/Format/Format.cpp:765 GoogleStyle.ColumnLimit = 100; +GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never; } benhamilton wrote: > jolesiak wrote: > > If I understand correctly this is meant t

[PATCH] D42708: [clang-format] Set ObjCBinPackProtocolList to Never for google style

benhamilton updated this revision to Diff 132188. benhamilton marked an inline comment as done. benhamilton added a comment. - BinPackObjCProtocolList -> ObjCBinPackProtocolList Repository: rC Clang https://reviews.llvm.org/D42708 Files: lib/Format/Format.cpp unittests/Format/FormatTestO

[PATCH] D42708: [clang-format] Set ObjCBinPackProtocolList to Never for google style

benhamilton updated this revision to Diff 132189. benhamilton added a comment. Fix comment. Repository: rC Clang https://reviews.llvm.org/D42708 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp =

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton added a comment. Thanks! @jolesiak is not available for the rest of the week, so should I just submit this as-is, or wait until next week? Repository: rC Clang https://reviews.llvm.org/D42650 ___ cfe-commits mailing list cfe-commits@

[PATCH] D42704: [clang-format] Do not break Objective-C string literals inside array literals

benhamilton added a comment. Ping! Any comments? Repository: rC Clang https://reviews.llvm.org/D42704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42812: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

benhamilton created this revision. benhamilton added reviewers: alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun, klimek. The following Objective-C code currently incorrectly triggers clang-tidy's performance-unnecessary-value-param check: % cat /tmp/performance-unnecessary-valu

[PATCH] D42812: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

This revision was automatically updated to reflect the committed changes. Closed by commit rL324097: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value… (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://re

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(tok::less) && Current.ParentBracket == tok::l_pa

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

This revision was automatically updated to reflect the committed changes. Closed by commit rC324131: [clang-format] New format param ObjCBinPackProtocolList (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42650?vs=132187&id=132650#toc Repository:

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton marked 2 inline comments as done. benhamilton added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(to

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

benhamilton created this revision. benhamilton added reviewers: stephanemoore, jolesiak, djasper. Herald added subscribers: cfe-commits, klimek. benhamilton edited the summary of this revision. benhamilton edited the summary of this revision. In r236412, @djasper added a comment: // FIXME: We l

[PATCH] D99063: [clang-format] Fix ObjC method indent after f7f9f94b

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99063/new/ https://reviews.llvm.org/D99063 _

[PATCH] D111975: [clang-format] [PR52015] clang-format should put __attribute__((foo)) on its own line before @interface / @implementation / @protocol

benhamilton accepted this revision. benhamilton added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111975/new/ https://reviews.llvm.org/D111975 ___ cfe-commits mailing list cfe-com

<    1   2   3   4