[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. In D70284#1978948 , @dexonsmith wrote: > In D70284#1752893 , @bendjones wrote: > > > In D70284#1752811 , @dexonsmith > > wrote: > > > > > For some

[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

bendjones added a comment. Seems reasonable to me. Thanks @erik.pilkington! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78066/new/ https://reviews.llvm.org/D78066 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

bendjones accepted this revision. bendjones marked an inline comment as done. bendjones added a comment. This revision is now accepted and ready to land. This addresses what we had an issue with on the tin. I’ll defer to @rjmccall for the specifics at the clang level. Comment

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. In D70284#1752806 , @bendjones wrote: > Any additional thoughts @dexonsmith @erik.pilkington @ahatanak? @dexonsmith @erik.pilkington @ahatanak does this look good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones created this revision. bendjones added reviewers: erik.pilkington, ahatanak. bendjones created this object with edit policy "Administrators". bendjones added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. Part of rdar://56643852 that makes all possible constant stri

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. In D70284#1746853 , @dexonsmith wrote: > The code looks right, but can you add a test for this in CodeGenObjC? Also, > when you re-upload the patch with the tests, please use `-U999` to > provide full context in the diff.

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones updated this revision to Diff 229441. bendjones added a comment. Added `"objc_arc_inert"` and updated `clang/test/CodeGenObjC/ns-constant-strings.m` tests to make sure the section is emitted as we want. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. Any additional thoughts @dexonsmith @erik.pilkington @ahatanak? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70284/new/ https://reviews.llvm.org/D70284 ___ cfe-commits maili

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. In D70284#1752811 , @dexonsmith wrote: > For some reason this revision is locked down and I'm not allowed to "edit" > it, which includes adding inline review comments. Can you add me as a > reviewer? Thought I did. > The tw