=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
steakhal wrote:
> I p
@@ -4096,7 +4096,8 @@ std::string ExprEngine::DumpGraph(bool trim, StringRef
Filename) {
std::string ExprEngine::DumpGraph(ArrayRef Nodes,
StringRef Filename) {
- std::unique_ptr TrimmedG(G.trim(Nodes));
+ TrimGraphWorklist Worklist{Nodes};
@@ -4096,7 +4096,8 @@ std::string ExprEngine::DumpGraph(bool trim, StringRef
Filename) {
std::string ExprEngine::DumpGraph(ArrayRef Nodes,
StringRef Filename) {
- std::unique_ptr TrimmedG(G.trim(Nodes));
+ TrimGraphWorklist Worklist{Nodes};
@@ -100,41 +100,7 @@ class SymbolConjured : public SymbolData {
ConstCFGElementRef getCFGElementRef() const { return Elem; }
// It might return null.
- const Stmt *getStmt() const {
steakhal wrote:
It must have been painful to iterate on this code :D
I a
https://github.com/steakhal approved this pull request.
LGTM. Thanks for the nice discussion.
https://github.com/llvm/llvm-project/pull/139980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
steakhal wrote:
I'll wait for the premerge checks to show green to avoid more reverts.
https://github.com/llvm/llvm-project/pull/139980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
steakhal wrote:
> What do you think about this?
I don't like this. LLVM is used as a library for wide set of tools and c
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/141076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
Superseded by #141076
https://github.com/llvm/llvm-project/pull/135720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/135720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -105,9 +105,6 @@ void errno_getcwd(char *Buf, size_t Sz) {
clang_analyzer_eval(errno != 0); // expected-warning{{TRUE}}
clang_analyzer_eval(Path == NULL); // expected-warning{{TRUE}}
if (errno) {} // no warning
- } else if (Path == NULL) {
https://github.com/steakhal approved this pull request.
LGTM, thank you for chiming in.
https://github.com/llvm/llvm-project/pull/141076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
,Balazs Benics ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Repl
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/141232
Resolves
https://github.com/llvm/llvm-project/issues/76208#issuecomment-2830854351
Quoting the docs of `[[clang::flag_enum]]`:
https://clang.llvm.org/docs/AttributeReference.html#flag-enum
> This attribute ca
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
,Balazs Benics ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Repl
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
,Balazs Benics ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Repl
steakhal wrote:
> Should we still warn if we store a negative value or a value >= 2*last member?
I was thinking about this but I chose the simplest way to suppress these.
https://github.com/llvm/llvm-project/pull/141232
___
cfe-commits mailing list
cf
@@ -105,9 +105,6 @@ void errno_getcwd(char *Buf, size_t Sz) {
clang_analyzer_eval(errno != 0); // expected-warning{{TRUE}}
clang_analyzer_eval(Path == NULL); // expected-warning{{TRUE}}
if (errno) {} // no warning
- } else if (Path == NULL) {
https://github.com/steakhal approved this pull request.
LGTM, thanks.
https://github.com/llvm/llvm-project/pull/142132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal requested changes to this pull request.
Thank you for the patch.
https://github.com/llvm/llvm-project/pull/142722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/142722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,39 @@
+// RUN: %clang_cc1 -triple x86_64-apple-macosx10.15.0 -emit-pch -o %t %s
+// RUN: %clang_analyze_cc1 -triple x86_64-apple-macosx10.15.0 -include-pch %t \
+// RUN: -analyzer-checker=core,apiModeling,unix.StdCLibraryFunctions -verify
%s
+//
+// RUN: %clang_cc1 -
@@ -129,11 +129,19 @@ std::optional tryExpandAsInteger(StringRef Macro,
const Preprocessor &PP) {
// Parse an integer at the end of the macro definition.
const Token &T = FilteredTokens.back();
- // FIXME: EOF macro token coming from a PCH file on macOS while marked as
-
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/142722
>From 3bd12ac6bb3c47b5e977cffec019df15a15426fc Mon Sep 17 00:00:00 2001
From: Ziqing Luo
Date: Wed, 4 Jun 2025 12:29:53 +0800
Subject: [PATCH 1/3] [StaticAnalyzer] Fix tryExpandAsInteger's failures on
macros f
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/142722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal approved this pull request.
Looks great. Much cleaner this way.
Thank you!
FYI: I also proposed a slight declarative simplification to the RUN lines, I
hope you like it.
https://github.com/llvm/llvm-project/pull/142722
___
@@ -0,0 +1,45 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+// RUN: split-file %s %t
+
+// RUN: %clang_cc1 -x c++ -triple x86_64-apple-macosx10.15.0 -emit-pch -o
%t/header.pch %t/header.h
+// RUN: %clang_analyze_cc1 -triple x86_64-apple-macosx10.15.0 -include-pch
%t/header.pch \
+
@@ -129,11 +129,19 @@ std::optional tryExpandAsInteger(StringRef Macro,
const Preprocessor &PP) {
// Parse an integer at the end of the macro definition.
const Token &T = FilteredTokens.back();
- // FIXME: EOF macro token coming from a PCH file on macOS while marked as
-
steakhal wrote:
FYI the CI checks are red, I don't think its related to this PR.
It had this line:
```
2025-06-05T08:01:02.4802924Z PASS: Clang :: Analysis/pch_macro.cpp (1263 of
21496)
```
So we should be good to merge, any time you want.
https://github.com/llvm/llvm-project/pull/142722
__
2501 - 2529 of 2529 matches
Mail list logo
