Author: Balazs Benics
Date: 2022-05-02T10:54:26+02:00
New Revision: fd7efe33f1b2d0dc3bce940154dba27413b72e7a
URL:
https://github.com/llvm/llvm-project/commit/fd7efe33f1b2d0dc3bce940154dba27413b72e7a
DIFF:
https://github.com/llvm/llvm-project/commit/fd7efe33f1b2d0dc3bce940154dba27413b72e7a.diff
Author: Balazs Benics
Date: 2022-05-02T11:42:08+02:00
New Revision: 5ce7050f701c6907cc2522fc43d39a8cbcc119d2
URL:
https://github.com/llvm/llvm-project/commit/5ce7050f701c6907cc2522fc43d39a8cbcc119d2
DIFF:
https://github.com/llvm/llvm-project/commit/5ce7050f701c6907cc2522fc43d39a8cbcc119d2.diff
Author: Balazs Benics
Date: 2022-05-02T11:48:52+02:00
New Revision: 29dff0d4fb46fe8f1e9774fd5e64d3e07937ff35
URL:
https://github.com/llvm/llvm-project/commit/29dff0d4fb46fe8f1e9774fd5e64d3e07937ff35
DIFF:
https://github.com/llvm/llvm-project/commit/29dff0d4fb46fe8f1e9774fd5e64d3e07937ff35.diff
Author: Ali Shuja Siddiqui
Date: 2022-05-03T14:05:19+02:00
New Revision: cf7cd664f3fd212c0f1e4a83fd2fe96902569d20
URL:
https://github.com/llvm/llvm-project/commit/cf7cd664f3fd212c0f1e4a83fd2fe96902569d20
DIFF:
https://github.com/llvm/llvm-project/commit/cf7cd664f3fd212c0f1e4a83fd2fe96902569d20.
Author: Tomasz Kamiński
Date: 2022-05-05T17:48:49+02:00
New Revision: f0d6cb4a5cf5723d7ddab2c7dab74f2f62116a6d
URL:
https://github.com/llvm/llvm-project/commit/f0d6cb4a5cf5723d7ddab2c7dab74f2f62116a6d
DIFF:
https://github.com/llvm/llvm-project/commit/f0d6cb4a5cf5723d7ddab2c7dab74f2f62116a6d.dif
Author: Balazs Benics
Date: 2022-05-06T12:13:51+02:00
New Revision: da5b5ae852c45236620e1dd8d498b2c49fa5c855
URL:
https://github.com/llvm/llvm-project/commit/da5b5ae852c45236620e1dd8d498b2c49fa5c855
DIFF:
https://github.com/llvm/llvm-project/commit/da5b5ae852c45236620e1dd8d498b2c49fa5c855.diff
Author: Tomasz Kamiński
Date: 2022-05-12T15:40:11+02:00
New Revision: 14742443a25826547e480189657b16c7a11664e7
URL:
https://github.com/llvm/llvm-project/commit/14742443a25826547e480189657b16c7a11664e7
DIFF:
https://github.com/llvm/llvm-project/commit/14742443a25826547e480189657b16c7a11664e7.dif
Author: Balazs Benics
Date: 2022-05-13T16:54:13+02:00
New Revision: 7e3ea55da88a9d7feaa22f29d51f89fd0152a189
URL:
https://github.com/llvm/llvm-project/commit/7e3ea55da88a9d7feaa22f29d51f89fd0152a189
DIFF:
https://github.com/llvm/llvm-project/commit/7e3ea55da88a9d7feaa22f29d51f89fd0152a189.diff
Author: Balazs Benics
Date: 2022-05-13T17:04:34+02:00
New Revision: d5ffc1ed8b629cd04bbd46ee6981529d9dafa48f
URL:
https://github.com/llvm/llvm-project/commit/d5ffc1ed8b629cd04bbd46ee6981529d9dafa48f
DIFF:
https://github.com/llvm/llvm-project/commit/d5ffc1ed8b629cd04bbd46ee6981529d9dafa48f.diff
Author: Balazs Benics
Date: 2022-05-13T17:07:58+02:00
New Revision: a1025e6ffe9b43afb9c6569423c4ea1d0ba8ecf2
URL:
https://github.com/llvm/llvm-project/commit/a1025e6ffe9b43afb9c6569423c4ea1d0ba8ecf2
DIFF:
https://github.com/llvm/llvm-project/commit/a1025e6ffe9b43afb9c6569423c4ea1d0ba8ecf2.diff
Author: Balazs Benics
Date: 2022-05-13T17:07:58+02:00
New Revision: e8cae487022c2216182ae1ec24f248f287a614b7
URL:
https://github.com/llvm/llvm-project/commit/e8cae487022c2216182ae1ec24f248f287a614b7
DIFF:
https://github.com/llvm/llvm-project/commit/e8cae487022c2216182ae1ec24f248f287a614b7.diff
Author: Balazs Benics
Date: 2022-05-20T16:06:46+02:00
New Revision: 5450db5f54b86f908ce67cb681fbdf86b88abc54
URL:
https://github.com/llvm/llvm-project/commit/5450db5f54b86f908ce67cb681fbdf86b88abc54
DIFF:
https://github.com/llvm/llvm-project/commit/5450db5f54b86f908ce67cb681fbdf86b88abc54.diff
Author: Balazs Benics
Date: 2022-05-20T21:12:39+02:00
New Revision: 665bfbb98daa0e40a2e6cecfbbfd6949980d8f2f
URL:
https://github.com/llvm/llvm-project/commit/665bfbb98daa0e40a2e6cecfbbfd6949980d8f2f
DIFF:
https://github.com/llvm/llvm-project/commit/665bfbb98daa0e40a2e6cecfbbfd6949980d8f2f.diff
Author: Balazs Benics
Date: 2022-05-20T21:41:25+02:00
New Revision: 0606467ea122da5cb23a588e1222a4140445734a
URL:
https://github.com/llvm/llvm-project/commit/0606467ea122da5cb23a588e1222a4140445734a
DIFF:
https://github.com/llvm/llvm-project/commit/0606467ea122da5cb23a588e1222a4140445734a.diff
Author: Balazs Benics
Date: 2022-05-20T21:41:25+02:00
New Revision: 6fa82e344c291cf0e1134b357b1f09fd2dcd3f4f
URL:
https://github.com/llvm/llvm-project/commit/6fa82e344c291cf0e1134b357b1f09fd2dcd3f4f
DIFF:
https://github.com/llvm/llvm-project/commit/6fa82e344c291cf0e1134b357b1f09fd2dcd3f4f.diff
Author: Balazs Benics
Date: 2022-05-21T22:16:55+02:00
New Revision: ecf5924eb4c4111bbab62425aca85866bb94b679
URL:
https://github.com/llvm/llvm-project/commit/ecf5924eb4c4111bbab62425aca85866bb94b679
DIFF:
https://github.com/llvm/llvm-project/commit/ecf5924eb4c4111bbab62425aca85866bb94b679.diff
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85104
>From 0f964127ed91e23f8e969e08ce680535cfeb8906 Mon Sep 17 00:00:00 2001
From: Andreas Steinhausen
Date: Wed, 13 Mar 2024 17:07:53 +0100
Subject: [PATCH 1/8] Adapted MemRegion::getDescriptiveName to handle
Eleme
steakhal wrote:
I hope you don't mind that I reworked the testing a bit, to be similar to the
rest of the tests.
I also reverted unnecessary clang-formatting where it was not relevant.
I refined the `auto` usage, but other than that I left your code untouched.
As I did everything I thought, I'l
steakhal wrote:
> However, I feel an urge to bikeshed that the "[invisible]" prefix is a bit
> puzzling for the developer who encounters it. Consider replacing it with the
> prefix "[debug]" which is a more conventional signal for "this is a debug
> printout" (i.e. normal users won't see it).
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85104
>From 0f964127ed91e23f8e969e08ce680535cfeb8906 Mon Sep 17 00:00:00 2001
From: Andreas Steinhausen
Date: Wed, 13 Mar 2024 17:07:53 +0100
Subject: [PATCH 1/9] Adapted MemRegion::getDescriptiveName to handle
Eleme
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 1/6] Fix crash on StaticAnalyzer loop unrolling
---
clang/lib/Static
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 1/7] Fix crash on StaticAnalyzer loop unrolling
---
clang/lib/Static
@@ -1,5 +1,7 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection
-analyzer-config unroll-loops=true,cfg-loopexit=true -verify -std=c++14
-analyzer-config exploration_strategy=unexplored_first_queue %s
// RUN: %clang_analyze_cc1 -analyzer-checker=core,debu
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 1/8] Fix crash on StaticAnalyzer loop unrolling
---
clang/lib/Static
steakhal wrote:
> Hello @steakhal, I have just looked through the changes again. What is the
> advantage of using checkPreCall instead of checkLocation? I would very much
> appreciate some background information. Thanks for your help!
Oh yes, I should have explained.
So, `checkLocation` can be
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 1/9] Fix crash on StaticAnalyzer loop unrolling
---
clang/lib/Static
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 01/10] Fix crash on StaticAnalyzer loop unrolling
---
clang/lib/Stat
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/82089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/85211
Inside the ExprEngine when we process the initializers, we create a
PostInitializer program-point, which will refer to the field being initialized,
see `FieldLoc` inside `ExprEngine::ProcessInitializer`.
When
@@ -720,14 +720,20 @@ std::string MemRegion::getDescriptiveName(bool UseQuotes)
const {
CI->getValue().toString(Idx);
ArrayIndices = (llvm::Twine("[") + Idx.str() + "]" + ArrayIndices).str();
}
-// If not a ConcreteInt, try to obtain the variable
-// na
steakhal wrote:
> In addition to the above-mentioned issues there is also a conceptual problem
> with using `getOriginRegion()` to describe a symbol: it names the region
> where the symbol _originated_ (if it originated as the unknown initial value
> of a symbol), which is not necessarily the
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/85224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/85224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1090,7 +1090,8 @@ static bool isStandardNewDelete(const FunctionDecl *FD) {
// If the header for operator delete is not included, it's still defined
// in an invalid source location. Check to make sure we don't crash.
return !L.isValid() ||
- FD->getASTContext
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85211
>From bde85e0d145049a6661afba6f4585865c5630792 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Thu, 14 Mar 2024 12:38:12 +0100
Subject: [PATCH 1/2] [analyzer] Wrap SymbolicRegions by ElementRegions before
ge
@@ -451,6 +451,38 @@ void ProgramState::setStore(const StoreRef &newStore) {
store = newStoreStore;
}
+/// FieldRegions are expected to be wrapped by an ElementRegion as a canonical
+/// representation. See f8643a9b31c4029942f67d4534c9139b45173504 why.
+static SVal wrapSymbo
steakhal wrote:
> I think it's good that we're moving towards establishing the invariant that
> the parent of a FieldRegion should always be a typed value region (of a
> suitable type) for the sake of consistency. Do I understand it correctly that
> this is not too far away? Would it be possib
steakhal wrote:
@T-Gruber Could you please add that test case with a FIXME?
https://github.com/llvm/llvm-project/pull/85104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -479,12 +479,15 @@ def add_raw_line(self, raw_line):
# A visitor that dumps the ExplodedGraph into a DOT file with fancy HTML-based
# syntax highlighing.
class DotDumpVisitor:
-def __init__(self, do_diffs, dark_mode, gray_mode, topo_mode,
dump_dot_only):
+def __init
@@ -1186,6 +1192,14 @@ def main():
"displaying it, dump the rewritten dot file "
"to stdout",
)
+dump_conflict.add_argument(
+"--dump-html-only",
+action="store_const",
+dest="dump_html_only",
+const=True,
+default
steakhal wrote:
> Hi @steakhal, just to be sure. We are talking about a test case that covers
> that the index is "recognised" as a wrong variable (the matrix example above)?
Exactly!
https://github.com/llvm/llvm-project/pull/85104
___
cfe-commits ma
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85211
>From bde85e0d145049a6661afba6f4585865c5630792 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Thu, 14 Mar 2024 12:38:12 +0100
Subject: [PATCH 1/3] [analyzer] Wrap SymbolicRegions by ElementRegions before
ge
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85104
>From 0f964127ed91e23f8e969e08ce680535cfeb8906 Mon Sep 17 00:00:00 2001
From: Andreas Steinhausen
Date: Wed, 13 Mar 2024 17:07:53 +0100
Subject: [PATCH 01/12] Adapted MemRegion::getDescriptiveName to handle
Ele
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85211
>From bde85e0d145049a6661afba6f4585865c5630792 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Thu, 14 Mar 2024 12:38:12 +0100
Subject: [PATCH 1/4] [analyzer] Wrap SymbolicRegions by ElementRegions before
ge
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/85211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/85104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/83985
>From 881701d528255e2c49ed64f5f1df98f0f44c1d7b Mon Sep 17 00:00:00 2001
From: Viktor
Date: Tue, 5 Mar 2024 09:46:26 +
Subject: [PATCH] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha
---
clang/d
steakhal wrote:
Retriggered the premerge checks.
https://github.com/llvm/llvm-project/pull/83985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1090,7 +1090,8 @@ static bool isStandardNewDelete(const FunctionDecl *FD) {
// If the header for operator delete is not included, it's still defined
// in an invalid source location. Check to make sure we don't crash.
return !L.isValid() ||
- FD->getASTContext
steakhal wrote:
@NagyDonat Thank you for the excellent feedback. Great recommendations, with
fixes. Thanks!
All applied.
https://github.com/llvm/llvm-project/pull/85211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
steakhal wrote:
I'm sorry, but I'm out of bandwidth. Maybe someone else can step up for the
review.
https://github.com/llvm/llvm-project/pull/83675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/steakhal approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/85515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Alejandro Álvarez Ayllón
Date: 2024-03-22T11:50:34+01:00
New Revision: a62441d4bb6bd0cd8eccab8c5692340c5a2c60bb
URL:
https://github.com/llvm/llvm-project/commit/a62441d4bb6bd0cd8eccab8c5692340c5a2c60bb
DIFF:
https://github.com/llvm/llvm-project/commit/a62441d4bb6bd0cd8eccab8c5692340c5a2
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=
Message-ID:
In-Reply-To:
steakhal wrote:
Rebase merged.
https://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
steakhal wrote:
Ping @NagyDonat
https://github.com/llvm/llvm-project/pull/84823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/84972
>From f66c62bcf3fd1427ad3f5061ec23110c1c3a5b6e Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 12 Mar 2024 19:55:29 +0100
Subject: [PATCH] [analyzer] Support C++23 static operator calls
Made by followin
Author: Alejandro Álvarez Ayllón
Date: 2024-03-22T11:50:34+01:00
New Revision: 730ca47a0cc7380def6df1d25b30c1378fd8bf14
URL:
https://github.com/llvm/llvm-project/commit/730ca47a0cc7380def6df1d25b30c1378fd8bf14
DIFF:
https://github.com/llvm/llvm-project/commit/730ca47a0cc7380def6df1d25b30c1378fd
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/84972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -804,10 +804,28 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (PaddingChecker)
+
https://github.com/steakhal requested changes to this pull request.
The docs should also explain why is a problem to have padding bytes, and how to
fix it.
How does the generated html look like after your change for this file?
(Have a look at my commits to this or to the releasenotes file for c
@@ -804,10 +804,28 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (PaddingChecker)
+
@@ -804,10 +804,28 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (PaddingChecker)
+
@@ -804,10 +804,28 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (PaddingChecker)
steakhal wrote:
It should be the la
@@ -804,10 +804,28 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (PaddingChecker)
+
@@ -804,10 +804,28 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (PaddingChecker)
+
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/86411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/86411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/86411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/84823
>From 94c6be96d92d8a25693ccbbffedf9edabfe79cc5 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Mon, 11 Mar 2024 21:18:30 +0100
Subject: [PATCH 1/2] [analyzer] Set and display CSA analysis entry points as
not
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,NagyDonat
,NagyDonat
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
https://github.com/llvm/llvm-project/pull/85791
___
cfe-commits mailing list
cfe-commit
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/84823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/86411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -804,10 +804,38 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (C, C++, ObjC)
+
Check for ex
@@ -804,10 +804,38 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (C, C++, ObjC)
+
Check for ex
@@ -804,10 +804,38 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (C, C++, ObjC)
+
Check for ex
@@ -804,10 +804,38 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (C, C++, ObjC)
+
Check for ex
https://github.com/steakhal requested changes to this pull request.
The grammar seems good.
I have further concerns inline.
https://github.com/llvm/llvm-project/pull/86411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/86411
>From b6ca6f0ef83d03e299d6ee9a8ed9b8044477914e Mon Sep 17 00:00:00 2001
From: komalverma04 <114138604+komalverm...@users.noreply.github.com>
Date: Sat, 23 Mar 2024 11:14:44 -0700
Subject: [PATCH 1/7] Update check
steakhal wrote:
I figured, it might be easier to directly propose and apply some of my thoughts.
Let me know if you like it.
My goal was:
- be specific what is the impact of not having the optimal layout: memory,
cachemisses
- have a single block of examples, demonstrating the bad, the good a
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/86536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -124,34 +124,45 @@ class CStringChecker : public Checker< eval::Call,
const CallEvent &)>;
CallDescriptionMap Callbacks = {
- {{CDM::CLibrary, {"memcpy"}, 3},
+ {{CDM::CLibraryMaybeHardened, {"memcpy"}, 3},
std::bind(
@@ -110,13 +110,24 @@ bool CheckerContext::isCLibraryFunction(const
FunctionDecl *FD,
if (FName.starts_with("__inline") && FName.contains(Name))
return true;
- if (FName.starts_with("__") && FName.ends_with("_chk") &&
- FName.contains(Name))
-return true;
-
https://github.com/steakhal commented:
I like your patch. This is an important fix.
I only had a couple nits, but overall looks good.
https://github.com/llvm/llvm-project/pull/86536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
@@ -124,34 +124,45 @@ class CStringChecker : public Checker< eval::Call,
const CallEvent &)>;
CallDescriptionMap Callbacks = {
- {{CDM::CLibrary, {"memcpy"}, 3},
+ {{CDM::CLibraryMaybeHardened, {"memcpy"}, 3},
std::bind(
https://github.com/steakhal approved this pull request.
LGTM, but I'd recommed @Xazax-hun to also have a look.
If nothing happens, merge this after one week.
https://github.com/llvm/llvm-project/pull/86536
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/86411
>From b6ca6f0ef83d03e299d6ee9a8ed9b8044477914e Mon Sep 17 00:00:00 2001
From: komalverma04 <114138604+komalverm...@users.noreply.github.com>
Date: Sat, 23 Mar 2024 11:14:44 -0700
Subject: [PATCH 1/8] Update check
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/86411
>From b6ca6f0ef83d03e299d6ee9a8ed9b8044477914e Mon Sep 17 00:00:00 2001
From: komalverma04 <114138604+komalverm...@users.noreply.github.com>
Date: Sat, 23 Mar 2024 11:14:44 -0700
Subject: [PATCH 1/9] Update check
https://github.com/steakhal approved this pull request.
https://github.com/llvm/llvm-project/pull/86411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/86411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/86411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/86411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/86953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal approved this pull request.
The simpler the better.
Thanks.
https://github.com/llvm/llvm-project/pull/86953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1238,12 +1238,12 @@ class StoreSiteFinder final : public
TrackingBugReporterVisitor {
///changes to its value in a nested stackframe could be pruned, and
///this visitor can prevent that without polluting the bugpath too
///much.
- StoreSiteF
https://github.com/steakhal approved this pull request.
https://github.com/llvm/llvm-project/pull/86919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal commented:
Unless you plan to add more heuristics, I'd prefer a more concrete option name,
like AssumeSuccessfulWrites=true.
This would better describe it imo.
https://github.com/llvm/llvm-project/pull/87322
___
cfe-commits
https://github.com/steakhal requested changes to this pull request.
I only had generic nits, as I'm not really in the domain. Consider my review as
such.
https://github.com/llvm/llvm-project/pull/87314
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/87314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5317,6 +5317,34 @@ TEST_P(ASTImporterOptionSpecificTestBase,
EXPECT_FALSE(ToX);
}
+TEST_P(ASTImporterOptionSpecificTestBase, VarTemplateDeclInlineWithCXX17) {
+ Decl *FromTU = getTuDecl(
+ R"(
+ struct S {
+template static constexpr bool X = true;
+
201 - 300 of 2340 matches
Mail list logo
