[clang] [llvm] Add RunTimeLang to Class and Enumeration DIBuilder functions (PR #72011)

2023-11-10 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/72011 RunTimeLang is already supported by DICompositeType, and already used by structs and unions. Add a new parameter in the class and enumeration create methods, so they can use the RunTimeLang attribute as well

[clang] [llvm] Add RunTimeLang to Class and Enumeration DIBuilder functions (PR #72011)

2023-11-13 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/72011 >From 051bd74b2af581fc52896538f0ce571770e57b3e Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Mon, 13 Nov 2023 09:48:00 -0800 Subject: [PATCH] Add RunTimeLang to Class and Enumeration DIBuilder function

[clang] [llvm] Add RunTimeLang to Class and Enumeration DIBuilder functions (PR #72011)

2023-11-14 Thread Augusto Noronha via cfe-commits
augusto2112 wrote: ping :) https://github.com/llvm/llvm-project/pull/72011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add RunTimeLang to Class and Enumeration DIBuilder functions (PR #72011)

2023-11-14 Thread Augusto Noronha via cfe-commits
@@ -424,6 +424,7 @@ namespace llvm { /// \param OffsetInBits Member offset. /// \param FlagsFlags to encode member attribute, e.g. private /// \param Elements class members. +/// \param RunTimeLang Optional parameter, Objective-C runtime version. --

[llvm] [clang] Add RunTimeLang to Class and Enumeration DIBuilder functions (PR #72011)

2023-11-14 Thread Augusto Noronha via cfe-commits
augusto2112 wrote: @felipepiovezan I don't this patch as it is has any changes that are testable. I haven't added any code that will emit a RuntimeLang, only added the option to do that so I can add those callers downstream. In retrospect I should've marked it as NFC. https://github.com/llvm/

[clang] [llvm] Add RunTimeLang to Class and Enumeration DIBuilder functions (PR #72011)

2023-11-15 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/72011 >From 8cebb68070de258e6f581e83c3b0541087f53570 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Mon, 13 Nov 2023 09:48:00 -0800 Subject: [PATCH] [DebugInfo][CGDebugInfo] Add RunTimeLang to more DIBuilder

[clang] [llvm] Add RunTimeLang to Class and Enumeration DIBuilder functions (PR #72011)

2023-11-15 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/72011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 87bd71e - Revert "[NFC] Fix the warning Wcovered-switch-default"

2023-12-15 Thread Augusto Noronha via cfe-commits
Author: Augusto Noronha Date: 2023-12-15T14:43:25-08:00 New Revision: 87bd71efd0af21b6663a7729317952535446f36d URL: https://github.com/llvm/llvm-project/commit/87bd71efd0af21b6663a7729317952535446f36d DIFF: https://github.com/llvm/llvm-project/commit/87bd71efd0af21b6663a7729317952535446f36d.dif

[clang] eccc1cc - Revert "[NFC] [Serialization] Packing more bits and refactor AbbrevToUse"

2023-12-15 Thread Augusto Noronha via cfe-commits
Author: Augusto Noronha Date: 2023-12-15T14:43:25-08:00 New Revision: eccc1cca71bb704e4dcaabccc993d08fd15b46a2 URL: https://github.com/llvm/llvm-project/commit/eccc1cca71bb704e4dcaabccc993d08fd15b46a2 DIFF: https://github.com/llvm/llvm-project/commit/eccc1cca71bb704e4dcaabccc993d08fd15b46a2.dif

[clang] Fix #pragma (packed, n) not emitting the alignment in debug info (PR #94673)

2024-06-06 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/94673 Debug info generation won't emit the alignment of types that have a standard alignment. It was not taking into account the that case. rdar://127785973 >From 8fd0e9dcfd915367db1b66001daab47415406302 Mon Sep

[clang] Fix #pragma (packed, n) not emitting the alignment in debug info (PR #94673)

2024-06-06 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/94673 >From 3bf273f06fc82a5ca699d64b57dbc734f05fd896 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 6 Jun 2024 12:29:05 -0700 Subject: [PATCH] Fix #pragma (packed, n) not emitting the alignment in debug

[clang] Fix #pragma (packed, n) not emitting the alignment in debug info (PR #94673)

2024-06-07 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/94673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #109490)

2024-09-25 Thread Augusto Noronha via cfe-commits
@@ -109,6 +110,21 @@ static bool IsArtificial(VarDecl const *VD) { cast(VD->getDeclContext())->isImplicit()); } +static bool usesDebugTransparent(const Decl *D, const CodeGenModule &CGM) { + if (!D) +return false; + + if (auto *attr = D->get

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #109490)

2024-09-25 Thread Augusto Noronha via cfe-commits
@@ -4160,6 +4178,8 @@ llvm::DISubprogram *CGDebugInfo::getFunctionFwdDeclOrStub(GlobalDecl GD, if (Stub) { Flags |= getCallSiteRelatedAttrs(); SPFlags |= llvm::DISubprogram::SPFlagDefinition; +if (usesDebugTransparent(FD, CGM)) augusto2112 wrote:

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #109490)

2024-09-25 Thread Augusto Noronha via cfe-commits
@@ -109,6 +110,21 @@ static bool IsArtificial(VarDecl const *VD) { cast(VD->getDeclContext())->isImplicit()); } +static bool usesDebugTransparent(const Decl *D, const CodeGenModule &CGM) { + if (!D) +return false; + + if (auto *attr = D->get

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-09-26 Thread Augusto Noronha via cfe-commits
augusto2112 wrote: I opened this PR since I messed up https://github.com/llvm/llvm-project/pull/109490 https://github.com/llvm/llvm-project/pull/110188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-09-26 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/110188 The `debug_transparent` attribute is intended as a hint for debuggers that this function itself is not interesting, but it calls a function that might be. So, when stepping in arrives at a function with th

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #109490)

2024-09-26 Thread Augusto Noronha via cfe-commits
augusto2112 wrote: I accidentally rebased on top of the wrong branch which tagged a lot of people as reviewers, I'm going to close this PR and open a new one as to not spam a ton of people. https://github.com/llvm/llvm-project/pull/109490 ___ cfe-com

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #109490)

2024-09-26 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/109490 >From b7271f2f4a638a5c03cb28b05bb836ca245acb41 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Mar 2023 14:01:36 -0700 Subject: [PATCH] [clang] Add "debug_transparent" attribute The `debug_tran

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #109490)

2024-09-26 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/109490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #109490)

2024-09-20 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/109490 The `debug_transparent` attribute is intended as a hint for debuggers that this function itself is not interesting, but it calls a function that might be. So, when stepping in arrives at a function with th

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #109490)

2024-09-20 Thread Augusto Noronha via cfe-commits
augusto2112 wrote: @dwblaikie @AaronBallman this is the "debug_transparent" patch that I opened last year but didn't get around to finish implementing (https://reviews.llvm.org/D146595). The current version addresses the comments left in the phabricator review: - Changed the name from debug_tr

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-10-01 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/110188 >From a28f8e716a7efe356e0088c00257edfc15132cb7 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Mar 2023 14:01:36 -0700 Subject: [PATCH] [clang] Add "debug_transparent" attribute The `debug_tran

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-10-01 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/110188 >From 807fc9a690555930ef0c047f0c4253c6204376a9 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Mar 2023 14:01:36 -0700 Subject: [PATCH] [clang] Add "debug_transparent" attribute The `debug_tran

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-10-02 Thread Augusto Noronha via cfe-commits
augusto2112 wrote: > As a new feature, this needs a proposal on Discourse. @efriedma-quic as an RFC under clang? I wasn't aware this was a rule, is this a recent change? https://github.com/llvm/llvm-project/pull/110188 ___ cfe-commits mailing list cf

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-10-02 Thread Augusto Noronha via cfe-commits
augusto2112 wrote: And would that be an RFC under "clang"? Or is there a different section on Discourse for feature proposals? https://github.com/llvm/llvm-project/pull/110188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.