rmaprath added a reviewer: compnerd.
rmaprath removed a subscriber: compnerd.
rmaprath updated this revision to Diff 62890.
rmaprath added a comment.
- Use `__ARM_WMMX` instead of `_LIBUNWIND_ARM_WMMX`
- Add a comment to the cmake option `LIBUNWIND_ENABLE_ARM_WMMX` to explain why
it is done this
rmaprath added inline comments.
Comment at: src/Registers.hpp:1497
@@ -1479,3 +1496,3 @@
_LIBUNWIND_ABORT("unsupported arm register");
}
compnerd wrote:
> Early returns would be nicer imo.
Not sure if I follow, did you mean to check the bounds of `regNum`
Author: asiri
Date: Thu Jul 7 05:55:39 2016
New Revision: 274744
URL: http://llvm.org/viewvc/llvm-project?rev=274744&view=rev
Log:
[libunwind][ARM] Improve unwinder stack usage - Make WMMX support optional
These registers are only available on a limited set of ARM targets (those
based on XScale)
Author: asiri
Date: Fri Jul 8 07:13:31 2016
New Revision: 274840
URL: http://llvm.org/viewvc/llvm-project?rev=274840&view=rev
Log:
[PATCH] [libunwind][ehabi] Use early returns where possible.
Just a minor code cleanup. NFC.
Modified:
libunwind/trunk/src/Registers.hpp
Modified: libunwind/tr
rmaprath added a comment.
@mclow.lists, @ericwf: Gentle ping.
http://reviews.llvm.org/D21968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added inline comments.
Comment at: src/Registers.hpp:1497
@@ -1479,3 +1496,3 @@
_LIBUNWIND_ABORT("unsupported arm register");
}
compnerd wrote:
> rmaprath wrote:
> > compnerd wrote:
> > > Early returns would be nicer imo.
> > Not sure if I follow,
rmaprath updated this revision to Diff 63670.
rmaprath added a comment.
Minor cleanup + Ping.
http://reviews.llvm.org/D21968
Files:
CMakeLists.txt
include/__config
include/__config_site.in
include/__threading_support
lib/CMakeLists.txt
test/CMakeLists.txt
test/libcxx/test/config.p
rmaprath added a comment.
In http://reviews.llvm.org/D22292#482560, @compnerd wrote:
> Can you explain why the write back is needed? You are doing the write back
> on r0, but then adjusting it back. So it is unclear why this change is
> needed. Could you provide some more context. A test ca
rmaprath added a comment.
Update: Almost there, should be able to put it up for review tomorrow.
Cheers,
/ Asiri
https://reviews.llvm.org/D22292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
rmaprath added a subscriber: olista01.
rmaprath added a comment.
Update: We've hit a minor issue with the patch, we're confident it can be
sorted by next week. I will ask @olista01 to put the final patch for review
next week, as I'm on holidays. Hope this is OK.
Cheers,
/ Asiri
https://revie
rmaprath updated this revision to Diff 45868.
rmaprath added a comment.
Re-based on trunk. Trivial.
http://reviews.llvm.org/D14653
Files:
include/__config
include/array
test/std/containers/sequences/array/at.pass.cpp
test/support/noexcept.h
test/support/test_allocator.h
Index: test/s
rmaprath created this revision.
rmaprath added reviewers: rjmccall, jmolloy, rengolin, olista01.
rmaprath added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
Lets consider the following plain struct:
```
struct S1 {
char a;
short b : 8;
};
```
According to the AAPCS,
rmaprath added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1761
@@ +1760,3 @@
+Ptr = Address(AdjustAAPCSBitfieldAccess(Dst, Info, false),
+ getContext().getTypeAlignInChars(Dst.getType()));
+
rjmccall wrote:
> This alignment computatio
rmaprath added inline comments.
Comment at: test/support/noexcept.h:23
@@ +22,3 @@
+// tests use multiple catch statements, in those cases we have to use the
+// _LIBCPP_NO_EXCEPTIONS macro and exclude the additional catch statements.
+#ifndef _LIBCPP_NO_EXCEPTIONS
---
rmaprath updated this revision to Diff 46264.
rmaprath added a comment.
Addressing review comments by @rjmccall:
Moved all the AAPCS specific tweaks to EmitLValueForField(), this simplified
the patch a lot (now there is no mucking about a de-constructed GEP at
load/store points). In order to do
rmaprath marked 2 inline comments as done.
rmaprath added a comment.
http://reviews.llvm.org/D16586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath created this revision.
rmaprath added reviewers: mclow.lists, jroelofs, rengolin.
rmaprath added a subscriber: cfe-commits.
Summary:
r252598 and r252870 added XFAILs to all those tests that are currently
failing on the -fno-exceptions libc++ library variant. This patch introduces
a mecha
rmaprath updated this revision to Diff 40307.
rmaprath added a comment.
Tidied up the patch a bit:
- Got rid of the different variants of the throw_helper function, can do with
one in almost all the cases (the exceptional case will be submitted for review
separately).
- Modified __config a litt
rmaprath added a comment.
@rengolin: Gentle ping.
Cheers,
- Asiri
http://reviews.llvm.org/D14293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath abandoned this revision.
rmaprath added a comment.
Makes sense. Thanks.
http://reviews.llvm.org/D14616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 40669.
rmaprath added a comment.
Addressing review comments:
- Renamed `throw_helper` as `__throw_helper` in order to not pollute the global
namespace (@jroelofs)
- Made `try_buf` a `thread_local` in order to be able to support those tests
the launch multi
rmaprath updated this revision to Diff 40707.
rmaprath added a comment.
Addressing review comments by @jroelofs:
- Got rid of the default implementation for `__libcxx_noexceptions_abort` by
making it a weak reference.
http://reviews.llvm.org/D14653
Files:
include/__config
include/__noexce
rmaprath updated this revision to Diff 40767.
rmaprath added a comment.
Addressing review comments:
- Fixed a couple of typos.
- Made the use of the thread-local storage specifier a bit more flexible to
allow testing on few other configurations.
http://reviews.llvm.org/D14653
Files:
include
rmaprath added a comment.
Gentle ping.
http://reviews.llvm.org/D14653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
Ping?
http://reviews.llvm.org/D14653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
Ping?
http://reviews.llvm.org/D14653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 42175.
rmaprath added a comment.
Addressing review comments by @mclow.lists:
Got rid of the `__noexcept` header by moving the `__throw_helper` function into
the `__config` header. The `__libcxx_noexceptions_abort` function now takes in
an extra parameter c
rmaprath updated this revision to Diff 42178.
rmaprath added a comment.
Added a header guard to the `noexcept.h` test support header (review comment by
@jroelofs).
http://reviews.llvm.org/D14653
Files:
include/__config
include/array
test/std/containers/sequences/array/at.pass.cpp
test/
rmaprath added a comment.
In http://reviews.llvm.org/D14653#306675, @EricWF wrote:
> - I like the approach taken in the library. `__throw_helper` and
> `__libcxx_noexceptions_abort()`. However I don't like that they are in their
> own header. We should find another header for these to live in.
rmaprath updated this revision to Diff 42440.
rmaprath added a comment.
Addressing review comments by @EricWF:
- Introduced `_LIBCPP_THROW` macro to appropriately throw or call the
no-exceptions report routine to handle the exceptional situation (avoid the
overhead of a function call in the def
rmaprath updated this revision to Diff 42694.
rmaprath added a comment.
Simplified the changes to `__config` header.
http://reviews.llvm.org/D14653
Files:
include/__config
include/array
test/std/containers/sequences/array/at.pass.cpp
test/support/noexcept.h
Index: test/support/noexcept
rmaprath updated this revision to Diff 42701.
rmaprath added a comment.
Further refined the changes to `__config` header.
- Now there's only one `_LIBCPP_THROW` macro, which does the right thing
depending on the availability of exceptions.
- Made `__libcxx_noexceptions_report` not take in the ex
rmaprath updated this revision to Diff 42977.
rmaprath added a comment.
Two minor additions:
- Introduced a `TEST_THROW` macro for those tests that need to throw exceptions
(Note:- not using the `_LIBCPP_THROW` macro here as we want to keep the tests
independent of the standard library implemen
rmaprath marked 2 inline comments as done.
rmaprath added a comment.
http://reviews.llvm.org/D14653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 43237.
rmaprath added a comment.
Addressing review comments by @mclow.lists:
- Introduced `TEST_TRY` and `TEST_CATCH` macros to avoid the non-standard
`#define try/catch`.
http://reviews.llvm.org/D14653
Files:
include/__config
include/array
test/st
rmaprath marked an inline comment as done.
rmaprath added a comment.
http://reviews.llvm.org/D14653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
301 - 336 of 336 matches
Mail list logo
