[clang] Add -fuse-lipo option (PR #121231)

https://github.com/khyperia updated https://github.com/llvm/llvm-project/pull/121231 >From 33b542152876b9ccbf42cc3d070d582c32145477 Mon Sep 17 00:00:00 2001 From: khyperia Date: Fri, 27 Dec 2024 23:03:58 +0100 Subject: [PATCH 1/2] Add -fuse-lipo option --- clang/include/clang/Driver/Options.t

[clang] Add -fuse-lipo option (PR #121231)

khyperia wrote: @carlocab I've removed the temporary std::string and added a guess at basic tests. Let me know if there's additional tests in particular that you're thinking of! https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing

[clang] Add -fuse-lipo option (PR #121231)

khyperia wrote: > It is better to add a CLANG_DEFAULT_LIPO cmake option to match the > CLANG_DEFAULT_LINKER for -fuse-ld. Sure, that's a possibility, but in my opinion can be done in a future PR. There's a lot of additional features that can be done in the future: - CLANG_DEFAULT_LIPO cmake o

[clang] Add -fuse-lipo option (PR #121231)

https://github.com/khyperia created https://github.com/llvm/llvm-project/pull/121231 This is my first LLVM PR! Please feel free to provide feedback/etc. - I am especially unsure about the `Options.td` change - I just kind of guessed here. Partially fixes https://github.com/llvm/llvm-project/is

[clang] Add -fuse-lipo option (PR #121231)

https://github.com/khyperia updated https://github.com/llvm/llvm-project/pull/121231 >From 33b542152876b9ccbf42cc3d070d582c32145477 Mon Sep 17 00:00:00 2001 From: khyperia Date: Fri, 27 Dec 2024 23:03:58 +0100 Subject: [PATCH] Add -fuse-lipo option --- clang/include/clang/Driver/Options.td |

[clang] Add -fuse-lipo option (PR #121231)

@@ -910,7 +910,10 @@ void darwin::Lipo::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back(II.getFilename()); } - const char *Exec = Args.MakeArgString(getToolChain().GetProgramPath("lipo")); + std::string LipoName = + std::string(Args.getLastArg

[clang] Add -fuse-lipo option (PR #121231)

khyperia wrote: (For what it's worth, just confirming that the current code doesn't work with a full path - it surprisingly kind of almost does, but not quite, due to quirks of `GetProgramPath`) https://github.com/llvm/llvm-project/pull/121231 ___ cf

[clang] Add -fuse-lipo option (PR #121231)

https://github.com/khyperia updated https://github.com/llvm/llvm-project/pull/121231 >From 33b542152876b9ccbf42cc3d070d582c32145477 Mon Sep 17 00:00:00 2001 From: khyperia Date: Fri, 27 Dec 2024 23:03:58 +0100 Subject: [PATCH 1/3] Add -fuse-lipo option --- clang/include/clang/Driver/Options.t

[clang] Add -fuse-lipo option (PR #121231)

khyperia wrote: > LGTM in general with a comment in test. > > For discussion. Is it better if the option supplies the full path to lipo or > just the name? Full path seems to be easy to use, but might deserve a warning > if the tool doesn't exist. If just the name, it might be better to rename

[clang] [clang][Driver] Add -fuse-lipo option (PR #121231)

khyperia wrote: Looks great, thanks! https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add -fuse-lipo option (PR #121231)

khyperia wrote: @cachemeifyoucan thank you, done! (feel free to rewrite it as well, if you want or have any nitpicks) https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] Add -fuse-lipo option (PR #121231)

https://github.com/khyperia edited https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add -fuse-lipo option (PR #121231)

khyperia wrote: @cachemeifyoucan Could you possibly help me get this merged? I'm not sure if your approval is enough, or if more reviewers are needed - and if so, who. Are you able to merge this if just your approval is enough? https://github.com/llvm/llvm-project/pull/121231 _