[clang] 922fa2f - Run Coverage pass before other *San passes under new pass manager, round 2

2020-05-28 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-05-28T14:25:23-07:00 New Revision: 922fa2fce38b0bd97921b91ff1cdc57f18d3569c URL: https://github.com/llvm/llvm-project/commit/922fa2fce38b0bd97921b91ff1cdc57f18d3569c DIFF: https://github.com/llvm/llvm-project/commit/922fa2fce38b0bd97921b91ff1cdc57f18d3569c.diff

[clang] e3fb844 - Revert "Run Coverage pass before other *San passes under new pass manager, round 2"

2020-05-28 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-05-28T14:38:05-07:00 New Revision: e3fb8446f2ec3953348f3c773004cf2aa28a8c04 URL: https://github.com/llvm/llvm-project/commit/e3fb8446f2ec3953348f3c773004cf2aa28a8c04 DIFF: https://github.com/llvm/llvm-project/commit/e3fb8446f2ec3953348f3c773004cf2aa28a8c04.diff

[clang] 1285e8b - Run Coverage pass before other *San passes under new pass manager, round 2

2020-05-28 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-05-28T17:04:47-07:00 New Revision: 1285e8bcac2c54ddd924ffb813b2b187467ac2a6 URL: https://github.com/llvm/llvm-project/commit/1285e8bcac2c54ddd924ffb813b2b187467ac2a6 DIFF: https://github.com/llvm/llvm-project/commit/1285e8bcac2c54ddd924ffb813b2b187467ac2a6.diff

[clang] b13b858 - [NewPM] Support optnone under new pass manager

2020-07-21 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-07-21T09:53:43-07:00 New Revision: b13b85818218aa17cee4c987cbf835208c06cf10 URL: https://github.com/llvm/llvm-project/commit/b13b85818218aa17cee4c987cbf835208c06cf10 DIFF: https://github.com/llvm/llvm-project/commit/b13b85818218aa17cee4c987cbf835208c06cf10.diff

[clang] 71d0a2b - [DFSan][NewPM] Port DataFlowSanitizer to NewPM

2020-07-29 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-07-29T10:19:15-07:00 New Revision: 71d0a2b8a31344ab29d1afd0c54d89873fb3cc9e URL: https://github.com/llvm/llvm-project/commit/71d0a2b8a31344ab29d1afd0c54d89873fb3cc9e DIFF: https://github.com/llvm/llvm-project/commit/71d0a2b8a31344ab29d1afd0c54d89873fb3cc9e.diff

[clang] c07339c - Move *San module passes later in the NPM pipeline

2020-06-08 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-06-08T12:08:49-07:00 New Revision: c07339c6754e1faf4078d3c592c0ae28455503cd URL: https://github.com/llvm/llvm-project/commit/c07339c6754e1faf4078d3c592c0ae28455503cd DIFF: https://github.com/llvm/llvm-project/commit/c07339c6754e1faf4078d3c592c0ae28455503cd.diff

[clang] a92ce3b - Revert "Reland D80966 [codeview] Put !heapallocsite on calls to operator new"

2020-06-08 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-06-08T12:49:41-07:00 New Revision: a92ce3b706d71a67913bca8445f7be9f3682f0c7 URL: https://github.com/llvm/llvm-project/commit/a92ce3b706d71a67913bca8445f7be9f3682f0c7 DIFF: https://github.com/llvm/llvm-project/commit/a92ce3b706d71a67913bca8445f7be9f3682f0c7.diff

[clang] ce7d3e1 - Reland (again) D80966 [codeview] Put !heapallocsite on calls to operator new

2020-06-09 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-06-09T09:27:32-07:00 New Revision: ce7d3e1c5531fce828722379cfbd58cb5d4dfab9 URL: https://github.com/llvm/llvm-project/commit/ce7d3e1c5531fce828722379cfbd58cb5d4dfab9 DIFF: https://github.com/llvm/llvm-project/commit/ce7d3e1c5531fce828722379cfbd58cb5d4dfab9.diff

[clang] bc38793 - Change debuginfo check for addHeapAllocSiteMetadata

2020-06-09 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-06-09T11:01:06-07:00 New Revision: bc38793852c0552337bae54961eb14fb0bacf356 URL: https://github.com/llvm/llvm-project/commit/bc38793852c0552337bae54961eb14fb0bacf356 DIFF: https://github.com/llvm/llvm-project/commit/bc38793852c0552337bae54961eb14fb0bacf356.diff

[clang] 8000d50 - [clangd] Strip /showIncludes in clangd compile commands

2020-04-26 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-04-26T18:57:39-07:00 New Revision: 8000d506afcdbb3aee7aa8f876688dd094c6eb85 URL: https://github.com/llvm/llvm-project/commit/8000d506afcdbb3aee7aa8f876688dd094c6eb85 DIFF: https://github.com/llvm/llvm-project/commit/8000d506afcdbb3aee7aa8f876688dd094c6eb85.diff

[clang] dab1326 - Strip -showIncludes in getClangStripDependencyFileAdjuster()

2020-04-27 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-04-27T11:20:08-07:00 New Revision: dab1326a5ae32ffd2dc277027e1ae68d8b5124d5 URL: https://github.com/llvm/llvm-project/commit/dab1326a5ae32ffd2dc277027e1ae68d8b5124d5 DIFF: https://github.com/llvm/llvm-project/commit/dab1326a5ae32ffd2dc277027e1ae68d8b5124d5.diff

[clang] c03d3ac - [test] Fix thinlto-distributed-newpm.ll

2020-07-30 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-07-30T20:09:34-07:00 New Revision: c03d3aca7d00db61eece554b7c4a9d921c1aff05 URL: https://github.com/llvm/llvm-project/commit/c03d3aca7d00db61eece554b7c4a9d921c1aff05 DIFF: https://github.com/llvm/llvm-project/commit/c03d3aca7d00db61eece554b7c4a9d921c1aff05.diff

[clang] 8dc4385 - [Driver] Accept -fno-lto in clang-cl

2020-08-05 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-08-05T12:24:10-07:00 New Revision: 8dc43852e4a8a5c6680d52aa6e73a75aef5a5954 URL: https://github.com/llvm/llvm-project/commit/8dc43852e4a8a5c6680d52aa6e73a75aef5a5954 DIFF: https://github.com/llvm/llvm-project/commit/8dc43852e4a8a5c6680d52aa6e73a75aef5a5954.diff

[clang] e6ea877 - [NewPM][optnone] Mark various passes as required

2020-08-14 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-08-14T15:51:59-07:00 New Revision: e6ea8779c2e0c60007d1015cc98fe3d2642a1652 URL: https://github.com/llvm/llvm-project/commit/e6ea8779c2e0c60007d1015cc98fe3d2642a1652 DIFF: https://github.com/llvm/llvm-project/commit/e6ea8779c2e0c60007d1015cc98fe3d2642a1652.diff

[clang] a397319 - [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone

2020-08-17 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-08-17T10:06:15-07:00 New Revision: a3973195095ed918915213341c132b41fb269f4e URL: https://github.com/llvm/llvm-project/commit/a3973195095ed918915213341c132b41fb269f4e DIFF: https://github.com/llvm/llvm-project/commit/a3973195095ed918915213341c132b41fb269f4e.diff

[clang] b0ceff9 - [test] Fix aggregate-assign-call.c in preparation for -enable-npm-optnone

2020-08-17 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-08-17T10:06:40-07:00 New Revision: b0ceff94d66372fd88dcf924e1c6751ce5ab5ee4 URL: https://github.com/llvm/llvm-project/commit/b0ceff94d66372fd88dcf924e1c6751ce5ab5ee4 DIFF: https://github.com/llvm/llvm-project/commit/b0ceff94d66372fd88dcf924e1c6751ce5ab5ee4.diff

[clang] 48451ee - [MSan] Pass MSan command line options under new pass manager

2020-05-07 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-05-07T08:21:35-07:00 New Revision: 48451ee6a7eed95856d6290f14626e871a073601 URL: https://github.com/llvm/llvm-project/commit/48451ee6a7eed95856d6290f14626e871a073601 DIFF: https://github.com/llvm/llvm-project/commit/48451ee6a7eed95856d6290f14626e871a073601.diff

[clang] 7d5bb94 - Run Coverage pass before other *San passes under new pass manager

2020-05-11 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-05-11T12:59:09-07:00 New Revision: 7d5bb94d78386e4653535c35d3e8258bf4502340 URL: https://github.com/llvm/llvm-project/commit/7d5bb94d78386e4653535c35d3e8258bf4502340 DIFF: https://github.com/llvm/llvm-project/commit/7d5bb94d78386e4653535c35d3e8258bf4502340.diff

[clang] 9599393 - Revert "[Pipelines] Introduce DAE after ArgumentPromotion"

2022-09-01 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-09-01T08:52:19-07:00 New Revision: 9599393eebf7b5ef46a144938f593e812dd01a18 URL: https://github.com/llvm/llvm-project/commit/9599393eebf7b5ef46a144938f593e812dd01a18 DIFF: https://github.com/llvm/llvm-project/commit/9599393eebf7b5ef46a144938f593e812dd01a18.diff

[clang] c911bef - [InstCombine] Treat passing undef to noundef params as UB

2022-09-01 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-09-01T15:16:45-07:00 New Revision: c911befaec494c52a63e3b957e28d449262656fb URL: https://github.com/llvm/llvm-project/commit/c911befaec494c52a63e3b957e28d449262656fb DIFF: https://github.com/llvm/llvm-project/commit/c911befaec494c52a63e3b957e28d449262656fb.diff

[clang] [Clang] Add codegen option to add passbuilder callback functions (PR #70171)

2023-11-06 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks commented: from an internal chat, this is meant to be used by modifying `PassBuilderCallbacks` from a statically linked clang plugin. that makes sense to me, could you update the description with this? as for a test, we can add a test similar to `PluginsOrder`. and

[clang] [Clang] Add codegen option to add passbuilder callback functions (PR #70171)

2023-11-06 Thread Arthur Eubanks via cfe-commits
@@ -906,6 +906,9 @@ void EmitAssemblyHelper::RunOptimizationPipeline( << PluginFN << toString(PassPlugin.takeError()); } } + for (auto PassCallback : CodeGenOpts.PassBuilderCallbacks) { aeubanks wrote: nit: no braces for single line loops htt

[clang] [Clang] Add codegen option to add passbuilder callback functions (PR #70171)

2023-11-06 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/70171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add codegen option to add passbuilder callback functions (PR #70171)

2023-11-06 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/70171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add codegen option to add passbuilder callback functions (PR #70171)

2023-11-06 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks approved this pull request. thanks for adding the test! https://github.com/llvm/llvm-project/pull/70171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add codegen option to add passbuilder callback functions (PR #70171)

2023-11-06 Thread Arthur Eubanks via cfe-commits
@@ -0,0 +1,23 @@ +# If we don't need RTTI or EH, there's no reason to export anything +# from the plugin. +if( NOT MSVC ) # MSVC mangles symbols differently, and +# PrintLLVMFunctionNames.export contains C++ symbols. + if( NOT LLVM_REQUIRES_RTTI ) +if( NOT LLVM_REQUIRES_E

[clang] Revert "Reland [clang] Canonicalize system headers in dependency file when -canonical-prefixes" (PR #71697)

2023-11-08 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/71697 This reverts commit 578a4716f549167165a2ec3bac89c86706136d4e. This causes multiple issues. Compile time slowdown due to more path canonicalization, and weird behavior on Windows. Fixes #70011. >From 7b9c256a

[clang] [clang] Do not pass -canonical-system-headers on Windows by default (PR #71097)

2023-11-08 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: closing in favor of 71697 https://github.com/llvm/llvm-project/pull/71097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Do not pass -canonical-system-headers on Windows by default (PR #71097)

2023-11-08 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/71097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Reland [clang] Canonicalize system headers in dependency file when -canonical-prefixes" (PR #71697)

2023-11-08 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/71697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Reland [clang] Canonicalize system headers in dependency file when -canonical-prefixes" (PR #71697)

2023-11-08 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/71697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-05 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: is it too late to change the gcc attribute name? https://github.com/llvm/llvm-project/pull/72078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add per-global code model attribute (PR #72078)

2023-12-05 Thread Arthur Eubanks via cfe-commits
@@ -57,6 +57,16 @@ global variable or function should be in after translation. let Heading = "section, __declspec(allocate)"; } +def CodeModelDocs : Documentation { + let Category = DocCatVariable; + let Content = [{ +The ``model`` attribute allows you to use a different c

[llvm] [clang] [llvm][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72234)

2023-11-15 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: we're seeing debug info verifier issues in Rust with this change, e.g. ``` invalid tag !50 = !DIDerivedType(tag: DW_TAG_imported_declaration, name: "DISCR_EXACT", scope: !37, file: !2, baseType: !51, flags: DIFlagStaticMember, extraData: i64 0) invalid tag !61 = !DIDerivedTy

[llvm] [clang] [llvm][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72234)

2023-11-15 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: ah I see, that definitely sounds plausible I've also recently done some NFC changes to better catch issues like this in https://github.com/llvm/llvm-project/pull/66295 https://github.com/llvm/llvm-project/pull/72234 ___ cfe-commits ma

[llvm] [clang] [llvm][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72234)

2023-11-15 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: actually I think the caller is in Rust, so perhaps we should just update Rust instead. but making some of these params more strongly typed would be good https://github.com/llvm/llvm-project/pull/72234 ___ cfe-commits mailing list cfe-c

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

2023-11-01 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: this breaks ``` $ cat /tmp/a2.ii template struct enable_if; template struct A { template struct C { C(B...); template = 0> C(A); }; template C(B...) -> C; }; int New; struct S : A { void f() { C{New}; } }; $ clang -fsyntax-only -std=c++20 /tmp/a2.ii

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

2023-11-01 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: and if not, could we revert while investigating? https://github.com/llvm/llvm-project/pull/69676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

2023-11-01 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: thanks! I appreciate the quick response https://github.com/llvm/llvm-project/pull/69676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Do not pass -canonical-system-headers on Windows by default (PR #71097)

2023-11-02 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/71097 Canonicalizing paths on Windows leads to unexpected things like changing drive letters. As a short term fix, do not canonicalize system headers on Windows by default. Fixes #70011 >From 3d519b42c350417727570ad

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/75542 In #74514 and #74778 we marked various instrumentation-added sections as large. This causes an extra PT_LOAD segment if using the small code model. Since people using the small code model presumably aren't hittin

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: Actually I'm going to go down the `Module::getCodeModel()` route. Right now I think frontends adding module metadata for the code model is probably not common, but we should aim for that. And this will in the short term still work for Fuchsia without breaking API for other fron

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/75542 >From 884347b73d68e2d469b3903f248e72921434 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Thu, 14 Dec 2023 15:41:31 -0800 Subject: [PATCH 1/2] [Instrumentation][X86] Limit setting large section flag to

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/75542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-14 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/75542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-15 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/75542 >From 884347b73d68e2d469b3903f248e72921434 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Thu, 14 Dec 2023 15:41:31 -0800 Subject: [PATCH 1/3] [Instrumentation][X86] Limit setting large section flag to

[clang] [llvm] [Instrumentation][X86] Limit setting large section flag to medium/large code models (PR #75542)

2023-12-15 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/75542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [lld] [lldb] [llvm] [clang] [flang] [mlir] [libcxx] [builtins] Refactor cpu_model support to reduce #if nesting. NFCI (PR #75635)

2023-12-19 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: still seeing Android errors ``` [275/404] Building C object CMakeFiles/clang_rt.builtins-aarch64.dir/cpu_model/aarch64.c.o FAILED: CMakeFiles/clang_rt.builtins-aarch64.dir/cpu_model/aarch64.c.o /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/./bin/clang --

[clang] [clang-tools-extra] [llvm] Report pass name when -llvm-verify-each reports breakage (PR #71447)

2023-12-01 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: thanks! https://github.com/llvm/llvm-project/pull/71447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] Report pass name when -llvm-verify-each reports breakage (PR #71447)

2023-12-01 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/71447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [flang] [clang] [InstCombine] Canonicalize constant GEPs to i8 source element type (PR #68882)

2023-12-20 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks approved this pull request. I think this is a good direction to go, lgtm https://github.com/llvm/llvm-project/pull/68882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-01-02 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: same in our stage 2 build ``` [4643/5157] Building CXX object tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o FAILED: tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o /Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm-bootstrap-install/bin/clang++ -DGTEST_H

[clang] d34901f - Revert "[clang][Darwin] Remove legacy framework search path logic in the frontend (#75841)"

2024-01-02 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2024-01-02T18:09:16Z New Revision: d34901f30b8b7ac8fe1437eeb588da6805b27cfb URL: https://github.com/llvm/llvm-project/commit/d34901f30b8b7ac8fe1437eeb588da6805b27cfb DIFF: https://github.com/llvm/llvm-project/commit/d34901f30b8b7ac8fe1437eeb588da6805b27cfb.diff LOG

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-01-02 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: I've reverted this, hopefully the command line in the failing invocation I gave is enough to repro the regression, otherwise lmk what else I can do to help repro https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

2024-01-05 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: This caused some ignorelist changes, e.g. `src:*third_party/vulkan_memory_allocator/include/vk_mem_alloc.h` didn't work anymore and the opt-out made it work again. Still investigating why. https://github.com/llvm/llvm-project/pull/74809 _

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2024-01-06 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: the file name is `vk_mem_alloc.h` so that shouldn't be the issue https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2024-01-06 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: ah it's because we something like ``` [cfi-unrelated-cast|cfi-derived-cast] src:*third_party/vulkan_memory_allocator/include/vk_mem_alloc.h ``` it seems like the new system doesn't match `[cfi-unrelated-cast|cfi-derived-cast]` https://github.com/llvm/llvm-project/pull/74809 _

[clang] [llvm] New calling convention preserve_none (PR #76868)

2024-01-08 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: the clang changes should be split into a followup patch https://github.com/llvm/llvm-project/pull/76868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-01-10 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: is the clang invocation in the logs I posted sufficient? https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9bd66b3 - [PassManager][Coroutine] Run passes under -O0 conditionally and run GlobalDCE

2022-03-23 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-03-23T11:03:26-07:00 New Revision: 9bd66b312c3e0e539ac6c85c1bacd17bdc731614 URL: https://github.com/llvm/llvm-project/commit/9bd66b312c3e0e539ac6c85c1bacd17bdc731614 DIFF: https://github.com/llvm/llvm-project/commit/9bd66b312c3e0e539ac6c85c1bacd17bdc731614.diff

[clang] 2eade1d - [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

2022-07-26 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-07-26T08:01:08-07:00 New Revision: 2eade1dba4a8d6e1c6867e9127bcd88cf4e55976 URL: https://github.com/llvm/llvm-project/commit/2eade1dba4a8d6e1c6867e9127bcd88cf4e55976 DIFF: https://github.com/llvm/llvm-project/commit/2eade1dba4a8d6e1c6867e9127bcd88cf4e55976.diff

[clang] 4fc7c55 - [NewPM] Actually recompute GlobalsAA before module optimization pipeline

2022-03-14 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-03-14T09:42:34-07:00 New Revision: 4fc7c551bb2b23fc022331b82b086d4b03b4 URL: https://github.com/llvm/llvm-project/commit/4fc7c551bb2b23fc022331b82b086d4b03b4 DIFF: https://github.com/llvm/llvm-project/commit/4fc7c551bb2b23fc022331b82b086d4b03b4.diff

[clang] 250620f - [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

2022-03-14 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-03-14T10:09:59-07:00 New Revision: 250620f76e070cbbd4e8511f751f577b6e1633ac URL: https://github.com/llvm/llvm-project/commit/250620f76e070cbbd4e8511f751f577b6e1633ac DIFF: https://github.com/llvm/llvm-project/commit/250620f76e070cbbd4e8511f751f577b6e1633ac.diff

[clang] 2371c5a - [OpaquePtr][ARM] Use elementtype on ldrex/ldaex/stlex/strex

2022-03-16 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-03-16T14:11:53-07:00 New Revision: 2371c5a0e06d22b48da0427cebaf53a5e5c54635 URL: https://github.com/llvm/llvm-project/commit/2371c5a0e06d22b48da0427cebaf53a5e5c54635 DIFF: https://github.com/llvm/llvm-project/commit/2371c5a0e06d22b48da0427cebaf53a5e5c54635.diff

[clang] b0270f6 - [clang] Remove Address::deprecated from MveEmitter

2022-03-21 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-03-21T09:39:13-07:00 New Revision: b0270f6e9583c2607e5b8bf0902010ae83a328c7 URL: https://github.com/llvm/llvm-project/commit/b0270f6e9583c2607e5b8bf0902010ae83a328c7 DIFF: https://github.com/llvm/llvm-project/commit/b0270f6e9583c2607e5b8bf0902010ae83a328c7.diff

[clang] 98574aa - [test] Remove references to -fno-legacy-pass-manager in tests

2022-04-11 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-04-11T13:40:27-07:00 New Revision: 98574aa1d24a310ddbabdc668cafee4d499b51e7 URL: https://github.com/llvm/llvm-project/commit/98574aa1d24a310ddbabdc668cafee4d499b51e7 DIFF: https://github.com/llvm/llvm-project/commit/98574aa1d24a310ddbabdc668cafee4d499b51e7.diff

[clang] 29363f8 - [test] Remove various legacy pass manager tests

2022-04-11 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-04-11T14:02:17-07:00 New Revision: 29363f80a80685fcab6b963ec128a923d05dc151 URL: https://github.com/llvm/llvm-project/commit/29363f80a80685fcab6b963ec128a923d05dc151 DIFF: https://github.com/llvm/llvm-project/commit/29363f80a80685fcab6b963ec128a923d05dc151.diff

[clang] 06285fc - [test][clang] Use -clear-ast-before-backend instead of -flegacy-pass-manager in CommandLineTest

2022-04-11 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-04-11T14:06:40-07:00 New Revision: 06285fc9fd522b5ab99f607b8123f4056d97e289 URL: https://github.com/llvm/llvm-project/commit/06285fc9fd522b5ab99f607b8123f4056d97e289 DIFF: https://github.com/llvm/llvm-project/commit/06285fc9fd522b5ab99f607b8123f4056d97e289.diff

[clang] 9faab43 - [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

2022-04-12 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-04-12T10:47:58-07:00 New Revision: 9faab435a35720fd7c6b3aeafe22c5dfb29f36e0 URL: https://github.com/llvm/llvm-project/commit/9faab435a35720fd7c6b3aeafe22c5dfb29f36e0 DIFF: https://github.com/llvm/llvm-project/commit/9faab435a35720fd7c6b3aeafe22c5dfb29f36e0.diff

[clang] cbcdd5f - [clang][test] Disable opaque pointers in test

2022-04-12 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-04-12T19:15:33-07:00 New Revision: cbcdd5ff8addd8677a0d15c08d449e759801e355 URL: https://github.com/llvm/llvm-project/commit/cbcdd5ff8addd8677a0d15c08d449e759801e355 DIFF: https://github.com/llvm/llvm-project/commit/cbcdd5ff8addd8677a0d15c08d449e759801e355.diff

[clang] f14ebe9 - [clang-format] Skip preprocessor lines when finding the record lbrace

2022-04-14 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-04-14T09:31:15-07:00 New Revision: f14ebe91c5dd6be5b64a45e479291cd08676be0c URL: https://github.com/llvm/llvm-project/commit/f14ebe91c5dd6be5b64a45e479291cd08676be0c DIFF: https://github.com/llvm/llvm-project/commit/f14ebe91c5dd6be5b64a45e479291cd08676be0c.diff

[clang] 19884d6 - [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

2022-04-20 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-04-20T08:42:30-07:00 New Revision: 19884d62c44cdcf236cdf4a55e8a50437070c4fc URL: https://github.com/llvm/llvm-project/commit/19884d62c44cdcf236cdf4a55e8a50437070c4fc DIFF: https://github.com/llvm/llvm-project/commit/19884d62c44cdcf236cdf4a55e8a50437070c4fc.diff

[clang] 2724c15 - [clang] Cache OpenCL types

2022-02-07 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-02-07T09:23:04-08:00 New Revision: 2724c153f92909523e225d9231ad90818795f7a2 URL: https://github.com/llvm/llvm-project/commit/2724c153f92909523e225d9231ad90818795f7a2 DIFF: https://github.com/llvm/llvm-project/commit/2724c153f92909523e225d9231ad90818795f7a2.diff

[clang] 45084ea - [clang] Fix some clang->llvm type cache invalidation issues

2022-02-07 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-02-07T18:59:09-08:00 New Revision: 45084eab5e63550bf2fdbf325d8fa5498263130d URL: https://github.com/llvm/llvm-project/commit/45084eab5e63550bf2fdbf325d8fa5498263130d DIFF: https://github.com/llvm/llvm-project/commit/45084eab5e63550bf2fdbf325d8fa5498263130d.diff

[clang] f05a63f - [clang] Properly cache member pointer LLVM types

2022-02-08 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-02-08T13:22:24-08:00 New Revision: f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149 URL: https://github.com/llvm/llvm-project/commit/f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149 DIFF: https://github.com/llvm/llvm-project/commit/f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149.diff

[clang] f16cc5d - [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

2022-02-08 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-02-08T13:22:43-08:00 New Revision: f16cc5df2288ef4637de29cd878627967b0fee3b URL: https://github.com/llvm/llvm-project/commit/f16cc5df2288ef4637de29cd878627967b0fee3b DIFF: https://github.com/llvm/llvm-project/commit/f16cc5df2288ef4637de29cd878627967b0fee3b.diff

[clang] e487ddc - [clang][OpaquePtr] Use proper Address constructor in AtomicInfo::getAtomicAddress()

2022-02-10 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-02-10T18:29:51-08:00 New Revision: e487ddc5c6d38522b7a2cf2c686539aa74432f1e URL: https://github.com/llvm/llvm-project/commit/e487ddc5c6d38522b7a2cf2c686539aa74432f1e DIFF: https://github.com/llvm/llvm-project/commit/e487ddc5c6d38522b7a2cf2c686539aa74432f1e.diff

[clang] 87dd3d3 - [clang][OpaquePtr] Remove call to getPointerElementType() in CodeGenModule::GetAddrOfGlobalTemporary()

2022-02-11 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-02-11T10:39:49-08:00 New Revision: 87dd3d350c4ce0115b2cdf91d85ddd05ae2661aa URL: https://github.com/llvm/llvm-project/commit/87dd3d350c4ce0115b2cdf91d85ddd05ae2661aa DIFF: https://github.com/llvm/llvm-project/commit/87dd3d350c4ce0115b2cdf91d85ddd05ae2661aa.diff

[clang] 7e77d31 - [test] Remove unnecessary -verify-machineinstrs=0

2022-07-20 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-07-20T10:55:54-07:00 New Revision: 7e77d31af75e48e2ac7899026040a66fe601961a URL: https://github.com/llvm/llvm-project/commit/7e77d31af75e48e2ac7899026040a66fe601961a DIFF: https://github.com/llvm/llvm-project/commit/7e77d31af75e48e2ac7899026040a66fe601961a.diff

[clang] 8016a0e - Explicitly add -target for Windows builds in file_test_windows.c

2022-05-11 Thread Arthur Eubanks via cfe-commits
Author: Alan Zhao Date: 2022-05-11T15:05:55-07:00 New Revision: 8016a0e5a56b8afc0f328412adae97369c71af78 URL: https://github.com/llvm/llvm-project/commit/8016a0e5a56b8afc0f328412adae97369c71af78 DIFF: https://github.com/llvm/llvm-project/commit/8016a0e5a56b8afc0f328412adae97369c71af78.diff LOG

[clang] [clang][SPIRV] Ignore -mcmodel (PR #86039)

2024-03-20 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/86039 The code model doesn't affect the sub-compilation, so don't check it. Followup to #70740. >From bba8e4003c4ccc36497e62ad1696197e6987525c Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Wed, 20 Mar 2024 23:

[clang] [clang][SPIRV] Don't warn on -mcmodel (PR #86039)

2024-03-21 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/86039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][SPIRV] Don't warn on -mcmodel (PR #86039)

2024-03-21 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/86039 >From bba8e4003c4ccc36497e62ad1696197e6987525c Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Wed, 20 Mar 2024 23:36:35 + Subject: [PATCH 1/2] [clang][SPIRV] Ignore -mcmodel The code model doesn't affe

[clang] [clang][SPIRV] Don't warn on -mcmodel (PR #86039)

2024-03-21 Thread Arthur Eubanks via cfe-commits
@@ -5804,7 +5804,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, } else if (Triple.getArch() == llvm::Triple::x86_64) { Ok = llvm::is_contained({"small", "kernel", "medium", "large", "tiny"}, CM); -} else if (Tripl

[clang] [clang][SPIRV] Don't warn on -mcmodel (PR #86039)

2024-03-21 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/86039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: why can't hwasan and PGO instrumentation coexist? and this seems like it should be an error at the clang driver level, instead of silently turning off one of the requested features https://github.com/llvm/llvm-project/pull/86739 ___ c

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: > > why can't hwasan and PGO instrumentation coexist? > > They can, but binary is like 5x times slower, on top of 10x slowdown of PGO > instrumentation. (don't quote me on these numbers, they are from large but > single benchmark, still it's very slow) > If it's usable as a co

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: > We already have similar stuff: > > ``` > if (PGOOpt && Phase != ThinOrFullLTOPhase::ThinLTOPostLink && > !PGOOpt->MemoryProfile.empty()) > MPM.addPass(MemProfUsePass(PGOOpt->MemoryProfile, PGOOpt->FS)); > ``` checking for ThinLTO pre/post link is a correctness thing

[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

2024-03-26 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: ah I see. I feel like this should be a more principled approach that other sanitizers also share, as you've mentioned as an alternative. do people not care about other sanitizers in production? (I'm going to be OOO for a week, so someone else will need to review) https://githu

[clang] [llvm] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2024-02-08 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: > Good example. This pass should be run post-inline. @aeubanks, any reason we > want to run it early in the pipeline? We want the main function simplification pipeline to see these function attributes because some optimizations trigger or don't trigger depending on the presenc

[clang] [llvm] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2024-02-09 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: > > > Good example. This pass should be run post-inline. @aeubanks, any reason > > > we want to run it early in the pipeline? > > > > > > We want the main function simplification pipeline to see these function > > attributes because some optimizations trigger or don't trigger

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-02-12 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: this seems to break `-fPIE` builds of clang on Linux with the following: ``` ld.lld: error: undefined symbol: alloca >>> referenced by cc1_main.cpp >>> >>> tools/clang/tools/driver/CMakeFiles/clang.dir/cc1_main.cpp.o:(ensureStackAddressSpace()) ``` the call to `al

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-02-12 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: I'll send out a PR to remove that code, and potentially also remove the `#undef alloca` separately https://github.com/llvm/llvm-project/pull/71709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-02-12 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: https://github.com/llvm/llvm-project/issues/4885 for why `#undef alloca` was added https://github.com/llvm/llvm-project/pull/71709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [clang] Remove old Linux kernel workaround for ensuring stack space (PR #81533)

2024-02-12 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/81533 PR #71709 broke the Linux PIE build with `undefined symbol: alloca` errors. With the newly included `clang/Basic/Builtins.h` in that PR, it surfaces an issue with a combination of two previous patches. 26670dc

[clang] [clang] Remove #undef alloca (PR #81534)

2024-02-12 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/81534 Added in 26670dcba1609574cba5942aff78ff97b567c5f3. >From c659a573a066809473ebb36421e612dcdcda5aef Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Mon, 12 Feb 2024 21:01:39 + Subject: [PATCH] [clang] Rem

[clang] [clang] Remove #undef alloca (PR #81534)

2024-02-12 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: seeing if Windows CI catches anything https://github.com/llvm/llvm-project/pull/81534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove old Linux kernel workaround for ensuring stack space (PR #81533)

2024-02-12 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/81533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove #undef alloca (PR #81534)

2024-02-12 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/81534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove #undef alloca workaround (PR #81534)

2024-02-12 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/81534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >