[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy, I

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 508167. aeubanks added a comment. add FIXME to phase ordering test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files: clang/test/CodeGen/thinlto-distributed-ne

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added a comment. got IR diffs for llvm-test-suite by dumping the IR in clang after running the optimization pipeline (-O3), IR file name is md5 of the module identifier @@@ -1093,6 -1093,6 +1096,16 @@@ void EmitAssemblyHelper::EmitAssembly(B std::unique_ptr ThinLinkOS, DwoO

[PATCH] D146987: [Assignment Tracking] Enable by default

aeubanks added a comment. I'm seeing llc: ../../llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6214: void llvm::SelectionDAGBuilder::visitIntrinsicCall(const CallInst &, unsigned int): Assertion `AssignmentTrackingEnabled && "expected assignment tracking to be enabled"' failed.

[PATCH] D146987: [Assignment Tracking] Enable by default

aeubanks added a comment. F27125556: a.tgz this is the original repro that crashed but maybe differently (you'll need to remove the plugin arguments since our clang has some custom plugins) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION