Artem-B wrote:
> > I see one suspicious failure in tensorflow tests. I suspect I've messed
> > something up in v4i8 comparison.
>
> Yup, there is a problem:
>
> ```
> Successfully custom legalized node
> ... replacing: t10: v4i8 = BUILD_VECTOR Constant:i16<-128>,
> Constant:i16<-128>, Consta
Artem-B wrote:
> > I see one suspicious failure in tensorflow tests. I suspect I've messed
> > something up in v4i8 comparison.
>
> Yup, there is a problem:
>
> ```
> Successfully custom legalized node
> ... replacing: t10: v4i8 = BUILD_VECTOR Constant:i16<-128>,
> Constant:i16<-128>, Consta
@@ -0,0 +1,1248 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --version 3
+; ## Support i16x2 instructions
+; RUN: llc < %s -mtriple=nvptx64-nvidia-cuda -mcpu=sm_90 -mattr=+ptx80 \
+; RUN: -O0 -disable-post-ra -frame-pointer=
@@ -0,0 +1,1248 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --version 3
+; ## Support i16x2 instructions
+; RUN: llc < %s -mtriple=nvptx64-nvidia-cuda -mcpu=sm_90 -mattr=+ptx80 \
+; RUN: -O0 -disable-post-ra -frame-pointer=
Artem-B wrote:
Found another issue. We merge four independent byte loads with `align 1` into a
32-bit load, which fails at runtime on misaligned pointers.
```
%t0 = type { [17 x i8] }
@shared_storage = linkonce_odr local_unnamed_addr addrspace(3) global %t0
undef, align 1
define <4 x i8> @i
Artem-B wrote:
Found another issue. We merge four independent byte loads with `align 1` into a
32-bit load, which fails at runtime on misaligned pointers.
```
%t0 = type { [17 x i8] }
@shared_storage = linkonce_odr local_unnamed_addr addrspace(3) global %t0
undef, align 1
define <4 x i8> @i
Artem-B wrote:
clang-format failure on GitHub is weird -- it just silently exits with an
error.
I ran the same command locally and fixed one place it was not happy about.
The buildkite failure somewhere in RISC-V appears to be unrelated.
https://github.com/llvm/llvm-project/pull/67866
___
Artem-B wrote:
clang-format failure on GitHub is weird -- it just silently exits with an
error.
I ran the same command locally and fixed one place it was not happy about.
The buildkite failure somewhere in RISC-V appears to be unrelated.
https://github.com/llvm/llvm-project/pull/67866
___
https://github.com/Artem-B closed
https://github.com/llvm/llvm-project/pull/67866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B closed
https://github.com/llvm/llvm-project/pull/67866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Artem-B wrote:
@rnk -- would that be acceptable for clang-cl on windows?
https://github.com/llvm/llvm-project/pull/68921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B approved this pull request.
https://github.com/llvm/llvm-project/pull/69081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B approved this pull request.
LGTM.
I'm still figuring out the github-based workflow. One thing that may be useful
in the future
would be to start the pull request branch with the original/reverted commit and
put the updates into separate commits, so one could see inc
https://github.com/Artem-B approved this pull request.
LGTM. Thank you!
https://github.com/llvm/llvm-project/pull/65990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B review_requested
https://github.com/llvm/llvm-project/pull/66138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B review_requested
https://github.com/llvm/llvm-project/pull/66138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B created
https://github.com/llvm/llvm-project/pull/66138:
https://github.com/llvm/llvm-project/issues/57544
>From 91c9d12e8f71cd55c877f80a0820615531cb62bd Mon Sep 17 00:00:00 2001
From: Artem Belevich
Date: Tue, 12 Sep 2023 11:47:17 -0700
Subject: [PATCH] Work around
https://github.com/Artem-B approved this pull request.
https://github.com/llvm/llvm-project/pull/66283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B edited
https://github.com/llvm/llvm-project/pull/66283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -43,6 +44,9 @@ __global__ void kernelfunc() {}
__global__ void kernel_decl();
+template
+__global__ void temp_kernel_decl(T x);
Artem-B wrote:
Nit: rename temp -> template? `temp` is strongly associated with 'temporary'.
https://github.com/llvm/llvm-proj
Author: boxu.zhang
Date: 2023-07-13T16:54:57-07:00
New Revision: f05b58a9468cc2990678e06bc51df56b30344807
URL:
https://github.com/llvm/llvm-project/commit/f05b58a9468cc2990678e06bc51df56b30344807
DIFF:
https://github.com/llvm/llvm-project/commit/f05b58a9468cc2990678e06bc51df56b30344807.diff
LO
Author: Artem Belevich
Date: 2023-09-05T16:02:42-07:00
New Revision: 2a702eca3efa066e3a470cd3b17082a05e118c91
URL:
https://github.com/llvm/llvm-project/commit/2a702eca3efa066e3a470cd3b17082a05e118c91
DIFF:
https://github.com/llvm/llvm-project/commit/2a702eca3efa066e3a470cd3b17082a05e118c91.diff
Author: Artem Belevich
Date: 2020-03-27T10:01:38-07:00
New Revision: fe8063e1a0e983f1b4d38530f4fb157a26c0771c
URL:
https://github.com/llvm/llvm-project/commit/fe8063e1a0e983f1b4d38530f4fb157a26c0771c
DIFF:
https://github.com/llvm/llvm-project/commit/fe8063e1a0e983f1b4d38530f4fb157a26c0771c.diff
Author: Artem Belevich
Date: 2019-11-07T17:16:51-08:00
New Revision: 7215b7ef530bff896a1da70c6b062e9259f5fde7
URL:
https://github.com/llvm/llvm-project/commit/7215b7ef530bff896a1da70c6b062e9259f5fde7
DIFF:
https://github.com/llvm/llvm-project/commit/7215b7ef530bff896a1da70c6b062e9259f5fde7.diff
Author: Artem Belevich
Date: 2020-03-11T13:42:16-07:00
New Revision: 0c06a389e5937895579effd5e608c79bc6332e53
URL:
https://github.com/llvm/llvm-project/commit/0c06a389e5937895579effd5e608c79bc6332e53
DIFF:
https://github.com/llvm/llvm-project/commit/0c06a389e5937895579effd5e608c79bc6332e53.diff
Author: Artem Belevich
Date: 2020-03-11T16:06:09-07:00
New Revision: 8527c1ed66c63db0590cd69320ba0bf8fad59b87
URL:
https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87
DIFF:
https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87.diff
Author: Artem Belevich
Date: 2020-03-12T10:04:10-07:00
New Revision: eb2ba2ea953b5ea73cdbb598f77470bde1c6a011
URL:
https://github.com/llvm/llvm-project/commit/eb2ba2ea953b5ea73cdbb598f77470bde1c6a011
DIFF:
https://github.com/llvm/llvm-project/commit/eb2ba2ea953b5ea73cdbb598f77470bde1c6a011.diff
Author: Artem Belevich
Date: 2020-01-23T13:17:52-08:00
New Revision: cc14de88da27a8178976972bdc8211c31f7ca9ae
URL:
https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae
DIFF:
https://github.com/llvm/llvm-project/commit/cc14de88da27a8178976972bdc8211c31f7ca9ae.diff
Author: Artem Belevich
Date: 2020-01-28T10:11:42-08:00
New Revision: 12fefeef203ab4ef52d19bcdbd4180608a4deae1
URL:
https://github.com/llvm/llvm-project/commit/12fefeef203ab4ef52d19bcdbd4180608a4deae1
DIFF:
https://github.com/llvm/llvm-project/commit/12fefeef203ab4ef52d19bcdbd4180608a4deae1.diff
Author: tra
Date: Tue Mar 20 10:18:59 2018
New Revision: 328006
URL: http://llvm.org/viewvc/llvm-project?rev=328006&view=rev
Log:
[NVPTX] Make tensor load/store intrinsics overloaded.
This way we can support address-space specific variants without explicitly
encoding the space in the name of the
*,
> ArrayRef, ArrayRef, const
> llvm::Twine &): Assertion `(i >= FTy->getNumParams()||
> FTy->getParamType(i) == Args[i]->getType()) && "Calling a function with
> a bad signature!"' failed.
>
> Cheers,
> Rafael
>
>
> Artem Be
Author: tra
Date: Wed Mar 21 14:55:02 2018
New Revision: 328158
URL: http://llvm.org/viewvc/llvm-project?rev=328158&view=rev
Log:
[NVPTX] Make tensor shape part of WMMA intrinsic's name.
This is needed for the upcoming implementation of the
new 8x32x16 and 32x8x16 variants of WMMA instructions
in
Author: tra
Date: Wed Mar 21 15:22:59 2018
New Revision: 328161
URL: http://llvm.org/viewvc/llvm-project?rev=328161&view=rev
Log:
[CUDA] Disable LTO for device-side compilations.
This fixes host-side LTO during CUDA compilation. Before, LTO
pipeline construction was clashing with CUDA pipeline co
On Thu, Mar 22, 2018 at 12:02 AM Yvan Roux wrote:
> This patch broke ARM/AArch64 bots, see:
>
> http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/841/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Athinlto.cu
>
>
Sorry about that. I'll fix it ASAP.
--
--Artem Belevich
___
Author: tra
Date: Thu Mar 22 09:47:41 2018
New Revision: 328213
URL: http://llvm.org/viewvc/llvm-project?rev=328213&view=rev
Log:
[CUDA] add REQUIRES fields for CUDA variants of LTO tests.
Also relax checking for nvptx triple. This should avoid test failure if
the test is executed on 32-bit platf
Author: tra
Date: Fri Mar 23 12:49:03 2018
New Revision: 328362
URL: http://llvm.org/viewvc/llvm-project?rev=328362&view=rev
Log:
[CUDA] Fixed false error reporting in case of calling H->G->HD->D.
Launching a kernel from the host code does not generate code for the
kernel itself. This fixes an is
Author: tra
Date: Tue Apr 3 11:29:31 2018
New Revision: 329099
URL: http://llvm.org/viewvc/llvm-project?rev=329099&view=rev
Log:
Revert "Set calling convention for CUDA kernel"
This reverts r328795 which introduced an issue with referencing __global__
function templates. More details in the orig
Author: tra
Date: Tue Apr 3 15:41:06 2018
New Revision: 329127
URL: http://llvm.org/viewvc/llvm-project?rev=329127&view=rev
Log:
[CUDA] Check initializers of instantiated template variables.
We were already performing checks on non-template variables,
but the checks on templated ones were missin
Author: tra
Date: Wed Apr 4 13:48:42 2018
New Revision: 329229
URL: http://llvm.org/viewvc/llvm-project?rev=329229&view=rev
Log:
Revert "[CUDA] Check initializers of instantiated template variables."
This (temporarily) reverts commit r329127 due to the problems
it exposed in TensorFlow.
Modifie
Author: tra
Date: Tue Apr 10 11:38:22 2018
New Revision: 329737
URL: http://llvm.org/viewvc/llvm-project?rev=329737&view=rev
Log:
[CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.
Currently we always include PTX into the fatbin along
with the GPU code.It about doubles the size of the GPU bin
Author: tra
Date: Wed Apr 11 10:51:19 2018
New Revision: 329829
URL: http://llvm.org/viewvc/llvm-project?rev=329829&view=rev
Log:
[NVPTX, CUDA] Improved feature constraints on NVPTX target builtins.
When NVPTX TARGET_BUILTIN specifies sm_XX or ptxYY as required feature,
consider those features av
Author: tra
Date: Wed Apr 11 10:51:33 2018
New Revision: 329830
URL: http://llvm.org/viewvc/llvm-project?rev=329830&view=rev
Log:
[NVPTX] Removed 'satom' feature which is no longer used.
Differential Revision: https://reviews.llvm.org/D45061
Modified:
cfe/trunk/lib/Basic/Targets/NVPTX.cpp
This change breaks CUDA as clang now reports an error during device-side
compilation when VLA is used in the *host-side* code.
http://lab.llvm.org:8011/builders/clang-cuda-build/builds/15591/steps/ninja%20build%20simple%20CUDA%20tests/logs/stdio
E.g. I would expect this code to compile successfull
Proposed fix: https://reviews.llvm.org/D40275
On Mon, Nov 20, 2017 at 4:13 PM, Artem Belevich wrote:
> This change breaks CUDA as clang now reports an error during device-side
> compilation when VLA is used in the *host-side* code.
> http://lab.llvm.org:8011/builders/clang-cuda-build/
> builds/1
Author: Artem Belevich
Date: 2023-03-21T15:36:12-07:00
New Revision: 2aa90da012596712a4166e96d2a40fc90598c7fb
URL:
https://github.com/llvm/llvm-project/commit/2aa90da012596712a4166e96d2a40fc90598c7fb
DIFF:
https://github.com/llvm/llvm-project/commit/2aa90da012596712a4166e96d2a40fc90598c7fb.diff
Author: Artem Belevich
Date: 2023-05-19T10:59:36-07:00
New Revision: 6963c61f0f6e4be2039cb45e824ea1e83a8f1526
URL:
https://github.com/llvm/llvm-project/commit/6963c61f0f6e4be2039cb45e824ea1e83a8f1526
DIFF:
https://github.com/llvm/llvm-project/commit/6963c61f0f6e4be2039cb45e824ea1e83a8f1526.diff
Author: Artem Belevich
Date: 2023-05-19T11:48:08-07:00
New Revision: 4450285bd74079bf87ba7b824a8dec8dcfb586ef
URL:
https://github.com/llvm/llvm-project/commit/4450285bd74079bf87ba7b824a8dec8dcfb586ef
DIFF:
https://github.com/llvm/llvm-project/commit/4450285bd74079bf87ba7b824a8dec8dcfb586ef.diff
Author: Artem Belevich
Date: 2023-05-24T11:48:39-07:00
New Revision: 29cb080c363d655ab1179a5564f1a82460e49a06
URL:
https://github.com/llvm/llvm-project/commit/29cb080c363d655ab1179a5564f1a82460e49a06
DIFF:
https://github.com/llvm/llvm-project/commit/29cb080c363d655ab1179a5564f1a82460e49a06.diff
Author: Artem Belevich
Date: 2023-05-25T11:57:55-07:00
New Revision: ffb635cb2d4e374e52b12066893458a8b70889fa
URL:
https://github.com/llvm/llvm-project/commit/ffb635cb2d4e374e52b12066893458a8b70889fa
DIFF:
https://github.com/llvm/llvm-project/commit/ffb635cb2d4e374e52b12066893458a8b70889fa.diff
Author: Artem Belevich
Date: 2023-05-25T11:57:54-07:00
New Revision: 0ad5d40fa19f27db0e5f999d0e17b0c18b811019
URL:
https://github.com/llvm/llvm-project/commit/0ad5d40fa19f27db0e5f999d0e17b0c18b811019
DIFF:
https://github.com/llvm/llvm-project/commit/0ad5d40fa19f27db0e5f999d0e17b0c18b811019.diff
Author: Artem Belevich
Date: 2023-05-25T11:57:56-07:00
New Revision: 0a0bae1e9f94ec86ac17b0b4eb817741689f3739
URL:
https://github.com/llvm/llvm-project/commit/0a0bae1e9f94ec86ac17b0b4eb817741689f3739
DIFF:
https://github.com/llvm/llvm-project/commit/0a0bae1e9f94ec86ac17b0b4eb817741689f3739.diff
Author: Artem Belevich
Date: 2023-05-25T11:57:57-07:00
New Revision: 25708b3df6e359123d5bce137652af812e168cfc
URL:
https://github.com/llvm/llvm-project/commit/25708b3df6e359123d5bce137652af812e168cfc
DIFF:
https://github.com/llvm/llvm-project/commit/25708b3df6e359123d5bce137652af812e168cfc.diff
Author: Artem Belevich
Date: 2023-05-25T11:57:58-07:00
New Revision: 5c082e7e15e38a2eea1f506725efe636a5b1bf8a
URL:
https://github.com/llvm/llvm-project/commit/5c082e7e15e38a2eea1f506725efe636a5b1bf8a
DIFF:
https://github.com/llvm/llvm-project/commit/5c082e7e15e38a2eea1f506725efe636a5b1bf8a.diff
Author: Artem Belevich
Date: 2023-05-25T12:41:25-07:00
New Revision: df1b2bef0c7cad11681a02e9e2f816b27fb480a6
URL:
https://github.com/llvm/llvm-project/commit/df1b2bef0c7cad11681a02e9e2f816b27fb480a6
DIFF:
https://github.com/llvm/llvm-project/commit/df1b2bef0c7cad11681a02e9e2f816b27fb480a6.diff
Author: Artem Belevich
Date: 2023-05-30T10:44:33-07:00
New Revision: 6cdc07a701eec08da450be58d6e1b67428a983dd
URL:
https://github.com/llvm/llvm-project/commit/6cdc07a701eec08da450be58d6e1b67428a983dd
DIFF:
https://github.com/llvm/llvm-project/commit/6cdc07a701eec08da450be58d6e1b67428a983dd.diff
Author: Artem Belevich
Date: 2023-06-02T14:16:13-07:00
New Revision: 0f49116e261cf5a156221b006acb677e3565fd1a
URL:
https://github.com/llvm/llvm-project/commit/0f49116e261cf5a156221b006acb677e3565fd1a
DIFF:
https://github.com/llvm/llvm-project/commit/0f49116e261cf5a156221b006acb677e3565fd1a.diff
Author: Artem Belevich
Date: 2023-05-17T12:51:01-07:00
New Revision: a825f3754b3ca1591068cf99bc224af30a311e63
URL:
https://github.com/llvm/llvm-project/commit/a825f3754b3ca1591068cf99bc224af30a311e63
DIFF:
https://github.com/llvm/llvm-project/commit/a825f3754b3ca1591068cf99bc224af30a311e63.diff
Author: Artem Belevich
Date: 2023-05-18T11:05:44-07:00
New Revision: e7b9c2f00fa04ef8d9b69ee0e36d7775823dbe6b
URL:
https://github.com/llvm/llvm-project/commit/e7b9c2f00fa04ef8d9b69ee0e36d7775823dbe6b
DIFF:
https://github.com/llvm/llvm-project/commit/e7b9c2f00fa04ef8d9b69ee0e36d7775823dbe6b.diff
Author: Artem Belevich
Date: 2023-05-18T11:45:06-07:00
New Revision: 0e43eb24bd791e8b857e7347ac3646a4454d97e3
URL:
https://github.com/llvm/llvm-project/commit/0e43eb24bd791e8b857e7347ac3646a4454d97e3
DIFF:
https://github.com/llvm/llvm-project/commit/0e43eb24bd791e8b857e7347ac3646a4454d97e3.diff
Author: Artem Belevich
Date: 2023-05-01T16:27:13-07:00
New Revision: a50e54fbeb48fb8a218a2914d827e1087bae2f8d
URL:
https://github.com/llvm/llvm-project/commit/a50e54fbeb48fb8a218a2914d827e1087bae2f8d
DIFF:
https://github.com/llvm/llvm-project/commit/a50e54fbeb48fb8a218a2914d827e1087bae2f8d.diff
Author: tra
Date: Wed Jan 4 12:39:29 2017
New Revision: 290982
URL: http://llvm.org/viewvc/llvm-project?rev=290982&view=rev
Log:
[CUDA] Pre-include sm_60 and sm_61 headers.
CUDA-8.0 comes with new headers which nvcc pre-includes via cuda_runtime.h
Clang now makes them available as well.
Differe
tra created this revision.
tra added reviewers: jlebar, sfantao.
tra added a subscriber: cfe-commits.
If they are, we end up with the last intermediary output preserved
in the current directory after compilation.
Added a test case to verify that we're using appropriate filenames
for outputs of di
tra updated this revision to Diff 68100.
tra added a comment.
Addressed comments.
https://reviews.llvm.org/D23526
Files:
lib/Driver/Driver.cpp
test/Driver/cuda-bindings.cu
Index: test/Driver/cuda-bindings.cu
===
--- /dev/null
tra marked 2 inline comments as done.
tra added a comment.
https://reviews.llvm.org/D23526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added inline comments.
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:125-133
@@ -122,8 +124,11 @@
__DEVICE__ float modf(float __x, float *__iptr) { return ::modff(__x, __iptr);
}
-__DEVICE__ float nexttoward(float __from, float __to) {
+__DEVICE__ float nexttoward(float
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM, but we may want someone familiar with math library to take a look.
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:125-133
@@ -122,8 +124,11 @@
__DEVICE__ float modf(float
Author: tra
Date: Mon Aug 22 13:50:34 2016
New Revision: 279455
URL: http://llvm.org/viewvc/llvm-project?rev=279455&view=rev
Log:
[CUDA] Collapsed offload actions should not be top-level jobs.
If they are, we end up with the last intermediary output preserved
in the current directory after compil
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279455: [CUDA] Collapsed offload actions should not be
top-level jobs. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D23526?vs=68100&id=68896#toc
Repository:
rL LLVM
https://r
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
Herald added a subscriber: jlebar.
CUDA target attributes are used for function overloading and must not be merged.
This fixes a bug where attributes were inherited during function template
specializati
Manman,
FYI, It appears that some of your ObjC commits today trigger asan error.
Sanitizer bots are broken by PR30341, so they don't report the issue yet.
--Artem
$ llvm/tools/clang/clang -cc1 -internal-isystem
llvm/tools/clang/staging/include -nostdsysteminc -fblocks -fsyntax-only
-Wnullable-to
tra updated this revision to Diff 71244.
tra marked an inline comment as done.
tra added a comment.
Removed REQUIRED lines.
https://reviews.llvm.org/D24522
Files:
lib/Sema/SemaDecl.cpp
test/SemaCUDA/function-overload.cu
test/SemaCUDA/target_attr_inheritance.cu
Index: test/SemaCUDA/target
Author: tra
Date: Tue Sep 13 17:16:30 2016
New Revision: 281406
URL: http://llvm.org/viewvc/llvm-project?rev=281406&view=rev
Log:
[CUDA] Do not merge CUDA target attributes.
CUDA target attributes are used for function overloading and must not be merged.
This fixes a bug where attributes were in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281406: [CUDA] Do not merge CUDA target attributes.
(authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D24522?vs=71244&id=71249#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24
Thanks for the quick fix. ASAN is happy now.
--Artem
On Tue, Sep 13, 2016 at 3:09 PM, Manman wrote:
> I checked in r281404. Hopefully it will fix the issue.
>
> Let me know if it does not.
>
> Thanks,
> Manman
>
> On Sep 13, 2016, at 3:03 PM, Artem Belevich via cfe
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: External/CUDA/README:58
@@ +57,3 @@
+ There's a cuda-tests-simple target that excludes tests that take a long time
+ to build (thrust).
+
It may
Author: tra
Date: Wed Sep 14 18:03:06 2016
New Revision: 281557
URL: http://llvm.org/viewvc/llvm-project?rev=281557&view=rev
Log:
Revert r281457 "Supports adding insertion around non-insertion replacements."
Commit was breaking our internal tests.
Modified:
cfe/trunk/include/clang/Tooling/Co
Author: tra
Date: Thu Jul 20 14:16:03 2017
New Revision: 308675
URL: http://llvm.org/viewvc/llvm-project?rev=308675&view=rev
Log:
[NVPTX] Add lowering of i128 params.
The patch adds support of i128 params lowering. The changes are quite trivial to
support i128 as a "special case" of integer type.
Author: tra
Date: Wed Jan 17 11:29:39 2018
New Revision: 322742
URL: http://llvm.org/viewvc/llvm-project?rev=322742&view=rev
Log:
[DeclPrinter] Fix two cases that crash clang -ast-print.
Both are related to handling anonymous structures.
* clang didn't handle () around an anonymous struct variabl
Author: tra
Date: Tue Jan 23 11:08:18 2018
New Revision: 323239
URL: http://llvm.org/viewvc/llvm-project?rev=323239&view=rev
Log:
[CUDA] CUDA has no device-side library builtins.
We should (almost) never consider a device-side declaration to match a
library builtin functio. Otherwise clang may i
Author: tra
Date: Wed Jan 24 09:41:02 2018
New Revision: 323345
URL: http://llvm.org/viewvc/llvm-project?rev=323345&view=rev
Log:
[CUDA] Disable PGO and coverage instrumentation in NVPTX.
NVPTX does not have runtime support necessary for profiling to work
and even call arc collection is prohibiti
Author: tra
Date: Mon Jan 29 16:00:12 2018
New Revision: 323713
URL: http://llvm.org/viewvc/llvm-project?rev=323713&view=rev
Log:
[CUDA] Added partial support for CUDA-9.1
Clang can use CUDA-9.1 now, though new APIs (are not implemented yet.
The major change is that headers in CUDA-9.1 went thro
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM, with couple of minor nits.
Comment at: clang/lib/Driver/Driver.cpp:3650-3654
+
+ // Intentionally omitted from the switch above: llvm::Triple::CUDA. CUDA
+ // compiles alw
Author: tra
Date: Thu Dec 1 13:34:35 2016
New Revision: 288406
URL: http://llvm.org/viewvc/llvm-project?rev=288406&view=rev
Log:
Send compiler output to /dev/null in defsym.s test.
Fixes test failures if tests are run in a read-only source tree.
Modified:
cfe/trunk/test/Driver/defsym.s
Mod
Author: tra
Date: Wed Dec 7 13:27:16 2016
New Revision: 288962
URL: http://llvm.org/viewvc/llvm-project?rev=288962&view=rev
Log:
[CUDA] Improve target attribute checking for function templates.
* __host__ __device__ functions are no longer considered to be
redeclarations of __host__ or __devic
Author: tra
Date: Thu Dec 8 13:38:13 2016
New Revision: 289091
URL: http://llvm.org/viewvc/llvm-project?rev=289091&view=rev
Log:
[CUDA] Ignore implicit target attributes during function template instantiation.
Some functions and templates are treated as __host__ __device__ even
when they don't h
Author: tra
Date: Fri Dec 9 16:59:17 2016
New Revision: 289287
URL: http://llvm.org/viewvc/llvm-project?rev=289287&view=rev
Log:
[CUDA,Driver] Added --no-cuda-gpu-arch= option.
This allows us to negate preceding --cuda-gpu-arch=X.
This comes handy when user needs to override default
flags set fo
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
Implicit functions are treated as if they were __host__ __device__ and clang
does not allow overloading
those with __host__ or __device__ variants.
In order for users to provide their own standard allo
tra created this revision.
tra added reviewers: jlebar, rsmith.
tra added a subscriber: cfe-commits.
Current behavior:
- __host__ __device__ (HD) functions are considered to be redeclarations of
`__host__` (H) of `__device__` (D) functions with same signature.
- Target attributes are not taken i
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
https://reviews.llvm.org/D25839
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaDecl.cpp
Index: lib/Sema/SemaDecl.cpp
=
tra created this revision.
tra added reviewers: jlebar, rsmith.
tra added a subscriber: cfe-commits.
Some functions and templates are treated as `__host__` `__device__` even when
they don't have explicitly specified target attributes.
What's worse, this treatment may change depending on command l
Author: tra
Date: Fri Oct 21 12:15:46 2016
New Revision: 284843
URL: http://llvm.org/viewvc/llvm-project?rev=284843&view=rev
Log:
Removed unused function argument. NFC.
Differential Revision: https://reviews.llvm.org/D25839
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Sema
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284843: Removed unused function argument. NFC. (authored by
tra).
Changed prior to commit:
https://reviews.llvm.org/D25839?vs=75339&id=75447#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25839
tra updated this revision to Diff 75462.
tra added a comment.
Addressed jlebar's comments.
https://reviews.llvm.org/D25796
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCUDA/overloaded-delete.cu
Index: test/SemaCUDA/overloaded-delete.cu
==
Author: tra
Date: Fri Oct 21 15:34:05 2016
New Revision: 284879
URL: http://llvm.org/viewvc/llvm-project?rev=284879&view=rev
Log:
Declare H and H new/delete.
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
cfe/trunk/test/SemaCUDA/overloaded-delete.cu
Modified: cfe/trunk/lib/Sema/SemaExprCXX
tra updated this revision to Diff 75482.
tra added a comment.
Added a comment explaining expected constexpr function template matching
behavior.
https://reviews.llvm.org/D25845
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaTemplate.cpp
301 - 400 of 1265 matches
Mail list logo
