[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

2021-01-18 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:17 // If the extensions are to be enumerated without the supported OpenCL version, -// define OPENCLEXT(ext) where ext is the name of the extension. +// define OPENCLEXTNAME(ext) where ex

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

2021-01-18 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:360 +// Set core features based on OpenCL version +for (auto CoreExt : clang::getCoreFeatures(Opts)) + getTargetOpts().OpenCLFeaturesMap[CoreExt] = true; Anastasia wrote: > a

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

2021-01-18 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:360 +// Set core features based on OpenCL version +for (auto CoreExt : clang::getCoreFeatures(Opts)) + getTargetOpts().OpenCLFeaturesMap[CoreExt] = true; azabaznov wrote: > A

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

2021-01-20 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:360 +// Set core features based on OpenCL version +for (auto CoreExt : clang::getCoreFeatures(Opts)) + getTargetOpts().OpenCLFeaturesMap[CoreExt] = true; Anastasia wrote: > a

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

2021-01-21 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov updated this revision to Diff 318165. azabaznov marked 7 inline comments as done. azabaznov added a comment. Thanks for feedback. I agree that providing diagnostics for unsupported core features is enough for now (I guess I'll try to come up with something for OpenCL C 3.0 features to

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

2021-10-21 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov created this revision. azabaznov added reviewers: Anastasia, yaxunl, svenvh. Herald added a subscriber: ldrumm. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires support of __opencl_c_generic_address_

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

2021-10-21 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added a comment. @Anastasia, @yaxunl, do you think it's possible to refactor code generation for blocks such that block literal for global blocks (with no captures) would be emitted in constant address space? Now it's emitted in global address space (for example @__block_literal_globa

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

2021-09-07 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109320/new/ https://reviews.llvm.org/D109320 ___ cfe-commits mailing lis

<    1   2   3