[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 358909. azabaznov added a comment. Restructured test a little Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103191/new/ https://reviews.llvm.org/D103191 Files: clang/include/clang/Basic/OpenCLOptions.h c

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05eb59e1d0ea: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro (authored by azabaznov). Repository: rG LLVM Github

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, kerbowa, yaxunl, nhaehnle, jvesely. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires support of

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

azabaznov added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1732-1734 +// __opencl_c_3d_image_writes feature. OpenCL C v3.0 API s4.2 - For devices +// that support OpenCL 3.0, cl_khr_3d_image_writes must be returned when and +// only when the optional fe

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

azabaznov updated this revision to Diff 359734. azabaznov added a comment. Change diagnostic output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106260/new/ https://reviews.llvm.org/D106260 Files: clang/include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

azabaznov added a comment. You also need to guard //memory_order_seq_cst// enum entry. Note that //memory_order_acq_rel// is always defined as it can be used in //atomic_work_item_fence()// built-in function, AFAIR in all other cases if //memory_order_acq_rel// is used without //__opencl_c_atom

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

azabaznov added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7 -#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_2_0 #define LANG_VER_OK ---

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

azabaznov updated this revision to Diff 361155. azabaznov added a comment. Unify with `err_opencl_requires_extension`. Infrastructure for getting aliased extensions seems to messy and doesn't seem worth it yet since there are only two cases of such functionality (fp64 and 3d image writes) :( R

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 'pipe' keyword is introduced in OpenCL C 2.0: so do checks fo

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154 "'%2' %select{type qualifier|storage class specifier}3">; +def err_opencl_type_specifier_requires : Error< + "%select{type qualifier|storage class specifier}0 '%1' requires " -

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov updated this revision to Diff 362018. azabaznov added a comment. Herald added a subscriber: dexonsmith. Preserve existing diagnostic with `err_opencl_unknown_type_specifier`, fix comments for language option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

azabaznov added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13304 +#else +void __ovld atomic_init(volatile __global atomic_int *object, int value); +void __ovld atomic_init(volatile __local atomic_int *object, int value); These new atomics with glob

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16a4fcbe510: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov updated this revision to Diff 362955. azabaznov added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106748/new/ https://reviews.llvm.org/D106748 Files: clang/include/clang/Basic/LangOptions.def clang/lib/Basic/OpenC

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e4b2575673: [OpenCL] Add support of __opencl_c_pipes feature macro. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

azabaznov added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13303 #endif +#elif __OPENCL_C_VERSION__ >= CL_VERSION_3_0 +void __ovld atomic_init(volatile __global atomic_int *object, int value); Sorry, I overlooked that. Not //elif//, just //if// as

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov added a comment. Reverted it due too suspicious failing: error: 'error' diagnostics expected but not seen: File /home/tcwg-buildslave/worker/clang-armv7-2stage/llvm/clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl Line 8: type '__global write_only pipe int ({{(void)?}})' can only b

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 405921. azabaznov added a comment. Reimplement with checking language options only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: clang/include/clang/Bas

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: Naghasan, ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OpenCL C 3.0 __opencl_c_subgroups feature is slight

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov added a comment. It seems hard to find a direct mention in the spec, but in the API spec: //CL_DEVICE_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS: Is CL_TRUE if this device supports independent forward progress of sub-groups, CL_FALSE otherwise. This query must return CL_TRUE for devices t

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 406434. azabaznov added a comment. Check only against specific language option, remove unused LanguageIDs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: c

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov marked 4 inline comments as done. azabaznov added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:79 + bool OclBlocksUnsupported = + (LangOpts.getOpenCLCompatibleVersion() < 200 || !LangOpts.Blocks) && + (BuiltinInfo.Langs & OCL_BLOCKS); ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added a comment. @Anastasia @svenvh ping. Just a kind reminder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 ___ cfe-commits mailing list cfe-commi

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 407823. azabaznov added a comment. Rename language mode for device side enqueue builtins; add the comment that device side enqueue builtins are not supported until OpenCL 2.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added a comment. > There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so we > need this check to preserve the existing behavior indeed. Thanks. The other test is `SemaOpenCL/clang-builtin-version.cl`. > But it might be worth asking someone outside of the OpenCL co

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

This revision was automatically updated to reflect the committed changes. Closed by commit rGbee4bd70f769: [OpenCL] Add support of language builtins for OpenCL C 3.0 (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov updated this revision to Diff 407856. azabaznov added a comment. Use existing diagnostics; add the comment that device can support extension but not the feature. Will follow up if we need explicit mention in the language spec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb1a33bec7c: [OpenCL] Adjust diagnostic for subgroup support. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118999/new/ https://re

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status on release 14

azabaznov added inline comments. Comment at: clang/docs/OpenCLSupport.rst:395 ++--+-+-+--+--

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status

azabaznov accepted this revision. azabaznov added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119719/new/ https://reviews.llvm.org/D119719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:22 -/// OpenCL supported extensions and optional core features -class OpenCLOptions { - struct Info { -bool Supported; // Is this option supported -bool Enabled; // Is this option

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added a comment. > I guess targets like SPIR will be supporting all features by default? It sounds confusing for me: can you please elaborate about why does SPIR-V target should support all features/extension by default? If we are compiling OpenCL C 3.0 with optional functionality we

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov updated this revision to Diff 304493. azabaznov added a comment. Addressed all concerns except replacing //__opencl_c_int64 //definition into header. The reason for this as follows: this macro should be predefined regardless if clang includes default header or not. CHANGES SINCE LAST

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added a comment. > What did you think in mind regarding activation of features for SPIR? I don't see any difference between extensions and features in that case (at least for now), so in the latest patch x86 and spir targets will define all the features. CHANGES SINCE LAST ACTION

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:100 +// OpenCL features +OPENCLFEAT_INTERNAL(__opencl_c_pipes, 200, ~0U) +OPENCLFEAT_INTERNAL(__opencl_c_generic_address_space, 200, ~0U) Anastasia wrote: > Btw I guess we

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:51 + // check specific version of feature) + void supportFeatureForPreOCL30(StringRef Feat, bool On = true) { +assert(CLVer < 300 && "Can'be called for OpenCL C higher 3.0");

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

azabaznov added a comment. Yes, in general this approach looks good to me conceptually. I have two suggestions: 1. As we discussed, the term //core functionality// should be revisited here. There's no clear meaning about that in the spec and I think interpreting it as //supported by default//

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

azabaznov added a comment. In D88300#2302796 , @svenvh wrote: > LGTM! I'd suggest waiting a bit before committing this though, to give > people time to catch up on the RFC. Thanks! Sure, I'm agree with that, let's wait. CHANGES SINCE LAST ACTION htt

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

azabaznov added a comment. Anastasia, Sven, thanks for the review! Anastasia, it seems that I don't have write access yet. Would you mind landing this change on behalf of me? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88300/new/ https://reviews.llvm.org/D88300 _

[PATCH] D89143: [OpenCL][Docs] Improved description of the supported language functionality.

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Looks good to me, thanks for the note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89143/new/ https://reviews.llvm.org/D89143 ___

[PATCH] D89372: [OpenCL] Remove unused extensions

azabaznov requested changes to this revision. azabaznov added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:74 OPENCLEXT_INTERNAL(cl_khr_mipmap_image_writes, 200, ~0U) -OPENCLEXT_INTERNAL(cl_khr_srgb_im

[PATCH] D89372: [OpenCL] Remove unused extensions

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:74 OPENCLEXT_INTERNAL(cl_khr_mipmap_image_writes, 200, ~0U) -OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U) OPENCLEXT_INTERNAL(cl_khr_subgroups, 200, ~0U) mantog

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

azabaznov added a comment. > Perhaps if you give me an example it would help to understand I was meant that this can potentially be used to undefine macros inside clang directly. In this case there will no need to add a lot of conditional preprocessor directives in the header, also the existing

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

azabaznov added a comment. > So if I understand it well you are suggesting to perform a check for every > parsed macro definition that would identify whether the macro has a name > matching what is provided in -cl-ext=? Then if the name matches it would > check whether the macro should be defin

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

azabaznov added a comment. Hi! Great to see the interest in OpenCL C 3.0! I'm being working already at a proper feature macros definition to unify both clang and header OpenCL C 3.0 related changes, here is the change:  https://reviews.llvm.org/D89869. So as this patch will be merged then the ch

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov updated this revision to Diff 307436. azabaznov marked 24 inline comments as done. azabaznov added a comment. Addressed almost all technical and cosmetic concerns concerns. Except putting reference of `OpenCLOptions` in `Sema` due to const of `TargetInfo`. I think I'll think about that

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added a comment. > I didn't want to end up with a big refactoring from this patch but now I > start to think that considering the situation it might be unavoidable. :( Well, it was expected. However, I didn't want to mess this refactoring with OpenCL C 3.0 support at first. I already

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: dexonsmith, jfb. azabaznov requested review of this revision. This change relates to OpenCL C 3.0 support. RFC thread: https://lists.llvm.org/pipermail/cfe-dev/2020-September/066883.html The

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov added inline comments. Comment at: clang/lib/Sema/Sema.cpp:306 +// Set conditionally to provide correct diagnostics for 'double' type +llvm::StringRef FP64Feature( +getLangOpts().OpenCLVersion >= 300 ? "__opencl_c_fp64" : "cl_khr_fp64"); ---

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 345846. azabaznov edited the summary of this revision. azabaznov added a comment. Rebase after https://reviews.llvm.org/D100976; addressed review comments and updated docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 346379. azabaznov added a comment. Drop formatting changes from Sema.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96524/new/ https://reviews.llvm.org/D96524 Files: clang/docs/OpenCLSupport.rst clang

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 346380. azabaznov added a comment. Drop one more formatting change from Sema.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96524/new/ https://reviews.llvm.org/D96524 Files: clang/docs/OpenCLSupport.rst

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/test/CodeGenOpenCL/printf.cl:9 -#ifdef cl_khr_fp64 +#if defined(cl_khr_fp64) || defined(__opencl_c_fp64) typedef __attribute__((ext_vector_type(2))) double double2;

[PATCH] D102853: [OpenCL] Align definition of __IMAGE_SUPPORT__ feature macro with OpenCL version and __opencl_c_images feature macro definition

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG826905787ae4: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64 (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, kerbowa, yaxunl, nhaehnle, jvesely. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mono

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/storageclass.cl:22 +extern generic float g_generic_extern_var; +#ifndef __opencl_c_program_scope_global_variables +// expected-error@-17 {{program scope variable must reside in constant address space}} --

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:405 + const auto &OpenCLFeaturesMap = getSupportedOpenCLOpts(); + Opts.OpenCLGenericAddressSpace = hasFeatureEnabled( + OpenCLFeaturesMap, "__opencl_c_generic_address_space"); -

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:405 + const auto &OpenCLFeaturesMap = getSupportedOpenCLOpts(); + Opts.OpenCLGenericAddressSpace = hasFeatureEnabled( + OpenCLFeaturesMap, "__opencl_c_generic_address_space"); -

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov updated this revision to Diff 318458. azabaznov added a comment. Herald added a project: clang. Removed getCoreFeatures() as it's not used in this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92277/new/ https://reviews.llvm.org/D

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/test/Misc/nvptx.languageOptsOpenCL.cl:18 // RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple nvptx64-unknown-unknown -Wpedantic-core-features -DTEST_CORE_FEATURES +// XFAIL: *

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe123cd674c02: [OpenCL] Refactor of targets OpenCL option settings (authored by azabaznov). Repository: rG LLVM Github M

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov created this revision. azabaznov added reviewers: Anastasia, mantognini. Herald added subscribers: jfb, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds possibility to define OpenCL C 3.0 feature m

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov abandoned this revision. azabaznov added a comment. Due to refactoring in https://reviews.llvm.org/D92277 this flow is no longer valid. New patch for this functionality is here: https://reviews.llvm.org/D95776. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89869/new/ https:

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added a comment. I suggest that renaming 'extension' to 'option' (extensions + features) concept to be done in separate commit. There are a lot of places to change all over the place in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: dexonsmith, yaxunl. Herald added a reviewer: jansvoboda11. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OpenCL keywords 'p

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 320708. azabaznov added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Basic/T

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov updated this revision to Diff 320709. azabaznov added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 Files: clang/include/clang/Basic/LangOptions.def clang/lib/Frontend/Com

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 320710. azabaznov added a comment. Rebased one more time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files: clang/include/clang/Basic/OpenCLExtensions.def cla

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added inline comments. Comment at: clang/lib/Basic/Targets.cpp:743 + // Assume compiling for FULL profile + Builder.defineMacro("__opencl_c_int64"); } Anastasia wrote: > Btw we could add the other feature macros for earlier versions too but I > gues

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov added a comment. In D95778#2536266 , @Anastasia wrote: >> LGTM, but perhaps you can add a test that has each keyword disabled? > > FYI we currently already test that `pipe` and `generic` are valid for OpenCL > 2.0 and invalid for OpenCL < 2.0. O

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:218 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +LANGOPT(OpenCLGenericKeyword, 1, 0, "OpenCL generic keyword") +LANGOPT(OpenCLPipeKeyword , 1, 0, "OpenCL pipe keywo

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov updated this revision to Diff 321348. azabaznov added a comment. Renamed language options and adjusted comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 Files: clang/include/clang/Basic/L

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 321385. azabaznov added a comment. Features remain defined in header for OpenCL C 2.0; adjusted the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files: clan

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES -

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 321425. azabaznov added a comment. Adjusted test one more time: moved header functionality into separate test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files:

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5b627aa4fe7: [OpenCL] Introduce new language options for OpenCL keywords. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd88c55ab95c9: [OpenCL] Add macro definitions of OpenCL C 3.0 features (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov created this revision. azabaznov added reviewers: svenvh, Anastasia. Herald added a subscriber: yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change affects 'SemaOpenCLCXX/newdelete.cl' test, thus the patc

[PATCH] D110036: [TargetInfo][LangOpts] Refactor target info and language options adjustment.

azabaznov created this revision. azabaznov added reviewers: aaron.ballman, Anastasia, svenvh. Herald added subscribers: dexonsmith, kerbowa, sunfish, kbarton, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. azabaznov requested review of this revision. Herald added subscribers: cfe-

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov added a comment. Thanks for review. Just to be clear: can I proceed with this? Or we should discuss it first? As I see possible this change can be abandoned after discussion. Moreover,  I see nothing about address space of void pointer in OpenCL C spec. For example (OpenCL C 2.2, Cla

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov updated this revision to Diff 323421. azabaznov added a comment. Rewrote 'RemoveAddressSpaceFromPtr' to return canonical type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 Files: clang/lib/AST

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15289 +ExpectedResultType->getAs()) { + ExpectedResultType = SemaRef.Context.getCanonicalType( + RemoveAddressSpaceFromPtr(SemaRef, Ex

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:157 + // Is OpenCL C feature (OpenCL C 3.0, 6.2.1. Features) + bool isFeature(llvm::StringRef Ext) const; + svenvh wrote: > The argument "Ext" suggests "Extension", so perhap

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov updated this revision to Diff 324004. azabaznov added a comment. Fix clang-tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/Sema

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov added a comment. Thanks for review. Last change is a small fix for if clang-tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 ___ cfe-commit

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1a64aa66c33: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: jfb, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no need to check for enabled pragma for core or optiona

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added a comment. Thanks! I review is shortly. As for now, I also was doing some refactoring: https://reviews.llvm.org/D97058. Check-clang passes, as I see there are no conflicts for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) I think core and optional core features d

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) Anastasia wrote: > azabaznov wrote: > > I

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov marked 3 inline comments as done. azabaznov added inline comments. Comment at: clang/lib/Basic/OpenCLOptions.cpp:24 + auto CLVer = LO.OpenCLCPlusPlus ? 200 : LO.OpenCLVersion; + return CLVer >= 300 ? isEnabled("__opencl_c_fp64") : isEnabled("cl_khr_fp64"); +} ---

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) Anastasia wrote: > azabaznov wrote: > > A

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. > FYI, I would even be ok if we remove the need for enabling non-core AFAIU this can be done not for every extension to maintain backward compatibility. In this case I think https://reviews.llvm.org/D97052 can be useful. Also, I imagine that implicit type definition

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added a comment. I see the update regaring this functionality on github issue: https://github.com/KhronosGroup/OpenCL-Docs/issues/82#issuecomment-785496025. Is it a right way to reflect this information in`OpenCLExtensions.def`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D102853: [OpenCL] Align definition of __IMAGE_SUPPORT__ feature macro with OpenCL version and __opencl_c_images feature macro definition

azabaznov added a comment. In D102853#2773890 , @Anastasia wrote: > LGTM! Although I think it would be better if we set `__IMAGE_SUPPORT__` > conditionally also for earlier OpenCL versions. It has always been defined for SPIR target only. Should we wait

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

  1   2   3   >