[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar updated this revision to Diff 219673. andwar marked 6 inline comments as done. andwar added a comment. - Removed `declare variant` from Attr.td - Moved the 'vector-var-id' lookup from ParseOpenMP.cpp to SemaOpenMP.cpp - Parsing 'vector-var-id' as an expression - Removed the creation of the

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar added a comment. I've addressed most of the comments except for those related to templates. I'd like to clarify as what is the expected behaviour there before proceeding with implementation. Comment at: include/clang/Basic/Attr.td:3220 +private: + NamedDecl *V

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar marked 2 inline comments as done. andwar added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:779-783 + auto Identinfo = PP.getIdentifierInfo(VectorVariantId.Ident->getName()); + LookupResult Lookup(Actions, Identinfo, VectorVariantId.Loc, +

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

andwar added inline comments. Comment at: llvm/examples/Bye/Bye.cpp:53 +/* New PM Registration */ + +llvm::PassPluginLibraryInfo getByePluginInfo() { [nit] Empty line Comment at: llvm/examples/Bye/CMakeLists.txt:9 +else() + target_link_librari

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

andwar added a comment. Btw, could you also add some negative tests? (e.g. out-of-range immediate) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76929/new/ https://reviews.llvm.org/D76929 ___ cfe-commi

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

andwar added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:240 + // Returns the SVETypeFlags for the given memory element type. + uint64_t encodeMemoryElementType(unsigned MT) { +return encodeFlag(MT, "MemEltTypeMask"); Shouldn't `MT` be

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

andwar added a comment. LGTM This patch now implements a bit more than the original commit message would suggest. Could you please update? Thanks for working on this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76617/new/ https://reviews.llvm.org/D76617 __

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

Andrzej added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:186 +def SVLDFF1 : MInst<"svldff1[_{2}]", "dPc", "csilUcUsUiUlhfd", [IsLoad], MemEltTyDefault, "aarch64_sve_ldff1">; +def SVLDFF1SB : MInst<"svldff1sb_{d}", "dPS", "silUsUiUl",

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

andwar added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7458 +llvm_unreachable("Invalid SVETypeFlag!"); + + case SVETypeFlags::EltTyInt8: SjoerdMeijer wrote: > nit: no need for the newlines here and also below? IMHO this improves readabilit

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

andwar added a comment. The buildbot failures are unrelated to this patch, and locally `make check-all` worked fine. I'll submit this patch as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77735/new/ https://reviews.llvm.org/D77735

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. The suggested flag, `-fortran-fe`, feels quite powerful and I wonder whether it's required this early into the development of the Flang driver? IIUC, this flag would be used to workaround the fact that currently `flang` is a bash script and hence can't be used when t

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. @richard.barton.arm @CarolineConcatto thank you both for clarification! @CarolineConcatto , if you prefer to go ahead with this approach - could you please address all the outstanding comments? I've left a few comments that I'd like addressed first, but nothing majo

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:71 const auto& D = C.getDriver(); - const std::string &customFortranName = D.getFFCGenericFortranName(); + const std::string &customFortranName = D.getGenericFortranFE(); const char *Fortr

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. @CarolineConcatto thank you for the updates! - It looks like you accidentally pushed two commits in one patch :) Could you please squash and resubmit? (this should clean-up the diff). Ta! - Perhaps `CFCGenericFlangName` instead of `GenericFortranFE`? This would bett

[PATCH] D131475: [Flang] Use find_program() to find clang-tblgen

awarzynski added a comment. Thanks for the quick fix, makes sense! 👍🏻 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131475/new/ https://reviews.llvm.org/D131475 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

This revision was automatically updated to reflect the committed changes. Closed by commit rG869385b11c32: [flang][driver] Add support for `-O{0|1|2|3}` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://revi

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3612533 , @peixin wrote: > In summary: > >> If you want to use the updated name, flang, set FLANG_USE_LEGACY_NAME to ON >> when configuring LLVM Flang. > > OFF? Updated, thanks! Repository: rG LLVM Github Monor

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, clementval wrote: > Why do we need two lines here? Sh

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 440283. awarzynski added a comment. Incorporate @clementval 's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp c

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski added a comment. @MaskRay, thank for taking a look! In D128333#3605745 , @MaskRay wrote: > gfortran defaults to PIE as well. While we strive to be compatible with `gfortan`, there's a lot relatively "basic" things still missing in LLVM Flang

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski added a comment. In D128333#3613696 , @MaskRay wrote: > True. If it is difficult to override the -pie default from flang side, I am > fine with the code change. Thanks! The proper/long-term fix will require extending Flang's frontend driver

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski updated this revision to Diff 440628. awarzynski added a comment. Update the test following the comments from @MaskRay Also added a comment in Linux.cpp and renamed no-pie.f90 as pic-flags.f90 (to avoid FileCheck matching e.g. `! CHECK: pie` against the file name). Repository: rG

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski updated this revision to Diff 440874. awarzynski added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333 Files: clang/lib/Driver/ToolChains/Linux.cpp flang/test/Dri

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

This revision was automatically updated to reflect the committed changes. Closed by commit rGb405407a4899: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D128333?vs=440874&id=440884#toc Repository: rG LL

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Thank your for reviewing @clementval ! In D125788#3621585 , @clementval wrote: > Shouldn't we just wait until we can make the permanent renaming so we do not > add unnecessary cmake option? This was discussed in one of our

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, richard.barton.arm wrote: > clementval wrote: > > Thi

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 441643. awarzynski added a comment. Add a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChain

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

awarzynski accepted this revision. awarzynski added a comment. Makes sense, many thanks for doing this! Comment at: clang/include/clang/Driver/Options.td:5756 + +} + [nit] IMHO this file lacks comments, hence the suggestion :) Repository: rG LLVM Github Mo

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 418580. awarzynski added a comment. Herald added a subscriber: MaskRay. Use llvm_add_library instead of add_flang_library Fortran_main should be a static library, but `add_flang_library` does not parse `STATIC` in `add_flang_library(Fortran_main STATIC For

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:5756 + +} + ekieri wrote: > awarzynski wrote: > > [nit] IMHO this file lacks comments, hence the suggestion :) > Sure! > > On the topic of this file's structure, I found the nes

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. We discussed this patch in our community call today and some people expressed their reservations about merging this just now. As I mentioned, I would like to have this merged to unblock the CMake PR . As p

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

awarzynski accepted this revision. awarzynski added a subscriber: jansvoboda11. awarzynski added a comment. This revision is now accepted and ready to land. Thanks for doing this, Emil! This is a much appreciated clean-up. On quite a few occasions I got confused with the nested `let` statements.

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

awarzynski added a comment. In D123070#3429519 , @hans wrote: > I worry that the closing comments on '}'s might rot since there's no tooling > to maintain them though. I share your concern. However, from my experience these `let` statements rarely chan

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski created this revision. Herald added a subscriber: mgorny. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Support for generating LLVM BC files is added in Flang's compiler a

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski updated this revision to Diff 420821. awarzynski added a comment. Herald added a reviewer: sscalpone. Add missing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123211/new/ https://reviews.llvm.org/D123211 Files: clang/include/cla

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski updated this revision to Diff 420862. awarzynski added a comment. Move code a bit, add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123211/new/ https://reviews.llvm.org/D123211 Files: clang/include/clang/Driver/Options.td

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:483 + + llvm::ModulePassManager MPM; + llvm::ModuleAnalysisManager MAM; rovka wrote: > Nit: I think you can move these closer to their first use. Thanks, I thought that I _did_

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski added a comment. Thanks for taking a look Diana! > Why not use the BackendAction for this? This action only requires the middle-end in LLVM :) The `BackendAction` will use the backend, but that's not needed here. > There seems to be a lot of shared code, up until the point where you

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

awarzynski added a comment. Thanks for working on this. This is not my area of expertise, so I focused on the implementation in the driver. Comment at: clang/include/clang/Driver/Options.td:4897 def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-length-">, Group, Alia

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

awarzynski added a comment. Many thanks for implementing this! I've only skimmed through so far, but mostly makes sense. Will take a closer look later. Could you update the summary by adding more detail? What options are enabled and whether the semantics from Clang are preserved or not (they sh

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. @stuartellis , thank you for working on this! I've left a few comments - mostly nits. Comment at: flang/examples/HelloWorld/CMakeLists.txt:1-5 +add_llvm_library( +flangHelloWorldPlugin +MODULE +HelloWorldPlugin.cpp +) I

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added a comment. Apologies, it has taken me a bit longer to get back to this. @jansvoboda11 , now I'm realising the key disadvantage of using `OptInFFlag/OptOutFFlag` - it's impossible to express the `opt-in`/`opt-out` semantics in TableGen. In fact, only the contents of `clang -cc1

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski updated this revision to Diff 360100. awarzynski added a comment. Switch from `BoolFOption` to `OptInFFlag`/`OptOutFFlag` I've refactored `OptInFFlag`/`OptOutFFlag` a tiny bit and created specialisations for `clang -cc1` (`OptInCC1FFlag`/`OptOutCC1FFlag`). I have added some comments

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added a comment. Thank you for your detailed reply! In D105881#2904699 , @jansvoboda11 wrote: > Sorry, I'm not sure I follow. OK, let me try to clarify. I've tried to split this into threads. (flag == OptionFlag

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. I think that this is almost ready to be merged. Just a couple more comments. Comment at: flang/examples/CMakeLists.txt:1 # This test is not run by default as it requires input. add_executable(external-hello-world Could you add the

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski updated this revision to Diff 414043. awarzynski added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120568/new/ https://reviews.llvm.org/D120568 Files: clang/include/clang/Driver/Options.td flang/include/flang/Fro

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38101b4e95aa: [flang][driver] Add support for -S and implement -c/

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

awarzynski created this revision. awarzynski added reviewers: rovka, schweitz, Leporacanthicus, kiranchandramohan, shraiysh. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscriber

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm.f90:1 +! Test the `-mlvm` option + xbolva00 wrote: > mllvm Does it matter? `-mllvm` is consistent with other tests in this directory (e.g. https://github.com/llvm/llvm-project/blob/main/flang/

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm.f90:1 +! Test the `-mlvm` option + xbolva00 wrote: > awarzynski wrote: > > xbolva00 wrote: > > > mllvm > > Does it matter? `-mllvm` is consistent with other tests in this directory > > (e.g.

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

awarzynski updated this revision to Diff 414648. awarzynski added a comment. Fix option spelling in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121374/new/ https://reviews.llvm.org/D121374 Files: clang/include/clang/Driver/Options.td cl

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7c08bcf777e: [flang][driver] Add support for `-mllvm` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121374/new/ https://reviews.l

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski created this revision. awarzynski added reviewers: kiranchandramohan, clementval. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Hera

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 416513. awarzynski added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/lib/Driver/ToolChains/Gnu.cpp flang/include/fla

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski created this revision. awarzynski added a reviewer: rovka. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shau

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski updated this revision to Diff 421168. awarzynski edited the summary of this revision. awarzynski added a comment. Fix pre-commit CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123297/new/ https://reviews.llvm.org/D123297 Files: clan

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added a comment. In D123297#3435816 , @rovka wrote: > I don't know the command line library that well, so I have this curiosity: > what happens if LLVM and MLIR have 2 different options with the same name? Do > we get a compile time error? T

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski updated this revision to Diff 421223. awarzynski added a comment. Make sure the MLIR CL options are "applied" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123297/new/ https://reviews.llvm.org/D123297 Files: clang/include/clang/Driver

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} rriddle wrote: > awarzynski wrote: > > awarzynski wrote: > > > rovka w

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added a comment. In D123297#3436867 , @mehdi_amini wrote: > `-mmlir` is fine with me, but note that MLIR has much less global options > than LLVM: you will only get access to context and passmanager options and > not individual passes flags.

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} awarzynski wrote: > rriddle wrote: > > awarzynski wrote: > > > awarzyn

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422143. awarzynski added a comment. Updates required after https://reviews.llvm.org/D122444 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/lib/Driv

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} rovka wrote: > awarzynski wrote: > > awarzynski wrote: > > > rriddle w

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added a comment. I did a bit of digging and realised that MLIR llvm::cl options are lazily constructed on demand (see the definition of options

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski updated this revision to Diff 422163. awarzynski added a comment. Rebase on top of `main`, re-fine the test Make sure that the test file correctly takes into account that `-mmlir -help` is a superset of `-mllvm -help`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski added a comment. In D123211#3435421 , @rovka wrote: > Is there actually a significant difference, besides the naming (which is easy > to change)? AFAICT the BackendAction isn't initializing anything > backend-related except very close to wher

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:491 + // Create and configure `TargetMachine` + std::unique_ptr TM; + ekieri wrote: > awarzynski wrote: > > ekieri wrote: > > > Is there a reason why use TM.reset instead of in

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd56939a4b04: [flang][driver] Add support for generating LLVM bytecode files (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D123211?vs=420862&id=422453#toc Repository: rG

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:15 +#include "mlir/IR/MLIRContext.h" +#include "mlir/Pass/PassManager.h" #include "flang/Frontend/CompilerInstance.h" rovka wrote: > Nit: Should these come after t

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. Thank you all for your feedback! **CMake integration** I have a couple more data points. I've experimented with CMake using Tin's CMake PR . I confirm that together with this patch, I was able to build a

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422525. awarzynski added a comment. Updates based on feedback from @MaskRay (thank you!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/lib/Driver/

[PATCH] D123297: [flang][driver] Add support for -mmlir

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c93e1d329e6: [flang][driver] Add support for `-mmlir` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D123297?vs=422163&id=422787#toc Repository: rG LLVM Github Monorepo

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:3272 MarshallingInfoStringVector>; +def mmlir : Separate<["-"], "mmlir">,Flags<[CoreOption,FC1Option,FlangOption]>, + HelpText<"Additional arguments to forward to MLIR's option processing">; -

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. @h-vetinari & @rouson, thanks for the encouragement! In D122008#3450214 , @h-vetinari wrote: > I'd be more than a little surprised that there's no way to do this. Have you > tried CMAKE_Fortran_FLAGS >

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422836. awarzynski added a comment. Add a flang, `-flang-experimental-exec`, to guard the new functionality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files:

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422841. awarzynski added a comment. Update the tests after the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/include/clang/Driver/

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. In D122008#3456445 , @clementval wrote: > Do you plan to discuss this again during the next call? Note that today is a > holiday in various country in Europe (maybe elsewhere too) so the one on 4/27 > is probably better. To

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. Btw, if there are no new comments, I would like to merge this in the coming days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 _

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. In D122008#3462665 , @klausler wrote: > New comments or not, this step remains premature from my perspective. Let me make `-flang-experimental-exec` a "hidden" option then. This way this flag (and the functionality that it en

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, clementval, schweitz. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, dang, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aar

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added a comment. `fir-dev` PR: https://github.com/flang-compiler/f18-llvm-project/pull/1008. I've also incorporated a few small changes from the subsequent PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.l

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, clementval, schweitz. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a project: Flang. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoe

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406005. awarzynski added a comment. Add missing CMake dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.llvm.org/D118985 Files: clang/include/clang/Driver/Options.td f

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:150 +//===--===// +class CodeGenAction : public FrontendAction { + schweitz wrote: > This appears in a

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406377. awarzynski added a comment. Removed trailing "_" from member variable names, added a comment, updated CMake dependencies (needed after https://reviews.llvm.org/D118966) @schweitz, thank you for reviewing! If there are no new comments, I'll merge

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406380. awarzynski added a comment. Rebase, remove trailing "_" from member variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/c

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. This has been extracted from `fir-dev`. Original PR: https://github.com/flang-compiler/f18-llvm-project/pull/1113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 _

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:69 + + // Create a LoweringBridge + auto &defKinds = ci.invocation().semanticsContext().defaultKinds(); kiranchandramohan wrote: > Nit: Can we remove the three autos below? Sur

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406398. awarzynski added a comment. Remove `auto`, update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.llvm.org/D118985 Files: clang/include/clang/Driver/Options.td

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:421 + // Set-up the MLIR pass manager + fir::setTargetTriple(*mlirModule_, "native"); + auto &defKinds = ci.invocation().semanticsContext().defaultKinds(); rovka wrote: > Nit:

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406425. awarzynski marked 2 inline comments as done. awarzynski added a comment. Update comments + add an `assert` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406428. awarzynski added a comment. Remove the calls to `setTargetTriple` and `setKindMapping`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/incl

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:419 + + // ... otherwise, print to a file. + auto os{ci.CreateDefaultOutputFile( kiranchandramohan wrote: > awarzynski wrote: > > kiranchandramohan wrote: > > > Nit: Should we

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406828. awarzynski added a comment. - Add a test to verify that an `.mlir` file is created - Set the target triple to `native` (as opposed to relying on it being set elsewhere, e.g. https://github.com/llvm/llvm-project/blob/81cde474e2c5a6280cb693b777ddcf4

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. I believe that Windows failures are due to the missing support here: https://github.com/llvm/llvm-project/blob/81cde474e2c5a6280cb693b777ddcf473825ae8a/flang/lib/Optimizer/CodeGen/Target.cpp#L290. I can disable the LIT test on Windows, but I'm not sure how to do it fo

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406832. awarzynski added a comment. Disable the LIT test on Windows, simplify how output is dumped in `EmitLLVMAction::ExecuteAction`, remove `auto` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c3309d4545: [flang][driver] Add support for `-emit-mlir` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://revie

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407070. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/clang/Driver/Options.td flang/in

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407130. awarzynski added a comment. Herald added a subscriber: mehdi_amini. Updated `fir::CodeGenSpecifics::get` to see whether the unit tests pass on Windows. If they do, I'll create a seperate patch with this change. Repository: rG LLVM Github Monore

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407139. awarzynski added a comment. Remove the change from `fir::CodeGenSpecifics::get` (this was uploaded as a seperate patch: https://reviews.llvm.org/D119332) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

  1   2   3   4   5   6   7   >