Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-26 Thread Andrii Grynenko via cfe-commits
andriigrynenko added inline comments. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199 @@ -164,7 +175,26 @@ ret += Run(argc - 1, 0, stack); +// CHECK: Child stack: [[CHILD_STACK:0x[0-9a-f]*]] +// CHECK: Main context from: [[CHILD_STACK]] 524288

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-26 Thread Andrii Grynenko via cfe-commits
andriigrynenko updated this revision to Diff 72571. andriigrynenko added a comment. Do CHECKs for all iterations of the loop. https://reviews.llvm.org/D24628 Files: include/sanitizer/common_interface_defs.h lib/asan/asan_thread.cc lib/asan/asan_thread.h test/asan/TestCases/Linux/swapcon

[PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-15 Thread Andrii Grynenko via cfe-commits
andriigrynenko created this revision. andriigrynenko added reviewers: kcc, blastrock, dvyukov, filcab. andriigrynenko added a subscriber: cfe-commits. andriigrynenko set the repository for this revision to rL LLVM. Herald added a subscriber: kubabrecka. This patch extends __sanitizer_finish_switch

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-16 Thread Andrii Grynenko via cfe-commits
andriigrynenko updated this revision to Diff 71677. andriigrynenko added a comment. fix the unit test https://reviews.llvm.org/D24628 Files: include/sanitizer/common_interface_defs.h lib/asan/asan_thread.cc lib/asan/asan_thread.h test/asan/TestCases/Linux/swapcontext_annotation.cc Inde

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-16 Thread Andrii Grynenko via cfe-commits
andriigrynenko added inline comments. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:9 @@ -8,3 +8,3 @@ // This test is too subtle to try on non-x86 arch for now. -// REQUIRES: x86_64-supported-target,i386-supported-target +// REQUIRES: x86-target-arch -

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-16 Thread Andrii Grynenko via cfe-commits
andriigrynenko updated this revision to Diff 71698. andriigrynenko added a comment. update unit test to use non-null values https://reviews.llvm.org/D24628 Files: include/sanitizer/common_interface_defs.h lib/asan/asan_thread.cc lib/asan/asan_thread.h test/asan/TestCases/Linux/swapconte

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-16 Thread Andrii Grynenko via cfe-commits
andriigrynenko updated this revision to Diff 71717. andriigrynenko added a comment. Addressing comments. https://reviews.llvm.org/D24628 Files: include/sanitizer/common_interface_defs.h lib/asan/asan_thread.cc lib/asan/asan_thread.h test/asan/TestCases/Linux/swapcontext_annotation.cc I

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-16 Thread Andrii Grynenko via cfe-commits
andriigrynenko added inline comments. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199 @@ -164,7 +175,26 @@ ret += Run(argc - 1, 0, stack); +// CHECK: Child stack: [[CHILD_STACK:0x[0-9a-f]*]] +// CHECK: Main context from: [[CHILD_STACK]] 524288