RE: r314262 - Emit section information for extern variables.

2017-10-04 Thread Andrews, Elizabeth via cfe-commits
Hello, I just spoke to Erich. The warning isn’t supposed to be emitted when the section attribute is specified on a definition. I’m not sure why struct r_debug _r_debug __attribute__((nocommon, section(".r_debug"))); failed the isThisDeclarationADefiniton check. I need to look into it. Thanks, E

RE: r314262 - Emit section information for extern variables.

2017-10-04 Thread Andrews, Elizabeth via cfe-commits
Alright. Will do. Thanks! From: Friedman, Eli [mailto:efrie...@codeaurora.org] Sent: Wednesday, October 4, 2017 4:51 PM To: Keane, Erich ; Andrews, Elizabeth ; Nico Weber Cc: cfe-commits Subject: Re: r314262 - Emit section information for extern variables. On 10/4/2017 1:48 PM, Keane, Erich wr

RE: r325081 - Implement function attribute artificial

2018-02-14 Thread Andrews, Elizabeth via cfe-commits
Thanks Richard. I’ll update the documentation and submit a new patch for review. Elizabeth From: Keane, Erich Sent: Wednesday, February 14, 2018 11:33 AM To: Richard Smith ; Andrews, Elizabeth Cc: cfe-commits Subject: RE: r325081 - Implement function attribute artificial Thanks for your comme

RE: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

2019-12-12 Thread Andrews, Elizabeth via cfe-commits
Hi Alexander, I am debugging this now but I assume the checks for the if condition were skipped before this commit (therefore no crash) because ‘c’ was set as type dependent. The checks are probably run now since c’s type dependency changed with this patch. The checks might need to be guarded b