Author: asavonic
Date: Thu Sep 6 04:54:09 2018
New Revision: 341539
URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=rev
Log:
[OpenCL] Disallow negative attribute arguments
Summary:
Negative arguments in kernel attributes are silently bitcast'ed to
unsigned, for example:
__attribute
Hi Aaron,
> On Thu, Sep 6, 2018 at 7:54 AM, Andrew Savonichev via cfe-commits
> wrote:
>> Author: asavonic
>> Date: Thu Sep 6 04:54:09 2018
>> New Revision: 341539
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=rev
>> Log:
>
Author: asavonic
Date: Thu Sep 6 08:10:26 2018
New Revision: 341553
URL: http://llvm.org/viewvc/llvm-project?rev=341553&view=rev
Log:
[OpenCL] Relax diagnostics on OpenCL access qualifiers
Summary:
Emit warning for multiple access qualifiers if they do not conflict.
Patch by Alexey Bader
Revie
Author: asavonic
Date: Thu Oct 11 06:35:34 2018
New Revision: 344246
URL: http://llvm.org/viewvc/llvm-project?rev=344246&view=rev
Log:
[Sema][OpenCL] Improve diagnostics for not viable overloadable function
candidates
Summary:
Allowed extension name (that ought to be disabled) printing in the no
Author: asavonic
Date: Tue Oct 23 08:19:20 2018
New Revision: 345038
URL: http://llvm.org/viewvc/llvm-project?rev=345038&view=rev
Log:
[OpenCL][NFC] Unify ZeroToOCL* cast types
Reviewers: Anastasia, yaxunl
Reviewed By: Anastasia
Subscribers: asavonic, cfe-commits
Differential Revision: https:/
Author: asavonic
Date: Tue Oct 23 09:13:16 2018
New Revision: 345044
URL: http://llvm.org/viewvc/llvm-project?rev=345044&view=rev
Log:
[OpenCL] Add cl_intel_planar_yuv extension
Just adding a preprocessor #define for the extension.
Patch by Alexey Sotkin and Dmitry Sidorov
Phabricator review: h
Author: asavonic
Date: Tue Oct 23 10:05:29 2018
New Revision: 345051
URL: http://llvm.org/viewvc/llvm-project?rev=345051&view=rev
Log:
[OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h
Summary:
PIPE_RESERVE_ID_VALID_BIT is implementation defined, so lets not keep it in the
header.
Prev
Author: asavonic
Date: Mon Oct 29 04:14:01 2018
New Revision: 345497
URL: http://llvm.org/viewvc/llvm-project?rev=345497&view=rev
Log:
[OpenCL] Fix serialization of OpenCLExtensionDecls
Summary:
I recently discovered that adding the following code into `opencl-c.h` causes
failure of `test/Headers
Author: asavonic
Date: Wed Nov 7 05:07:18 2018
New Revision: 346311
URL: http://llvm.org/viewvc/llvm-project?rev=346311&view=rev
Log:
[OpenCL] Fix diagnostic message about overload candidates
Summary:
I wonder if there are some extension which need to be disabled to get
overloadable candidate av
Author: asavonic
Date: Wed Nov 7 07:44:01 2018
New Revision: 346326
URL: http://llvm.org/viewvc/llvm-project?rev=346326&view=rev
Log:
[OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension
Summary:
Documentation can be found at
https://www.khronos.org/registry/OpenCL/exten
Author: asavonic
Date: Wed Nov 7 10:34:19 2018
New Revision: 346338
URL: http://llvm.org/viewvc/llvm-project?rev=346338&view=rev
Log:
Revert r346326 [OpenCL] Add support of
cl_intel_device_side_avc_motion_estimation
This patch breaks Index/opencl-types.cl LIT test:
Script:
--
: 'RUN: at line 1
Author: asavonic
Date: Thu Nov 8 03:25:41 2018
New Revision: 346392
URL: http://llvm.org/viewvc/llvm-project?rev=346392&view=rev
Log:
[OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension
Summary:
Documentation can be found at
https://www.khronos.org/registry/OpenCL/exten
Author: asavonic
Date: Mon Dec 10 04:03:00 2018
New Revision: 348752
URL: http://llvm.org/viewvc/llvm-project?rev=348752&view=rev
Log:
[OpenCL][CodeGen] Fix replacing memcpy with addrspacecast
Summary:
If a function argument is byval and RV is located in default or alloca address
space
an optimi
Author: asavonic
Date: Wed Mar 20 09:43:07 2019
New Revision: 356571
URL: http://llvm.org/viewvc/llvm-project?rev=356571&view=rev
Log:
[OpenCL] Generate 'unroll.enable' metadata for
__attribute__((opencl_unroll_hint))
Summary:
[OpenCL] Generate 'unroll.enable' metadata for
__attribute__((open
Author: asavonic
Date: Mon Sep 17 03:39:46 2018
New Revision: 342367
URL: http://llvm.org/viewvc/llvm-project?rev=342367&view=rev
Log:
Merge two attribute diagnostics into one
Summary:
Merged the recently added `err_attribute_argument_negative` diagnostic
with existing `err_attribute_requires_pos
Author: asavonic
Date: Mon Sep 17 04:19:42 2018
New Revision: 342370
URL: http://llvm.org/viewvc/llvm-project?rev=342370&view=rev
Log:
[OpenCL] Allow blocks to capture arrays in OpenCL
Summary: Patch by Egor Churaev
Reviewers: Anastasia, yaxunl
Reviewed By: Anastasia
Subscribers: asavonic, bad
Author: asavonic
Date: Thu Feb 21 03:02:10 2019
New Revision: 354568
URL: http://llvm.org/viewvc/llvm-project?rev=354568&view=rev
Log:
[OpenCL] Simplify LLVM IR generated for OpenCL blocks
Summary:
Emit direct call of block invoke functions when possible, i.e. in case the
block is not passed as a
Author: asavonic
Date: Mon Jun 3 06:02:43 2019
New Revision: 362398
URL: http://llvm.org/viewvc/llvm-project?rev=362398&view=rev
Log:
[OpenCL] Undefine cl_intel_planar_yuv extension
Summary:
Remove unnecessary definition (otherwise the extension will be defined
where it's not supposed to be def
Author: asavonic
Date: Wed Dec 12 01:51:23 2018
New Revision: 348919
URL: http://llvm.org/viewvc/llvm-project?rev=348919&view=rev
Log:
[OpenCL] Fix for TBAA information of pointer after addresspacecast
Summary: When addresspacecast is generated resulting pointer should preserve
TBAA information
asavonic added a comment.
Hi @Anastasia,
Sorry for my late reply.
> > > What would be the use case to override the supported extensions for the
> > > end user?
>
> >
>
> >
>
> > Some extensions may be supported by the platform in general, but not by the
>
> > specific version of
asavonic updated this revision to Diff 72143.
asavonic added a comment.
Herald added a subscriber: yaxunl.
Add more test cases and fix minor issues
https://reviews.llvm.org/D23712
Files:
include/clang/Basic/OpenCLOptions.h
include/clang/Basic/TargetInfo.h
include/clang/Basic/TargetOptions
asavonic marked 3 inline comments as done.
Comment at: include/clang/Basic/OpenCLOptions.h:39
@@ +38,3 @@
+
+ void set(llvm::StringRef Ext, bool Enable = true) {
+assert(!Ext.empty() && "Extension is empty.");
yaxunl wrote:
> It seems Enable should be a local
asavonic updated this revision to Diff 73443.
asavonic added a comment.
- Describe OpenCLOptions::set() function
- Move -cl-ext option to cc1
- Reword -cl-ext option help
- Move -cl-ext handling out of target-specific code
- Add two more test cases regarding -cl-ext option
https://reviews.llvm.o
Author: Andrew Savonichev
Date: 2022-04-26T21:40:36+03:00
New Revision: 0a27622a1d625f179a17f3a22a547d50b042b76e
URL:
https://github.com/llvm/llvm-project/commit/0a27622a1d625f179a17f3a22a547d50b042b76e
DIFF:
https://github.com/llvm/llvm-project/commit/0a27622a1d625f179a17f3a22a547d50b042b76e.d
Author: Andrew Savonichev
Date: 2021-06-07T12:54:08+03:00
New Revision: b31f41e78b2722785f3df1da0d77dfcd68125d15
URL:
https://github.com/llvm/llvm-project/commit/b31f41e78b2722785f3df1da0d77dfcd68125d15
DIFF:
https://github.com/llvm/llvm-project/commit/b31f41e78b2722785f3df1da0d77dfcd68125d15.d
Author: Andrew Savonichev
Date: 2021-11-03T12:08:39+03:00
New Revision: a8083d42b1c346e21623a1d36d1f0cadd7801d83
URL:
https://github.com/llvm/llvm-project/commit/a8083d42b1c346e21623a1d36d1f0cadd7801d83
DIFF:
https://github.com/llvm/llvm-project/commit/a8083d42b1c346e21623a1d36d1f0cadd7801d83.d
asavonic created this revision.
asavonic added a reviewer: Anastasia.
asavonic added a subscriber: cfe-commits.
This patch adds a command line option '-cl-ext' to control a set of
supported OpenCL extensions. Option accepts a comma-separated list
of extensions prefixed with '+' or '-'.
It can be
asavonic updated this revision to Diff 68677.
asavonic added a comment.
- Remove unused test case
https://reviews.llvm.org/D23712
Files:
include/clang/Basic/OpenCLOptions.h
include/clang/Basic/TargetInfo.h
include/clang/Basic/TargetOptions.h
include/clang/Driver/Options.td
lib/Basic/T
asavonic added a comment.
In https://reviews.llvm.org/D23712#520818, @Anastasia wrote:
> What would be the use case to override the supported extensions for the end
> user?
Some extensions may be supported by the platform in general, but not by the
specific version of the OpenCL runtime.
For
asavonic updated this revision to Diff 75568.
asavonic added a comment.
- Fix comments and code formatting
https://reviews.llvm.org/D23712
Files:
include/clang/Basic/OpenCLOptions.h
include/clang/Basic/TargetInfo.h
include/clang/Basic/TargetOptions.h
include/clang/Driver/CC1Options.td
asavonic added inline comments.
Comment at: test/SemaOpenCL/images-typedef.cl:40
@@ +39,3 @@
+ myWrite(img); // expected-error {{passing 'img1d_ro_default' (aka
'__read_only image1d_t') to parameter of incompatible type '__write_only
image1d_t'}}
+}
+
No, but w
asavonic updated this revision to Diff 59890.
asavonic added a comment.
- Cleanup images-typedef.cl
- Fix typo in SemaType.cpp
- Change diagnostic: error when access qualifier applied to a typedef
http://reviews.llvm.org/D20948
Files:
include/clang/Basic/Attr.td
include/clang/Basic/Diagnost
asavonic updated this revision to Diff 59893.
asavonic marked 3 inline comments as done.
asavonic added a comment.
- Fix images-typedef.cl for OpenCL 2.0
http://reviews.llvm.org/D20948
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Attribu
asavonic updated this revision to Diff 63073.
asavonic added a comment.
Merged invalid-access-qualifier.cl and images-typedef.cl tests, fixed
code style issues.
http://reviews.llvm.org/D20948
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/
asavonic marked 4 inline comments as done.
asavonic added a comment.
http://reviews.llvm.org/D20948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asavonic marked 2 inline comments as done.
asavonic added a comment.
http://reviews.llvm.org/D20948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asavonic marked an inline comment as done.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2509-2510
@@ -2508,4 +2508,4 @@
"functions, methods, and parameters|classes|enums|variables|methods|"
- "fields and global variables|structs|variables and typedefs|thread-local
v
asavonic updated this revision to Diff 63222.
asavonic added a comment.
Change diagnostic wording
http://reviews.llvm.org/D20948
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/ke
https://github.com/asavonic created
https://github.com/llvm/llvm-project/pull/107828
Fields from external sources are typically loaded implicitly by `RecordDecl` or
`DeclContext` iterators and other functions (see LoadFieldsFromExternalStorage
function and its uses). The assumption is that we
asavonic wrote:
Thanks Michael, I'm glad I'm not the only one seeing this problem.
> > If an implicit import happens between (2) and (3), it may indirectly bring
> > the same field into the context. When (3) happens we add it again,
> > duplicating the field and breaking the record. This is no
Author: Andrew Savonichev
Date: 2021-05-04T20:29:01+03:00
New Revision: b451ecd86e13ec6ef47caf37f62977645c4f748e
URL:
https://github.com/llvm/llvm-project/commit/b451ecd86e13ec6ef47caf37f62977645c4f748e
DIFF:
https://github.com/llvm/llvm-project/commit/b451ecd86e13ec6ef47caf37f62977645c4f748e.d
Author: Andrew Savonichev
Date: 2021-10-15T13:55:36+03:00
New Revision: 3dbcea8b957a5f0094f1d5a73b7a8ebebeedebb6
URL:
https://github.com/llvm/llvm-project/commit/3dbcea8b957a5f0094f1d5a73b7a8ebebeedebb6
DIFF:
https://github.com/llvm/llvm-project/commit/3dbcea8b957a5f0094f1d5a73b7a8ebebeedebb6.d
Author: Andrew Savonichev
Date: 2021-09-13T14:59:37+03:00
New Revision: ec6c847179fd019acae4d97a18f9e7d3961a6fdf
URL:
https://github.com/llvm/llvm-project/commit/ec6c847179fd019acae4d97a18f9e7d3961a6fdf
DIFF:
https://github.com/llvm/llvm-project/commit/ec6c847179fd019acae4d97a18f9e7d3961a6fdf.d
Author: Andrew Savonichev
Date: 2021-09-13T15:34:21+03:00
New Revision: 6377426b4a326b52733065609a5d811afd2b8b1b
URL:
https://github.com/llvm/llvm-project/commit/6377426b4a326b52733065609a5d811afd2b8b1b
DIFF:
https://github.com/llvm/llvm-project/commit/6377426b4a326b52733065609a5d811afd2b8b1b.d
asavonic wrote:
> Our idea is summarized in
> https://discourse.llvm.org/t/rfc-lldb-more-reliable-completion-of-record-types/77442.
> Basically the goal is to guarantee that a call to `getDefinition`, _will_
> fetch the definition. This is something that Clang already does, but we just
> neve
45 matches
Mail list logo
