Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu updated this revision to Diff 72026. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@ -2863,8 +2863,20 @@

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu updated this revision to Diff 72790. Abpostelnicu marked 2 inline comments as done. Abpostelnicu added a comment. i will add the unit tests in the next patch. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp ==

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu updated this revision to Diff 72806. Abpostelnicu marked an inline comment as done. Abpostelnicu added a comment. corrected typo https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp

[PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu updated this revision to Diff 73766. Abpostelnicu marked 3 inline comments as done. https://reviews.llvm.org/D22910 Files: lib/AST/Expr.cpp Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@ -28

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu marked 2 inline comments as done. Comment at: lib/AST/Expr.cpp:2868 @@ +2867,3 @@ +OverloadedOperatorKind binOp = cast(this)->getOperator(); +if (binOp == OO_Equal || (binOp >= OO_PlusEqual && binOp <= OO_PipeEqual)) { + return true; rs

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu removed rL LLVM as the repository for this revision. Abpostelnicu updated this revision to Diff 68507. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp ===

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu updated this revision to Diff 69205. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@ -2861,8 +2861,19 @@

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu marked 4 inline comments as done. Abpostelnicu added a comment. I've added also support for pure in case CXXOperatorCallExprClass::isAssignmentOperator is true. https://reviews.llvm.org/D22910 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu added inline comments. Comment at: lib/AST/Expr.cpp:2869 @@ +2868,3 @@ +OverloadedOperatorKind Op = cast(this)->getOperator(); +if (CXXOperatorCallExpr::isAssignmentOp(Op)) { + const Decl *FD = cast(this)->getCalleeDecl(); aaron.ballman w

[PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu added a comment. Can someone please show me an example on how to write a test for this patch? https://reviews.llvm.org/D22910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu added a comment. In https://reviews.llvm.org/D22910#499082, @aaron.ballman wrote: > Thank you for the patch! > > One thing this patch is missing is a test case that exercises this code path. > For instance, there are diagnostics triggered for expressions with side > effects when us