AndersRonnholm updated this revision to Diff 114346.
AndersRonnholm added a comment.
Herald added subscribers: xazax.hun, JDevlieghere.
Fixed comments
Repository:
rL LLVM
https://reviews.llvm.org/D36672
Files:
clang-tidy/readability/NonConstParameterCheck.cpp
test/clang-tidy/readability-
AndersRonnholm marked 2 inline comments as done.
AndersRonnholm added inline comments.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:147
+if (const auto *Parent = Par->getParentFunctionOrMethod()) {
+ if (const auto *F = dyn_cast(Parent)) {
+const
AndersRonnholm abandoned this revision.
AndersRonnholm added a comment.
Fixed by https://reviews.llvm.org/rL319021. At least for c/c++ not sure if it
handles objective-c.
Repository:
rL LLVM
https://reviews.llvm.org/D36672
___
cfe-commits mailin
AndersRonnholm created this revision.
AndersRonnholm added a project: clang-tools-extra.
Fixes assert reported in https://bugs.llvm.org/show_bug.cgi?id=33660
Repository:
rL LLVM
https://reviews.llvm.org/D36670
Files:
clang-tidy/misc/MisplacedWideningCastCheck.cpp
test/clang-tidy/misc-mis
AndersRonnholm created this revision.
Fixes issue reported in https://bugs.llvm.org/show_bug.cgi?id=33219
Repository:
rL LLVM
https://reviews.llvm.org/D36672
Files:
clang-tidy/readability/NonConstParameterCheck.cpp
test/clang-tidy/readability-non-const-parameter.cpp
Index: test/clang-t
AndersRonnholm created this revision.
The MallocChecker does not currently detect freeing of function pointers.
Example code.
void (*fnptr)(int);
void freeIndirectFunctionPtr() {
void *p = (void*)fnptr;
free(p); // expected-warning {{Argument to free() points to a function
pointer}}
AndersRonnholm updated this revision to Diff 95929.
AndersRonnholm added a comment.
Updated after comments
Repository:
rL LLVM
https://reviews.llvm.org/D31650
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/malloc.c
Index: test/Analysis/malloc.c
=