Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

Anastasia added inline comments. Comment at: test/SemaOpenCL/implicit-typedef.cl:3 @@ +2,3 @@ +// RUN: %clang_cc1 %s -cl-std=CL2.0 -fsyntax-only + +#if defined(TEST_WARNINGS) ichesnokov wrote: > Are you mean another text of warning? Notice that actual patch will w

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

Anastasia added inline comments. Comment at: test/SemaOpenCL/implicit-typedef.cl:3 @@ +2,3 @@ +// RUN: %clang_cc1 %s -cl-std=CL2.0 -fsyntax-only + +#if defined(TEST_WARNINGS) ichesnokov wrote: > Anastasia wrote: > > ichesnokov wrote: > > > Are you mean another tex

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added inline comments. Comment at: lib/Parse/ParseStmt.cpp:2214 @@ +2213,3 @@ + +bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttributes &Attrs) { + MaybeParseGNUAttributes(Attrs); pxli168 wrote: > I am wondering where should this function goes in,

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5067 @@ +5066,3 @@ + if (DeclTy->isPipeType() || + (S.getLangOpts().OpenCLVersion < 200 && DeclTy->isImageType())) { +S.Diag(D->getLocation(), diag::err_opencl_invalid_read_write)

[PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia created this revision. Anastasia added reviewers: pekka.jaaskelainen, pxli168. Anastasia added a subscriber: cfe-commits. Anastasia set the repository for this revision to rL LLVM. Applying the following restrictions for block variables in OpenCL (v2.0 s6.12.5): - __block storage class

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

Anastasia added a comment. I think some comments from Richad's feedback are missing, specifically: - Missing space after comma. - Why are these conversions performed here rather than in Sema? - You should attempt to implicitly convert to the desired type here, rather than demanding the right typ

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

Anastasia added inline comments. Comment at: lib/Sema/SemaChecking.cpp:294 @@ +293,3 @@ + diag::err_opencl_builtin_pipe_invalid_access_modifier) + << "read_only" << Arg0->getSourceRange(); + return true; Anastasia wrote: > Could we use ge

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

Anastasia added a comment. I am missing to understand the intention of this change. Are you trying to improve the testing for OpenCL? http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D16682: 19957 - OpenCL incorrectly accepts implicit address space conversion with ternary operator

Anastasia added inline comments. Comment at: test/SemaOpenCL/ternary-implicit-casts.cl:6 @@ +5,3 @@ + // will not compile, ptr is not generic but local + local int *ptr = cond ? gint : lint; // expected-warning {{pointer type mismatch ('__global int *' and '__local int *')

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

Anastasia added inline comments. Comment at: test/SemaOpenCL/implicit-typedef.cl:1 @@ +1,2 @@ +// RUN: %clang_cc1 %s -DTEST_WARNINGS -cl-std=CL2.0 -verify -pedantic -fsyntax-only -Wsystem-headers +// RUN: %clang_cc1 %s -cl-std=CL2.0 -fsyntax-only do you need -ped

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added a comment. Adding a few final comments, otherwise, looks good! Comment at: lib/Sema/SemaDeclAttr.cpp:5050 @@ +5049,3 @@ + + // Check if there only one access qualifier + if (D->hasAttr()) { there is only one Comment at: lib/Se

Re: [PATCH] D16539: [FIX] 26194 - LLVM crash in CXXNameMangler::mangleType

Anastasia added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1386 @@ -1385,1 +1385,3 @@ + if (Quals.hasAddressSpace()) { +// Address space extension: I was just wondering since this code appears to be a repetition from ItaniumMangler.cpp, could

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added inline comments. Comment at: lib/Parse/ParseStmt.cpp:2214 @@ +2213,3 @@ + +bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttributes &Attrs) { + MaybeParseGNUAttributes(Attrs); pxli168 wrote: > Anastasia wrote: > > pxli168 wrote: > > > I am won

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

Anastasia added a comment. Related to: 1. I think I would still add space. You can also reformat other lines. There are only 5 lines above. 2. Agree. 3. Feels like may be we should try to see if the passed argument is convertible to the function parameter type. For example, I see that some bui

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added inline comments. Comment at: test/SemaOpenCL/unroll-hint-cl20.cl:1 @@ +1,2 @@ +//RUN: %clang_cc1 -O0 -cl-std=CL2.0 -fsyntax-only -verify %s + Could we just combine this with test/SemaOpenCL/unroll-hint.cl. You can have two RUN lines and pass somet

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lib/CodeGen/CGLoopInfo.cpp:134 @@ +133,3 @@ +// 1 - disable unroll +// other positive integer n - unroll by n +if (OpenCLHint) { --

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! @Pekka, any comments here? We will finalize it if not. Comment at: lib/Sema/SemaDeclAttr.cpp:5823 @@ -5788,8 +5822,3 @@ - // Walk the declarator structure, app

r260671 - [OpenCL] Disable C99 standard lib functions

Author: stulova Date: Fri Feb 12 06:07:04 2016 New Revision: 260671 URL: http://llvm.org/viewvc/llvm-project?rev=260671&view=rev Log: [OpenCL] Disable C99 standard lib functions The library functions defined in the C99 standard headers are not available (OpenCL v1.2 s6.9.f). This change stops t

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added a comment. @Pekka, Xiuli, Richard, any more comments here? Thanks! http://reviews.llvm.org/D16686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5823 @@ -5788,8 +5822,3 @@ - // Walk the declarator structure, applying decl attributes that were in a type - // position to the decl itself. This handles cases like: - // int *__attr__(x)** D; - // w

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia removed rL LLVM as the repository for this revision. Anastasia updated this revision to Diff 47823. Anastasia added a comment. Update according to review comments! http://reviews.llvm.org/D16928 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/Sem

OpenCL support for Clang release 3.8 notes

Hi Hans, Could we please add the description of OpenCL support into the release notes? It covers a larger time frame than just the current release but since it hasn't been in the release notes before, I hope it's fine. It would be good to inform what we were working on in the past. I propose t

r261084 - [OpenCL] Added half type literal with suffix h.

Author: stulova Date: Wed Feb 17 05:34:37 2016 New Revision: 261084 URL: http://llvm.org/viewvc/llvm-project?rev=261084&view=rev Log: [OpenCL] Added half type literal with suffix h. OpenCL Extension v1.2 s9.5 allows half precision floating point type literals with suffices h or H when cl_khr_fp16

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia updated this revision to Diff 48219. Anastasia added a comment. Drafted code for printf handling. Made me think about: 1. How much signature check should we do i.e. should we check the pointer AS itself (generic for CL2.0, any other otherwise) or qualifiers being used for the first p

[PATCH] D17343: [OpenCL] Diagnose program scope pointers

Anastasia created this revision. Anastasia added reviewers: pekka.jaaskelainen, yaxunl. Anastasia added a subscriber: cfe-commits. Programs scope pointers should point to objects in constant AS or for OpenCL 2.0 in global AS. http://reviews.llvm.org/D17343 Files: include/clang/Basic/Diagnosti

[PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia created this revision. Anastasia added reviewers: pekka.jaaskelainen, yaxunl. Anastasia added a subscriber: cfe-commits. This patch: 1. Prevents local variables to be declared in global AS 2. Diagnoses AS of local variables with an extern storage class as if they would be in a program s

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia added a comment. @Mats, I think I would prefer not to add even more special handling (i.e. error in this case) for printf. I will look into adding it as a Builtin instead. However, I would prefer to remove it from this change and submit a separate patch as it doesn't belong to Clang

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia added a comment. @Mats, I think I would prefer not to add even more special handling (i.e. error in this case) for printf. I will look into adding it as a Builtin instead. However, I would prefer to remove it from this change and submit a separate patch as it doesn't belong to Clang

r261350 - [OpenCL] Generate metadata for opencl_unroll_hint attribute

Author: stulova Date: Fri Feb 19 12:30:11 2016 New Revision: 261350 URL: http://llvm.org/viewvc/llvm-project?rev=261350&view=rev Log: [OpenCL] Generate metadata for opencl_unroll_hint attribute Add support for opencl_unroll_hint attribute from OpenCL v2.0 s6.11.5. Reusing most of metadata genera

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia updated this revision to Diff 48514. Anastasia added a comment. Removed varargs due to printf special handling. To be added as a separate review! http://reviews.llvm.org/D16928 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaType.cpp test/

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia updated this revision to Diff 48516. Anastasia added a comment. Fixed error msg and test! http://reviews.llvm.org/D17345 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/Parser/opencl-storage-class.cl test/SemaOpenCL/storageclass-cl20.cl test/Sema

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia updated this revision to Diff 48518. Anastasia added a comment. Corrected to new error msg in tests too! http://reviews.llvm.org/D17345 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/Parser/opencl-storage-class.cl test/SemaOpenCL/storageclass-cl20

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5046 @@ +5045,3 @@ + if (D->hasAttr()) { +S.Diag(Attr.getLoc(), diag::err_opencl_multiple_access_qualifiers) +<< D->getSourceRange(); Yes, I think attribute would make more sense.

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7719 @@ +7718,3 @@ +def err_opencl_block_proto_variadic : Error< + "invalid block prototype, variadic arguments are not allowed in opencl">; +def err_opencl_invalid_block_array : Error< --

Re: [PATCH] D17437: [OpenCL] Add Sema checks for image and pipe

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5714 @@ +5713,3 @@ + // OpenCL v2.0 s6.9.b + // An image type can only be used as a type of a function argument. + if (getLangOpts().OpenCL && R->isImageType()) { Move to the line above, separat

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia added inline comments. Comment at: test/SemaOpenCL/storageclass-cl20.cl:23 @@ -19,1 +22,3 @@ + extern global int G5; + extern int G6; // expected-error{{program scope variable must reside in global or constant address space}} } Apparently not, becaus

Re: [PATCH] D17438: [OpenCL] Add Sema checks for atomics and implicit declaration

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3900 @@ -3899,1 +3899,3 @@ if (!DeclaresAnything) { +// OpenCL C doesn't support bit-field, so declaration with no declarator +// has no use. I am still not convinced about this change?

Re: [PATCH] D17438: [OpenCL] Add Sema checks for atomics and implicit declaration

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11504 @@ +11503,3 @@ + else if (getLangOpts().OpenCL) +// OpenCL function need to be called with prototype, so we don't allow +// implicit function declarations in OpenCL Could you add spe

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia added a comment. Yes, that's right. In this commit I assume parser has already accepted the blocks. We currently accept them if -fblocks is passed. I think we should also accept blocks by default with CL2.0. But I am thinking not to restrict passing -fblocks with earlier CL version.

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia added a comment. Yes, that's right. In this commit I assume parser has already accepted the blocks. We currently accept them if -fblocks is passed. I think we should also accept blocks by default with CL2.0. But I am thinking not to restrict passing -fblocks with earlier CL version.

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:6714 @@ +6713,3 @@ + if (LangOpts.OpenCLVersion >= 200 && T->isBlockPointerType()) { +const BlockPointerType *BlkTy = T->getAs(); +const FunctionProtoType *FTy = Yes, but you have to diagn

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-image.cl:3 @@ +2,3 @@ + +void test1(image1d_t *i){} // expected-error {{pointer to type 'image1d_t' is invalid in OpenCL}} + Could we add similar tests for other types too. I think we could put

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-image.cl:3 @@ +2,3 @@ + +void test1(image1d_t *i){} // expected-error {{pointer to type 'image1d_t' is invalid in OpenCL}} + Anastasia wrote: > Could we add similar tests for other types too. I

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added a comment. A few small comments! Comment at: include/clang/Basic/AttrDocs.td:1572 @@ +1571,3 @@ +The __read_only, __write_only, __read_write, read_only, write_only and +read_write names are reserved for use as access qualifiers and shall not be +used otherwise. -

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl:24 @@ -23,3 +23,3 @@ work_group_commit_read_pipe(p, tmp);// expected-error{{invalid argument type to function work_group_commit_read_pipe (expecting 'reserve_id_t')}} - sub_group_co

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D17436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D17438: [OpenCL] Add Sema checks for atomics and implicit declaration

Anastasia added a comment. I agree there seems to be nothing specifically on this topic in OpenCL spec. However, I wouldn't modify Clang and rely on its default behavior: 1. In C99 gives a warning 2. For some targets set up in a special way (i.e. SPIR) gives an error Comment a

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

Anastasia added a comment. Could you please address number 1 from my previous comment? Otherwise, I think we should try to proceed quickly here, it will be too hard to merge back in after long delay and also it would be nice to have as many corrections as possible ASAP. Could we move Richard t

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

Anastasia accepted this revision. Comment at: test/SemaOpenCL/sampler_t.cl:13 @@ -12,2 +12,3 @@ foo(5); // expected-error {{sampler_t variable required - got 'int'}} + sampler_t sa[] = {argsmp,const_smp}; // expected-error {{array of 'sampler_t' type is invalid in OpenCL}} }

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

Anastasia added a comment. In http://reviews.llvm.org/D16876#359786, @pekka.jaaskelainen wrote: > In http://reviews.llvm.org/D16876#359781, @Anastasia wrote: > > > @Pekka, do you have any more comments? > > > Nope. Looking forward to finally implementing proper pipe support to pocl. > > With the

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia removed a reviewer: pekka.jaaskelainen. Anastasia added a subscriber: pekka.jaaskelainen. Anastasia updated this revision to Diff 48826. Anastasia added a comment. I am adding a small clean up here for duplicate code! @Sam, could you please re-check again. Thanks! http://reviews.llvm.

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia added inline comments. Comment at: test/SemaOpenCL/storageclass-cl20.cl:19 @@ -15,1 +18,2 @@ + extern int G6; // expected-error{{program scope variable must reside in global or constant address space}} } Khronos bug: https://cvs.khronos.org/bugzilla/s

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-block.cl:17 @@ +16,3 @@ +void f2(BlkInt *BlockPtr) { + BlkInt B = ^int(int I) {return 1;}; + BlkInt *P = &B; // expected-error {{invalid argument type 'BlkInt' (aka 'int (^)(int)') to unary expression}} --

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1572 @@ +1571,3 @@ +The __read_only, __write_only, __read_write, read_only, write_only and +read_write names are reserved for use as access qualifiers and shall not be +used otherwise. An

Re: [PATCH] D17438: [OpenCL] Add Sema checks for atomics and implicit declaration

Anastasia added a comment. Yes, I think it deserves clarification. Could you submit a bug to Khronos then? http://reviews.llvm.org/D17438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia added inline comments. Comment at: test/SemaOpenCL/storageclass-cl20.cl:11 @@ -10,3 +10,3 @@ static global int S2 = 5; - static private int S3 = 5;// expected-error{{program scope variable must reside in global or constant address space}} + static private int S3 =

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D16040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

Anastasia added a comment. I was just wondering with SPIRV coming these days, how long should we be supporting and maintaining previous SPIR versions. Might be worth clarifying that... Comment at: lib/CodeGen/TargetInfo.cpp:7022 @@ -7021,1 +7021,3 @@ +class SPIRTargetCodeGen

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

Anastasia added a comment. Could you please change my role to the Subscriber and add Joey as a reviewer please. http://reviews.llvm.org/D17578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

Anastasia added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7211 @@ +7210,3 @@ + +/// SPIR uses emitTargetMD to emit spir spec requried metadate. +void SPIRTargetCodeGenInfo::emitTargetMD(const Decl *D, llvm::GlobalValue *GV, Could you change the comme

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

Anastasia added a comment. I think we are not covering all the possible cases with tests now! May be we could also create a separate cl file since it becomes quite large. Comment at: lib/AST/ASTContext.cpp:7605 @@ -7604,3 +7604,3 @@ // If two types are identical, they are co

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

Anastasia added a comment. Joey Gouly! Thanks! http://reviews.llvm.org/D17578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19524: [OpenCL] Fix pipe type dump.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! http://reviews.llvm.org/D19524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D19662: [OpenCL] Fix bug in mergeTypes which causes equivalent types treated as different.

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/address-spaces-conversions.cl:52 @@ -51,3 +51,3 @@ generic void *var_gen_v; - + var_gen = var_gen ? var_gen : var_gen2; // operands of the same addr spaces and the same type Inserting a white

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

Anastasia added a comment. Could you export a full diff please? There are too many small bits here to review! Thanks! Comment at: test/SemaOpenCL/extensions.cl:2 @@ +1,3 @@ +// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only +// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-

Re: [PATCH] D19662: [OpenCL] Fix bug in mergeTypes which causes equivalent types treated as different.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D19662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Apart from small comments that can be addressed directly before committing. Comment at: include/clang/Basic/OpenCLExtensions.def:18 @@ +17,3 @@ +#else +#define OP

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:14 @@ +13,3 @@ +#if __OPENCL_C_VERSION__ >= CL_VERSION_2_0 +#define _CL20_AND_ABOVE 1 +#endif Is there any reason to define this extra macro? Could we not just check __OPENCL_C_VERSION__ >= CL_VE

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

Anastasia added inline comments. Comment at: lib/Parse/ParseDecl.cpp:3519 @@ +3518,3 @@ + / 100); +const char *VerSpec = (VerMajor + std::string (".") + VerMinor).c_str(); +Diag(Tok, DiagID) << VerSpec << PrevSpec << i

RE: [Clang] Convergent Attribute

Hi Ettore, LGTM generally! I was just wondering whether it would make sense to restrict the usage of the attribute to OpenCL language i.e. to add "let LangOpts = [OpenCL];" in the attribute definition. Thanks! Anastasia -Original Message- From: Ettore Speziale [mailto:speziale.ett...

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

Anastasia added inline comments. Comment at: lib/Parse/ParseDecl.cpp:3519 @@ +3518,3 @@ + / 100); +const char *VerSpec = (VerMajor + std::string (".") + VerMinor).c_str(); +Diag(Tok, DiagID) << VerSpec << PrevSpec << i

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

Anastasia added a comment. In http://reviews.llvm.org/D19932#422374, @yaxunl wrote: > In http://reviews.llvm.org/D19932#421961, @pxli168 wrote: > > > Could we output a generic function in CodeGen? > > This seems to have no big difference to have a lot of declaration in an > > opencl c header fi

RE: [Clang] Convergent Attribute

nault [mailto:matthew.arsena...@amd.com] Sent: 07 May 2016 00:37 To: Anastasia Stulova; Ettore Speziale; Aaron Ballman Cc: nd; Clang Commits Subject: Re: [Clang] Convergent Attribute On 05/06/2016 12:11 PM, Anastasia Stulova via cfe-commits wrote: > I was just wondering whether it would make sense to restrict the

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! http://reviews.llvm.org/D19780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

Anastasia added a comment. Please, move cfe-commits to Subscribers list! http://reviews.llvm.org/D19780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

Anastasia added inline comments. Comment at: lib/Sema/SemaChecking.cpp:480 @@ +479,3 @@ + .getQualifiers().getAddressSpace() == LangAS::opencl_constant) { +S.Diag(Call->getLocStart(), diag::err_opencl_builtin_to_addr_invalid_arg) +<< Call->getArg(0) << Call->getDi

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:2055 @@ -2054,3 +2054,3 @@ - return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser, - S.LangOpts.GNUMode).isInvalid(); + return S + .VerifyIntege

RE: [Clang] Convergent Attribute

then. ;) Anastasia -Original Message- From: Hal Finkel [mailto:hfin...@anl.gov] Sent: 10 May 2016 00:33 To: Anastasia Stulova Cc: nd; Clang Commits; Matt Arsenault; Ettore Speziale; Aaron Ballman Subject: Re: [Clang] Convergent Attribute - Original Message ----- > From: "An

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

Anastasia added a comment. Sure! Will do! Thanks! I am thinking to factor out the version computation string into a common function, because we might use it in the other places too. http://reviews.llvm.org/D19780 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

Anastasia added inline comments. Comment at: test/SemaOpenCL/to_addr_builtin.cl:26 @@ +25,3 @@ +#if __OPENCL_C_VERSION__ < CL_VERSION_2_0 + // expected-error@-2{{'to_global' needs OpenCL version 2.0 or above}} +#else @Xiuli, I think Sam is right. Passing constant

r269305 - [OpenCL] Output OpenCL version in diagnostics.

Author: stulova Date: Thu May 12 11:28:25 2016 New Revision: 269305 URL: http://llvm.org/viewvc/llvm-project?rev=269305&view=rev Log: [OpenCL] Output OpenCL version in diagnostics. Diagnostics should note version dependent issues by giving a hint about current version being compiled for. This pa

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

Anastasia added a comment. Sure. Committed in r269305! Thanks! http://reviews.llvm.org/D19780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:501 @@ -500,1 +500,3 @@ def err_builtin_needs_feature : Error<"%0 needs target feature %1">; +def err_builtin_needs_opencl_version +: Error<"%0 needs OpenCL version %1%select{| or above}2"

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added a comment. In http://reviews.llvm.org/D18369#424617, @yaxunl wrote: > In http://reviews.llvm.org/D18369#424347, @pxli168 wrote: > > > In http://reviews.llvm.org/D18369#422367, @yaxunl wrote: > > > > > In http://reviews.llvm.org/D18369#421963, @pxli168 wrote: > > > > > > > If we wa

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:2055 @@ -2054,3 +2054,3 @@ - return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser, - S.LangOpts.GNUMode).isInvalid(); + return S + .VerifyIntege

[PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia created this revision. Anastasia added reviewers: bader, yaxunl. Anastasia added subscribers: pekka.jaaskelainen, pxli168, cfe-commits. An implementation of device side enqueue (DSE) - enqueue_kernel and related BIFs from OpenCL v2.0 s6.13.17. This change includes: 1. adding enqueue_k

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia added inline comments. Comment at: include/clang/Basic/Builtins.h:39 @@ -38,3 +38,3 @@ MS_LANG = 0x10, // builtin requires MS mode. - OCLC_LANG = 0x20, // builtin for OpenCL C only. + OCLC20_LANG = 0x20, // builtin for OpenCL C only. ALL_LANGUAGES = C_LANG

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:7452 @@ +7451,3 @@ + +// OpenCL v1.2 s6.12.2, v2.0 s6.13.2 - Math functions + Could you put OpenCL v1.1 section too? Comment at: lib/Headers/opencl-c.h:7767 @@ +7766,3 @@ +/** +

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:14057 @@ +14056,3 @@ +event_t __attribute__((overloadable)) async_work_group_copy(__local float2 *dst, const __global float2 *src, size_t num_elements, event_t event); +event_t __attribute__((overloadable)) async

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added a comment. Looking good already! I just have one general concern about committing 16K lines of code with no tests. But perhaps testing all the declarations isn't an option actually. Could we at least have a test that includes the header and makes sure it's compiled successfully

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Sam, Has this been addressed? @Jeroen, as far as I am aware adding supported extensions is completely new to Clang and shouldn't be braking any existing functionality that are related to that. Could you elaborate on the problem. Would creating new Clang target help? Otherwise, do you have a

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

Anastasia added a subscriber: Anastasia. Anastasia added a comment. Has this commit been merged without being approved by all the reviewers? Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp:5109 @@ -5108,3 +5108,3 @@ // natively, and does not need to interwork with AAPCS code

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! http://reviews.llvm.org/D19932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Thanks Sam! @Jeroen, could you give us more details about your problem. Anastasia -Original Message- From: Liu, Yaxun (Sam) [mailto:yaxun@amd.com] Sent: 20 May 2016 20:52 To: Anastasia Stulova; Jeroen Ketema Cc: Clang Commits; nd Subject: RE: r269670 - [OpenCL] Add supported OpenCL

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

Anastasia added a comment. LG, apart from small comments mentioned here. Comment at: lib/AST/ASTContext.cpp:7613 @@ +7612,3 @@ +if (getLangOpts().OpenCL) { + if (LHS.getUnqualifiedType() != RHS.getUnqualifiedType() || + LQuals.getCVRQualifiers() != RQuals.getCV

Re: [PATCH] D17955: [OpenCL] Fix pipe builtin bugs

Anastasia accepted this revision. Anastasia added a comment. LGTM! http://reviews.llvm.org/D17955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

Anastasia added a comment. Regarding half types since there is inconsistency in both headers (commented in CL1.2), should we just enable the extension cl_khr_fp16 in the header and then have the overloads with half there with all the other types? They shouldn't be visible to custom code unless

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

Anastasia accepted this revision. Anastasia added a comment. LGTM, except for one tiny comment that can be addressed before committing. Comment at: test/SemaOpenCL/nosvm.cl:11 @@ +10,3 @@ +// expected-warning@-4 {{'nosvm' attribute is deprecated and ignored in OpenCL version 2.

Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-block.cl:9 @@ -8,3 +8,3 @@ int (^const bl2)(); // expected-error{{invalid block variable declaration - must be initialized}} - int (^const bl3)() = ^const(){ + int (^const bl3)() = ^(){ // expected-error{{i

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM, please correct two small issues commented here! Comment at: lib/Sema/SemaExpr.cpp:169 @@ -168,4 +168,3 @@ break; - bool Warn = !D->getAttr()->isIn

<    1   2   3   4   5   6   7   >