[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. Generally LGTM! I only have one suggestion regarding testing - I feel that it makes more sense to just omit the tests that are not specific to the target itself. This is mainly because SPIR-V is now inherited from SPIR so the same logic applies in most of places. I t

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added subscribers: svenvh, bader. Anastasia added a comment. CC: @bader @svenvh Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144 ___ cfe-commits mailin

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109002/new/ https://reviews.llvm.org/D109002 ___ cfe-commits mailing list

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9972 // OpenCL v1.2 s6.8 static is invalid for kernel functions. -if ((getLangOpts().OpenCLVersion >= 120) -&& (SC == SC_Static)) { +if ((getLangOpts().getOpenCLCompatibleVersion() >= 12

[PATCH] D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109305/new/ https://reviews.llvm.org/D109305 _

[PATCH] D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109306/new/ https://reviews.llvm.org/D109306 _

[PATCH] D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109307/new/ https://reviews.llvm.org/D109307 _

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Cool! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109150/new/ https://reviews.llvm.org/D109150 ___ cfe-commits mailing list

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

Anastasia created this revision. Anastasia added reviewers: azabaznov, airlied. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Updated a section of OpenCLSupport page to reflect the latest development in OpenCL 3.0 support for release 13. This table will

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

Anastasia added a comment. @azabaznov and @airlied the main feedback I am looking for is whether I have missed any important patch and whether you agree with the judgement about the completion status. Note, that due to the release completion schedule and my planned absences it is likely that

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:392 ++--+-+-+--+--

[PATCH] D109327: [OpenCL][Docs] Release 13 notes

Anastasia created this revision. Anastasia added reviewers: azabaznov, olestrohm, Topotuna, svenvh, airlied, stuart, tstellar. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Major OpenCL functionality added in release 13. https://reviews.llvm.org/D109327

[PATCH] D109327: [OpenCL][Docs] Release 13 notes

Anastasia added a comment. Due to the release completion schedule and my planned absences, it is likely that this needs finalizing by the end of the week. Any small changes can still be added later on should you wish to improve something afterwards up until the release branch is frozen. I just

[PATCH] D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109328/new/ https://reviews.llvm.org/D109328 _

[PATCH] D109327: [OpenCL][Docs] Release 13 notes

Anastasia updated this revision to Diff 371536. Anastasia added a comment. - Addressed review comments from @Topotuna - Reordered items to group features and fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109327/new/ https://reviews.llvm.org/D109327 Files: clang/docs/ReleaseNote

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL 2021 version macros

Anastasia added inline comments. Comment at: clang/test/Preprocessor/predefined-macros.c:138 // RUN: | FileCheck -match-full-lines %s --check-prefix=CHECK-FRM -// RUN: %clang_cc1 %s -E -dM -o - -x cl -cl-std=clc++ \ +// RUN: %clang_cc1 %s -E -dM -o - -x cl -cl-std=clc++1.0 \

[PATCH] D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109370/new/ https://reviews.llvm.org/D109370 _

[PATCH] D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109424/new/ https://reviews.llvm.org/D109424

[PATCH] D109492: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109492/new/ https://reviews.llvm.org/D109492 _

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/spirv32_target.cl:12 +kernel void foo(global long *arg) { + int res1[sizeof(my_st) == 12 ? 1 : -1]; + int res2[sizeof(void *) == 4 ? 1 : -1]; Are these lines tested somehow? You could chang

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL version macros

Anastasia added inline comments. Comment at: clang/test/Preprocessor/predefined-macros.c:139 // RUN: %clang_cc1 %s -E -dM -o - -x cl -cl-std=clc++ \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=CHECK-CLCPP +// RUN: %clang_cc1 %s -E -dM -o - -x cl -cl-std=clc++1.0 \

[PATCH] D109526: [OpenCL][Docs] Added ref to libclcxx

Anastasia created this revision. Anastasia added a reviewer: olestrohm. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Linked in libclcxx GitHub project page with C++ libraries for OpenCL on OpenCLSupport page. https://reviews.llvm.org/D109526 Files:

[PATCH] D109327: [OpenCL][Docs] Release 13 notes

Anastasia closed this revision. Anastasia added a comment. this is now on the release branch https://github.com/llvm/llvm-project/commit/9723fc15338e83737d0c5f7cbf415e7f1d9d1ec3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109327/new/ https://reviews.llvm.org/D109327

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcff03d5fc487: [OpenCL][Docs] Update OpenCL 3.0 implementation status. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D109526: [OpenCL][Docs] Added ref to libclcxx

This revision was automatically updated to reflect the committed changes. Closed by commit rG9685631cbeb8: [OpenCL][Docs] Added ref to libclcxx (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D109526?vs

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/spirv32_target.cl:12 +kernel void foo(global long *arg) { + int res1[sizeof(my_st) == 12 ? 1 : -1]; + int res2[sizeof(void *) == 4 ? 1 : -1]; linjamaki wrote: > Anastasia wrote: > > Are the

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Please, address suggested test simplifications in the final commit if applicable. I am also not sure if more types should be tested from the data layout... but my guess i

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL version macros

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109366/new/ https://reviews.llvm.org/D109366 ___ cfe-commits mailing list

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in bader

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. My guess is that this is not onl

[PATCH] D109609: [C++4OpenCL] Add support for multiple address spaced destructors

Anastasia added a comment. > The feature is also C++ for OpenCL specific to let the fast path remain when > not utilizing the > address spaces, as this new implementation will be slower than the bitfields > that C++ currently > uses, but I hope this can also be optimized in the future if it turn

<    13   14   15   16   17   18