https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/66554
>From de9c8618210103074e580105ce894e66dba782a9 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Thu, 7 Sep 2023 11:32:17 -0700
Subject: [PATCH 1/3] [MSVC, ARM64] Add _Copy* and _Count* intrinsics
---
clang/incl
https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/66554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang created
https://github.com/llvm/llvm-project/pull/67174
Implement __prefetch intrinsic.
MSVC docs:
https://learn.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-170
Bug: https://github.com/llvm/llvm-project/issues/65405
>From c60ccb5cb84b7855b3a4a9
https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang created
https://github.com/llvm/llvm-project/pull/67195
None
>From d5347c906ac7db40f9b31ad0c0bcd193df453e4e Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 22 Sep 2023 13:54:28 -0700
Subject: [PATCH] Fix attr docs from previous no-unique-adderss change
---
cl
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/67195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/67195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang created
https://github.com/llvm/llvm-project/pull/67198
This reverts commit 4a55d426967b9c70f5dea7b3a389e11393a4f4c4.
Reverting because this breaks sphinx documentation, and even with it
fixed the format of the attribute makes the no_unique_address
documentation sho
https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/67198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang created
https://github.com/llvm/llvm-project/pull/67199
Change the attribute docs so that there is a separate one for the MSVC
attribute.
This reverts commit 71f9e7695b87298f9855d8890f0e6a3b89381eb5.
>From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amykhuang wrote:
Previous commit attempt caused sphinx errors. Also, because we now have two
attributes for the itanium and MSVC versions, there are two separate sections
in the documentation, which I didn't realize before.
https://github.com/llvm/llvm-project/pull/67199
__
@@ -1798,11 +1798,24 @@ def ArmMveStrictPolymorphism : TypeAttr,
TargetSpecificAttr {
let Documentation = [ArmMveStrictPolymorphismDocs];
}
-def NoUniqueAddress : InheritableAttr, TargetSpecificAttr
{
- let Spellings = [CXX11<"", "no_unique_address", 201803>];
+def NoUniq
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/67199
>From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 22 Sep 2023 14:40:14 -0700
Subject: [PATCH 1/2] Recommit "Implement [[msvc::no_unique_address]] (#65675)"
Chan
amykhuang wrote:
hmm this passes most of the checks in SemaCXX/cxx2a-no-unique-address.cpp, but
fails "attribute 'no_unique_address' cannot have an argument list". Also fails
Preprocessor/has_attribute.cpp because both attributes are recognized on
itanium and windows targets.
https://github.c
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/67199
>From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 22 Sep 2023 14:40:14 -0700
Subject: [PATCH 1/3] Recommit "Implement [[msvc::no_unique_address]] (#65675)"
Chan
amykhuang wrote:
Added a section for target specific spellings in
`GenerateHasAttrSpellingStringSwitch`, and a check for "existsInTarget" in
`ParseCXX11AttributeArgs`, and looks like all tests are passing now.
https://github.com/llvm/llvm-project/pull/67199
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/67199
>From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 22 Sep 2023 14:40:14 -0700
Subject: [PATCH 1/4] Recommit "Implement [[msvc::no_unique_address]] (#65675)"
Chan
https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Amy Huang
Date: 2023-07-26T16:13:36-07:00
New Revision: 27dab4d305acb6e0935e014c061c5317016ae2b3
URL:
https://github.com/llvm/llvm-project/commit/27dab4d305acb6e0935e014c061c5317016ae2b3
DIFF:
https://github.com/llvm/llvm-project/commit/27dab4d305acb6e0935e014c061c5317016ae2b3.diff
LOG
https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/67174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang labeled
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang created
https://github.com/llvm/llvm-project/pull/65675:
This implements the [[msvc::no_unique_address]] attribute.
There is not ABI compatibility in this patch because the attribute is
relatively new and there's still some uncertainty in the MSVC version.
Bug: ht
https://github.com/amykhuang review_requested
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang review_requested
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang review_requested
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang labeled
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang review_requested
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang review_requested
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang review_requested
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang resolved
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3055,7 +3195,7 @@ void MicrosoftRecordLayoutBuilder::injectVBPtr(const
CXXRecordDecl *RD) {
// It is possible that there were no fields or bases located after vbptr,
// so the size was not adjusted before.
if (Size < FieldStart)
- Size = FieldStart;
+
@@ -2937,14 +2964,97 @@ void MicrosoftRecordLayoutBuilder::layoutNonVirtualBase(
BaseOffset = CharUnits::Zero();
} else {
// Otherwise, lay the base out at the end of the MDC.
- BaseOffset = Size = Size.alignTo(Info.Alignment);
+ BaseOffset = DataSize
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/65675:
>From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 21 Jul 2023 16:30:30 -0700
Subject: [PATCH 1/2] Implement [[msvc::no_unique_address]]
This attribute should m
https://github.com/amykhuang resolved
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2999,17 +3139,17 @@ void MicrosoftRecordLayoutBuilder::layoutBitField(const
FieldDecl *FD) {
auto NewSize = Context.toCharUnitsFromBits(
llvm::alignDown(FieldBitOffset, Context.toBits(Info.Alignment)) +
Context.toBits(Info.Size));
-Size = std::max(S
https://github.com/amykhuang resolved
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang resolved
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4505,6 +4505,14 @@ bool FieldDecl::isZeroSize(const ASTContext &Ctx) const {
if (!CXXRD->isEmpty())
return false;
+ // MS ABI: nonzero if class type with class type fields
amykhuang wrote:
As far as I can tell the cases above still apply to MSVC so
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/65675:
>From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 21 Jul 2023 16:30:30 -0700
Subject: [PATCH 1/3] Implement [[msvc::no_unique_address]]
This attribute should m
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/65675:
>From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 21 Jul 2023 16:30:30 -0700
Subject: [PATCH 1/3] Implement [[msvc::no_unique_address]]
This attribute should m
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/65675:
>From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 21 Jul 2023 16:30:30 -0700
Subject: [PATCH 1/3] Implement [[msvc::no_unique_address]]
This attribute should m
https://github.com/amykhuang resolved
https://github.com/llvm/llvm-project/pull/65675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -55,7 +55,7 @@ CXX11(unlikely)
// CHECK: likely: 201803L
// CHECK: maybe_unused: 201603L
// ITANIUM: no_unique_address: 201803L
-// WINDOWS: no_unique_address: 0
+// WINDOWS: no_unique_address: 201803L
amykhuang wrote:
Tried this and the inheritance part w
https://github.com/amykhuang created
https://github.com/llvm/llvm-project/pull/66554
Implement the _Count* and _Copy* Windows ARM intrinsics:
```
double _CopyDoubleFromInt64(__int64)
float _CopyFloatFromInt32(__int32)
__int32 _CopyInt32FromFloat(float)
__int64 _CopyInt64FromDouble(double)
unsig
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/66554
>From 2f18bc9802942e5fa08181026212ea711f9f16a9 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Thu, 7 Sep 2023 11:32:17 -0700
Subject: [PATCH] [MSVC, ARM64] Add _Copy* and _Count* intrinsics
---
clang/include/
Author: Amy Huang
Date: 2019-10-30T16:52:39-07:00
New Revision: 6d03890384517919a3ba7fe4c35535425f278f89
URL:
https://github.com/llvm/llvm-project/commit/6d03890384517919a3ba7fe4c35535425f278f89
DIFF:
https://github.com/llvm/llvm-project/commit/6d03890384517919a3ba7fe4c35535425f278f89.diff
LOG
Author: Amy Huang
Date: 2019-10-30T17:31:12-07:00
New Revision: 004ed2b0d1b86d424643ffc88fce20ad8bab6804
URL:
https://github.com/llvm/llvm-project/commit/004ed2b0d1b86d424643ffc88fce20ad8bab6804
DIFF:
https://github.com/llvm/llvm-project/commit/004ed2b0d1b86d424643ffc88fce20ad8bab6804.diff
LOG
Author: Amy Huang
Date: 2019-11-04T09:15:26-08:00
New Revision: ab76cfdd200d35177df2042a1c0c7e86868d01bc
URL:
https://github.com/llvm/llvm-project/commit/ab76cfdd200d35177df2042a1c0c7e86868d01bc
DIFF:
https://github.com/llvm/llvm-project/commit/ab76cfdd200d35177df2042a1c0c7e86868d01bc.diff
LOG
Author: Amy Huang
Date: 2019-12-18T10:41:12-08:00
New Revision: a85f5efd9597d0036f5c347b362cb873bdf51f16
URL:
https://github.com/llvm/llvm-project/commit/a85f5efd9597d0036f5c347b362cb873bdf51f16
DIFF:
https://github.com/llvm/llvm-project/commit/a85f5efd9597d0036f5c347b362cb873bdf51f16.diff
LOG
Author: Amy Huang
Date: 2019-12-18T13:17:39-08:00
New Revision: e3fa4604076d01d2fe48d44d86fc2d6a48d4970c
URL:
https://github.com/llvm/llvm-project/commit/e3fa4604076d01d2fe48d44d86fc2d6a48d4970c
DIFF:
https://github.com/llvm/llvm-project/commit/e3fa4604076d01d2fe48d44d86fc2d6a48d4970c.diff
LOG
Author: Amy Huang
Date: 2023-06-20T17:30:20-07:00
New Revision: 015049338d7e8e0e81f2ad2f94e5a43e2e3f5220
URL:
https://github.com/llvm/llvm-project/commit/015049338d7e8e0e81f2ad2f94e5a43e2e3f5220
DIFF:
https://github.com/llvm/llvm-project/commit/015049338d7e8e0e81f2ad2f94e5a43e2e3f5220.diff
LOG
Author: Amy Huang
Date: 2023-06-22T11:42:33-07:00
New Revision: 8ed7aa59f489715d39d32e72a787b8e75cfda151
URL:
https://github.com/llvm/llvm-project/commit/8ed7aa59f489715d39d32e72a787b8e75cfda151
DIFF:
https://github.com/llvm/llvm-project/commit/8ed7aa59f489715d39d32e72a787b8e75cfda151.diff
LOG
https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/96578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amykhuang wrote:
here's a reduced example of what we ran into in Chrome. I guess the attribute
is being applied to a function that's passed to `f()`, and the warning points
to the call in the definition of `f`.
```
#define a(b) __attribute__((__availability__(android, introduced = b)))
#defin
amykhuang wrote:
nevermind, that example is working as intended
https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang approved this pull request.
Looks reasonable to me.
https://github.com/llvm/llvm-project/pull/95259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amykhuang wrote:
Yes, feel free to take over that part, thanks!
https://github.com/llvm/llvm-project/pull/95259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang approved this pull request.
lgtm!
https://github.com/llvm/llvm-project/pull/92141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang approved this pull request.
Thanks for the fix
https://github.com/llvm/llvm-project/pull/93235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Amy Huang
Date: 2022-01-07T14:42:16-08:00
New Revision: 28d2977ff236dffa2a955714aee86e798ca9acd9
URL:
https://github.com/llvm/llvm-project/commit/28d2977ff236dffa2a955714aee86e798ca9acd9
DIFF:
https://github.com/llvm/llvm-project/commit/28d2977ff236dffa2a955714aee86e798ca9acd9.diff
LOG
Author: Amy Huang
Date: 2021-03-15T15:30:55-07:00
New Revision: f5352dd9dab1ee8a2ae19a3fca3111c8b5de8ce2
URL:
https://github.com/llvm/llvm-project/commit/f5352dd9dab1ee8a2ae19a3fca3111c8b5de8ce2
DIFF:
https://github.com/llvm/llvm-project/commit/f5352dd9dab1ee8a2ae19a3fca3111c8b5de8ce2.diff
LOG
Author: Amy Huang
Date: 2021-01-15T09:28:27-08:00
New Revision: 6227069bdce6b0c3c22f0a0c8f1aef705985125a
URL:
https://github.com/llvm/llvm-project/commit/6227069bdce6b0c3c22f0a0c8f1aef705985125a
DIFF:
https://github.com/llvm/llvm-project/commit/6227069bdce6b0c3c22f0a0c8f1aef705985125a.diff
LOG
Author: Amy Huang
Date: 2021-01-15T12:05:33-08:00
New Revision: a1be47b4771467998d7549dcd1b9f9cebdaa9af9
URL:
https://github.com/llvm/llvm-project/commit/a1be47b4771467998d7549dcd1b9f9cebdaa9af9
DIFF:
https://github.com/llvm/llvm-project/commit/a1be47b4771467998d7549dcd1b9f9cebdaa9af9.diff
LOG
Author: Amy Huang
Date: 2021-01-20T12:47:35-08:00
New Revision: a3d7cee7f9bdfbe3e88e4de39a76c3d3e2690fdb
URL:
https://github.com/llvm/llvm-project/commit/a3d7cee7f9bdfbe3e88e4de39a76c3d3e2690fdb
DIFF:
https://github.com/llvm/llvm-project/commit/a3d7cee7f9bdfbe3e88e4de39a76c3d3e2690fdb.diff
LOG
Author: Amy Huang
Date: 2021-10-05T10:56:29-07:00
New Revision: c7104e506619b551ee7ab888a040114f260e8cb5
URL:
https://github.com/llvm/llvm-project/commit/c7104e506619b551ee7ab888a040114f260e8cb5
DIFF:
https://github.com/llvm/llvm-project/commit/c7104e506619b551ee7ab888a040114f260e8cb5.diff
LOG
https://github.com/amykhuang created
https://github.com/llvm/llvm-project/pull/96578
None
>From 1b436900146e1a91efac95416077485571722517 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Mon, 24 Jun 2024 16:55:08 -0700
Subject: [PATCH] Add __hlt intrinsic for Windows ARM.
---
clang/include/clan
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/96578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/96578
>From 1b436900146e1a91efac95416077485571722517 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Mon, 24 Jun 2024 16:55:08 -0700
Subject: [PATCH 1/2] Add __hlt intrinsic for Windows ARM.
---
clang/include/clang/
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/96578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/96578
>From 1b436900146e1a91efac95416077485571722517 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Mon, 24 Jun 2024 16:55:08 -0700
Subject: [PATCH 1/3] Add __hlt intrinsic for Windows ARM.
---
clang/include/clang/
amykhuang wrote:
Hi we're seeing some msan failures after this patch in tests such as
clang-tools-extra/test/clang-tidy/checkers/modernize/use-using.cpp
Here's the top of the stack trace
```
==6262==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x560847d4ff8a in
clang::DependentT
amykhuang wrote:
> We have internal reports of incorrect mangling substitutions after updating
> to
> [537b654](https://github.com/llvm/llvm-project/commit/537b6541e8067d7ef7aa38791989fca6303b7fdf)
> from
> [799e905](https://github.com/llvm/llvm-project/commit/799e9053641a6478d3144866a97737b3
101 - 175 of 175 matches
Mail list logo
