[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/102757 Currently the constexpr vectors lit test depend on CHECK to compare the vector values and IR, but after vector element access feature is implemented. This patch rewrite all tests in constexpr vectors to de

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

AmrDeveloper wrote: If you have time for review @tbaederr https://github.com/llvm/llvm-project/pull/102757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

@@ -1,10 +1,6 @@ -// RUN: %clang_cc1 -std=c++14 -Wno-unused-value %s -disable-llvm-passes -triple x86_64-linux-gnu -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -Wno-uninitialized -std=c++17 -fsyntax-only -verify AmrDeveloper wrote: To use C++ extension

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

@@ -1,10 +1,6 @@ -// RUN: %clang_cc1 -std=c++14 -Wno-unused-value %s -disable-llvm-passes -triple x86_64-linux-gnu -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -Wno-uninitialized -std=c++17 -fsyntax-only -verify AmrDeveloper wrote: Sure i will, thanks

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/102757 >From 673b9e08de8a661c9deed2ee497889312f059f3d Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 10 Aug 2024 16:54:33 +0200 Subject: [PATCH] [clang][llvm-lit] Rewrite constexpr vectors test to use ele

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

@@ -1,10 +1,6 @@ -// RUN: %clang_cc1 -std=c++14 -Wno-unused-value %s -disable-llvm-passes -triple x86_64-linux-gnu -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -Wno-uninitialized -std=c++17 -fsyntax-only -verify AmrDeveloper wrote: @tbaederr Done https

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

AmrDeveloper wrote: Should we merge now? https://github.com/llvm/llvm-project/pull/102757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

AmrDeveloper wrote: > > Should we merge now? > > Well, there seem to be some CI failures, so unless those are unrelated, > they’ll have to be resolved first. It was related to a file that not removed on the linux server `rm: cannot remove Output.TestFile: Permission deniedz https://github.co

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/102757 >From 7c594e09860fd1be7d66a7c3f99d079267581c11 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 10 Aug 2024 16:54:33 +0200 Subject: [PATCH] [clang][llvm-lit] Rewrite constexpr vectors test to use ele

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/102757 >From 7c0c21c60b70ee2970e1fa5ed414529b5bd5bc23 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 10 Aug 2024 16:54:33 +0200 Subject: [PATCH] [clang][llvm-lit] Rewrite constexpr vectors test to use ele

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

AmrDeveloper wrote: CI is happy now, i think we can merge @tbaederr, @Sirraide https://github.com/llvm/llvm-project/pull/102757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From cd1c20ce8856ca24ffea6db22a758e588f0398e2 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

@@ -15,70 +15,70 @@ // DXIL_NATIVE_HALF: define noundef half @ // SPIR_NATIVE_HALF: define spir_func noundef half @ -// DXIL_NATIVE_HALF: %hlsl.frac = call half @llvm.dx.frac.f16( -// SPIR_NATIVE_HALF: %hlsl.frac = call half @llvm.spv.frac.f16( +// DXIL_NATIVE_HALF: %hlsl.frac

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

@@ -25,7 +25,7 @@ void main(unsigned GI : SV_GroupIndex) {} //CHECK-NEXT: entry: //CHECK-NEXT: call void @"?call_me_first@@YAXXZ"() //CHECK-NEXT: call void @"?then_call_me@@YAXXZ"() -//CHECK-NEXT: %0 = call i32 @llvm.dx.flattened.thread.id.in.group() +//CHECK-NEXT: %0 =

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From f161a06ef18e52fd03809a7b73cc0aa978513344 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From 452073564bd2e5c43b7a485db2fdf1652aa3da1f Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From 027034d06257953e065ab906a567e604023a33f3 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

@@ -1,12 +1,12 @@ -// RUN: %clang_cc1 -triple spirv-vulkan-library -x hlsl -emit-llvm -disable-llvm-passes -o - %s | FileCheck %s --check-prefix=CHECK-SPIRV +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -emit-llvm -disable-llvm-passes -o - %s | FileCheck %s

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

@@ -16,262 +16,220 @@ #ifdef __HLSL_ENABLE_16_BIT // DXIL_NATIVE_HALF: define noundef i1 @ // SPIR_NATIVE_HALF: define spir_func noundef i1 @ -// DXIL_NATIVE_HALF: %hlsl.all = call i1 @llvm.dx.all.i16 -// SPIR_NATIVE_HALF: %hlsl.all = call i1 @llvm.spv.all.i16 +// DXIL_NATIVE_H

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From 1bcddd68fca3b5393ddd2c4918135d5f7fd397c2 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From f2e483e38b4b0b4ad34aa8198aad9daa48d001db Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

@@ -1,98 +1,83 @@ // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ // RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ -// RUN: --check-prefixes=CHECK,DXIL_CHECK,DXIL_NATIVE_HALF,NATIVE_

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From 33b59a3cc600081fab5d8862b521d4ea929d566a Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From 6ae18c6da6dff942ad8524d7e3aa2565369e8cfb Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From ff7bbba695a727da01ee51fcb0c1126380f6bb7f Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

@@ -1,98 +1,83 @@ // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ // RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ -// RUN: --check-prefixes=CHECK,DXIL_CHECK,DXIL_NATIVE_HALF,NATIVE_

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From 67beeaf5cf48372351e914519e7b0af3b94769b1 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

@@ -15,49 +15,49 @@ // RUN: -o - | FileCheck %s --check-prefixes=CHECK,NO_HALF,SPIR_CHECK #ifdef __HLSL_ENABLE_16_BIT -// DXIL_NATIVE_HALF: %dx.umad = call i16 @llvm.dx.umad.i16(i16 %0, i16 %1, i16 %2) +// DXIL_NATIVE_HALF: %dx.umad = call i16 @llvm.[[ICF:dx]].umad.i16(i16

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

AmrDeveloper wrote: > Looks great, thanks! Do you need someone to commit this for you? Yes please, i don't have commit access yet :D https://github.com/llvm/llvm-project/pull/105930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [clang] Increase the default expression nesting limit (PR #104717)

https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/104717 Increase the default expression nesting limit from 256 to 1024 Fixes: #94728 Compile time with different Bracket depth Clang version 20.0.0git (https://github.com/AmrDeveloper/llvm-project.git 673b9e08de

[clang] [clang] Increase the default expression nesting limit (PR #104717)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/104717 >From 8add317c1997297980a5cda12ee750f4bc24e31f Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sun, 18 Aug 2024 20:05:38 +0200 Subject: [PATCH] [clang] Increase the default expression nesting limit Incre

[clang] [clang] Increase the default expression nesting limit (PR #104717)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/104717 >From 6635b518d0413273831dc730b89b27780c6f2419 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sun, 18 Aug 2024 20:05:38 +0200 Subject: [PATCH] [clang] Increase the default expression nesting limit Incre

[clang] [clang] Increase the default expression nesting limit (PR #104717)

AmrDeveloper wrote: @AaronBallman https://github.com/llvm/llvm-project/pull/104717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Increase the default expression nesting limit (PR #104717)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/104717 >From 42eee38e3139110ad95bde697c38b23046dd2c77 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sun, 18 Aug 2024 20:05:38 +0200 Subject: [PATCH] [clang] Increase the default expression nesting limit Incre

[clang] [clang] Increase the default expression nesting limit (PR #104717)

@@ -7959,7 +7959,7 @@ def fapply_global_visibility_to_externs : Flag<["-"], "fapply-global-visibility- MarshallingInfoFlag>; def fbracket_depth : Separate<["-"], "fbracket-depth">, HelpText<"Maximum nesting level for parentheses, brackets, and braces">, - MarshallingInfoI

[clang] [clang] Increase the default expression nesting limit (PR #104717)

AmrDeveloper wrote: > Hello! Looks like increasing the max depth makes the debug build stack > overflow. In release builds, `clang/test/Parser/parser_overflow.c` is fine, > but in debug builds, the stack size reaches my OS limit (8MB) and crashes. > Shall the max depth be reduced a bit? @Aaro

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/105930 Update all hybird DXIL/SPIRV codegen tests to use temp variable representing interchange target Fixes: #105710 >From 6f7b394dc573dfb2c9ce68b5ff8ec3a933830225 Mon Sep 17 00:00:00 2001 From: AmrDeveloper D

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

AmrDeveloper wrote: @pow2clk https://github.com/llvm/llvm-project/pull/105930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use temp var (PR #105930)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/105930 >From 4568aab8bfd39be10a3df69535e083f3429e3a9e Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 Aug 2024 10:08:23 +0200 Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From dea97ae4f893774489bfd423e9536e486f022bb9 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

@@ -1217,6 +1217,8 @@ static void handlePreferredName(Sema &S, Decl *D, const ParsedAttr &AL) { bool Sema::isValidPointerAttrType(QualType T, bool RefOkay) { if (RefOkay) { +if (T->isDependentType()) AmrDeveloper wrote: Think you, updated https://gith

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From 076c867c16141f2c1b78c55fd78250155c0d97fd Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

@@ -4453,9 +4453,9 @@ class Sema final : public SemaBase { SourceLocation *ArgLocation = nullptr); /// Determine if type T is a valid subject for a nonnull and similar - /// attributes. By default, we look through references (the behavi

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/111573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

AmrDeveloper wrote: > > This part in ObjectiveC tests conflict with the current solution, any > > suggestion how we can go around it right now until to be handled later > > https://github.com/llvm/llvm-project/blob/18952bdcd6f987620e6396261c2bb444e428e07e/clang/test/SemaObjCXX/noescape.mm#L202-L

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

@@ -4453,9 +4453,9 @@ class Sema final : public SemaBase { SourceLocation *ArgLocation = nullptr); /// Determine if type T is a valid subject for a nonnull and similar - /// attributes. By default, we look through references (the behavi

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/111573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/111573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From 3e83fd9e73520bfeefd5a39da6daad172cfb2512 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From d3f853895e806ebe2370dafdc628a21d0d4184a6 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

AmrDeveloper wrote: > > This part in ObjectiveC tests conflict with the current solution, any > > suggestion how we can go around it right now until to be handled later > > https://github.com/llvm/llvm-project/blob/18952bdcd6f987620e6396261c2bb444e428e07e/clang/test/SemaObjCXX/noescape.mm#L202-L

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From a0066f706b1173afe573ddd5f79cb5c8916a19cf Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From 0f1405efdbb6a9bc24c878346d96ae6720771a44 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

AmrDeveloper wrote: This part in ObjectiveC tests conflict with the current solution, any suggestion how we can go around it right now until to be handled later https://github.com/llvm/llvm-project/blob/18952bdcd6f987620e6396261c2bb444e428e07e/clang/test/SemaObjCXX/noescape.mm#L202-L205 @erich

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/111573 Fix `assume_aligned` incorrectly diagnoses a dependent return type Fixes: #111563 >From fd3247ecb2fb2c83e8441d082a446c85e6268146 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

@@ -1216,6 +1216,8 @@ static void handlePreferredName(Sema &S, Decl *D, const ParsedAttr &AL) { } bool Sema::isValidPointerAttrType(QualType T, bool RefOkay) { + if (T->isDependentType()) AmrDeveloper wrote: Done, please check the updated documentation of t

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From 4202153623dd64cec76b6ca9a08191ff884327a7 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From 036f76530beca7f6fddae1460a5fd527a71bcf94 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/111573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/118031 Currently, we support `-wdeprecated-array-compare` for C++20 or above and don't report any warning for older versions, this PR supports `-Warray-compare` for older versions and for GCC compatibility. Fixe

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 1/6] Add support for '-Warray-compare' compiler flag --- cl

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 1/5] Add support for '-Warray-compare' compiler flag --- cl

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

@@ -10264,6 +10264,10 @@ def warn_depr_array_comparison : Warning< "to compare array addresses, use unary '+' to decay operands to pointers">, InGroup; +def warn_array_comparison : Warning< + "comparison between two arrays compare their addresses and will be deprecated i

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

AmrDeveloper wrote: All comments are addressed, please take a second look. https://github.com/llvm/llvm-project/pull/118031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 01/12] Add support for '-Warray-compare' compiler flag ---

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

@@ -702,6 +702,7 @@ def GNUStatementExpressionFromMacroExpansion : def GNUStatementExpression : DiagGroup<"gnu-statement-expression", [GNUStatementExpressionFromMacroExpansion]>; def StringConcatation : DiagGroup<"string-concatenation">;

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 1/8] Add support for '-Warray-compare' compiler flag --- cl

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/118031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

AmrDeveloper wrote: @shafik, @cor3ntin For C++26 there is already an issue and discussion their and i will handle it after landing this PR https://github.com/llvm/llvm-project/issues/117859 https://github.com/llvm/llvm-project/pull/118031 ___ cfe-com

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

@@ -10264,6 +10264,10 @@ def warn_depr_array_comparison : Warning< "to compare array addresses, use unary '+' to decay operands to pointers">, InGroup; +def warn_array_comparison : Warning< + "comparison between two arrays compare their addresses and will be deprecated i

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/118031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/118031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

@@ -10264,6 +10264,11 @@ def warn_depr_array_comparison : Warning< "to compare array addresses, use unary '+' to decay operands to pointers">, InGroup; +def warn_array_comparison : Warning< + "comparison between two arrays; " AmrDeveloper wrote: I think

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 01/11] Add support for '-Warray-compare' compiler flag ---

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 01/10] Add support for '-Warray-compare' compiler flag ---

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 1/8] Add support for '-Warray-compare' compiler flag --- cl

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

@@ -10264,6 +10264,11 @@ def warn_depr_array_comparison : Warning< "to compare array addresses, use unary '+' to decay operands to pointers">, InGroup; +def warn_array_comparison : Warning< + "comparison between two arrays; " AmrDeveloper wrote: I am thi

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 1/7] Add support for '-Warray-compare' compiler flag --- cl

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

AmrDeveloper wrote: Should we merge now? @cor3ntin @AaronBallman @erichkeane @shafik https://github.com/llvm/llvm-project/pull/118031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

AmrDeveloper wrote: > yes. do you need me to do it? Thanks, i will merge now :D https://github.com/llvm/llvm-project/pull/118031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/118031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/118872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

AmrDeveloper wrote: > > We can also create a new matcher for `dependentNameType` so we can use it > > like `dependentNameType(hasDependentType(builtinType()))`, which is similar > > to Complex and Array types. > > I don't think `DependentNameType` has a `Type` property that we could match > i

[clang] [Clang][ASTMatcher] Add `dependentTemplateSpecializationType` AST mat… (PR #121435)

@@ -2546,6 +2546,17 @@ Node Matchers }; +MatcherType>dependentTemplateSpecializationTypeMatcherDependentTemplateSpecializationT

[clang] [Clang][ASTMatcher] Add `dependentTemplateSpecializationType` AST mat… (PR #121435)

https://github.com/AmrDeveloper requested changes to this pull request. https://github.com/llvm/llvm-project/pull/121435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ASTMatcher] Add `dependentTemplateSpecializationType` AST mat… (PR #121435)

@@ -1113,6 +1113,8 @@ AST Matchers - Add ``dependentNameType`` matcher to match a dependent name type. +- Add ``dependentTemplateSpecializationType`` matcher to match dependent template specialization types. AmrDeveloper wrote: ```suggestion - Add ``depende

[clang] [Clang][ASTMatcher] Extend `hasDependentName` to match DependentNameType name (PR #121975)

https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/121975 Extending the `hasDependentName` to be a polymorphic matcher that matches the dependent name of `DependentNameType` or `DependentScopeDeclRefExpr` >From 353f3ca4e997f658c65570e75749220e1abcad72 Mon Sep 17

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

AmrDeveloper wrote: > Thanks! The update looks good, I have one more minor suggestion for a change > which I'll just go ahead and make before merging. Thank you https://github.com/llvm/llvm-project/pull/121656 ___ cfe-commits mailing list cfe-commits

[clang] [Clang][ASTMatcher] Add a matcher for the name of a DependentScopeDeclRefExpr (PR #121656)

AmrDeveloper wrote: @HighCommander4 We can also create a new matcher for `dependentNameType` so we can use it like `dependentNameType(hasDependentType(builtinType()))`, which is similar to Complex and Array types. If confirmed I can work on it too :D Thank you https://github.com/llvm/llvm-

[clang] [Clang][ASTMatcher] Add `dependentNameType` Matcher (PR #121263)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/121263 >From bdbd11db849506c4d99036dd674f03d1eda815cc Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 28 Dec 2024 13:23:33 +0100 Subject: [PATCH 1/2] [Clang][ASTMatcher] Add `dependentNameType` Matcher ---

[clang] [Clang][ASTMatcher] Add `dependentNameType` Matcher (PR #121263)

@@ -218,6 +218,7 @@ RegistryMaps::RegistryMaps() { REGISTER_MATCHER(cxxTryStmt); REGISTER_MATCHER(cxxUnresolvedConstructExpr); REGISTER_MATCHER(decayedType); + REGISTER_MATCHER(dependentNameType); AmrDeveloper wrote: Done, thank you https://github.com/

[clang] [Clang][ASTMatcher] Add `dependentNameType` Matcher (PR #121263)

@@ -7711,6 +7711,16 @@ AST_MATCHER_P(DecayedType, hasDecayedType, internal::Matcher, return InnerType.matches(Node.getDecayedType(), Finder, Builder); } +/// Matches dependent name type AmrDeveloper wrote: Done https://github.com/llvm/llvm-project/pull/12

[clang] [Clang][ASTMatcher] Add `dependentNameType` Matcher (PR #121263)

@@ -2536,6 +2536,15 @@ Node Matchers matches "decltype(i + j)" +MatcherStmt>dependentNameTypeMatcherDependentNameType>... AmrDev

[clang] [Clang][ASTMatcher] Add `dependentNameType` Matcher (PR #121263)

@@ -1912,6 +1912,21 @@ TEST_P(ASTMatchersTest, DeducedTemplateSpecializationType) { deducedTemplateSpecializationType())); } +TEST_P(ASTMatchersTest, DependentNameType) { + if (!GetParam().isCXX()) { +// FIXME: Add a test for `dependentNameType()` that does

[clang] [Clang][ASTMatcher] Add `dependentNameType` Matcher (PR #121263)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/121263 >From bdbd11db849506c4d99036dd674f03d1eda815cc Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 28 Dec 2024 13:23:33 +0100 Subject: [PATCH 1/3] [Clang][ASTMatcher] Add `dependentNameType` Matcher ---

[clang] [Clang][ASTMatcher] Add `dependentScopeDeclRefExpr` Matcher (PR #120996)

https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/120996 >From a0b71504fa31e55d42cb54e349838b2669f6fde5 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Mon, 23 Dec 2024 19:42:30 +0100 Subject: [PATCH 1/2] [Clang][ASTMatcher] Add `dependentScopeDeclRefExpr` Mat

[clang] [Clang][ASTMatcher] Add `dependentScopeDeclRefExpr` Matcher (PR #120996)

@@ -556,6 +556,22 @@ TEST_P(ASTMatchersTest, DeclRefExpr) { Reference)); } +TEST_P(ASTMatchersTest, DependentScopeDeclRefExpr) { + if (!GetParam().isCXX() || GetParam().hasDelayedTemplateParsing()) { +// FIXME: Add a test for `dependentScopeDeclRe

[clang] [Clang][ASTMatcher] Add `dependentNameType` Matcher (PR #121263)

AmrDeveloper wrote: > ~@AmrDeveloper if you're not tired of these yet, I have one final one: > #121307~ > > (Update: that one's been taken by another contributor.) Thank you, if you found another one, I will be interested to work on it, you can assign me directly :D https://github.com/llvm/l

[clang] [Clang][ASTMatcher] Add `dependentScopeDeclRefExpr` Matcher (PR #120996)

AmrDeveloper wrote: > #121240 Sure, i am interested, Thank you :D https://github.com/llvm/llvm-project/pull/120996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ASTMatcher] Add `dependentNameType` Matcher (PR #121263)

https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/121263 Add AST Matcher for `DependentNameType` Fixes: https://github.com/llvm/llvm-project/issues/121240 >From 21873d01238f8da0eb0f19656801347400afae65 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 28 D

  1   2   3   >