Alpha updated this revision to Diff 81779.
Alpha added a comment.
It was tested against the clang extra unit tests, but not tests run with
check-clang-tools.
Updated Yaml test files to match the new format, this might need further review.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Alpha added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alpha updated this revision to Diff 82860.
Alpha added a comment.
Rebase on top of HEAD.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/DiagnosticsYaml.h
include/c
Alpha added a comment.
Thanks for the review!
Comment at: tools/extra/clang-tidy/ClangTidy.cpp:106
void reportDiagnostic(const ClangTidyError &Error) {
-const ClangTidyMessage &Message = Error.Message;
+const ClangTidyMessage Message = Error.Message;
SourceLocat
Alpha added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alpha marked 10 inline comments as done.
Alpha added inline comments.
Comment at: include/clang/Tooling/DiagnosticsYaml.h:79
+ for (auto &Diagnostic : Doc.Diagnostics) {
+if (Diagnostic.Fix.size() > 0) {
+ Diagnostics.push_back(Diagnostic);
Alpha updated this revision to Diff 79899.
Herald added a subscriber: JDevlieghere.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/DiagnosticsYaml.h
include/clang/Tooling/
Alpha updated this revision to Diff 79904.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/DiagnosticsYaml.h
include/clang/Tooling/ReplacementsYaml.h
lib/Tooling/Core/CMa
Alpha updated this revision to Diff 79917.
Alpha added a comment.
Rebase on top of HEAD.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/DiagnosticsYaml.h
include/clang/T
Alpha added a comment.
I don't have commit access.
Thank you for the review @alexfh
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Alpha updated this revision to Diff 80732.
Alpha added a comment.
Rebase on top of HEAD.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/DiagnosticsYaml.h
include/c
Alpha updated this revision to Diff 80874.
Alpha added a comment.
Fix clang compilation warnings. These didn't appear when compiled on Windows.
Tested on a Linux distribution, should be fixed.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.
12 matches
Mail list logo