[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

2018-08-29 Thread Alistair Davies via Phabricator via cfe-commits
AlistairD created this revision. AlistairD added a reviewer: yaxunl. This change adds a warning if a parameter is passed with named address space to parameter that is in generic address space. For example: int i; to_private(&i); //generate warning as conversion from private to private is r

[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

2018-09-06 Thread Alistair Davies via Phabricator via cfe-commits
AlistairD updated this revision to Diff 164162. AlistairD added a comment. Reworded warning message, switched warning off by default, and added it to a group: generic-address-conversion. https://reviews.llvm.org/D51411 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking

[PATCH] D51727: [OpenCL] Allow zero assignment and comparisons between queue_t type variables

2018-09-06 Thread Alistair Davies via Phabricator via cfe-commits
AlistairD created this revision. AlistairD added reviewers: yaxunl, bader. This change allows for zero assignment and comparison of queue_t type variables, and extends null_queue.cl to test this. https://reviews.llvm.org/D51727 Files: lib/Sema/SemaExpr.cpp test/SemaOpenCL/null_queue.cl I

[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

2018-09-11 Thread Alistair Davies via Phabricator via cfe-commits
AlistairD updated this revision to Diff 164835. https://reviews.llvm.org/D51411 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/SemaOpenCL/to_addr_builtin.cl Index: test/SemaOpenCL/to_addr_builtin.cl

[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

2018-09-11 Thread Alistair Davies via Phabricator via cfe-commits
AlistairD added a comment. Reworded warning message, switched warning off by default, and added it to -Wconversion group https://reviews.llvm.org/D51411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D52020: [OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests

2018-09-13 Thread Alistair Davies via Phabricator via cfe-commits
AlistairD created this revision. AlistairD added a reviewer: yaxunl. Adds cl_khr_depth_images to extension-version.cl, and extends to_addr_builtin.cl. https://reviews.llvm.org/D52020 Files: test/SemaOpenCL/extension-version.cl test/SemaOpenCL/to_addr_builtin.cl Index: test/SemaOpenCL/to_a