r253866 - [OPENMP] 'out' dependency for 'task' directives must be the same as 'inout'.

2015-11-23 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Nov 23 07:33:42 2015 New Revision: 253866 URL: http://llvm.org/viewvc/llvm-project?rev=253866&view=rev Log: [OPENMP] 'out' dependency for 'task' directives must be the same as 'inout'. Runtime library requires, that codegen for 'depend' clause for 'out' dependency kind m

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-23 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 41004. ABataev added a comment. Renamed MCU target class http://reviews.llvm.org/D14864 Files: lib/Basic/Targets.cpp test/Sema/callingconv-iamcu.c Index: lib/Basic/Targets.cpp === --- lib/

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

2015-11-24 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 41018. ABataev added a comment. Update after review http://reviews.llvm.org/D13336 Files: include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/StmtNodes.td include/clang/Serialization/ASTBitCodes.h lib/AST/Expr.c

r253977 - [OPENMP] Fix crash on codegen for 'task' directive with no shared variables.

2015-11-24 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Nov 24 07:01:44 2015 New Revision: 253977 URL: http://llvm.org/viewvc/llvm-project?rev=253977&view=rev Log: [OPENMP] Fix crash on codegen for 'task' directive with no shared variables. If 'task' region does not have shared variables codegen could crash on calculation of

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-25 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254063: [X86] Support for C calling convention only for MCU target. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D14864?vs=41004&id=41115#toc Repository: rL LLVM http://re

r254063 - [X86] Support for C calling convention only for MCU target.

2015-11-25 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Nov 25 03:24:26 2015 New Revision: 254063 URL: http://llvm.org/viewvc/llvm-project?rev=254063&view=rev Log: [X86] Support for C calling convention only for MCU target. For MCU only C calling convention is allowed, all other calling conventions are not supported. Differen

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

2015-11-25 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Richard, could you take a look one more time, please? http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

2015-11-25 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Richard, any comments? http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r254067 - [MSVC] 'property' with an empty array in array subscript expression.

2015-11-25 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Nov 25 06:01:00 2015 New Revision: 254067 URL: http://llvm.org/viewvc/llvm-project?rev=254067&view=rev Log: [MSVC] 'property' with an empty array in array subscript expression. MSVC supports 'property' attribute and allows to apply it to the declaration of an empty array

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

2015-11-25 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254067: [MSVC] 'property' with an empty array in array subscript expression. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13336?vs=41018&id=41125#toc Repository: rL LLVM

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

2015-11-25 Thread Alexey Bataev via cfe-commits
ABataev added a comment. John, thanks a lot for the review! Committed version has a fix according to your last comment. Repository: rL LLVM http://reviews.llvm.org/D13336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

r254141 - [OPENMP 4.5] Fixed rules for 'ordered' clause.

2015-11-25 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Nov 26 01:50:39 2015 New Revision: 254141 URL: http://llvm.org/viewvc/llvm-project?rev=254141&view=rev Log: [OPENMP 4.5] Fixed rules for 'ordered' clause. According to OpenMP 4.5 the parameter of 'ordered' clause must be greater than or equal to the parameter of 'collaps

Re: [PATCH] D14940: [OpenMP] Update target directive codegen to use 4.5 implicit data mappings.

2015-11-25 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/Stmt.h:2018-2020 @@ -2016,2 +2017,5 @@ break; + case VCK_ByCopy: +assert(Var && "capturing by copy must have a variable!"); +break; case VCK_VLAType: Also add asserti

Re: [PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

2015-11-26 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5220-5242 @@ -5216,2 +5219,25 @@ +static bool IsNonNegativeIntegerValue(Expr *&ValExpr, Sema &SemaRef, + OpenMPClauseKind CKind) { + if (!ValExpr->isTypeDependent() && !ValEx

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

2015-11-30 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Richard, could you take a look one more time, please? http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

2015-11-30 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Ping http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

2015-12-02 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:667 @@ -666,3 +666,3 @@ OpenMPScheduleClauseKind Kind; - /// \brief Start location of the schedule ind in source code. + /// \brief Start location of the schedule kind in source code. SourceLocatio

[PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-02 Thread Alexey Bataev via cfe-commits
ABataev created this revision. ABataev added reviewers: rnk, rjmccall. ABataev added a subscriber: cfe-commits. All problems described in http://llvm.org/PR25636 are implemented except for return value of the 'put' property. This patch fixes this problem with the indexed properties http://revie

r254596 - PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type, patch by D. Polukhin

2015-12-03 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Dec 3 03:34:49 2015 New Revision: 254596 URL: http://llvm.org/viewvc/llvm-project?rev=254596&view=rev Log: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type, patch by D. Polukhin This CL is for discussion how to better fix bit-filed layout comp

Re: [PATCH] D14872: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type

2015-12-03 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254596: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D14872?vs=41648&id=41724#toc Repository: rL

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-04 Thread Alexey Bataev via cfe-commits
John, the result is always the result of Put operation. For pre-increment we have to return new value, for the post-increment - previous value returned by Get (checked it on MSVC). So, currently postincrement works correctly, pre-increment and assignment not. For pre-increment and assignment we

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

2015-12-04 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang-c/Index.h:2263-2267 @@ -2262,3 +2262,7 @@ - CXCursor_LastStmt = CXCursor_OMPTaskLoopDirective, + /** \brief OpenMP distribute directive. + */ + CXCursor_OMPDistributeDirective= 259, + +

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-04 Thread Alexey Bataev via cfe-commits
John, Actually both, subscripts and references. Ok, got will do. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 04.12.2015 12:00, John McCall пишет: > rjmccall added a comment. > > In http://reviews.llvm.org/D15174#302248, @ABataev wrote: > >> John, >> the resul

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-04 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 41848. ABataev added a comment. Update after review http://reviews.llvm.org/D15174 Files: lib/Sema/SemaPseudoObject.cpp test/CodeGenCXX/ms-property.cpp test/SemaCXX/ms-property-error.cpp test/SemaCXX/ms-property.cpp Index: lib/Sema/SemaPseudoObject

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-06 Thread Alexey Bataev via cfe-commits
ABataev marked 2 inline comments as done. Comment at: lib/Sema/SemaPseudoObject.cpp:232 @@ -231,3 +231,3 @@ /// Return true if assignments have a non-void result. -bool CanCaptureValue(Expr *exp) { +bool CanCaptureValue(Expr *exp) const { if (exp->isGLValue())

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

2015-12-06 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Tests? Repository: rL LLVM http://reviews.llvm.org/D15220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-06 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 42026. ABataev marked 2 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D15174 Files: lib/Sema/SemaPseudoObject.cpp test/CodeGenCXX/ms-property.cpp test/SemaCXX/ms-property-error.cpp test/SemaCXX/ms-prop

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-06 Thread Alexey Bataev via cfe-commits
John, Your example won't be compiled at all. Clang and MSVC emit error messages in this case. The next code struct A { __declspec(property(get=GetX,put=SetX)) int x; int GetX() const { return 0; } void SetX(long y) {} }; a.x = 5; compiled fine by MSVC and clang and provides c

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-07 Thread Alexey Bataev via cfe-commits
Set value is a call to SetX() function, neither the argument of the SetX(), nor the result of the GetX(). So, expression a.x=5 always emits the following code as a result a.Setx(5). MSPropertyRefBuilder::buildSet() does not capture results at all. It just ignores captureSetValueAsResult value

r254899 - [OPENMP 4.5] parsing/sema support for 'nogroup' clause.

2015-12-07 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Dec 7 04:51:44 2015 New Revision: 254899 URL: http://llvm.org/viewvc/llvm-project?rev=254899&view=rev Log: [OPENMP 4.5] parsing/sema support for 'nogroup' clause. OpenMP 4.5 adds 'taskloop' and 'taskloop simd' directives. These directives have new 'nogroup' clause. Patc

r254903 - [OPENMP 4.5] parsing/sema support for 'grainsize' clause.

2015-12-07 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Dec 7 06:52:51 2015 New Revision: 254903 URL: http://llvm.org/viewvc/llvm-project?rev=254903&view=rev Log: [OPENMP 4.5] parsing/sema support for 'grainsize' clause. OpenMP 4.5 adds 'taksloop' and 'taskloop simd' directives, which have 'grainsize' clause. Patch adds pars

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

2015-12-07 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Carlo, 1. please post your diffs exactly as said in http://llvm.org/docs/Phabricator.html, with full context available. 2. add a test with ast-printing, serialization/deserialization Comment at: include/clang/Basic/OpenMPKinds.def:394-399 @@ -394,1 +39

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-07 Thread Alexey Bataev via cfe-commits
Ok, I will implement this logic Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 07.12.2015 22:30, John McCall пишет: > rjmccall added a comment. > > Oh, I see, of course. > > It would be clearer if you asked the subclass which value to use abstractly > (i.e. indep

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-07 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Michael, please provide full diff log, as described in http://llvm.org/docs/Phabricator.html (with full context) Repository: rL LLVM http://reviews.llvm.org/D15321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-07 Thread Alexey Bataev via cfe-commits
ABataev added a comment. I think we'd better to try to use attributes for declare target. I think it will be much easier and correct solution rather than adding a new declaration Comment at: include/clang/AST/DeclBase.h:164 @@ -163,3 +163,3 @@ /// has been declared outside

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-07 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 42140. ABataev added a comment. Update after review http://reviews.llvm.org/D15174 Files: lib/Sema/SemaPseudoObject.cpp test/CodeGenCXX/ms-property.cpp test/SemaCXX/ms-property-error.cpp test/SemaCXX/ms-property.cpp Index: lib/Sema/SemaPseudoObject

r255008 - [OPENMP 4.5] Parsing/sema for 'num_tasks' clause.

2015-12-08 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 8 06:06:20 2015 New Revision: 255008 URL: http://llvm.org/viewvc/llvm-project?rev=255008&view=rev Log: [OPENMP 4.5] Parsing/sema for 'num_tasks' clause. OpenMP 4.5 adds directives 'taskloop' and 'taskloop simd'. These directives support clause 'num_tasks'. Patch add

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

2015-12-09 Thread Alexey Bataev via cfe-commits
Hi Hans, I asked Chandler to look at this once again but seems to me he is very busy. Maybe you could ping him also? Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 09.12.2015 0:35, Hans Wennborg пишет: > hans added a comment. > > Alexey & Chandler: Is there any o

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-09 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 42282. ABataev added a comment. Update after review http://reviews.llvm.org/D15174 Files: lib/Sema/SemaPseudoObject.cpp test/CodeGenCXX/ms-property.cpp test/SemaCXX/ms-property-error.cpp test/SemaCXX/ms-property.cpp Index: lib/Sema/SemaPseudoObject

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-09 Thread Alexey Bataev via cfe-commits
ABataev marked an inline comment as done. Comment at: lib/Sema/SemaPseudoObject.cpp:259 @@ +258,3 @@ +/// +/// If this method returns false, and the set value isn't capturable for +/// some reason, the result of the expression will be void. rjmccall wr

r255218 - [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-09 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Dec 9 22:38:18 2015 New Revision: 255218 URL: http://llvm.org/viewvc/llvm-project?rev=255218&view=rev Log: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly. All problems described in http://llvm.org/PR25636 are implemented except

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-09 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. ABataev marked an inline comment as done. Closed by commit rL255218: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D15174?vs

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

2015-12-09 Thread Alexey Bataev via cfe-commits
ABataev marked an inline comment as done. ABataev added a comment. Chandler, thank you very much for review! Comment at: docs/GettingStarted.rst:58-62 @@ -57,1 +57,7 @@ +#. Checkout Libomp (required for OpenMP support) **[Optional]**: + + * ``cd where-you-want-llvm-to-live``

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

2015-12-09 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. ABataev marked an inline comment as done. Closed by commit rL255222: [OPENMP] Make -fopenmp to turn on OpenMP support by default. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13802?vs=38374&id=

Re: [PATCH] D13803: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part

2015-12-09 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255223: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13803?vs=37574&id=42384#toc Repository: rL LLV

r255223 - [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part

2015-12-09 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Dec 9 23:47:10 2015 New Revision: 255223 URL: http://llvm.org/viewvc/llvm-project?rev=255223&view=rev Log: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots. Differentia

r255229 - [OPENMP] Fixed processing of predetermined data-sharing attributes

2015-12-10 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Dec 10 02:20:58 2015 New Revision: 255229 URL: http://llvm.org/viewvc/llvm-project?rev=255229&view=rev Log: [OPENMP] Fixed processing of predetermined data-sharing attributes Predetermined data-shared attributes for local variables are now considered as implicit. Also, p

r255487 - [OPENMP] Fix debug info for 'atomic' construct.

2015-12-14 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Dec 14 03:26:19 2015 New Revision: 255487 URL: http://llvm.org/viewvc/llvm-project?rev=255487&view=rev Log: [OPENMP] Fix debug info for 'atomic' construct. Debug info for statement under 'atomic' construct must point exactly to that statement, not the directive itself.

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-14 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:209 @@ -142,2 +208,3 @@ case OMPD_taskloop_simd: + default: Diag(Tok, diag::err_omp_unexpected_directive) fraggamuffin wrote: > ABataev wrote: > > Do not add default:, coding standard re

r255625 - [OPENMP 4.5] Parsing/sema for 'hint' clause of 'critical' directive.

2015-12-15 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 15 02:19:24 2015 New Revision: 255625 URL: http://llvm.org/viewvc/llvm-project?rev=255625&view=rev Log: [OPENMP 4.5] Parsing/sema for 'hint' clause of 'critical' directive. OpenMP 4.5 adds 'hint' clause to critical directive. Patch adds parsing/semantic analysis for

r255639 - [OPENMP 4.5] Codegen for 'hint' clause of 'critical' directive

2015-12-15 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 15 04:55:09 2015 New Revision: 255639 URL: http://llvm.org/viewvc/llvm-project?rev=255639&view=rev Log: [OPENMP 4.5] Codegen for 'hint' clause of 'critical' directive OpenMP 4.5 defines 'hint' clause for 'critical' directive. Patch adds codegen for this clause. Modi

r255640 - [OPENMP 4.5] Fix test compatibility with 32 bit mode.

2015-12-15 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 15 05:38:29 2015 New Revision: 255640 URL: http://llvm.org/viewvc/llvm-project?rev=255640&view=rev Log: [OPENMP 4.5] Fix test compatibility with 32 bit mode. Modified: cfe/trunk/test/OpenMP/critical_codegen.cpp Modified: cfe/trunk/test/OpenMP/critical_codegen.cp

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

2015-12-16 Thread Alexey Bataev via cfe-commits
ABataev added a comment. In http://reviews.llvm.org/D10599#312135, @rjmccall wrote: > Richard should really be the one to sign off on this, since he's been > managing the review so far. > > I am curious why we decided to handle this separately instead of treating it > as a different attribute s

r255879 - [OPENMP] Fix for http://llvm.org/PR25142: openmp: Assertion failed: DD && "queried property of class with no definition", file AST/DeclCXX.h

2015-12-16 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Dec 17 00:55:08 2015 New Revision: 255879 URL: http://llvm.org/viewvc/llvm-project?rev=255879&view=rev Log: [OPENMP] Fix for http://llvm.org/PR25142: openmp: Assertion failed: DD && "queried property of class with no definition", file AST/DeclCXX.h Added processing for t

r255986 - [OPENMP 4.5] Parsing/sema analysis for 'depend(source)' clause in 'ordered' directive.

2015-12-17 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Dec 17 23:05:56 2015 New Revision: 255986 URL: http://llvm.org/viewvc/llvm-project?rev=255986&view=rev Log: [OPENMP 4.5] Parsing/sema analysis for 'depend(source)' clause in 'ordered' directive. OpenMP 4.5 adds 'depend(source)' clause for 'ordered' directive to support

r255990 - [OPENMP] Fix for http://llvm.org/PR25878: Error compiling an OpenMP program

2015-12-18 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Dec 18 01:58:25 2015 New Revision: 255990 URL: http://llvm.org/viewvc/llvm-project?rev=255990&view=rev Log: [OPENMP] Fix for http://llvm.org/PR25878: Error compiling an OpenMP program OpenMP codegen tried to emit the code for its constructs even if it was detected as a d

Re: [PATCH] D15561: [OpenMP] Remove explicit call for implicit barrier

2015-12-18 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255992: [OPENMP] Remove explicit call for implicit barrier (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D15561?vs=42984&id=43210#toc Repository: rL LLVM http://reviews.llv

r255992 - [OPENMP] Remove explicit call for implicit barrier

2015-12-18 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Dec 18 04:24:53 2015 New Revision: 255992 URL: http://llvm.org/viewvc/llvm-project?rev=255992&view=rev Log: [OPENMP] Remove explicit call for implicit barrier #pragma omp parallel needs an implicit barrier that is currently done by an explicit call to __kmpc_barrier. How

Re: [PATCH] D15561: [OpenMP] Remove explicit call for implicit barrier

2015-12-18 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Fixed tests and committed. Thanks! Repository: rL LLVM http://reviews.llvm.org/D15561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-21 Thread Alexey Bataev via cfe-commits
ABataev created this revision. ABataev added reviewers: aaron.ballman, rjmccall. ABataev added a subscriber: cfe-commits. This attribute may be attached to a function definition and instructs the backend to generate appropriate function entry/exit code so that it can be used directly as an interru

r256238 - [OPENMP 4.5] Parsing/sema for 'depend(sink:vec)' clause in 'ordered' directive.

2015-12-22 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 22 06:21:47 2015 New Revision: 256238 URL: http://llvm.org/viewvc/llvm-project?rev=256238&view=rev Log: [OPENMP 4.5] Parsing/sema for 'depend(sink:vec)' clause in 'ordered' directive. OpenMP 4.5 adds 'depend(sink:vec)' in 'ordered' directive for doacross loop synchro

r256239 - [OPENMP] Revert r256238 to fix the problem with tests on Linux.

2015-12-22 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 22 06:44:46 2015 New Revision: 256239 URL: http://llvm.org/viewvc/llvm-project?rev=256239&view=rev Log: [OPENMP] Revert r256238 to fix the problem with tests on Linux. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/include/clang/Basi

r256330 - [OPENMP 4.5] Parsing/sema for 'depend(sink:vec)' clause in 'ordered' directive.

2015-12-23 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Dec 23 04:27:45 2015 New Revision: 256330 URL: http://llvm.org/viewvc/llvm-project?rev=256330&view=rev Log: [OPENMP 4.5] Parsing/sema for 'depend(sink:vec)' clause in 'ordered' directive. OpenMP 4.5 adds 'depend(sink:vec)' in 'ordered' directive for doacross loop synchro

r256417 - [OPENMP] Do not allow to use threadprivate or thread local variables as loop iteration variables.

2015-12-25 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Dec 25 07:38:08 2015 New Revision: 256417 URL: http://llvm.org/viewvc/llvm-project?rev=256417&view=rev Log: [OPENMP] Do not allow to use threadprivate or thread local variables as loop iteration variables. According to OpenMP the loop iteration variable may not appear in

r256485 - [OPENMP 4.5] Do not allow 'linear' clause along with 'ordered(expr)' clause.

2015-12-27 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Dec 28 00:23:08 2015 New Revision: 256485 URL: http://llvm.org/viewvc/llvm-project?rev=256485&view=rev Log: [OPENMP 4.5] Do not allow 'linear' clause along with 'ordered(expr)' clause. According to OpenMP 4.5 "A linear clause or an ordered clause with a parameter can be

r256487 - [OPENMP 4.5] Sema/parsing support for extended format of 'schedule' clause.

2015-12-27 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Dec 28 01:25:51 2015 New Revision: 256487 URL: http://llvm.org/viewvc/llvm-project?rev=256487&view=rev Log: [OPENMP 4.5] Sema/parsing support for extended format of 'schedule' clause. OpenMP 4.0-3.1 supports the next format of ‘schedule’ clause: schedule(kind[, chunk_siz

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-28 Thread Alexey Bataev via cfe-commits
ABataev marked 8 inline comments as done. ABataev added a comment. Aaron, thanks for the review! Comment at: include/clang/Basic/AttrDocs.td:1867 @@ +1866,3 @@ +Clang supports the GNU style ``__attribute__((interrupt))`` attribute on +x86 targets. This attribute may be attached

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-28 Thread Alexey Bataev via cfe-commits
ABataev marked 9 inline comments as done. ABataev added a comment. John, thanks for the review! Comment at: include/clang/Basic/Attr.td:255 @@ -254,2 +254,3 @@ def TargetX86 : TargetArch<["x86"]>; +def TargetIA : TargetArch<["x86", "x86_64"]>; def TargetWindows : TargetArch<["

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-28 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 43676. ABataev marked 3 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D15709 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/Ta

[clang] [OpenACC] Implement beginning parts of the 'parallel' Sema impl (PR #81659)

2024-02-15 Thread Alexey Bataev via cfe-commits
@@ -0,0 +1,132 @@ +//===--- SemaOpenACC.cpp - Semantic Analysis for OpenACC constructs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [OpenACC] Implement beginning parts of the 'parallel' Sema impl (PR #81659)

2024-02-15 Thread Alexey Bataev via cfe-commits
@@ -0,0 +1,132 @@ +//===--- SemaOpenACC.cpp - Semantic Analysis for OpenACC constructs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [OpenACC] Implement beginning parts of the 'parallel' Sema impl (PR #81659)

2024-02-15 Thread Alexey Bataev via cfe-commits
@@ -0,0 +1,132 @@ +//===--- SemaOpenACC.cpp - Semantic Analysis for OpenACC constructs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [OpenACC] Implement beginning parts of the 'parallel' Sema impl (PR #81659)

2024-02-15 Thread Alexey Bataev via cfe-commits
@@ -13662,3 +13663,8 @@ StringRef ASTContext::getCUIDHash() const { CUIDHash = llvm::utohexstr(llvm::MD5Hash(LangOpts.CUID), /*LowerCase=*/true); return CUIDHash; } + +void ASTContext::setOpenACCStructuredBlock(OpenACCComputeConstruct *C, +

[clang] [OpenACC] Implement beginning parts of the 'parallel' Sema impl (PR #81659)

2024-02-15 Thread Alexey Bataev via cfe-commits
@@ -745,9 +745,14 @@ bool Parser::ParseOpenACCClause(OpenACCDirectiveKind DirKind) { << getCurToken().getIdentifierInfo(); // Consume the clause name. - ConsumeToken(); + SourceLocation ClauseLoc = ConsumeToken(); + + bool ParamsResult = ParseOpenACCClausePara

[clang] [OpenACC] Implement beginning parts of the 'parallel' Sema impl (PR #81659)

2024-02-15 Thread Alexey Bataev via cfe-commits
@@ -0,0 +1,132 @@ +//===--- SemaOpenACC.cpp - Semantic Analysis for OpenACC constructs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [OpenACC] Implement beginning parts of the 'parallel' Sema impl (PR #81659)

2024-02-15 Thread Alexey Bataev via cfe-commits
@@ -0,0 +1,132 @@ +//===--- SemaOpenACC.cpp - Semantic Analysis for OpenACC constructs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [OpenACC][NFC] Implement basic OpenACC Sema infrastructure (PR #81874)

2024-02-15 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/81874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

2024-02-15 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: I already told, that you don't need the changes neither in sema, nor in stmt class. All function changes are in codegen, no other changes are required. https://github.com/llvm/llvm-project/pull/72417 ___ cfe-commits mailing list c

[clang] [OpenACC] Implement beginning parts of the 'parallel' Sema impl (PR #81659)

2024-02-16 Thread Alexey Bataev via cfe-commits
@@ -0,0 +1,132 @@ +//===--- SemaOpenACC.cpp - Semantic Analysis for OpenACC constructs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [OpenACC] Implement beginning parts of the 'parallel' Sema impl (PR #81659)

2024-02-16 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/81659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][Clang] Enable inscan modifier for generic datatypes (PR #82220)

2024-02-19 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: Add a test https://github.com/llvm/llvm-project/pull/82220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][Clang] Enable inscan modifier for generic datatypes (PR #82220)

2024-02-20 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/82220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-21 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-21 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-21 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-21 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-21 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/82543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/82543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/82543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/82543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Clang Codegen Interop : Accept multiple init (PR #82604)

2024-02-22 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: The test is required https://github.com/llvm/llvm-project/pull/82604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Implement `isOpenMPCapturingDirective` (PR #97090)

2024-07-01 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/97090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Rewrite `getOpenMPCaptureRegions` in terms of leafs (PR #97110)

2024-07-01 Thread Alexey Bataev via cfe-commits
@@ -747,105 +747,79 @@ void clang::getOpenMPCaptureRegions( assert(unsigned(DKind) < llvm::omp::Directive_enumSize); assert(isOpenMPCapturingDirective(DKind) && "Expecting capturing directive"); - switch (DKind) { - case OMPD_metadirective: -CaptureRegions.push_back(

[clang] [clang][OpenMP] Rewrite `getOpenMPCaptureRegions` in terms of leafs (PR #97110)

2024-07-01 Thread Alexey Bataev via cfe-commits
@@ -709,139 +709,125 @@ bool clang::isOpenMPExecutableDirective(OpenMPDirectiveKind DKind) { return Cat == Category::Executable || Cat == Category::Subsidiary; } -void clang::getOpenMPCaptureRegions( -SmallVectorImpl &CaptureRegions, -OpenMPDirectiveKind DKind) { -

[clang] [clang][OpenMP] Rewrite `getOpenMPCaptureRegions` in terms of leafs (PR #97110)

2024-07-01 Thread Alexey Bataev via cfe-commits
@@ -709,139 +709,125 @@ bool clang::isOpenMPExecutableDirective(OpenMPDirectiveKind DKind) { return Cat == Category::Executable || Cat == Category::Subsidiary; } -void clang::getOpenMPCaptureRegions( -SmallVectorImpl &CaptureRegions, -OpenMPDirectiveKind DKind) { -

[clang] [clang][OpenMP] Rewrite `getOpenMPCaptureRegions` in terms of leafs (PR #97110)

2024-07-01 Thread Alexey Bataev via cfe-commits
@@ -709,139 +709,125 @@ bool clang::isOpenMPExecutableDirective(OpenMPDirectiveKind DKind) { return Cat == Category::Executable || Cat == Category::Subsidiary; } -void clang::getOpenMPCaptureRegions( -SmallVectorImpl &CaptureRegions, -OpenMPDirectiveKind DKind) { -

<    11   12   13   14   15   16   17   18   19   20   >