[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

ABataev added a comment. In D79186#2016737 , @jdoerfert wrote: > In D79186#2013689 , @ABataev wrote: > > > In D79186#2013603 , @jdoerfert > > wrote: > > > > > What would you

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.h:30-31 + + /// Declare AMDGCN specific specialization of functions which + /// have been generalized as virtual functions in CGOpenMPRuntimeGPU + These 2 lines can be removed, t

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 ___ c

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

ABataev updated this revision to Diff 282942. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_is_dev

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

ABataev updated this revision to Diff 282958. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84457/new/ https://reviews.llvm.org/D84457 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D85321: [OPENMP]Do not capture base pointer by reference if it is used as a base for array-like reduction.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. If the declaration is used in the reduction clause, it is captured by refer

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:3329 } - OMPDeclareMapperDecl *NewDMD = SemaRef.ActOnOpenMPDeclareMapperDirectiveStart( - /*S=*/nullptr, Owner, D->getDeclName(), SubstMapperTy, D->getLocation(),

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85551/new/ https://reviews.llvm.org/D85551 ___ c

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1, i64

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1, i64

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80735/new/ https://reviews.llvm.org/D80735 ___ c

[PATCH] D85695: [OpenMP] split execution of a long test into smaller parts.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85695/new/ https://reviews.llvm.org/D85695 ___ c

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5 and default - Part 1

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/ https://reviews.llvm.org/D84844 ___ c

[PATCH] D85755: [OPENMP]Do not add TGT_OMP_TARGET_PARAM flag to non-captured mapped arguments.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. If the arguments are mapped, but are actually not used in the target region, the compiler still adds attribute T

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

ABataev updated this revision to Diff 284815. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_is_dev

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. The base must be shared between the threads, threadprivates are not allowed

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

ABataev updated this revision to Diff 284830. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84457/new/ https://reviews.llvm.org/D84457 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D85321: [OPENMP]Do not capture base pointer by reference if it is used as a base for array-like reduction.

ABataev updated this revision to Diff 284836. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85321/new/ https://reviews.llvm.org/D85321 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/distribute_parallel_f

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec9563c54ed2: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks. (authored by ABataev). Repository: rG LLVM Github Monorepo

[PATCH] D85755: [OPENMP]Do not add TGT_OMP_TARGET_PARAM flag to non-captured mapped arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rGddbd21d288f6: [OPENMP]Do not add TGT_OMP_TARGET_PARAM flag to non-captured mapped arguments. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D85755?vs=284806&id=285074#toc Repo

[PATCH] D85875: [OpenMP][FIX] Do not crash trying to print a missing (demangled) user condition

ABataev added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:2204-2207 +if (Selector.ScoreOrCondition) + Selector.ScoreOrCondition->printPretty(OS, nullptr, Policy); +else + OS << "..."; Why it can be `nullptr` if it

[PATCH] D85876: [OpenMP][FIX] Do not drop a '$' while demangling declare variant names

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85876/new/ https://reviews.llvm.org/D85876 ___ c

[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5879 D.SetIdentifier(&VariantII, D.getBeginLoc()); return BaseFD; } Does the user of this function expect that BaseFD can be `nullptr` after this change? Repository: rG LLVM Gith

[PATCH] D86037: [OpenMP][FIX] Do not use TBAA in type punning reduction GPU code PR46156

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86037/new/ https://reviews.llvm.org/D86037 ___ c

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:499 + + QualType TgtAttributeStructQTy; class OffloadEntriesInfoManagerTy { Cab this type and corresponding functions be made AMDGCN-specific only? Comment at: c

[PATCH] D85321: [OPENMP]Do not capture base pointer by reference if it is used as a base for array-like reduction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b93ebccaa09: [OPENMP]Do not capture base pointer by reference if it is used as a base for… (authored by ABataev). Repository: rG LLVM Github Mono

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

ABataev updated this revision to Diff 286270. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_is_dev

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

ABataev updated this revision to Diff 286272. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85762/new/ https://reviews.llvm.org/D85762 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/parallel_reduction_me

[PATCH] D86164: [OPENMP]Fix PR47158, case 2: do not report host-only functions in unused function in device mode.

ABataev created this revision. ABataev added reviewers: jdoerfert, cchen. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. If the function is not marked exlicitly as declare target and it call

[PATCH] D86164: [OPENMP]Fix PR47158, case 2: do not report host-only functions in unused function in device mode.

ABataev added a comment. In D86164#2224577 , @jdoerfert wrote: > LGTM, nit: Is there a "not" missing in the the commit message? Yes, will add it, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86164/

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

ABataev added a comment. In D83261#2224619 , @cchen wrote: > In PR45212 comment 5 (https://bugs.llvm.org/show_bug.cgi?id=45212#c5), there > is a reduced test case that failed after adding this patch. The assertion is > from OMPChildren::getInnermostCaptu

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

ABataev updated this revision to Diff 261917. ABataev added a comment. Rebase and simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78232/new/ https://reviews.llvm.org/D78232 Files: clang/include/clang/AST/OpenMPClause.h clang/include/cla

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

ABataev added a comment. In D79186#2023322 , @jdoerfert wrote: > LGTM. > > In D79186#2016893 , @ABataev wrote: > > > In D79186#2016737 , @jdoerfert > > wrote: > > > > > In D

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8026394d3cc7: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79186/new

[PATCH] D79257: [OPENMP50]Codegen for uses_allocators clause.

ABataev updated this revision to Diff 262649. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79257/new/ https://reviews.llvm.org/D79257 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:38 #include "llvm/Frontend/OpenMP/OMPConstants.h" +#include "llvm/Support/ErrorHandling.h" #include Why do you need this here? Comment at: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2053 + D, [](OpenMPClauseKind K) -> bool { return K != OMPC_unknown; }, + Level, /*NotLastprivate=*/true) && + !DSAStack->isLoopControlVariable(D, Level).first) { `/*N

[PATCH] D79921: [OpenMP] Fix omp and clang pragmas

ABataev added a comment. Tests? Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1736 + const AttributedStmt *AS = nullptr; + if (auto *OMPD = dyn_cast(&S)) { +const CapturedStmt *CS = OMPD->getCapturedStmt(OMPD_parallel); 1. Cast it to `OMPExecutableDirect

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added a comment. Do you have the tests for static locals and static data members with `default(firstprivate)`? Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787 + if (getLangOpts().OpenMP < 51 && Kind == OMPC_default && + static_cast(Val.getValue().Type) == +

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a project: clang. Implemented codegen for reduction clauses with inscan modifiers in worksharing constructs. Emits the code for the directive with inscan reductio

[PATCH] D79257: [OPENMP50]Codegen for uses_allocators clause.

ABataev updated this revision to Diff 264020. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79257/new/ https://reviews.llvm.org/D79257 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D79966: [OPENMP]Fix PR45911: Data sharing and lambda capture.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. No need to generate inlined OpenMP region for variables captured in lambdas or block decls, only for implicitly captured variables in the OpenMP region.

[PATCH] D79257: [OPENMP50]Codegen for uses_allocators clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0363ae97abb8: [OPENMP50]Codegen for uses_allocators clause. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79257/new/ https://reviews.

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3434-3435 + if (Stack->getDefaultDSA() == DSA_firstprivate && + VD->getStorageDuration() == SD_Static && + CanonicalVD->getDeclContext()->isFileContext() && !Stack->isLoopCo

[PATCH] D80148: [OPENMP50]Add initial support for 'affinity' clause.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, arphaman, guansong, yaxunl. Herald added projects: clang, LLVM. Added parsing/sema/serialization support for affinity clause in task directives. Repository: rG LLVM Github Monorepo http

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80200/new/ https://reviews.llvm.org/D80200 ___

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1735 + // If attributes are attached, push to the basic block with them. + const OMPExecutableDirective *OMPED = dyn_cast(&S); + const CapturedStmt *ICS = OMPED->getInnermostCapturedStmt(); -

[PATCH] D80148: [OPENMP50]Add initial support for 'affinity' clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e499eee5884: [OPENMP50]Add initial support for 'affinity' clause. (authored by ABataev). Herald added a subscriber: sstefan1. Changed prior to commit: https://reviews.llvm.org/D80148?vs=264687&id=26487

[PATCH] D80240: [OPENMP50]Initial codegen for 'affinity' clauses.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1, guansong, yaxunl. Herald added projects: clang, LLVM. Added initial codegen for 'affinity' clauses on task directives. Emits next code: kmp_task_affinity_info_t affs[]; voi

[PATCH] D40354: [OpenMP] Adjust arguments of nvptx runtime functions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D40354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 123932. ABataev added a comment. Added codegen for `target teams` construct. https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- doc

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 124430. ABataev added a comment. Added codegen for `distribute parallel for simd` construct. https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst ===

[PATCH] D40588: [OpenMP] Diagnose undeclared variables on declare target clause

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. I'm unable to reproduce a crash, the test works correctly even without you patch https://reviews.llvm.org/D40588 ___ cfe-commits mail

[PATCH] D40588: [OpenMP] Diagnose undeclared variables on declare target clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D40588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D40795: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for simd' on host

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D40795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

ABataev added a comment. Fixed in a bit different way in r319774 https://reviews.llvm.org/D40752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

ABataev added a comment. In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > r319774 works for my current use cases. Thanks. > > While we're on this topic, do you happen to know the rationale behind the > OpenMP restriction for which err_omp_union_type_not_allowed diagnoses > violation

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

ABataev added a comment. In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > r319774 works for my current use cases. Thanks. > > While we're on this topic, do you happen to know the rationale behind the > OpenMP restriction for which err_omp_union_type_not_allowed diagnoses > violation

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

ABataev added a comment. In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > r319774 works for my current use cases. Thanks. > > While we're on this topic, do you happen to know the rationale behind the > OpenMP restriction for which err_omp_union_type_not_allowed diagnoses > violation

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

ABataev added a comment. In https://reviews.llvm.org/D40752#945571, @jdenny wrote: > In https://reviews.llvm.org/D40752#945255, @ABataev wrote: > > > In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > > > > > r319774 works for my current use cases. Thanks. > > > > > > While we're on thi

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 125722. ABataev added a comment. Update Repository: rC Clang https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst +

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110 +PrivateAddr.getPointer(), +SharedAddresses[N].first.getPointer()->getType()); +llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment); Bette

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110 +PrivateAddr.getPointer(), +SharedAddresses[N].first.getPointer()->getType()); +llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment); Hahnf

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D40911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

ABataev added a comment. In https://reviews.llvm.org/D40752#948399, @jdenny wrote: > Alexey: I see that you committed the error message change, so I think this > issue is done. Is Abandon Revision correct in this scenario? Sorry, I'm new > here. Yes, it is correct https://reviews.llvm.org

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:12576 +if (MT == OMPDeclareTargetDeclAttr::MT_Link && isa(ND)) { + Diag(Id.getLoc(), diag::err_omp_function_in_link_clause); I would like to see this some in `check` functions, like `c

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:12671 +void Sema::checkDeclIsAllowedInOpenMPTarget(Expr *E, Decl *D, +const DeclarationNameInfo *Id) { if (!D || D->isInvalidDecl()) You can get `Dec

[PATCH] D41012: [OpenMP] Further adjustments of nvptx runtime functions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D41012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:12671 +void Sema::checkDeclIsAllowedInOpenMPTarget(Expr *E, Decl *D, +const DeclarationNameInfo *Id) { if (!D || D->isInvalidDecl()) kkwli0 wrote: >

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D40968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D41123: [OpenMP] Add function attribute for triggering data sharing.

ABataev added inline comments. Comment at: test/OpenMP/nvptx_data_sharing.cpp:25-43 +// CK1: define internal void @__omp_offloading_{{.*}}test_ds{{.*}}worker() #0 // CK1: [[SHAREDARGS:%.+]] = alloca i8** // CK1: call i1 @__kmpc_kernel_parallel(i8** %work_fn, i8*** [[SHAREDARGS]

[PATCH] D41123: [OpenMP] Add function attribute for triggering data sharing.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D41123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 126773. ABataev added a comment. Status update. Repository: rC Clang https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- docs/ind

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 126800. ABataev added a comment. Status update Repository: rC Clang https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- docs/inde

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 126820. ABataev added a comment. Status update Repository: rC Clang https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- docs/inde

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3837-3838 return nullptr; - return Actions.ActOnOpenMPClause(Kind, Loc, Tok.getLocation()); + OMPClause *Clause = Actions.ActOnOpenMPClause(Kind, Loc, Tok.getLocation()); + return Clause; } --

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12694-12695 + SourceLocation DisplayLocation = + ((FailParameter == OMPC_unknown) ? FC->getBeginLoc() + : FC->getFailParameterLoc()); + if ((FailP

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/lib/Sema/SemaOpenMP.cpp:12693 + OpenMPClauseKind FailParameter = FC->getFailParameter(); + SourceLocation DisplayLocation = (FailP

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added a comment. In D123235#4656459 , @koops wrote: > After the reverting of changes, putting the default in the switch case as > discussed in the comments earlier. No, do not put the default: switch, instead you need explicitly list all other

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2555 + break; +default: + this->FailParameter = llvm::omp::OMPC_unknown; Same here, remove default: and explicitly list all possible values CHANGES SINCE LAST ACTION

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added a comment. In D123235#4656464 , @koops wrote: > In clang/lib/AST/OpenMPClause.cpp, > > OMPClauseWithPreInit::get(const OMPClause *C) { > switch(C->getClauseKind()) { > case OMPC_schedule: > > default: > break; > } > >

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2554 + break; +case llvm::omp::OMPC_adjust_args: +case llvm::omp::OMPC_affinity: I think all these cases are unexpected and must be terminated with llvm_unreachable

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2516 +extern bool checkFailParameter(OpenMPClauseKind FailParameter); +/// This represents 'fail' clause in the '#pragma omp atomic' No way for extern functions. Declare in includ

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:4 TargetParser + FrontendOpenMP ) What requires this new dependency? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 __

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2525 + + OMPClause *FailMemoryOrderClause = nullptr; + SourceLocation ArgumentLoc; I don't like the idea of a reference to another clause here, it may lead to many issues with se

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2543 + void setFailParameter(OpenMPClauseKind FailParameter) { + +switch (FailParameter) { Remove this empty line Comment at: clang/include/clang/AST/OpenMPC

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3328-3332 if (!FirstClause) { Diag(Tok, diag::err_omp_more_one_clause) << getOpenMPDirectiveName(DKind) << getOpenMPClauseName(CKind) << 0; ErrorFound = true; } -

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2561 + + void initFailClause(SourceLocation LParenLoc, OpenMPClauseKind FailParameter, + SourceLocation FailParameterLoc) { Unused? Comment

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126549/new/ https://reviews.llvm.org/D126549 ___

[PATCH] D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128686/new/ https://reviews.llvm.org/D128686 ___

[PATCH] D122255: Meta directive runtime support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:8859 +/// \code +/// #pragma omp metadirective when(user={consition(N<100)}:parallel for) +/// \endcode condition? Comment at: clang/include/clang/AST/OpenMPClaus

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:199 UsesAllocatorsDecls; +struct ImplicitDefaultFDInfoTy { + const FieldDecl *FD = nullptr; Add comments for the structure and all fields, please. Commen

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 ___

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:199 UsesAllocatorsDecls; +/// Data is needed on creating capture fields for implicit +/// defualt first|private clause. Data required? Comment at: clang/l

[PATCH] D122255: Meta directive runtime support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:8893-8894 + + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + abidmalikwaterloo wrote: > ABataev wrote: > > make it private > Any reas

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:122 + /// the RebuildME uses to set if member expression needs to be rebuilt. + bool RebuildME = false; + jyu2 wrote: > ABataev wrote: > > I think we don't need to add a new field here. C

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2273-2274 +bool Sema::isOpenMPRebuildMemberExpr(ValueDecl *D) { + if (getCurCapturedRegion() && + getCurCapturedRegion()->CapRegionKind == CR_OpenMP) { +DSAStackTy::DSAVarData DVarPrivate = DSAStac

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2273-2274 +bool Sema::isOpenMPRebuildMemberExpr(ValueDecl *D) { + if (getCurCapturedRegion() && + getCurCapturedRegion()->CapRegionKind == CR_OpenMP) { +DSAStackTy::DSAVarData DVarPrivate = DSAStac

<    4   5   6   7   8   9   10   11   12   13   >