[PATCH] D28160: [OpenMP] Sema and parsing for 'target teams distribute parallel for' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:114 /// \brief Get the name of the capture helper. - StringRef getHelperName() const override { return ".omp_outlined."; } + StringRef getHelperName() const override { return "__omp_outlined__"; } -

[PATCH] D28202: [OpenMP] Sema and parsing for 'target teams distribute parallel for simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:539-542 +llvm::Value *EndArgs[] = {emitUpdateLocation(CGF, Loc), ThreadID}; +CGF.EmitRuntimeCall( +createNVPTXRuntimeFunction(OMPRTL_NVPTX__kmpc_end_serialized_parallel), +EndA

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:63 +/// Common pre(post)-action for different OpenMP constructs. +class CommonActionTy final : public PrePostActionTy { + llvm::Value *EnterCallee; I don't think it is good to name it Commo

[PATCH] D28243: [OpenMP] Add missing regression test for pragma distribute, clause firstprivate

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D28252: [OpenMP] Sema and parsing for 'target teams distribute simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/Sema/SemaOpenMP.cpp:6444 + + CapturedStmt *CS = cast(AStmt); + // 1.2.2 OpenMP Language Terminology auto * https://review

[PATCH] D28255: [OpenMP] support the 'is_device_ptr' clause with 'target parallel for' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D28418: Fixing test to work when the compiler defaults to a different C++ standard version

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:409 +llvm::FunctionType *FnTy = +llvm::FunctionType::get(CGM.VoidTy, {}, /*isVarArg*/ false); +

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

ABataev added a comment. Guys, sorry for the delay with the reviews. I was on a vacation, now I'm on a relocation process. Will look at all patches as soon as possible, but not earlier than next week :( Sorry again. https://reviews.llvm.org/D30739 ___

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

ABataev added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2167-2172 +// Set the flag to prevent the implementation from emitting device exception +// handling code for those requiring so. +if (Opts.OpenMPIsDevice && T.isNVPTX()) { + Opts.Exc

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

ABataev added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:430 +bool tools::addOpenMPRuntime(ArgStringList &CmdArgs, const ToolChain &TC, + const ArgList &Args, const JobAction &JA, + bool GompNeedsRT) {

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:495-506 + + StringRef PtxVersion = DriverArgs.getLastArgValue( +options::OPT_fopenmp_ptx_EQ); + CC1Args.push_back("+ptx42"); + if (DeviceOffloadingKind == Action::OFK_OpenMP && --

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:358-360 + /// Do the check specified in \a Check to all component lists at a given level + /// and return true if any issue is found. + bool checkMappableExprComponentListsForDeclAtLevel( Coul

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

ABataev added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:122-123 createOpenCLRuntime(); - if (LangOpts.OpenMP) + if (LangOpts.OpenMP || LangOpts.OpenMPSimd) createOpenMPRuntime(); if (LangOpts.CUDA) I don't think you need to create

[PATCH] D29651: [OpenMP] Consider LIBRARY_PATH when selecting library paths for NVPTX targets in OpenMP mode.

ABataev added inline comments. Comment at: test/Driver/openmp-offload.c:622 +/// Check that the lib folder pointed to by the LIBRARY_PATH is correctly passsed to the loader script. +// RUN: LIBRARY_PATH=/a/b/c/lib %clang -### -fopenmp=libomp -fopenmp-targets=powerpc64le-ibm-l

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6818-6819 +ISAData); +} +if (CGM.getTriple().getArch() == llvm::Triple::aarch64) { + ISADataTy ISAData[] = { else if Com

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:358-360 + /// Do the check specified in \a Check to all component lists at a given level + /// and return true if any issue is found. + bool checkMappableExprComponentListsForDeclAtLevel( gtbe

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:499 +options::OPT_fopenmp_ptx_EQ); +CC1Args.back() = (!PtxVersion.empty()) ? PtxVersion.data() : "+ptx42"; + } else No, use `CC1Args.push_back()` here, or `CC1Args.emplace_back

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

ABataev added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:174 + case OMPD_target_teams_distribute_simd: +DKind = OMPD_simd; +break; huntergr wrote: > ABataev wrote: > > huntergr wrote: > > > rengolin wrote: > > > > I'd like @ABatae

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:343 +for (unsigned I = Stack.size() - 1; I > 0; --I) + if (checkMappableExprComponentListsForDeclAtLevel(VD, I - 2, Check)) +return true; Are you sure this is correct? If I is 1,

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D29905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D32035: [OpenMP] Error when trying to offload to an unsupported architecture

ABataev added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2242-2253 + if (!(TT.getArch() == llvm::Triple::ppc || +TT.getArch() == llvm::Triple::ppc64 || +TT.getArch() == llvm::Triple::ppc64le || +TT.getArch() == llvm::

[PATCH] D32035: [OpenMP] Error when trying to offload to an unsupported architecture

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D32035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D28752: [OpenMP] Refactor code that calls codegen for target regions on the device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. Is this an NFC patch? If so add 'NFC' to this patch. LG https://reviews.llvm.org/D28752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

ABataev added inline comments. Comment at: include/clang/Sema/Sema.h:8328-8330 + /// Return the number of captured regions created for an OpenMP directive. + static int getOpenMPCaptureLevels(OpenMPDirectiveKind Kind); + I think it would be good to have a membe

[PATCH] D28755: [OpenMP] Codegen for the 'target parallel' directive on the NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'.

ABataev added inline comments. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:84-115 +/// Lexical scope for OpenMP parallel construct, that handles correct codegen +/// for captured expressions. +class OMPParallelScope final : public CodeGenFunction::LexicalScope { + void emitPreInitS

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:543 virtual llvm::Value *emitParallelOrTeamsOutlinedFunction( - const OMPExecutableDirective &D, const VarDecl *ThreadIDVar, - OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen);

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:543 virtual llvm::Value *emitParallelOrTeamsOutlinedFunction( - const OMPExecutableDirective &D, const VarDecl *ThreadIDVar, - OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen);

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with nits Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:848-860 +const StringRef outlinedHelperName, const RegionCodeGenTy &CodeGen) { assert(ThreadIDVar->getType()

[PATCH] D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29026: [OpenMP] DSAChecker bug fix for combined directives.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29026 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29082: [OpenMP] Support for the num_threads-clause on 'target parallel'.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4996 + CodeGenFunction::RunCleanupsScope NumThreadsScope(CGF); + auto NumThreads = CGF.EmitScalarExpr(Nu

[PATCH] D29083: [OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29084: [OpenMP] Codegen support for 'target teams' on the host.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29085: [OpenMP] Support for num_teams-clause on the 'target teams' directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29087: [OpenMP] Support for thread_limit-clause on the 'target teams' directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29128: [OpenMP] Support for the proc_bind-clause on 'target parallel' on the NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29143: [OpenMP] Codegen support for 'target teams' on the NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev added a comment. Ping https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29358: [OpenMP] Report an error for -faltivec on anything other than PowerPC.

ABataev added a comment. Did not find any errors in this patch, neither in code, nor in test Repository: rL LLVM https://reviews.llvm.org/D29358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D29339: [OpenMP] Add support for auxiliary triple specification

ABataev added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:914-915 + // Create TargetInfo for the other side of CUDA and OpenMP compilation. + if ((getLangOpts().CUDA && !getFrontendOpts().AuxTriple.empty()) || + (getLangOpts().OpenMPIsDevice && !getFront

[PATCH] D29480: C++11 Compatibility - OpenMP constant expressions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29506: [OpenMP] Teams reduction on the NVPTX device.

ABataev added a comment. The patch is too big and quite hard to review? Could you split it into several smaller parts? Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4280-4282 + // We don't need debug information in this function as nothing here refers to + // user source code.

[PATCH] D29725: Lit C++11 Compatibility - Parse OpenMP

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D34888: [OpenMP] Fix mapping of scalars for combined directives

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D34888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D35854: Fix double destruction of objects when OpenMP construct is canceled

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D35854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. After some investigation, I think this whole code is incorrect. We should not rely on the fact that there is no padding on some architectures and should mix the type generated by the Clang and initial value, generated by LLVM. Repository: rC Clang https://reviews.ll

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. In https://reviews.llvm.org/D42168#978594, @Hahnfeld wrote: > In https://reviews.llvm.org/D42168#978593, @ABataev wrote: > > > After some investigation, I think this whole code is incorrect. We should > > not rely on the fact that there is no padding on some architecture

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. Or, there is another one solution - mark `_tgt_offload_entry` record as packed. Repository: rC Clang https://reviews.llvm.org/D42168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. 1. Please, mark the record as packed. 2. Tests Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3576-3577 EntryInit.addInt(CGM.Int32Ty, 0); - llvm::GlobalVariable *Entry = -EntryInit.finishAndCreateGlobal(".omp_offloading.entry", -

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. In https://reviews.llvm.org/D42168#978689, @Hahnfeld wrote: > In https://reviews.llvm.org/D42168#978634, @ABataev wrote: > > > 1. Please, mark the record as packed. > > > Where and how do I need to do this? I found that `PackedAttr` is checked on > `FieldDecl`s but I'm n

[PATCH] D42168: [OpenMP] Correct generation of offloading entries

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D42168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D42349: [DOCS] Mention OpenMP Tools Interface in runtime library

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D42349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

ABataev created this revision. ABataev added reviewers: tra, jlebar. Herald added subscribers: JDevlieghere, aprantl. NVPTX target supports debug info in DWARF-2 format. Patch adds emission of debug info in DWARF-2 by default. Repository: rC Clang https://reviews.llvm.org/D42581 Files: lib

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:353 CmdArgs.push_back(Args.MakeArgString(Output.getFilename())); + if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag)) +CmdArgs.push_back("-g"); tra wrote: > There's mo

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:353 CmdArgs.push_back(Args.MakeArgString(Output.getFilename())); + if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag)) +CmdArgs.push_back("-g"); tra wrote: > ABataev wr

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

ABataev added a comment. In https://reviews.llvm.org/D42581#989760, @probinson wrote: > If you want to force DWARF 2, probably clamping the version in LLVM would be > simpler? Although most of the debug-info tests are architecture-specific and > wouldn't run for an NVPTX target anyway. Hi, I

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:353 CmdArgs.push_back(Args.MakeArgString(Output.getFilename())); + if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag)) +CmdArgs.push_back("-g"); tra wrote: > ABataev wr

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

ABataev updated this revision to Diff 132016. ABataev added a comment. 1. Updated after review. 2. Changed the default behavior of --[no]cuda-noopt-device-debug. If the optimization level is not specified or is O0 and debug info must be emitted, the device debug info is emitted. If optimization

[PATCH] D42841: [docs] Improve help for OpenMP options

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. 1. Mark this patch as NFC. 2. LG https://reviews.llvm.org/D42841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D29758: [OpenMP] Parallel reduction on the NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:956-962 virtual void emitReduction(CodeGenFunction &CGF, SourceLocation Loc, ArrayRef Privates, ArrayRef LHSExprs,

[PATCH] D29758: [OpenMP] Parallel reduction on the NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29879: [OpenMP] Teams reduction on the NVPTX device.

ABataev added a comment. General note: Be more strict with the types. For indeces it's better to use `SizeTy` or `UintPtrTy`, if `Int32Ty` is specified as type of parameter, use `Int32y`, not `IntTy` Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:725 +

[PATCH] D29910: [OpenMP] Specialize default schedule on a worksharing loop on the NVPTX device.

ABataev added a comment. General comment: do you really need to define default schedule kind in Sema? Could you do it during codegen phase? Comment at: include/clang/Basic/OpenMPKinds.h:23-25 +class Sema; +class OMPClause; + No way, these classes should not be

[PATCH] D29910: [OpenMP] Specialize default schedule on a worksharing loop on the NVPTX device.

ABataev added a comment. In https://reviews.llvm.org/D29910#676186, @arpith-jacob wrote: > Hi Alexey, > > Thank you for your review. The main difference in the specialized codegen > (if vs. else part in CGStmtOpenMP.cpp). > > If-part: emitForStaticInit uses the Chunk parameter (else has it set

[PATCH] D29910: [OpenMP] Specialize default schedule on a worksharing loop on the NVPTX device.

ABataev added a comment. In https://reviews.llvm.org/D29910#676777, @arpith-jacob wrote: > Hi Alexey, > > Thank you for reviewing this patch. > > > I don't like the idea of adding some kind of default scheduling, that is > > not defined in standard in Sema > > Actually, "default scheduling" is d

[PATCH] D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for'

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D29922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D29879: [OpenMP] Teams reduction on the NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:715 +// lane_offset, int16_t shortCircuit), +// void (*kmp_InterWarpCopyFctPtr)(void* src, int warp_num), +// void (*kmp_CopyToScratchpadFctPtr)(void *reduce_data, void * scratchpad, -

[PATCH] D29879: [OpenMP] Teams reduction on the NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D30088: [OpenMP] Remove barriers at cancel and cancellation point

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D30088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D30091: [OpenMP] Fix cancellation point in task with no cancel

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D30091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D30135: [OpenMP] Generate better diagnostics for cancel and cancellation point

ABataev added a comment. Not sure that this is better because at first, we need to be sure that this nesting is allowed. Why do we need to perform some additional analysis if nesting is not allowed at all? https://reviews.llvm.org/D30135 ___ cfe-c

[PATCH] D30135: [OpenMP] Generate better diagnostics for cancel and cancellation point

ABataev added a comment. I see. I think it is better to check the `CancelRegion` just before call of `CheckNestingOfRegions()` function. You need to extract checks for `CancelRegion` from `ActOnOpenMPCancellationPointDirective()` and `ActOnOpenMPCancelDirective()` functions into a standalone fu

[PATCH] D30135: [OpenMP] Generate better diagnostics for cancel and cancellation point

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:1959 +static bool CheckCancelRegion(Sema &SemaRef, OpenMPDirectiveKind CurrentRegion, + OpenMPDirectiveKind CancelRegion, Should be `checkCancelRegion` ===

[PATCH] D30135: [OpenMP] Generate better diagnostics for cancel and cancellation point

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:1959 +static bool CheckCancelRegion(Sema &SemaRef, OpenMPDirectiveKind CurrentRegion, + OpenMPDirectiveKind CancelRegion, Hahnfeld wrote: > ABataev wrote: > > Should

[PATCH] D30135: [OpenMP] Generate better diagnostics for cancel and cancellation point

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:1968-1973 + if (CancelRegion != OMPD_parallel && CancelRegion != OMPD_for && + CancelRegion != OMPD_sections && CancelRegion != OMPD_taskgroup) { +SemaRef.Diag(StartLoc, diag::err_omp_wrong_cancel_region

[PATCH] D30135: [OpenMP] Generate better diagnostics for cancel and cancellation point

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D30135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma

ABataev added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:685 bool clang::isOpenMPWorksharingDirective(OpenMPDirectiveKind DKind) { return DKind == OMPD_for || DKind == OMPD_for_simd || I think this new directive must be considered as a workshari

[PATCH] D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. 1. Please provide full context for your changes (check this document how to do this http://llvm.org/docs/Phabricator.html). 2. Use clang-format for all your changes. 3. Do not use b

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. You did just some minor changes. The main questions are still unanswered. https://reviews.llvm.org/D27250 ___ cfe-commits mailing lis

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

ABataev added a comment. In https://reviews.llvm.org/D27250#609111, @fpetrogalli wrote: > In https://reviews.llvm.org/D27250#609006, @ABataev wrote: > > > > > > Hi! Thanks for your review! > > > 1. Please provide full context for your changes (check this document how to > > do this http://llvm.o

[PATCH] D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma

ABataev added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:721 DKind == OMPD_target_parallel_for_simd; // TODO add next directives. } You should consider this new directive as a parallel directive. And OMPD_teams_distribute_parallel_for_s

[PATCH] D27488: Fixing test to work when the compiler defaults to a different c++ standard version.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D30087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D32237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

ABataev accepted this revision. ABataev added a comment. LG Repository: rL LLVM https://reviews.llvm.org/D29904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

ABataev added a comment. Tests? Comment at: lib/Driver/Driver.cpp:556 else { -const ToolChain &TC = getToolChain(C.getInputArgs(), TT); -C.addOffloadDeviceToolChain(&TC, Action::OFK_OpenMP); +const ToolChain *TC = nullptr; +

[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:297 + !Args.hasFlag(options::OPT_fnoopenmp_relocatable_target, +options::OPT_fopenmp_relocatable_target, false)) CmdArgs.push_back("-c"); 1. Add a comment with

[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D29659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D32807: [OpenMP] Extended parse for 'always' map modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D32807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

ABataev added a comment. In D70549#3256063 , @JonChesterfield wrote: > @ABataev @jhuber6 and I would like to change this to annotate variables with > whatever visibility the user asked for. > > Can you recall if the concern about premption here was for t

[PATCH] D118383: [OpenMP] Enable inoutset dependency-type in depend clause.

ABataev added a comment. Is it a new mode from OpenMP 5.2? Or 5.1? Can you add a check for OpenMP version, if so? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118383/new/ https://reviews.llvm.org/D118383 _

[PATCH] D118399: [OpenMP] Only generate runtime flags with host input

ABataev added a comment. Tests, if possible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118399/new/ https://reviews.llvm.org/D118399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added a comment. sema and parsing tests? Comment at: clang/lib/Sema/SemaOpenMP.cpp:10921 +/// Get the node id of the fixed point of an expression \a S. +llvm::FoldingSetNodeID getNodeId(ASTContext &Context, const Expr *S) { + llvm::FoldingSetNodeID Id;

<    15   16   17   18   19   20   21   22   23   >