[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev created this revision. ABataev added reviewers: rjmccall, hfinkel. Herald added subscribers: arphaman, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Basic codegen for the declarations marked as nontemporal. Also, if the base declaration in the member expressi

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258 ___

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: clang/lib/AST/StmtProfile.cpp:777 +if (E) + Profiler->VisitStmt(E); + } rjmccall wrote: > Can `E` actually be null here? No, remnants of the initial version.

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234902. ABataev added a comment. Fix + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true);

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true);

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234943. ABataev added a comment. Fix + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234950. ABataev added a comment. Removed check for isArrow() + added requested test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/Op

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0860db966a7d: [OPENMP50]Codegen for nontemporal clause. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75209/new/ https://reviews.llvm.org/D75209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev marked 6 inline comments as done. ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:2891 ArgExprs); } + } else if (!getLangOpts().ObjC && getLangOpts().OpenMP >= 50 && jdoerfert wrote

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

ABataev added a comment. In D75209#1909976 , @jdoerfert wrote: > I am unsure we need this with the proper math support. Sema patch for that is > going for review today. I'll try this out soon. It has nothing to do with the math functions support. These

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev updated this revision to Diff 248789. ABataev marked an inline comment as done. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 Files: clang/include/clang-c

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D76211: OpenMP Metadirective with user defined condition

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:863 +/// clause with user defined condition. +class OMPWhenClause : public OMPClause { + friend class OMPClauseReader; `final` Comment at: clang/include/clang/AS

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15554 +LocatorChecker Checker; +if (Checker.Visit(OrigExpr)) { + llvm::copy(Checker.getComponents(), cchen wrote: > ABataev wrote: > > General question about several

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15554 +LocatorChecker Checker; +if (Checker.Visit(OrigExpr)) { + llvm::copy(Checker.getComponents(), cchen wrote: > ABataev wrote: > > cchen wrote: > > > ABataev wro

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option]>, -

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194 +--+--+--+---+ -| devi

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option]>, -

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, but still would be good to add some references to the standard. Some of the features use special wording, which very hard to find in the standard. CHANGES SINCE LAST ACTION https://re

[PATCH] D74046: [clang][driver] Fix null pointer dereference warning inside PrintActions1 (PR43462)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74046/new/ https://reviews.llvm.org/D74046 ___

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3411-3413 +// C++ SYCL options +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; Usually, we add a pair of such flags, `-fsycl` and

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd3437a4f791: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4028-4030 + Arg *SYCLArg = Args.getLastArg(options::OPT_fsycl, options::OPT_fno_sycl); + if (SYCLArg) +IsSYCL = SYCLArg->getOption().matches(options::OPT_fsycl); I suggest to u

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 ___

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:122 + enum class SYCLVersionList { SYCL_2015, SYCL_1_2_1 = SYCL_2015, undefined }; + s/undefined/Undefined/g Comment at: clang/include/clang/Basic/LangOptions

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { Should this option also be controlled by `-fsycl`?

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { bader wrote: > ABataev wrote: > > Should this option a

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { bader wrote: > ABataev wrote: > > bader wrote: > > > A

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev created this revision. ABataev added reviewers: rjmccall, rsmith. Herald added subscribers: arphaman, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Added basic representation and parsing/sema handling of array-shaping operations. Array shaping expression is a

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def fno_sycl : Flag<["-"], "fno-sycl">, Group,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def fno_sycl : Flag<["-"], "fno-sycl">, Group,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2547 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); `-fno-sycl` should not be

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

ABataev added a comment. Partial linking may lead to some incorrect results with global constructors. How are you going to handle this? Comment at: clang/test/Driver/clang-offload-bundler-missing-size-section.cpp:1-44 +// REQUIRES: x86-registered-target +// RUN: %clangxx -c %

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

ABataev added a comment. I would add a check for the use of unsupported types in kernels. They should not be allowed to be used if target does not support it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1870218 , @rsmith wrote: > In D71241#1788003 , @jdoerfert wrote: > > > In D71241#1787652 , @hfinkel wrote: > > > > > In D71241#1787571

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. I would suggest starting with the reworking of the existing implementation with StmtVisitor class and after that step-by-step extend the functionality of the visitor with handling other kinds а expressions. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15293 + // TypeDecorCnt for B: 0 + if (Depth <= TypeDecorCnt) { +RelevantExpr = cast(DRE); cchen wrote: > ABataev wrote: > > The check is really bad. If you want to handle

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

ABataev added a comment. In D74262#1876835 , @grokos wrote: > In D74262#1867245 , @ABataev wrote: > > > Partial linking may lead to some incorrect results with global > > constructors. How are you going to handle t

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2549 + Opts.SYCLIsDevice = Opts.SYCL && Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) { +// -sycl-std applies to any SYCL source, not only those containin

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. Not sure that we need to dig that deep. Maybe just keep thw original analysis for the known expressions and map all other lvalues without some extra analysis, just like DeclRefExpr nodes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. Hmm, we still need to find some basic decl to remap it successfully at the codegen. Not sure that we'll be able to support it in full. It would be good to investigate how we can handle them at the codegen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

ABataev added a comment. In D69585#1823969 , @llunak wrote: > In D69585#1821831 , @aganea wrote: > > > What is the error? > > > I take that part back, actually. I don't quite remember anymore what exactly > I did i

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

ABataev added a comment. In D69585#1825252 , @llunak wrote: > In D69585#1825133 , @ABataev wrote: > > > I thought you were going to add an option or a flag to control the > > behavior? If so, just provide an option

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194 +--+--+--+---+ -| devi

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:240 ++--+--+--+---+ +| misc

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:242 +--+--+--+---+ -| misc

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

ABataev created this revision. ABataev added a reviewer: hfinkel. Herald added subscribers: guansong, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. ABataev added a comment. A note: this header file requires to include stdlib.h too to see the declarations of malloc/fre

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

ABataev added a comment. A note: this header file requires to include stdlib.h too to see the declarations of malloc/free. Shall We include it here to fix it? otherwise the error is reported that malloc and free are declared. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: > cchen

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

ABataev added a comment. In D73128#1832061 , @jdoerfert wrote: > Some minor comments but other than that, LGTM. > > Nit: Clang format the file It is a formatted file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

ABataev updated this revision to Diff 239399. ABataev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73128/new/ https://reviews.llvm.org/D73128 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/openmp_w

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: > ABata

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: > cchen

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7711-7713 +isa(Next->getAssociatedExpression()) || +isa(Next->getAssociatedExpression()) || +isa(Next->getAssociatedExpression())) &&

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7829 if (EncounteredME) { - const auto *FD = dyn_cast(EncounteredME->getMemberDecl()); - unsigned FieldIndex = FD->getFieldIndex(); - - // Update info about the lo

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. In D72811#1839538 , @cchen wrote: > In D72811#1837392 , @jdoerfert wrote: > > > Thanks for working on this! While you are at it, `*this` is probably one of > > the most important ones to te

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467-475 +// We will use llvm-objcopy to add target objects’ sections to the output +// fat object. These sections should have ‘exclude’ flag set which tells +// link e

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. In D72811#1843066 , @cchen wrote: > In D72811#1839561 , @ABataev wrote: > > > In D72811#1839538 , @cchen wrote: > > > > > In D72811#1837392

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:493-518 +// Temporary files that need to be removed. +struct TempFileList : public SmallVector, 2u> { + ~TempFileList() { +for (const auto &File : *this) +

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:371 +// object destruction. +struct TempFileList { + ~TempFileList() { If you have `private` members, it should be a class. Also, seems to me it is a RAII class

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15201 +namespace { +class LocatorChecker final : public StmtVisitor { + OMPClauseMappableExprCommon::MappableExprComponentList Components; Seems to me, you're skipping many expressions, whi

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73721/new/ https://reviews.llvm.org/D73721 ___

[PATCH] D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73738/new/ https://reviews.llvm.org/D73738 ___

[PATCH] D44541: [OpenMP][Clang] Move device global stack init before master-workers split

ABataev added a comment. LG Repository: rC Clang https://reviews.llvm.org/D44541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44749: [OpenMP][Clang] Add call to global data sharing stack initialization on the workers side

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D44749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D38798: [OpenMP] Support for implicit "declare target" functions - Sema patch

ABataev added a comment. Tests? Comment at: include/clang/Basic/LangOptions.def:193 LANGOPT(OpenMPUseTLS , 1, 0, "Use TLS for threadprivates or runtime calls") +LANGOPT(OpenMPImplicitDeclareTarget , 1, 0, "Enable implicit declare target extension - marks automatically d

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev created this revision. Some info about supported features of OpenMP 4.5-5.0. https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst +++ docs/index.rst

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev added a comment. In https://reviews.llvm.org/D39457#911950, @Hahnfeld wrote: > Do we want to add documentation about which target devices Clang can generate > code for? Ok Comment at: docs/OpenMPSupport.rst:46 + +* #pragma omp distribute parallel for [simd]: :partia

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 121018. ABataev added a comment. Added info about supported devices. https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- docs/index.

[PATCH] D39504: [OpenMP] Extend "Avoid VLAs for reduction" optimization to VLAs as base

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D39504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D38976: [OpenMP] Add implicit data sharing support when offloading to NVIDIA GPUs using OpenMP device offloading

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D38976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D39505: [OpenMP] Show error if VLAs are not supported

ABataev added inline comments. Comment at: include/clang/Basic/TargetInfo.h:944 + /// \brief Whether target supports variable-length arrays. + bool isVLASupported() const { return VLASupported; } + Hahnfeld wrote: > rjmccall wrote: > > Hahnfeld wrote: > > > rjm

[PATCH] D39505: [OpenMP] Show error if VLAs are not supported

ABataev added inline comments. Comment at: include/clang/Basic/TargetInfo.h:944 + /// \brief Whether target supports variable-length arrays. + bool isVLASupported() const { return VLASupported; } + ABataev wrote: > Hahnfeld wrote: > > rjmccall wrote: > > > Hahn

[PATCH] D39745: Clang/libomptarget map interface flag renaming - NFC patch

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D39745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 122268. ABataev added a comment. Update status. https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst +++ docs/index.rs

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 122273. ABataev added a comment. Fixed version of OpenMP standard https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

ABataev added inline comments. Comment at: lib/Sema/SemaExpr.cpp:14356 +if (S.IsOpenMPCapturedDecl(Var)) { + bool hasConst = DeclRefType.isConstQualified(); DeclRefType = DeclRefType.getUnqualifiedType(); `hasConst` must start from capital letter

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D39859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

ABataev added a comment. In https://reviews.llvm.org/D39859#921780, @jdenny wrote: > Alexey: Thanks for accepting. I do not have commit privileges. Would you > please commit for me? Sure, no problems. https://reviews.llvm.org/D39859 ___ cfe-co

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

This revision was automatically updated to reflect the committed changes. Closed by commit rL317891: [OpenMP] diagnose assign to firstprivate const, patch by Joel E. Denny (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D39859?vs=122329&id=122434#toc Repository: rL L

[PATCH] D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D39902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D39505: [OpenMP] Show error if VLAs are not supported

ABataev added inline comments. Comment at: include/clang/Basic/TargetInfo.h:944 + /// \brief Whether target supports variable-length arrays. + bool isVLASupported() const { return VLASupported; } + Hahnfeld wrote: > rjmccall wrote: > > Hahnfeld wrote: > > > rjm

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 123373. ABataev added a comment. Updated info about supported constructs. https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === --- docs/i

[PATCH] D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D40187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

<    13   14   15   16   17   18   19   20   21   22   >