[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2402661 , @ye-luo wrote: > 1. Could you separate the reordering related changes to separate patch? It is impossible. There is a separate patch for removing extra TGT_TARGET_PARAM but it cannot be separated from this pat

[PATCH] D91660: [OPENMP]Fix PR48174: compile-time crash with target enter data on a global struct.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ba324ccadce: [OPENMP]Fix PR48174: compile-time crash with target enter data on a global… (authored by ABataev). Repository: rG LLVM Github Monor

[PATCH] D91805: [OPENMP]Use the real pointer value as base, not indexed value.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. After fix for PR48174 the base pointer for pointer-based array-sections/array-subscripts will be emitt

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. In D74144#2307454 , @cchen wrote: > @ABataev, the below test is extracted from Sollve test suite and Clang now > emit: > > test.c:17:35: error: subscripted value is not an array or pointer > #pragma omp target update to(

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. In D74144#2308796 , @cchen wrote: > In D74144#2307494 , @ABataev wrote: > >> In D74144#2307454 , @cchen wrote: >> >>> @ABataev, the below test is ext

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added a comment. LG with a nit. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3195 +enum ArchPtrSize { Arch16Bit, Arch32Bit, Arch64Bit }; +auto getArchPtrSize = [](llvm::Triple &T) { + if (T.isArch16Bit()) `const Triple &` Reposit

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

ABataev added a comment. In D88978#2325982 , @scott.linder wrote: > @ABataev Sorry if I'm pulling you in without enough context/work on my end, > but I wanted to ask how the Clang codegen for OpenMP locals works at a high > level? > > Is the idea that i

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2330310 , @jdenny wrote: > Thanks for working on this. Sorry to take so long to review. Before I try > to digest the code, I have a few high-level questions. > > Based on the test suite changes, `TARGET_PARAM` is disap

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2330601 , @jdenny wrote: > In D86119#2330339 , @ABataev wrote: > >> In D86119#2330310 , @jdenny wrote: >> >>> Thanks for working on this.

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

ABataev added a comment. In D91373#2408175 , @jacobdweightman wrote: > Ping 1. Provide full diff, see https://www.llvm.org/docs/Phabricator.html for the guidance. 2. Need some more test with ast printing and codegen. 3. Would be good if you could run

[PATCH] D91644: [OPENMP]Honor constantness of captured variables.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f51dc49673c: [OPENMP]Honor constantness of captured variables. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D91805: [OPENMP]Use the real pointer value as base, not indexed value.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc964f3081415: [OPENMP]Use the real pointer value as base, not indexed value. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > `const` member functi

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; What about `llvm::iplist`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; sdmitriev wrote: > ABataev wrote: > > What about `llvm::iplist`? > It can be changed to

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92010/new/ https://reviews.llvm.org/D92010 ___ c

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added a comment. Why don't yo want to try to implement the scheme similar to the declare target? Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssum

[PATCH] D91261: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives.

ABataev updated this revision to Diff 307694. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91261/new/ https://reviews.llvm.org/D91261 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_mappe

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added a comment. In D91980#2417049 , @jdoerfert wrote: > In D91980#2416950 , @ABataev wrote: > >> Why don't yo want to try to implement the scheme similar to the declare >> target? > > Because it is not cle

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1569-1593 +int idx = -1; +if (Tok.isAnyIdentifier()) { + II = Tok.getIdentifierInfo(); + llvm::StringSwitch SS(II->getName()); + for (const AssumptionClauseMappingInfo &ACMI : Assump

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16869 +// Allow results of method calls to be mapped. +if (isa(ME->getMemberDecl())) { + RelevantExpr = ME; I don't think it should always return `true`. What about `map(s.foo)`

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

ABataev added a comment. I would just remove this extra symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3310 + case OMPC_DEFAULTMAP_MODIFIER_present: +// If implicit-behavior is present, each variable referenced in the +// construct in the category specified by variable-category is treated as if

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1296-1297 +: Error<"'#pragma omp end assumes' with no matching '#pragma omp begin assumes'">; +def err_expected_assumption_clause +: Error<"'%0' directive requires at least one c

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:373 +/// +class OMPMetaDirective final : public OMPExecutableDirective { + friend class ASTStmtReader; I think, metadirective should be a kind of a container for different sub-direc

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:373 +/// +class OMPMetaDirective final : public OMPExecutableDirective { + friend class ASTStmtReader; alokmishra.besu wrote: > ABataev wrote: > > I think, metadirective should be a

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3490 +OMPC_MAP_MODIFIER_present); +ImplicitMapModifierLoc[ClauseKind].push_back(SourceLocation()); + } cchen wrote: > ABataev wrote: > > Why need to add

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3203-3206 + if (!SkippedClauses && Assumptions.empty()) +Diag(Loc, diag::err_omp_no_clause_for_directive) +<< llvm::omp::getAllAssumeClauseOptions() +<< llvm::omp::getOpenMPDirectiveName

[PATCH] D92655: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Compiler needs to convert some of the loop iteration variables/conditions t

[PATCH] D92655: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2502f8995431: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5940 +void Sema::ActOnFinishedFunctionDefinitionInOpenMPAssumeScope(Decl *D) { + FunctionDecl *FD = nullptr; + if (auto *UTemplDecl = dyn_cast(D)) You can also check if the decl is invalid

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 ___ c

[PATCH] D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: jfb, guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. The variables used in atomic construct should be captured in outer tas

[PATCH] D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd764ad72e5fe: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs. (authored by ABataev). Repository: rG LLVM Github Monorepo

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. Entry 0 is the address that should be passed to the kernel (for the captured variable, that's why it is marked as TGT_TARGET_PARAM - target kernel argument), entries 1-3 are the actual mappings. Yes, I assume the frontend can fuse these entries in many cases, but it is

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I]; Ma

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2437676 , @cchen wrote: > Just tried this patch and found that below test abort inside > `generateInfoCapture`. > > #include > #define LEN 100 > int buf[LEN]; > > int main() > { > int i; > int *

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

ABataev added a comment. In D88978#2343484 , @jdoerfert wrote: > I have no idea what from the commit message what this has to do with the > OpenMP code gen but I saw this randomly while looking for something else so > here we go: > > In D88978#2326036

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

ABataev added a comment. In D89994#2348655 , @JonChesterfield wrote: > The nvptx back end accepts common + zero + shared, but not common + undef + > shared. I think weak_odr is conceptually right here, but given the warning > that nvlink doesn't support

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2858 TransferMedium = new llvm::GlobalVariable( -M, Ty, /*isConstant=*/false, llvm::GlobalVariable::CommonLinkage, -llvm::Constant::getNullValue(Ty), TransferMediumName, +

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2858 TransferMedium = new llvm::GlobalVariable( -M, Ty, /*isConstant=*/false, llvm::GlobalVariable::CommonLinkage, -llvm::Constant::getNullValue(Ty), TransferMediumName, +

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12577-12578 Stmt *Body = nullptr; - SmallVector OriginalInits; + SmallVector>, 4> OriginalInits; + OriginalInits.emplace_back(); if (!OMPLoopBasedDirective::doForAllLoops( `SmallVe

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added a comment. Some previous comments were not addressed yet Comment at: clang/include/clang/AST/OpenMPClause.h:972-974 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + Make it private

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12579 Stmt *Body = nullptr; - SmallVector OriginalInits; + SmallVector>, 4> OriginalInits(1); if (!OMPLoopBasedDirective::doForAllLoops( Why still `std::vector`? Repository: rG

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 345565. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ABataev added a comment. In D101849#2764798 , @jdoerfert wrote: > In D101849#2764703 , @mikerice > wrote: > >>> // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd >>> -emit-llvm %s -o - |

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102670/new/ https://reviews.llvm.org/D102670 ___

[PATCH] D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102752/new/ https://reviews.llvm.org/D102752 ___

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 ___

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:907 + /// \param C Context of the AST. + /// \param Loc Location of the 'full' identifier. + static OMPFullClause *Create(const ASTContext &C, SourceLocation StartLoc, Fix para

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2535321 , @Meinersbur wrote: > Thank you for the update. > > From comparing the diffs, here is the list of main changes I found: > > 1. Create `OMPLoopBasedDirective` as a new base class for OMPLoopDirective > (and OMPTi

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } 1. Make it private, please 2. Var names must start from capital letter `stmt`->`S

[PATCH] D109990: [OpenMP][Docs] Update clang support based on community discussion

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109990/new/ https://reviews.llvm.org/D109990 ___

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } cchen wrote: > ABataev wrote: > > 1. Make it private, please > > 2. Var names mus

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } cchen wrote: > ABataev wrote: > > cchen wrote: > > > ABataev wrote: > > > > 1. Ma

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:54 + sa[1].f.b == &x[0] ? 1 : 0); + // CHECK: 111 222 777 20.0 1 + cchen wrote: > Do we really expect `sa[1].f.b` be the same

[PATCH] D111045: [clang] Fix computation of number of dependencies using OpenMP iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfc8f9e9b0bd: [clang] Fix computation of number of dependencies using OpenMP iterator, (authored by ABataev). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 376914. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 376920. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 376945. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/reduction_i

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 376947. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_linear_codegen.

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8445-8463 +const ValueDecl *VD = Cap.getCapturedVar()->getCanonicalDecl(); +const auto *RD = VD->getType() + .getCanonicalType() + .getNonRefer

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19/new/ https://reviews.llvm.org/D19 ___

[PATCH] D111124: [Clang][OpenMP] Allow loop-transformations with template parameters.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24/new/ https://reviews.llvm.org/D24 ___

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. Just a note: >> 4.b. still feels like a hack because there are captures variables outside of >> any CapturedStmt and therefore complicated the AST. Comparable directive >> such as master don't do this. It is not a hack, this was an optimization to minimize the number o

[PATCH] D95903: [OpenMP][NFC] Pre-commit test changes regarding PR48933

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95903/new/ https://reviews.llvm.org/D95903 ___ c

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev marked 2 inline comments as done. ABataev added a comment. In D86119#2562187 , @grokos wrote: > In D86119#2561163 , @abhinavgaba > wrote: > >> Thanks for the changes, Alexey! I tried the patch locally, and

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2562097 , @Meinersbur wrote: > Who is going to commit? I can commit it as soon as you accepted it if you don't mind of course. Comment at: clang/include/clang/AST/StmtOpenMP.h:651-677 + static bool +

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2565945 , @Meinersbur wrote: > In D76342#2565686 , @ABataev wrote: > >> I can commit it as soon as you accepted it if you don't mind of course. > > I do not mind Ok, will commit i

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

ABataev updated this revision to Diff 325425. ABataev added a comment. Temp update, not finished yet. Still WIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92195/new/ https://reviews.llvm.org/D92195 Files: clang/include/clang/AST/OpenMPClause

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

ABataev updated this revision to Diff 326144. ABataev added a comment. Fixes and updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92195/new/ https://reviews.llvm.org/D92195 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

ABataev updated this revision to Diff 326445. ABataev added a comment. Removed unnecessary changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92195/new/ https://reviews.llvm.org/D92195 Files: clang/include/clang/AST/OpenMPClause.h clang/li

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 349627. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D103642: [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper` clause.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a project: clang. Patch allows using of constexpr vars evaluatable to constant calue to be used in declare mapper construct. Rep

[PATCH] D103665: [Clang][OpenMP] Add static version of getSingleClause. NFC.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103665/new/ https://reviews.llvm.org/D103665 ___

[PATCH] D103666: [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103666/new/ https://reviews.llvm.org/D103666 ___

[PATCH] D103642: [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper` clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG827b5c21545a: [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper`… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12821 +/// Determine whether an expression is constant without emitting diagnostic. +static bool isConstantExpression(Sema &SemaRef, Expr *E) { + struct ConstTripcountDiagnoser : public Sema::VerifyICEDiagn

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 350870. ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Se

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103995/new/ https://reviews.llvm.org/D103995 ___

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600-2604 + RValue FactorRVal = EmitAnyExpr(FactorExpr, AggValueSlot::ignored(), + /*ignoreResult=*/true); + Factor = + cast(FactorRVal.getScalarV

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99459/new/ https://reviews.llvm.org/D99459 ___ c

[PATCH] D104240: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Added support for CXXRewrittenBinaryOperator as a condition in ran

<    7   8   9   10   11   12   13   14   15   16   >