[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231644. bader marked an inline comment as done. bader added a comment. Applied @aaron.ballman suggestions to kernel-attribute.cpp test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader added a comment. I hope all comments from are @Fznamznon and @aaron.ballman are applied. @ABataev, do you have any other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 ___

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231679. bader marked 2 inline comments as done. bader added a comment. Fixed SYCL code example for sycl_kernel attribute documentation and commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

This revision was automatically updated to reflect the committed changes. Closed by commit rGc094e7dc4b3f: [SYCL] Add sycl_kernel attribute for accelerated code outlining (authored by Fznamznon, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader created this revision. bader added reviewers: aaron.ballman, Anastasia. Herald added subscribers: cfe-commits, ebevhan, yaxunl. Herald added a project: clang. Enable a way to set OpenCL language address space using attributes in addition to existing keywords. Signed-off-by: Victor Lomuller

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader updated this revision to Diff 232098. bader added a comment. Change attribute prefix: `ocl_` -> `opencl_`. Updated OpenCL spelling in the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71005/new/ https://reviews.llvm.org/D71005 Fil

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1123 def OpenCLPrivateAddressSpace : TypeAttr { - let Spellings = [Keyword<"__private">, Keyword<"private">]; + let Spellings = [Keyword<"__private">, Keyword<"pr

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader marked an inline comment as done. bader added a comment. In D71005#1770338 , @Anastasia wrote: > LGTM! Thanks! > > I presume OpenCL addr space logic won't apply in all cases in non-OpenCL > compilations i.e. for example C++ because we enclose some o

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG11a9bae8f669: [AST] Enable expression of OpenCL language address spaces an attribute (authored by Naghasan, committed by bader). Changed prior to commit: https://reviews.llvm.org/D71005?vs=232098&id=232

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1123 def OpenCLPrivateAddressSpace : TypeAttr { - let Spellings = [Keyword<"__private">, Keyword<"private">]; + let Spellings = [Keyword<"__private">, Keyword<"pr

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader added a comment. >>> is there a reason this should be clang::opencl_private as opposed to >>> opencl::private? >> >> I'm okay with [[opencl::private]] as well. I have only one problem - >> currently OpenCL address spaces are exposed as keywords and using them in >> C++ breaks valid C++ c

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader added a comment. @aaron.ballman, thank you for fixing the problem with documentation generation. With regards to attributes naming question, let me check if I get it right. 1. You suggest checking with Khronos if they want to adopt `[[opencl::private]]` attribute names in OpenCL kernel la

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

bader added a comment. I'm looking for test suggestions as I was not able to find tests covering similar changes for OpenMP compiler. https://github.com/llvm/llvm-project/commit/59d7b77b16bf11810091fe75a4348198783d3fbc modifies driver and front-end, but adds only driver tests. Repository: r

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

bader created this revision. bader added a reviewer: ABataev. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a reviewer: jdoerfert. Herald added a project: clang. bader added a comment. I'm looking for test suggestions as I was not able to find tests covering similar chan

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

bader added a comment. In D71286#1777894 , @ABataev wrote: > Most probably, just missed the testing of the frontend part here Should I add test for both: SYCL and OpenMP? What is the right place for this kind of tests: clang/test/Preprocessor/ or clang/

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

bader updated this revision to Diff 233303. bader added a comment. Added LIT test. If it's okay, I'll add similar test for OpenMP device compiler to clang/test/OpenMP directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/ https://rev

[PATCH] D71286: [SYCL] Add support for auxiliary triple specification to Frontend

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb30ad728f0b: [SYCL] Add support for auxiliary triple specification to Frontend (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/

[PATCH] D71272: [OpenCL] Pretty print __private addr space

bader added a subscriber: AlexeySotkin. bader added a comment. LGTM, but I'd like someone who works on OpenCL front-end to approve. +@AlexeySotkin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71272/new/ https://reviews.llvm.org/D71272 ___

[PATCH] D71413: [OpenMP][Test] Add check for aux-triple predefined macros

bader created this revision. bader added a reviewer: ABataev. Herald added subscribers: cfe-commits, ebevhan, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Make sure that auxiliary target specific macros are defined in OpenMP mode. Repository: rG LLVM Github Mono

[PATCH] D71413: [OpenMP][Test] Add check for aux-triple predefined macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d6a5e4fe45d: [OpenMP][Test] Add check for aux-triple predefined macros (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71413/new/ https:

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

bader added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 241757. bader added a comment. Applied suggestion from Ruyman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang/Basic/LangOptions.def clang/

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 241872. bader added a comment. Fix clang-format and clang-tidy issues reported by merge_guards_bot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Gro

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader created this revision. bader added a reviewer: ABataev. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. As a first step this implementation enables compilation of the offload code. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242590. bader added a comment. Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChain

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242627. bader added a comment. Applied suggestions from Alexey Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader marked 3 inline comments as done. bader added a comment. Thanks for the prompt review. I've applied your suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242639. bader added a comment. Refactor clang/lib/Driver/ToolChains/Clang.cpp in accordance with Alexey's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Fil

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242640. bader added a comment. Applied clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Too

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG863d9752105f: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 242845. bader added a comment. Applied suggestions from Alexey and Ruyman and rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 242909. bader marked 2 inline comments as done. bader added a comment. Applied Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/c

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 7 inline comments as done. bader added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { ABataev wrote: >

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { ABataev wrote: >

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 243029. bader added a comment. Ignore `-sycl-std` if it used in non-SYCL mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang/Basic/LangOpti

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 243173. bader marked 2 inline comments as done. bader added a comment. Applied code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/includ

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def fno_s

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 243856. bader marked 3 inline comments as done. bader added a comment. Applied review commits from Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined, "Versi

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 245213. bader added a comment. Address comments from Victor and Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. User can select the version of SYCL the compiler will use via the flag -sycl-std, similar to -cl-std. The flag defines the LangOpts.SYCLVersion option to the version of SYCL. The

[PATCH] D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

bader created this revision. bader added reviewers: aaron.ballman, Fznamznon. Herald added subscribers: cfe-commits, ebevhan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73104 Files: clang/include/clang/Basic/AttrDocs.td Index: clang/include

[PATCH] D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd18729b2a7a: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D731

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added a comment. > Maybe we should use the year of issue (2015 instead of 1.2.1) for the > -sycl-std version? That would be more stable for the upcoming SYCL versions, > and match somehow the C++ versioning. Sounds good to me. I'll update the patch.

[PATCH] D73651: [OpenCL][CUDA][HIP] Add norecurse

bader added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:923 +if ((getLangOpts().CPlusPlus && FD->isMain()) || getLangOpts().OpenCL || +(getLangOpts().CUDA && FD->hasAttr())) + Fn->addFnAttr(llvm::Attribute::NoRecurse); SYCL

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

bader added a comment. In D73651#1847862 , @yaxunl wrote: > Added handling of SYCL kernels by Alexey's comments. I cannot add a codegen > test for SYCL since I cannot find a way to instantiate a SYCL kernel. I think SYCL implementation should follow Ope

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

bader accepted this revision. bader added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

bader added a comment. @lebedev.ri, thanks for the suggestion. We will investigate this option when we ready to upload clang diagnostics patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72362/new/ https://reviews.llvm.org/D72362 ___

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

bader added inline comments. Comment at: include/clang/Frontend/LangStandards.def:167 +LANGSTANDARD_ALIAS_DEPR(opencl22, "CL2.2") +LANGSTANDARD_ALIAS_DEPR(opencl22, "clc++") +LANGSTANDARD_ALIAS_DEPR(opencl22, "CLC++") OpenCL C++ 1.0 specification defines only 'c+

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D45363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D39129: [OpenCL] Fix generation of constant address space sampler in function scope

bader added a comment. In https://reviews.llvm.org/D39129#923235, @Anastasia wrote: > In https://reviews.llvm.org/D39129#902848, @bader wrote: > > > @Anastasia, during the discussion of similar fix > > (https://reviews.llvm.org/D34342). > > > > I found another bug in the CodeGen library. Do you

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL318290: [OpenCL] Fix code generation of function-scope constant samplers. (authored by bader). Repository: rL LLVM https://reviews.llvm.org/D34342 Files: cfe/trunk/lib/CodeGen/CGDecl.cpp cfe/trunk

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

bader added a comment. @hvdijk, thanks a lot for fixing this. In D147097#4229121 , @hvdijk wrote: > Is the rationale I gave in the description correct, or would it be better for > SYCL device code to unconditionally build without `-fexceptions` and get

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

bader added inline comments. Comment at: clang/test/Driver/offload-packager.c:2-3 +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target +// REQUIRES: amdgpu-registered-target +// UNSUPPORTED: system-windows Are nvptx and amdgpu target required

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147097/new/ https://reviews.llvm.org/D147097

[PATCH] D151361: [CUDA] bump supported CUDA version to 12.1/11.8

bader added inline comments. Comment at: clang/docs/ReleaseNotes.rst:590 +- Clang now supports CUDA SDK up to 12.1 @tra, could you update llvm/docs/CompileCudaWithLLVM.rst as well, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D151361: [CUDA] bump supported CUDA version to 12.1/11.8

bader added inline comments. Comment at: clang/docs/ReleaseNotes.rst:590 +- Clang now supports CUDA SDK up to 12.1 tra wrote: > bader wrote: > > @tra, could you update llvm/docs/CompileCudaWithLLVM.rst as well, please? > Done in d028188412fa54774

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader added a comment. Thanks for working on this! Looks good, except a few pedantic notes. Comment at: docs/UsersManual.rst:44 - :ref:`Objective C++ Language ` +- :ref:`OpenCL Language `: v1.0, v1.1, v1.2, v2.0. It should and to be perfectly clear we migh

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader accepted this revision. bader added a comment. LGTM. Thanks! https://reviews.llvm.org/D28080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

bader added a comment. > From all the above arguments, I feel like the right approach would be to > implement it as Clang builtin which closely matches the operator semantic in > my opinion. We could of course reuse the implementation of __bultin_astype > to avoid unnecessary extra work and co

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

bader added inline comments. Comment at: lib/Headers/opencl-c.h:6588 -char __ovld __cnfn as_char(char); -char __ovld __cnfn as_char(uchar); - Anastasia wrote: > Why do we have some of the overloads omitted? Would this cause any extra > conversions? uchar -> char

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

bader added a comment. Anastasia, could you generate patch with full context, please? https://reviews.llvm.org/D31397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

bader added inline comments. Comment at: lib/Sema/SemaDecl.cpp:2157 if (getDiagnostics().getSuppressSystemWarnings() && - (Context.getSourceManager().isInSystemHeader(Old->getLocation()) || + // Some standard types are defined implicitly in Clang (e.g. OpenCL). +

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. I think my topics are not related to the bug 25404 and can be handled separately. Thanks! https://reviews.llvm.org/D31397 ___ cfe-commits mailing

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader added inline comments. Comment at: docs/UsersManual.rst:2065 + + $ clang -cc1 -triple spir64-unknown-unknown -cl-ext=-cl_khr_fp64 test.cl + pekka.jaaskelainen wrote: > Anastasia wrote: > > pekka.jaaskelainen wrote: > > > Is this correct? I cannot make i

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

bader added a comment. Note: `get_sampler_initializer` from my test case returns integer, not a sampler, but having function is not relevant to the problem. Here is a bit simplified test case without function calls that still reproduces the problem: kernel void foo(int sampler_init_value) {

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

bader added a comment. @chapuni, thanks for taking care of this. I'll take a look. https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34871: [OpenCL] Add function name to extension diagnostic

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Just one minor comment. Thanks. Comment at: clang/Sema/Sema.h:8435 /// \return true if type is disabled. - bool checkOpenCLDisabledDecl(const Decl &D, const Expr &E);

[PATCH] D34948: [OpenCL] Generalise err_opencl_enqueue_kernel_expected_type to be used with other builtins

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Do you have another built-in in mind which can use this diagnostic message? If so, it would make sense to re-use it in the same patch. https://reviews.llvm.org/D34948 __

[PATCH] D34948: [OpenCL] Generalise err_opencl_enqueue_kernel_expected_type to be used with other builtins

bader added a comment. >> Do you have another built-in in mind which can use this diagnostic message? >> If so, it would make sense to re-use it in the same patch. > > This is split off from https://reviews.llvm.org/D33945, which I will be > rebasing/re-uploading once this patch is committed.

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM, thanks. https://reviews.llvm.org/D35082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Thanks! Overall the patch looks good, but I would suggest splitting it into three commits (as they seems to be independent): 1. [OpenCL] Check that cl_khr_subgroups pragma is enabled if respecti

[PATCH] D42307: [OpenCL][6.0.0 Release] Release notes for OpenCL in Clang

bader accepted this revision. bader added a comment. Looks good to me. Thanks for working on this. https://reviews.llvm.org/D42307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42532: [OpenCL] Add "cles_khr_int64" extension.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM, but I'd like Anastasia to approve. Thanks. Repository: rC Clang https://reviews.llvm.org/D42532 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D42532: [OpenCL] Add "cles_khr_int64" extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323522: [OpenCL] Add "cles_khr_int64" extension. (authored by bader, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42532 Files: cfe/trunk/inc

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

bader added a comment. > Why do you think this is a bug? It seems to follow standard behavior in C to > promote char to int if required. Just like if you would have a C code: > > int as_int(int i); > void foo() { > char src = 1; > int dst = as_int(src); > } > > > This cod

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

bader added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error< ---

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

bader added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error< ---

[PATCH] D30816: [OpenCL] Added implicit conversion rank for overloading functions with vector data type in OpenCL

bader added inline comments. Comment at: test/SemaOpenCL/overload_addrspace_resolution.cl:1 -// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple x86_64-unknown-unknown %s | FileCheck %s +// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple spir-unknown-unknown %s | Fil

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

bader added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error< ---

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288126: [OpenCL] Prohibit using reserve_id_t in program scope. (authored by bader). Changed prior to commit: https://reviews.llvm.org/D27099?vs=79508&id=79525#toc Repository: rL LLVM https://reviews

[PATCH] D27334: [OpenCL] Ambiguous function call.

bader added a comment. In https://reviews.llvm.org/D27334#611703, @Anastasia wrote: > This change seems to modify normal C behavior again. Is there any strong > motivation for doing this and if yes could it be done generically with C? Motivation: // Non-portable OpenCL 1.2 code __kernel

[PATCH] D27334: [OpenCL] Ambiguous function call.

bader added a comment. In https://reviews.llvm.org/D27334#613504, @Anastasia wrote: > In https://reviews.llvm.org/D27334#612858, @bader wrote: > > > In https://reviews.llvm.org/D27334#611703, @Anastasia wrote: > > > > > This change seems to modify normal C behavior again. Is there any strong > >

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288890: [OpenCL] Fix SPIR version generation. (authored by bader). Changed prior to commit: https://reviews.llvm.org/D27300?vs=80229&id=80548#toc Repository: rL LLVM https://reviews.llvm.org/D27300

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288891: [OpenCL] Added a LIT test for ensuring address space mangling is done the same… (authored by bader). Changed prior to commit: https://reviews.llvm.org/D27403?vs=80401&id=80549#toc Repository:

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

bader added a comment. @echuraev, please, request commit access as described here: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rL LLVM https://reviews.llvm.org/D27403 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

bader added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); ---

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

bader added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); ---

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

bader added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); ---

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

bader added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); ---

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

bader added inline comments. Comment at: clang/docs/UsersManual.rst:3602 +Linking is done using ``spirv-link`` from `the SPIRV-Tools project +`_. Similar to other external @Anastasia, sorry for late feedback.

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM, just one suggestion. It would be great to get @aaron.ballman approve too. Comment at: clang/lib/Sema/SemaDecl.cpp:16690 + diag::err_sycl_special_type_missing_

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local

<    1   2   3   4   >