Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

alexshap added a comment. Thx, I do. Repository: rL LLVM https://reviews.llvm.org/D24484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r281373 - [analyzer] Fix ExprEngine::VisitMemberExpr

Author: alexshap Date: Tue Sep 13 14:17:20 2016 New Revision: 281373 URL: http://llvm.org/viewvc/llvm-project?rev=281373&view=rev Log: [analyzer] Fix ExprEngine::VisitMemberExpr AST may contain intermediate ParenExpr nodes between MemberExpr and ArrayToPointerDecay. This diff adjusts the check in

Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL281373: [analyzer] Fix ExprEngine::VisitMemberExpr (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D24484?vs=71082&id=71218#toc Repository: rL LLVM https://reviews.llvm.org

r281385 - Remove excessive padding from PTHWriter

Author: alexshap Date: Tue Sep 13 15:17:57 2016 New Revision: 281385 URL: http://llvm.org/viewvc/llvm-project?rev=281385&view=rev Log: Remove excessive padding from PTHWriter The class PTHWriter is in lib/Frontend/CacheTokens.cpp inside the anonymous namespace. This diff changes the order of fie

Re: [PATCH] D23902: Minor cleanup of PTHWriter

This revision was automatically updated to reflect the committed changes. Closed by commit rL281385: Remove excessive padding from PTHWriter (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D23902?vs=69311&id=71229#toc Repository: rL LLVM https://reviews.llvm.org/D2

Re: [PATCH] D24330: Add some MS aliases for existing intrinsics

alexshap added a subscriber: alexshap. Comment at: include/clang/Basic/Builtins.h:142 @@ -141,1 +141,3 @@ + // \brief Returns true if this builtin requires appropriate header in other + // compilers. In Clang it will work even without including it, but we can emit ---

r300114 - [analyzer] Add a check for IvarRegion in getExtraInvalidatedValues

Author: alexshap Date: Wed Apr 12 17:00:13 2017 New Revision: 300114 URL: http://llvm.org/viewvc/llvm-project?rev=300114&view=rev Log: [analyzer] Add a check for IvarRegion in getExtraInvalidatedValues This diff adds a defensive check in getExtraInvalidatedValues for the case when there are no re

[clang-tools-extra] r300356 - [clang-move] Create ClangMoveActionFactory on stack

Author: alexshap Date: Fri Apr 14 13:12:11 2017 New Revision: 300356 URL: http://llvm.org/viewvc/llvm-project?rev=300356&view=rev Log: [clang-move] Create ClangMoveActionFactory on stack This diff removes unnecessary using of unique_ptr with ClangMoveActionFactory (pico cleanup). NFC Test plan:

r300427 - [clang] Register isConstexpr matcher

Author: alexshap Date: Sun Apr 16 14:05:17 2017 New Revision: 300427 URL: http://llvm.org/viewvc/llvm-project?rev=300427&view=rev Log: [clang] Register isConstexpr matcher This diff registers isConstexpr matcher. Test plan: make check-all check that "match varDecl(isConstexpr())" works in clang

r306343 - [clang] Enable printf check for CFIndex

Author: alexshap Date: Mon Jun 26 16:02:27 2017 New Revision: 306343 URL: http://llvm.org/viewvc/llvm-project?rev=306343&view=rev Log: [clang] Enable printf check for CFIndex According to https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers

r307604 - [analyzer] Start fixing modeling of bool based types

Author: alexshap Date: Mon Jul 10 17:30:14 2017 New Revision: 307604 URL: http://llvm.org/viewvc/llvm-project?rev=307604&view=rev Log: [analyzer] Start fixing modeling of bool based types This is a follow up for one of the previous diffs https://reviews.llvm.org/D32328. getTypeSize and with getI

r308037 - [clang] Add getSignedSizeType method

Author: alexshap Date: Fri Jul 14 10:30:14 2017 New Revision: 308037 URL: http://llvm.org/viewvc/llvm-project?rev=308037&view=rev Log: [clang] Add getSignedSizeType method C11 standard refers to the signed counterpart of the type size_t in the paragraph 7.21.6.1 where it defines d, i, o, u, x, or

r308067 - [clang] Fix handling of "%zd" format specifier

Author: alexshap Date: Fri Jul 14 15:57:00 2017 New Revision: 308067 URL: http://llvm.org/viewvc/llvm-project?rev=308067&view=rev Log: [clang] Fix handling of "%zd" format specifier This diff addresses FIXME in lib/Analysis/PrintfFormatString.cpp and makes PrintfSpecifier::getArgType return the c

r308073 - [clang] Fix format test

Author: alexshap Date: Fri Jul 14 18:06:59 2017 New Revision: 308073 URL: http://llvm.org/viewvc/llvm-project?rev=308073&view=rev Log: [clang] Fix format test This diff makes the test FixIt/format.m more robust. The issue was caught by the build bot clang-cmake-thumbv7-a15. Test plan: make chec

r308662 - [clang] Fix handling of "%zd" in scanf

Author: alexshap Date: Thu Jul 20 13:11:47 2017 New Revision: 308662 URL: http://llvm.org/viewvc/llvm-project?rev=308662&view=rev Log: [clang] Fix handling of "%zd" in scanf This diff addresses FIXMEs in lib/Analysis/ScanfFormatString.cpp for the case of ssize_t format specifier and adds tests.

[clang-tools-extra] r308678 - [clang-tools-extra] Add support for plain C structs in clang-reorder-fields

Author: alexshap Date: Thu Jul 20 14:41:20 2017 New Revision: 308678 URL: http://llvm.org/viewvc/llvm-project?rev=308678&view=rev Log: [clang-tools-extra] Add support for plain C structs in clang-reorder-fields This diff updates the tool clang-reorder-fields to enable reordering of fields of plai

Re: [PATCH] Add warning to clang-reorder-fields when dependencies of init-list exprs are violated

Hi, Sam, many thanks for the patch, I'm sorry I didn't notice it earlier. Do you mind uploading your patch to Phabricator, see https://llvm.org/docs/Phabricator.html for instructions, so it would be easier to review / discuss the changes. Kind regards, Alexander Shaposhnikov On Sun, Jul 9, 2017 at

r323146 - [analyzer] Protect against dereferencing a null pointer

Author: alexshap Date: Mon Jan 22 12:18:42 2018 New Revision: 323146 URL: http://llvm.org/viewvc/llvm-project?rev=323146&view=rev Log: [analyzer] Protect against dereferencing a null pointer The check (inside StackHintGeneratorForSymbol::getMessage) if (!N) return getMessageForSymbolNotFound(

r323382 - [analyzer] Do not attempt to get the pointee of void*

Author: alexshap Date: Wed Jan 24 14:17:30 2018 New Revision: 323382 URL: http://llvm.org/viewvc/llvm-project?rev=323382&view=rev Log: [analyzer] Do not attempt to get the pointee of void* Do not attempt to get the pointee of void* while generating a bug report (otherwise it will trigger an asse

[PATCH] D26839: [analyzer] An attempt to fix pr19539 - crashes on temporaries life-extended via members

alexshap added inline comments. Comment at: test/Analysis/lifetime-extension.cpp:11 + int j[2]; + S s; + A() : i(1) { what is the role of S in this test ? https://reviews.llvm.org/D26839 ___ cfe-commits mailing

[PATCH] D26845: [analyzer] Fix crash on the access to a union's region.

alexshap added a comment. Thanks, - just want to have one of them (https://reviews.llvm.org/D26442 or this one) checked in sooner rather than later. Looks like i have missed that diff on cfe-commits, I'm ok to abandon my patch in favor of https://reviews.llvm.org/D26442. Repository: rL LLVM

[PATCH] D26442: [analyzer] Fix crash on getSVal: handle case of CompoundVal

alexshap added a comment. @NoQ , @ilya-palachev - what are the plans for this ? Repository: rL LLVM https://reviews.llvm.org/D26442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r289464 - [clang-move] Use appendArgumentsAdjuster for adding extra arguments

Author: alexshap Date: Mon Dec 12 13:56:37 2016 New Revision: 289464 URL: http://llvm.org/viewvc/llvm-project?rev=289464&view=rev Log: [clang-move] Use appendArgumentsAdjuster for adding extra arguments 1. Remove some boilerplate code for appending -fparse-all-comments to the list of arguments.

[clang-tools-extra] r289465 - [clang-move] Fix buildbot failures

Author: alexshap Date: Mon Dec 12 14:24:44 2016 New Revision: 289465 URL: http://llvm.org/viewvc/llvm-project?rev=289465&view=rev Log: [clang-move] Fix buildbot failures Fix the buildbot failures introduced by D27669 Modified: clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp Modifi

r300936 - [analyzer] Fix assert in ExprEngine::processSwitch

Author: alexshap Date: Thu Apr 20 20:05:26 2017 New Revision: 300936 URL: http://llvm.org/viewvc/llvm-project?rev=300936&view=rev Log: [analyzer] Fix assert in ExprEngine::processSwitch This diff replaces getTypeSize(CondE->getType())) with getIntWidth(CondE->getType())) in ExprEngine::processSw

r302855 - [tooling] RefactoringCallbacks code cleanup

Author: alexshap Date: Thu May 11 19:16:56 2017 New Revision: 302855 URL: http://llvm.org/viewvc/llvm-project?rev=302855&view=rev Log: [tooling] RefactoringCallbacks code cleanup This diff 1. adds missing "explicit" for single argument constructors 2. adds missing std::move in ReplaceNodeWithTe

[PATCH] D22712: Remove FileEntry copy-constructor

alexshap added a comment. @bkramer ? https://reviews.llvm.org/D22712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22712: Remove FileEntry copy-constructor

alexshap added a comment. i see, thanks. So do i understand correctly that we can proceed with this patch ? https://reviews.llvm.org/D22712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:149 BugReporter &BR) const { MatchFinder F; Callback CB(this, BR, AM.getAnalysisDeclContext(D));

r284782 - [clang] Remove FileEntry copy-constructor

Author: alexshap Date: Thu Oct 20 16:20:35 2016 New Revision: 284782 URL: http://llvm.org/viewvc/llvm-project?rev=284782&view=rev Log: [clang] Remove FileEntry copy-constructor Code cleanup: address FIXME in the file include/clang/Basic/FileManager.h and remove copy-constructor of the class File

[PATCH] D22712: Remove FileEntry copy-constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL284782: [clang] Remove FileEntry copy-constructor (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D22712?vs=65187&id=75356#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

alexshap added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:578 + continue; +ProcessedFileEntries.insert(FE); +Result[Entry.first] = std::move(Entry.second); (saves 2 lines of code) (although not particularly important) if (Proces

[PATCH] D22712: Remove FileEntry copy-constructor

alexshap created this revision. alexshap added reviewers: bkramer, jdennett. alexshap added subscribers: compnerd, cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Code cleanup: address FIXME in llvm/tools/clang/include/

Re: [PATCH] D22712: Remove FileEntry copy-constructor

alexshap added a comment. no, i don't. https://reviews.llvm.org/D22712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22712: Remove FileEntry copy-constructor

alexshap added a comment. two separate observations: 1. **without my changes** : I checked the following revision: r276508 | rsmith | 2016-07-22 19:32:21 (with gcc 4.7.4, g++ 4.7.4, Ubuntu 16.04.1 LTS) build of llvm/clang failed, the logs are here: https://reviews.llvm.org/P6916 (emplace is one

[PATCH] D22881: Fix NamedDeclFindingASTVisitor

alexshap created this revision. alexshap added reviewers: klimek, omtcyfz. alexshap added subscribers: compnerd, cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Properly initialize the field Context in NamedDeclFindingAS

Re: [PATCH] D22881: Fix NamedDeclFindingASTVisitor

alexshap added a comment. inside setResult Decl->getQualifiedNameAsString() is used so RD should not be nullptr there. we get there in the newly added test. https://reviews.llvm.org/D22881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D22881: Fix NamedDeclFindingASTVisitor

alexshap added a comment. i took a look at handleNestedNameSpecifierLoc: const auto *Decl = NameLoc.getNestedNameSpecifier()->getAsNamespace(); if (Decl) { setResult(Decl, NameLoc.getLocalBeginLoc(), NameLoc.getLocalEndLoc()); } and added this check to VisitTypeLoc. the other Visit* methods ar

[PATCH] D22906: Refactor NamedDeclFindingASTVisitor

alexshap created this revision. alexshap added reviewers: omtcyfz, klimek, compnerd. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Address the comments on the diff D22881. Remove SourceMgr.

Re: [PATCH] D22906: Refactor NamedDeclFindingASTVisitor

alexshap added a comment. Thanks! https://reviews.llvm.org/D22906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23279: clang-reorder-fields

alexshap created this revision. alexshap added reviewers: klimek, compnerd. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". This diff adds v0 of clang-reorder-fields tool to clang/tools/extra

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. Thank you for the feedback. I was keeping in mind some other use-cases as well - someone might want to change the order of fields even if the padding is not affected. Repository: rL LLVM https://reviews.llvm.org/D23279 ___

[PATCH] D23298: [clang-rename] nit: use isWritten

alexshap created this revision. alexshap added reviewers: omtcyfz, alexfh. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". nit: use isWritten and const auto *Initializer in NamedDeclFindingA

Re: [PATCH] D23298: [clang-rename] nit: use isWritten

alexshap updated this revision to Diff 67301. alexshap added a comment. Fix clang-rename/USRLocFinder.cpp:47 as well https://reviews.llvm.org/D23298 Files: clang-rename/USRFinder.cpp clang-rename/USRLocFinder.cpp Index: clang-rename/USRLocFinder.cpp

Re: [PATCH] D23298: [clang-rename] nit: use isWritten

alexshap added a comment. > Do you have a commit access or do you need me to land the patch? No, I don't. I will be grateful to you if you land the patch. Thanks. https://reviews.llvm.org/D23298 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. First of all, many thanks for the comments & proposal of clang-refactor. 1. Regarding high-level project organization: clang-refactor - that can be a good place for various refactoring techniques like the existing clang-rename, my simple tool, etc - essentially what Kir

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. > The excess padding checker doesn't provide a fix-it. yup, although i think it would be useful to add one of the optimal layouts to the report (i have a diff for that (still in the oven), i have not sent it for code review yet). But as i mentioned above - it seems to

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. Regarding TUs - i am aware of that - would be useful if you could provide a test which doesn't work - that would help us avoid miscommunication. Thanks. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commit

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. Suppose you have a struct Foo defined in LibA and you have used clang-rename to rename Foo into Bar (or just a field of Foo say - you have renamed Foo::x into Foo::y); LibA is linked to LibB and you have Foo foo = { &x, 17, 1.29, 0 }; in LibB. Therefore LibA knows noth

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. The difference is that if we reorder fields the new struct is not binary-compatible with the old one. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. my point is the following: this tool helps perform some operation (changing the order of fields), if smb decides to do it manually - the result will have exactly the same issue. Repository: rL LLVM https://reviews.llvm.org/D23279

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. > I do think that an automated tool will do a better job of changing field > orderings in a non-breaking way than most people would, mostly due to > initializer lists. yeah, that was the original motivation Repository: rL LLVM https://reviews.llvm.org/D23279 _

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. 0. the tool relies on the compilation database from day one (like the other clang tools using tooling::RefactoringTool) 1. regarding TUs:. A. just in case how it works: it uses the full name of record to find the definition, then it changes the definition, then it fin

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. > Well, multi-TU support is needed for many tools and it is far beyond one tool > implementation details if we want it to be nice. I want to >have multi-TU > support in the clang-refactor, but it is still in designing stage at the > moment. At first, one translation un

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap added a comment. Thanks, your points regarding better formatting of the diagnostics / moving it into a note or fixit and using more stable sort are valid, i will update this diff today or tomorrow. Regarding the type name - i am not sure - for example for template specializations (for

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap updated this revision to Diff 67773. alexshap added a comment. Use more stable sort (preserving the original order if possible). Change the format of the report. Update the tests. I have not turned it to "note:" or "remark:" because in this case it's not included into the description and

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap added a comment. toy example: F2262237: toy_example.png https://reviews.llvm.org/D23387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap updated this revision to Diff 67797. alexshap added a comment. Update the tests. Update the format again (do not include the type name because the diagnostics becomes too verbose and unreadable (i ran it against LLVM and clang - with type names the diagnostic messages are getting very l

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217 @@ +216,3 @@ +// then large field indices to small field indices +return std::make_tuple(Align, -Size, + Field ? -static_cast(Field->getFie

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap marked 2 inline comments as done. alexshap added a comment. ping https://reviews.llvm.org/D23387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap added a comment. i don't have commit access, if you could land this patch i would be grateful https://reviews.llvm.org/D23387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Enable nsan instrumentation pass (PR #97359)

https://github.com/alexander-shaposhnikov created https://github.com/llvm/llvm-project/pull/97359 Enable nsan instrumentation pass >From 6b7f292ba467beb973099ca0e4994563ef5db381 Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Mon, 1 Jul 2024 22:20:29 + Subject: [PATCH] [Clang]

[clang] [Clang][Driver] Link nsan runtime (PR #97364)

https://github.com/alexander-shaposhnikov created https://github.com/llvm/llvm-project/pull/97364 Link nsan runtime. >From ac52e1dc1ceabdefb6230173c42181f2c098dc58 Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Mon, 1 Jul 2024 23:29:57 + Subject: [PATCH] [Clang][Driver] Link n

[clang] [Clang] Enable nsan instrumentation pass (PR #97359)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/97359 >From b231f0be6963a9cf0233c307b0b9030f9bdc120a Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Mon, 1 Jul 2024 22:20:29 + Subject: [PATCH] [Clang] Add nsan instrumentation pass to t

[clang] [Clang] Enable nsan instrumentation pass (PR #97359)

@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - -fsanitize=numerical %s | FileCheck %s alexander-shaposhnikov wrote: done https://github.com/llvm/llvm-project/pull/97359 ___ cfe-comm

[clang] [Clang] Enable nsan instrumentation pass (PR #97359)

@@ -707,6 +708,9 @@ static void addSanitizers(const Triple &TargetTriple, MPM.addPass(createModuleToFunctionPassAdaptor(ThreadSanitizerPass())); } +if (LangOpts.Sanitize.has(SanitizerKind::NumericalStability)) + MPM.addPass(NumericalStabilitySanitizerPass())

[clang] [Clang] Enable nsan instrumentation pass (PR #97359)

https://github.com/alexander-shaposhnikov closed https://github.com/llvm/llvm-project/pull/97359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Link nsan runtime (PR #97364)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/97364 >From 1e5ab152d018c9cfe15ba849c2a287efafa7bbc0 Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Mon, 1 Jul 2024 23:29:57 + Subject: [PATCH] [Clang][Driver] Link nsan runtime --- cl

[clang] [Clang][Driver] Link nsan runtime (PR #97364)

@@ -627,6 +627,20 @@ // CHECK-COV-LINUX: "-lpthread" // CHECK-COV-LINUX: "-lresolv" +// RUN: %clang -### %s 2>&1 \ +// RUN: --target=x86_64-unknown-linux -fuse-ld=ld -fsanitize=numerical \ +// RUN: -resource-dir=%S/Inputs/resource_dir \ +// RUN: --sysroot=%S/Inputs

[clang] [Clang][Driver] Link nsan runtime (PR #97364)

@@ -627,6 +627,20 @@ // CHECK-COV-LINUX: "-lpthread" // CHECK-COV-LINUX: "-lresolv" +// RUN: %clang -### %s 2>&1 \ +// RUN: --target=x86_64-unknown-linux -fuse-ld=ld -fsanitize=numerical \ +// RUN: -resource-dir=%S/Inputs/resource_dir \ +// RUN: --sysroot=%S/Inputs

[clang] [Clang][Driver] Link nsan runtime (PR #97364)

https://github.com/alexander-shaposhnikov closed https://github.com/llvm/llvm-project/pull/97364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/93783 >From 8556f6f2a255379e1f78db3354b1f750833c10a9 Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Thu, 30 May 2024 08:15:44 + Subject: [PATCH] [Clang][Sanitizers] Add numerical sanitiz

[clang] [llvm] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

@@ -826,6 +826,10 @@ SanitizerMask Linux::getSupportedSanitizers() const { if (IsX86_64 || IsAArch64) { Res |= SanitizerKind::KernelHWAddress; } + if (IsX86_64) { +Res |= SanitizerKind::NumericalStability; alexander-shaposhnikov wrote: Done https

[clang] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/93783 >From 8c5199181b94d1ae79f3ca7758ed8574774da551 Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Thu, 30 May 2024 08:15:44 + Subject: [PATCH] [Clang][Sanitizers] Add numerical sanitiz

[clang] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

https://github.com/alexander-shaposhnikov closed https://github.com/llvm/llvm-project/pull/93783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sanitizers] Enable NSAN on X86_64 only (PR #95885)

https://github.com/alexander-shaposhnikov created https://github.com/llvm/llvm-project/pull/95885 This is a follow-up to https://github.com/llvm/llvm-project/pull/93783. The current set of patches covers only x86_64 (in particular, on compiler-rt's side), therefore we should now enable this fla

[clang] [Clang][Sanitizers] Enable NSAN on X86_64 only (PR #95885)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/95885 >From 7c286a320256732eca6a9183a1ba21ae60b99746 Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Tue, 18 Jun 2024 06:15:12 + Subject: [PATCH] [Clang][Sanitizers] Enable NSAN on X86_64

[clang] [Clang][Sanitizers] Enable NSAN on X86_64 only (PR #95885)

https://github.com/alexander-shaposhnikov edited https://github.com/llvm/llvm-project/pull/95885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sanitizers] Enable NSAN on X86_64 only (PR #95885)

https://github.com/alexander-shaposhnikov edited https://github.com/llvm/llvm-project/pull/95885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sanitizers] Enable NSAN on X86_64 only (PR #95885)

alexander-shaposhnikov wrote: ~90% of the functionality would work on aarch64, but there are a few x86_64-specific quirks (__float128, x86-64-specific assumptions about long double in the helper routines) that need to be refactored (beyond my current bandwidth). https://github.com/llvm/llvm-p

[clang] [Clang][Sanitizers] Enable NSAN on X86_64 only (PR #95885)

alexander-shaposhnikov wrote: yeah, but I kind of wanted to be defensive - people will try the tool and I wanted to avoid any potential confusions / overpromises. https://github.com/llvm/llvm-project/pull/95885 ___ cfe-commits mailing list cfe-commit

[clang] [Clang][Sanitizers] Enable NSAN on X86_64 only (PR #95885)

https://github.com/alexander-shaposhnikov closed https://github.com/llvm/llvm-project/pull/95885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sanitizers] Enable NSAN on Linux only (PR #96120)

https://github.com/alexander-shaposhnikov created https://github.com/llvm/llvm-project/pull/96120 Enable nsan on Linux only. Adding support for X86_64 MacOS requires minimal efforts (might need to copy some bits from other sanitizers (in compiler-rt)). Currently the functionality has been tested

[clang] [llvm] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

https://github.com/alexander-shaposhnikov created https://github.com/llvm/llvm-project/pull/93783 Add plumbing for the numerical sanitizer on Clang's side. This patch was extracted from https://github.com/llvm/llvm-project/pull/85916 Test plan: ninja check-all >From 1b02427f1dce543ef5ada06def

[clang] [llvm] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/93783 >From c02e1911abb04c4f9ec36d30984d3b10a87e1739 Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Thu, 30 May 2024 08:15:44 + Subject: [PATCH] [Clang][Sanitizers] Add numerical sanitiz

[clang] [llvm] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

https://github.com/alexander-shaposhnikov converted_to_draft https://github.com/llvm/llvm-project/pull/93783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/93783 >From 50a524b17ce31e1e781a480c2cdf10a9153f9b9c Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Thu, 30 May 2024 08:15:44 + Subject: [PATCH] [Clang][Sanitizers] Add numerical sanitiz

[clang] [llvm] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

@@ -285,6 +285,9 @@ def SanitizeHWAddress : EnumAttr<"sanitize_hwaddress", [FnAttr]>; /// MemTagSanitizer is on. def SanitizeMemTag : EnumAttr<"sanitize_memtag", [FnAttr]>; +/// NumericalStabilitySanitizer is on. +def SanitizeNumericalStability : EnumAttr<"sanitize_numericals

[clang] [llvm] [Clang][Sanitizers] Add numerical sanitizer (PR #93783)

https://github.com/alexander-shaposhnikov ready_for_review https://github.com/llvm/llvm-project/pull/93783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [nsan] Add shared runtime (PR #98415)

https://github.com/alexander-shaposhnikov approved this pull request. LG, thanks https://github.com/llvm/llvm-project/pull/98415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-reorder-fields] Handle macros fields declarations. (PR #118005)

https://github.com/alexander-shaposhnikov approved this pull request. LG https://github.com/llvm/llvm-project/pull/118005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CudaSPIRV] Add support for optional spir-v attributes (PR #116589)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/116589 >From ef96f72a055d36bea43bfc416dad6fcd1d790e26 Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Mon, 18 Nov 2024 09:06:39 + Subject: [PATCH] [CudaSPIRV] Add support for optional spi

[clang] [CudaSPIRV] Add support for optional spir-v attributes (PR #116589)

https://github.com/alexander-shaposhnikov closed https://github.com/llvm/llvm-project/pull/116589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CudaSPIRV] Add support for optional spir-v attributes (PR #116589)

https://github.com/alexander-shaposhnikov created https://github.com/llvm/llvm-project/pull/116589 Add support for optional spir-v attributes. Test plan: ninja check-all >From 72b2e9435ac797f97f660efd7f72c64e53d7e61b Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Mon, 18 Nov 2024

[clang] [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (PR #125448)

https://github.com/alexander-shaposhnikov approved this pull request. https://github.com/llvm/llvm-project/pull/125448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-reorder-fields] Reorder leading comments (PR #123740)

https://github.com/alexander-shaposhnikov approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/123740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-reorder-fields] Move trailing comments. (PR #122918)

@@ -116,26 +118,78 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the full source range for the field declaration up to (not -/// including) the trailing semicolumn, including potential macro invocations, -/// e.g. `int a

[clang-tools-extra] [clang-reorder-fields] Move trailing comments. (PR #122918)

https://github.com/alexander-shaposhnikov approved this pull request. LG https://github.com/llvm/llvm-project/pull/122918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

@@ -118,47 +118,19 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the next token after `Loc` (including comment tokens). -static std::optional getTokenAfter(SourceLocation Loc, - co

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

https://github.com/alexander-shaposhnikov approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/123060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >