Re: [PATCH] D19038: Add AST Matchers for CXXConstructorDecl::isDelegatingConstructor and CXXMethodDecl::isUserProvided.

This revision was automatically updated to reflect the committed changes. Closed by commit rL266189: Add AST Matchers for CXXConstructorDecl::isDelegatingConstructor and… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D19038?vs=53479&id=53534#toc Repository: rL LLVM

[clang-tools-extra] r266190 - [clang-tidy] Add a readability-deleted-default clang-tidy check.

Author: alexfh Date: Wed Apr 13 06:33:40 2016 New Revision: 266190 URL: http://llvm.org/viewvc/llvm-project?rev=266190&view=rev Log: [clang-tidy] Add a readability-deleted-default clang-tidy check. Checks if constructors and assignment operators that are marked '= default' are actually deleted by

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL266190: [clang-tidy] Add a readability-deleted-default clang-tidy check. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D18961?vs=53533&id=53536#toc Repository: rL LLVM http:

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL266191: Complete support for C++ Core Guidelines Type.6: Always initialize a member… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D18584?vs=53480&id=53537#toc Repository: rL

[clang-tools-extra] r266191 - Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

Author: alexfh Date: Wed Apr 13 06:35:47 2016 New Revision: 266191 URL: http://llvm.org/viewvc/llvm-project?rev=266191&view=rev Log: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable. Summary: Added the remaining features needed to satisfy C++ Core Guideline T

[PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

alexfh created this revision. alexfh added a reviewer: sbenza. alexfh added a subscriber: cfe-commits. Herald added a subscriber: klimek. AllKindInfo is being indexed by NodeKindId, so the order must match. I've updated the tests, though I'm not sure what exactly they verify and whether the new st

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

alexfh updated this revision to Diff 53566. alexfh added a comment. - Added a test http://reviews.llvm.org/D19059 Files: lib/AST/ASTTypeTraits.cpp unittests/AST/ASTTypeTraitsTest.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unit

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

alexfh updated this revision to Diff 53569. alexfh added a comment. Added a Decl descendant for a test. http://reviews.llvm.org/D19059 Files: lib/AST/ASTTypeTraits.cpp unittests/AST/ASTTypeTraitsTest.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp unittests/ASTMatchers/Dynamic/Registry

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

alexfh marked an inline comment as done. alexfh added a comment. http://reviews.llvm.org/D19059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r266265 - clang-tools-extra/test/clang-tidy/readability-deleted-default.cpp: Add -fno-ms-compatibility.

Thanks! I was planning to do this myself, but got side-tracked. On Thu, Apr 14, 2016 at 1:50 AM, NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Wed Apr 13 18:50:45 2016 > New Revision: 266265 > > URL: http://llvm.org/viewvc/llvm-project?rev=266265&v

r266268 - Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

Author: alexfh Date: Wed Apr 13 19:47:40 2016 New Revision: 266268 URL: http://llvm.org/viewvc/llvm-project?rev=266268&view=rev Log: Reorder ASTNodeKind::AllKindInfo to match NodeKindId. Summary: AllKindInfo is being indexed by NodeKindId, so the order must match. Extended ASTTypeTraits tests to

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

This revision was automatically updated to reflect the committed changes. Closed by commit rL266268: Reorder ASTNodeKind::AllKindInfo to match NodeKindId. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D19059?vs=53569&id=53647#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

No, but I'm working on the solution. On Apr 14, 2016 11:06, "Piotr Padlewski" wrote: > Prazek added a subscriber: Prazek. > Prazek added a comment. > > Does it solve my problem with isInTemplateInstantiation? :) > > > Repository: > rL LLVM > > http://reviews.llvm.org/D19059 > > > >

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

alexfh added a subscriber: alexfh. alexfh added a comment. No, but I'm working on the solution. Repository: rL LLVM http://reviews.llvm.org/D19059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D19121: [clang-tidy] Fix documentation generation.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D19121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D19118: [clang-tidy] Add checker for operations between integrals and pointers

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Nice check! Comment at: test/clang-tidy/misc-pointer-and-integral-operation-cxx98.cpp:9 @@ +8,3 @@ + pb = false; + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: suspicious

[PATCH] D19144: Handle TemplateArgument in DynTypedNode comparison operations.

alexfh created this revision. alexfh added reviewers: sbenza, bkramer. alexfh added a subscriber: cfe-commits. This patch fixes an assertion failure on some matchers containing templateArgument() on some code in some configurations. I couldn't come up with a consistent repro, since the failure de

Re: [PATCH] D18136: boost-use-to-string check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. FYI, a fix for the assertion failure you see is sent for review as http://reviews.llvm.org/D19144. Let's wait for it to land, before going on with this patch. http://reviews.llvm.o

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/ClangTidyOptions.h:99 @@ +98,3 @@ + /// \brief Stores all options that have higher priority than current one. + std::vector HigherPriorityOptions; +

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

alexfh added a comment. Ignoring 1-bit wide bitfields seems like a reasonable thing to do for the check. Most of the changes I see here are making the code less idiomatic, I'd say. http://reviews.llvm.org/D19105 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D19146: [clang-tidy] New checker to detect suspicious string constructor.

alexfh added a comment. I wonder whether `misc-swapped-arguments` can be tuned to handle these cases in a more generic way? The only missing part so far seems to be the lack of `cxxConstructExpr` support. Comment at: clang-tidy/misc/StringConstructorCheck.cpp:104 @@ +103,3 @@

Re: [PATCH] D19146: [clang-tidy] New checker to detect suspicious string constructor.

alexfh added a comment. In http://reviews.llvm.org/D19146#402410, @alexfh wrote: > I wonder whether `misc-swapped-arguments` can be tuned to handle these cases > in a more generic way? The only missing part so far seems to be the lack of > `cxxConstructExpr` support. And by "these cases" I me

Re: [PATCH] D19146: [clang-tidy] New checker to detect suspicious string constructor.

alexfh added a comment. In http://reviews.llvm.org/D19146#402414, @alexfh wrote: > In http://reviews.llvm.org/D19146#402410, @alexfh wrote: > > > I wonder whether `misc-swapped-arguments` can be tuned to handle these > > cases in a more generic way? The only missing part so far seems to be the

Re: [PATCH] D19146: [clang-tidy] New checker to detect suspicious string constructor.

alexfh added inline comments. Comment at: clang-tidy/misc/StringConstructorCheck.cpp:104 @@ +103,3 @@ + const auto *E = Result.Nodes.getNodeAs("constructor"); + assert(E); + We usually add some description to asserts (`assert(X && "X should not be nullptr");`).

Re: [PATCH] D19165: [clang-tidy] Add modernize-increment-bool check.

alexfh added a comment. In http://reviews.llvm.org/D19165#403099, @Prazek wrote: > In http://reviews.llvm.org/D19165#402657, @aaron.ballman wrote: > > > This strikes me as something the compiler should diagnose instead of a > > clang-tidy check. Incrementing a bool has been deprecated for some t

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

alexfh added a comment. FYI, the check has started crashing after this patch. I'll try to provide a minimal test case soon. The relevant part of the stack trace is: @ 0x7fc9c255efa0 8 clang::Stmt::getLocStart() @ 0x7fc9c48fdac1 64 clang::tidy::cppcoreguidelines::(a

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:18 @@ +17,3 @@ + +// FIXME: Move to ASTMatchers.h on acceptance. +namespace ast_matchers { Please send a separate patch

Re: [PATCH] D18136: boost-use-to-string check

alexfh added inline comments. Comment at: clang-tidy/boost/UseToStringCheck.cpp:53 @@ +52,3 @@ + CharType->isSpecificBuiltinType(BuiltinType::Char_U)) +// Is CharType 'char'. +StringType = "string"; These comments don't seem to be useful, but if you w

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

alexfh added a comment. Looks better now, thanks! Comment at: clang-tidy/ClangTidyOptions.cpp:163 @@ +162,3 @@ +DefaultOptionsProvider::getRawOptions(llvm::StringRef FileName) { + return {OptionsSource(DefaultOptions, OptionsSourceTypeDefaultBinary)}; +} I'm no

Re: [PATCH] D19144: Handle TemplateArgument in DynTypedNode comparison operations.

alexfh added a comment. In http://reviews.llvm.org/D19144#402853, @sbenza wrote: > I think the bug is coming from `memoizedMatchesAncestorOfRecursively`. > `memoizedMatchesRecursively` has a special case at the top to skip the cache > if the node is not sortable. The other function should do th

Re: [PATCH] D19231: [ASTMatchers] Do not try to memoize nodes we can't compare.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thanks! http://reviews.llvm.org/D19231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D19144: Handle TemplateArgument in DynTypedNode comparison operations.

alexfh added a comment. In http://reviews.llvm.org/D19144#404234, @sbenza wrote: > Sent http://reviews.llvm.org/D19231 to fix the underlying bug in > `hasAncestor`. > We can proceed with this change if you want, but it is not required anymore. > I don't know whether we need the extra complexit

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

alexfh added a subscriber: alexfh. alexfh added a comment. Would be nice, if you could write a patch. I don't yet have a reduced test case (it crashes without delayed template parsing), since my creduce is still running after many hours ;) Repository: rL LLVM http://reviews.llvm.org/D18584

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

Would be nice, if you could write a patch. I don't yet have a reduced test case (it crashes without delayed template parsing), since my creduce is still running after many hours ;) On Apr 18, 2016 8:45 PM, "Michael Miller" wrote: > michael_miller added a comment. > > In http://reviews.llvm.org/D1

Re: [PATCH] D19259: Initial version of misc-unused-using-decl check

alexfh added a comment. Awesome! Thank you for tackling this! A few comments. Comment at: clang-tidy/misc/CMakeLists.txt:38 @@ -37,2 +37,3 @@ UnusedRAIICheck.cpp UniqueptrResetReleaseCheck.cpp + UnusedUsingDeclsCheck.cpp Please fix file sorting around the

Re: [PATCH] D19259: Initial version of misc-unused-using-decl check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one nit. Thank you! Comment at: clang-tidy/misc/MiscTidyModule.cpp:123 @@ -121,1 +122,3 @@ +CheckFactories.registerCheck( +"misc-unused-using-decls");

Re: [PATCH] D19144: Handle TemplateArgument in DynTypedNode comparison operations.

alexfh abandoned this revision. alexfh added a comment. Ok, let's drop this on the floor. http://reviews.llvm.org/D19144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18136: boost-use-to-string check

alexfh added a comment. FYI, an alternative fix has been submitted in http://reviews.llvm.org/D19231. Please check whether it fixes the issue. http://reviews.llvm.org/D18136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D18136: boost-use-to-string check

alexfh added inline comments. Comment at: test/clang-tidy/boost-use-to-string.cpp:2 @@ +1,3 @@ +// RUN: %check_clang_tidy %s boost-use-to-string %t + + nit: Remove one empty line. http://reviews.llvm.org/D18136 ___

Re: [PATCH] D19270: Fix a crash in cppcoreguidelines-pro-type-member-init related to missing constructor bodies.

alexfh accepted this revision. alexfh added a comment. LG. Do you need me to submit the patch? http://reviews.llvm.org/D19270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19200: [clang-tidy] Cleanup some ast-matchers and lift some to utils.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Thank you for the cleanup! http://reviews.llvm.org/D19200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a couple of nits. Thank you! Comment at: clang-tidy/misc/SuspiciousStringCompareCheck.cpp:25 @@ +24,3 @@ + +static const char *KnownStringCompareFunctions = "_

Re: [PATCH] D19146: [clang-tidy] New checker to detect suspicious string constructor.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a nit. In http://reviews.llvm.org/D19146#403234, @alexfh wrote: > In http://reviews.llvm.org/D19146#402414, @alexfh wrote: > > > In http://reviews.llvm.org/D19146#402410, @alex

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

alexfh added a comment. (hit Submit early...) 2. How does AST look for these test cases? I wonder whether there are any similar cases not covered by PredefinedExpr. And thank you for the patch! Repository: rL LLVM http://reviews.llvm.org/D19331 __

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

alexfh added a comment. 1. Please generate diffs with full context when sending patches. Use any of the methods described in http://llvm.org/docs/Phabricator.html. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:111 @@ -110,2 +110,3 @@ void RawStringLiteralCheck::re

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you for the explanation! The change looks good now. Do you need me to submit the patch for you? As for other cases that can lead to this, it might be possible to achieve the same effect

[clang-tools-extra] r266992 - [Clang-tidy] Fix for crash in modernize-raw-string-literal check

Author: alexfh Date: Thu Apr 21 09:39:12 2016 New Revision: 266992 URL: http://llvm.org/viewvc/llvm-project?rev=266992&view=rev Log: [Clang-tidy] Fix for crash in modernize-raw-string-literal check Summary: Clang-tidy modernize-raw-string-literal check crashes on run-time assert while it is eval

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

alexfh added a comment. In http://reviews.llvm.org/D19201#403585, @Prazek wrote: > Do you know guys is it possible to get to noexcept source location, or we > have to do by hand using lexer? If it might be possible to get the location of `noexcept(expression)` using `FunctionProtoType::getNoE

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

This revision was automatically updated to reflect the committed changes. Closed by commit rL266992: [Clang-tidy] Fix for crash in modernize-raw-string-literal check (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D19331?vs=54401&id=54504#toc Repository: rL LLVM http:

Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

alexfh added a subscriber: alexfh. alexfh requested changes to this revision. alexfh added a reviewer: alexfh. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/PassByValueCheck.cpp:166 @@ -150,3 +165,3 @@ hasDeclaration(cxxCo

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:30 @@ +29,3 @@ + + Finder->addMatcher(implicitCastExpr(hasIntegerLiteralCastToBool, + unless(ha

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/ClangTidy.cpp:61 @@ -60,3 +60,3 @@ FULLNAME, -#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc" +#include "Checkers.inc" #undef CHECKER

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/FoldInitTypeCheck.cpp:23 @@ +22,3 @@ + // Note: Right now we check only builtin types. + const auto BuiltinTypeWithId = [](const char *id) { +return hasCanon

Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

alexfh added a comment. Now the problem is that the check changed behavior, but the tests are not updated. Do the tests still pass? If yes, we need to add tests for this behavior. If no, please fix the tests. http://reviews.llvm.org/D19194 ___ cfe

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Please fix formatting, btw. Repository: rL LLVM http://reviews.llvm.org/D19201 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang-tools-extra] r267254 - [clang-tidy] Fix misc-macro-repeated-side-effects false positive with stringified arguments

Author: alexfh Date: Fri Apr 22 19:00:08 2016 New Revision: 267254 URL: http://llvm.org/viewvc/llvm-project?rev=267254&view=rev Log: [clang-tidy] Fix misc-macro-repeated-side-effects false positive with stringified arguments Added: clang-tools-extra/trunk/test/clang-tidy/misc-macro-repeated-

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

alexfh added a comment. A few nits. Comment at: clang-tidy/misc/FoldInitTypeCheck.cpp:90 @@ +89,3 @@ + // It's OK to fold an int into: + // - an int of the same size and signedness. + // - a bigger int, regardless of signedness. No, I don't have a better na

Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. This test doesn't fail without your fix. Comment at: clang-tidy/modernize/PassByValueCheck.cpp:155 @@ -155,1 +154,3 @@ +.bind("Initializer")), +

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good now. Thank you for the new check! Do you need me to submit the patch for you? http://reviews.llvm.org/D18442 ___ cfe-commits mailing

Re: [PATCH] D19259: Initial version of misc-unused-using-decl check

alexfh closed this revision. alexfh added a comment. This seems to have been committed as r266735. http://reviews.llvm.org/D19259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18265: [clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. There still seem to be a few comments from sbenza and myself that need to be resolved. http://reviews.llvm.org/D18265 ___ cfe-commits

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

alexfh added a comment. Felix, do you have time to commit the patch or should I do this for you? Repository: rL LLVM http://reviews.llvm.org/D18300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

BTW, this commit removes the last usage of llvm/ADT/VariadicFunction.h. Should we kill this header? On Fri, Mar 25, 2016 at 8:51 PM, Mehdi Amini via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Thanks! > > On Mar 25, 2016, at 12:47 PM, Samuel Benzaquen wrote: > > Fixed in r264453. > Sorry

[clang-tools-extra] r267542 - A clang-tidy check for std:accumulate.

Author: alexfh Date: Tue Apr 26 05:05:45 2016 New Revision: 267542 URL: http://llvm.org/viewvc/llvm-project?rev=267542&view=rev Log: A clang-tidy check for std:accumulate. Summary: For folds (e.g. std::accumulate), check matches between the provided init value and the range's value_type. A typic

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267542: A clang-tidy check for std:accumulate. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D18442?vs=54969&id=54978#toc Repository: rL LLVM http://reviews.llvm.org/D18442

Re: [PATCH] D18265: [clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature

alexfh added a comment. Wait, I probably was looking at an older diff somehow. After returning to the page I don't see any unresolved comments. Reviewing... http://reviews.llvm.org/D18265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D18265: [clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. No objections from me, but please wait for Samuel's review. http://reviews.llvm.org/D18265 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

alexfh added a comment. Sorry for the long delay. This is getting closer. A few more comments though. Comment at: clang-tidy/ClangTidyOptions.cpp:224 @@ +223,3 @@ + DefaultOptionsProvider::getRawOptions(FileName); + OptionsSource CommandLineOptions = + OptionsSource(O

Re: [PATCH] D19497: [clang-tidy] Enhance misc-suspicious-string-compare to move down false-positives.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one nit. Comment at: clang-tidy/misc/SuspiciousStringCompareCheck.cpp:215 @@ +214,3 @@ + if (Result.Nodes.getNodeAs("suspicious-operator")) { +diag(Call->getLocSt

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

alexfh added a comment. BTW, have you seen the `alpha.core.IdenticalExpr` static analyzer checker? http://reviews.llvm.org/D19451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome idea! LG with a couple of nits. In http://reviews.llvm.org/D19451#410064, @etienneb wrote: > Tested over LLVM code, no false positives. > > Two catches: > http://reviews.llvm.org/D19

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

alexfh added a comment. In http://reviews.llvm.org/D19451#411990, @alexfh wrote: > BTW, have you seen the `alpha.core.IdenticalExpr` static analyzer checker? Anna, Jordan, and whoever else is interested in the `alpha.core.IdenticalExpr` checker (lib/StaticAnalyzer/Checkers/IdenticalExprChecker

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In http://reviews.llvm.org/D19249#408437, @chh wrote: > This change depends on http://reviews.llvm.org/D19393. I'm personally fine with the solution in http://reviews.llvm.org/D1939

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Thank you for implementing this! Comment at: clang-tidy/tool/ClangTidyMain.cpp:320 @@ +319,3 @@ + if (ExplainConfig) { +std::vector +Raw

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

alexfh added a comment. One more nit. Comment at: clang-tidy/ClangTidyOptions.h:233 @@ -200,2 +232,3 @@ - ClangTidyOptions getOptions(llvm::StringRef FileName) override; + std::vector getRawOptions( + llvm::StringRef FileName) override; clang-format? C

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In http://reviews.llvm.org/D18821#403117, @Prazek wrote: > In http://reviews.llvm.org/D18821#402686, @Prazek wrote: > > > In http://reviews.llvm.org/D18821#398843, @alexfh wrote: > >

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

alexfh added a comment. In http://reviews.llvm.org/D18300#412003, @flx wrote: > I should free up again soon, just caught the flu though. Maybe next week? > Feel free to commit before then. Just tried it, and the patch doesn't apply cleanly. Leaving this to you. Repository: rL LLVM http://

Re: [PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

alexfh added a comment. Manuel, can you take a look at this? We need your input. http://reviews.llvm.org/D17981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r270288 - Fix docs

Author: alexfh Date: Fri May 20 17:42:03 2016 New Revision: 270288 URL: http://llvm.org/viewvc/llvm-project?rev=270288&view=rev Log: Fix docs Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-avoid-bind.rst Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-

Re: [PATCH] D20519: [clang-tidy] Ignore ADL-style using decls in unused-using-decls check.

alexfh added inline comments. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47 @@ +46,3 @@ + return; +// Ignores using-declarations defined in function definitions to avoid +// arguement-dependent lookup. I don't think using declarations in fu

Re: [PATCH] D20428: Tracking exception specification source locations

alexfh added a comment. Richard, ping. http://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20365: [PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move

alexfh added a comment. In http://reviews.llvm.org/D20365#436335, @madsravn wrote: > Just curious, as I'm sort of new to this. How long will it take before its > merged in? I was waiting for an answer to the "Do you need me to submit the patch for you?" question. Apparently, the answer is "no

Re: [PATCH] D20597: Speed up check by using a recursive visitor.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:25 @@ +24,3 @@ + bool TraverseStmt(Stmt* Node) { +if (!Node) return Base::TraverseStmt(Node); + --

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh added inline comments. Comment at: clang-tidy/llvm/HeaderGuardCheck.cpp:18 @@ +17,3 @@ + const std::string RawStringHeaderFileExtensions( + Options.getLocalOrGlobal("HeaderFileExtensions", ",h,hh,hpp,hxx")); + utils::parseHeaderFileExtensions(RawStringHeader

Re: [PATCH] D20510: [PATCH] Fix for bug 27802 misc-macro-parentheses breaks variadic macros

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D20510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D20519: [clang-tidy] Ignore ADL-style using decls in unused-using-decls check.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47 @@ +46,3 @@ + return; +// Ignores using-declarations defined in function definitions to avoid +// arguement-dependent loo

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

alexfh added a comment. Full context diffs, please. See http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface for instructions. Repository: rL LLVM http://reviews.llvm.org/D20714 ___ cfe-commits mailing list cfe-commit

Re: [PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

alexfh added a comment. Thank you for the new check! Before starting with the review, I'd like to clarify one important thing. It's not immediately obvious that the pattern the check detects is actually a good indicator of a programming mistake. Did you try to run the check on a large enough c

Re: [PATCH] D20666: Fix a wrong check in misc-unused-using-decls

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D20666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D20010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D20766: [clang-tidy] Fix script adding new clang-tidy check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D20766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

Thank you, Tom. I'm not very familiar with the release process and it will indeed be better, if you merge the patch. On Thu, Jun 2, 2016 at 3:27 AM, Tom Stellard wrote: > On Wed, Jun 01, 2016 at 11:19:44PM +0200, Edoardo P. wrote: > > Ping. > > > > Deadline to merge the changes to the 3.8 branch

[PATCH] D20917: [clang-tidy] Add RemoveStars option to the modernize-use-auto check

alexfh created this revision. alexfh added reviewers: sbenza, aaron.ballman. alexfh added a subscriber: cfe-commits. Add RemoveStars option to the modernize-use-auto check. With the new option turned on (by default) the check will change `MyType *t = new MyType;` to `auto *t = new MyType;` instead

Re: [PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:109 @@ -100,1 +108,3 @@ + // giving an incorrect message, we mark all of them as used. for (auto &Context : Contex

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

alexfh added a comment. In http://reviews.llvm.org/D20917#447046, @sbenza wrote: > Is it a typo in the description when it says that when RemoveStar is on we > will write 'auto*' instead if 'auto'? Yep, the whole patch description is a typo, fixed ;) http://reviews.llvm.org/D20917 ___

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

alexfh updated this revision to Diff 59599. alexfh marked an inline comment as done. alexfh added a comment. - Updated formatting in the doc. http://reviews.llvm.org/D20917 Files: clang-tidy/modernize/UseAutoCheck.cpp clang-tidy/modernize/UseAutoCheck.h docs/clang-tidy/checks/modernize-us

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

alexfh added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list. -if (Dec == *D->decl_begin()) - conti

[clang-tools-extra] r271739 - [clang-tidy] modernize-use-auto: don't remove stars by default

Author: alexfh Date: Fri Jun 3 16:22:58 2016 New Revision: 271739 URL: http://llvm.org/viewvc/llvm-project?rev=271739&view=rev Log: [clang-tidy] modernize-use-auto: don't remove stars by default Summary: By default, modernize-use-auto check will retain stars when replacing an explicit type with

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL271739: [clang-tidy] modernize-use-auto: don't remove stars by default (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D20917?vs=59599&id=59625#toc Repository: rL LLVM http://

Re: [PATCH] D20856: [clang-tidy] readability-identifier-naming - Support for Type Aliases

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you for the patch! Do you need me to submit it? http://reviews.llvm.org/D20856 ___ cfe-commits mailing list cfe-commits@lists.l

<    9   10   11   12   13   14   15   16   17   18   >