Re: [PATCH] D12281: Tests no longer need the 'REQUIRES: SHELL' line.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D12281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D12287: Add replace-auto_ptr check.

alexfh added inline comments. Comment at: clang-tidy/modernize/ReplaceAutoPtrCheck.h:20 @@ +19,3 @@ + +class ReplaceAutoPtrCheck : public ClangTidyCheck { +public: Please add a class comment describing what the check does and why. http://reviews.llvm.org/D12287

Re: [PATCH] D12287: Add replace-auto_ptr check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Thank you! Comment at: test/clang-tidy/modernize-replace-auto-ptr.cpp:12 @@ +11,3 @@ +std::auto_ptr create_derived_ptr(); +// CHECK-MESSAGES: :[[@LIN

Re: [PATCH] D12321: Avoid LoopConvertCheck replacements in template instantiations.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a comment. Comment at: test/clang-tidy/modernize-loop-convert-extra.cpp:636 @@ +635,3 @@ + SE = container.end(); SI != SE; ++SI) { + } +} --

Re: [PATCH] D12321: Avoid LoopConvertCheck replacements in template instantiations.

alexfh added a comment. Thanks! Still looks good. http://reviews.llvm.org/D12321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12361: LoopConvert no longer take as alias references to other containers.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D12361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D12370: Fix another LoopConvert fail.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D12370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang-tools-extra] r246169 - [clang-tidy] Update docs for clang-tidy checks. NFC

Author: alexfh Date: Thu Aug 27 13:01:58 2015 New Revision: 246169 URL: http://llvm.org/viewvc/llvm-project?rev=246169&view=rev Log: [clang-tidy] Update docs for clang-tidy checks. NFC Changes mostly address formatting and unification of the style. Use MarkDown style for inline code snippets and

[clang-tools-extra] r246170 - [clang-tidy] Renamed a test file to .cpp.

Author: alexfh Date: Thu Aug 27 13:03:37 2015 New Revision: 246170 URL: http://llvm.org/viewvc/llvm-project?rev=246170&view=rev Log: [clang-tidy] Renamed a test file to .cpp. Added: clang-tools-extra/trunk/test/clang-tidy/misc-argument-comment.cpp - copied unchanged from r245699, clang

[clang-tools-extra] r246173 - [clang-tidy] Move clang-tidy docs to a separate directory. Create doc files for checks

Author: alexfh Date: Thu Aug 27 13:10:07 2015 New Revision: 246173 URL: http://llvm.org/viewvc/llvm-project?rev=246173&view=rev Log: [clang-tidy] Move clang-tidy docs to a separate directory. Create doc files for checks The doc files for checks have been generated from the corresponding header f

Re: [PATCH] D12411: [PATCH] Expose AST language options to checkers

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good .Thanks for fixing this! BTW, there are other checks that use LangOpts in the check() method. IIRC, misc-use-override, google-readabiity-casting and maybe something else. We need t

Re: [PATCH] D12081: Add use-nullptr check to clang-tidy.

alexfh added a comment. In http://reviews.llvm.org/D12081#234614, @aaron.ballman wrote: > While working on r246209, one of the build bots ran into an issue (commented > below) that has me slightly perplexed. The build break can be found at: > http://lab.llvm.org:8011/builders/clang-x86_64-debia

Re: [PATCH] D12081: Add use-nullptr check to clang-tidy.

On Fri, Aug 28, 2015 at 1:23 AM, Aaron Ballman wrote: > On Thu, Aug 27, 2015 at 7:20 PM, Alexander Kornienko > wrote: > > alexfh added a comment. > > > > In http://reviews.llvm.org/D12081#234614, @aaron.ballman wrote: > > > >> While working on r246209,

[clang-tools-extra] r246238 - [clang-tidy] Documented the reason to run the test in C++98 mode.

Author: alexfh Date: Thu Aug 27 18:43:39 2015 New Revision: 246238 URL: http://llvm.org/viewvc/llvm-project?rev=246238&view=rev Log: [clang-tidy] Documented the reason to run the test in C++98 mode. Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr-basic.cpp Modified:

Re: [PATCH] D12446: [PATCH] Enable clang-tidy misc-static-assert for C11

alexfh added a comment. > 1. If is included, then static_assert() is also fine to use. > Presumably, in order for the assert() check to trigger, has to be > included, but I don't feel particularly comfortable with that assumption. Do you have any C11 code that uses `assert()`, but doesn't in

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

alexfh added a comment. Thanks for contributing the new check! This check seems pretty similar to the check implemented in clang-tidy/readability/NamedParameterCheck.h/.cpp. Having both doesn't make much sense, so one of them will have to die (probably, the other one). Nothing should be done

[clang-tools-extra] r246437 - [clang-tidy] Move misc-use-override and readability-shrink-to-fit to "modernize/"

Author: alexfh Date: Mon Aug 31 08:17:43 2015 New Revision: 246437 URL: http://llvm.org/viewvc/llvm-project?rev=246437&view=rev Log: [clang-tidy] Move misc-use-override and readability-shrink-to-fit to "modernize/" These checks are focusing on migrating the code from C++98/03 to C++11, so they b

[clang-tools-extra] r246446 - [clang-tidy] misc-assert-side-effect: support assert macros defined through other macros

Author: alexfh Date: Mon Aug 31 09:47:14 2015 New Revision: 246446 URL: http://llvm.org/viewvc/llvm-project?rev=246446&view=rev Log: [clang-tidy] misc-assert-side-effect: support assert macros defined through other macros Modified: clang-tools-extra/trunk/clang-tidy/misc/AssertSideEffectChec

Re: [clang-tools-extra] r246444 - Using an early return as it is more clear; NFC.

Thanks! Could you do the same for the other files changed in that revision? On Mon, Aug 31, 2015 at 4:23 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Mon Aug 31 09:23:21 2015 > New Revision: 246444 > > URL: http://llvm.org/viewvc/llvm-proje

Re: [PATCH] D12446: [PATCH] Enable clang-tidy misc-static-assert for C11

alexfh added inline comments. Comment at: test/clang-tidy/misc-static-assert-c99.c:2 @@ +1,3 @@ +// RUN: %python %S/check_clang_tidy.py %s misc-static-assert %t -- -std=c99 + +void abort() {} aaron.ballman wrote: > I am not certain how to accomplish this with the

Re: [PATCH] D12473: [clang-tidy] Add old style function check

alexfh added a comment. A high-level comment: It seems that the scope of the check is artificially made too narrow. The check could actually look at any POD variables declared unnecessarily far from their initialization and usages. And here the value of the check would also be much higher, if

Re: [PATCH] D12446: [PATCH] Enable clang-tidy misc-static-assert for C11

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D12446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

ent clang-tidy-diff.py on all > platforms, the regular expression does not match quotes. > There is surely some Python package to process filenames correctly if this > ever become a problem. > > > 2015-08-21 13:37 GMT+03:00 Alexander Kornienko : > >> On Fri, Aug 21, 20

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

test against before comitting and so far didn't get a reply. > > Anyhow, adding the \n is safe and I've commited it now on r246575 but I'm > still not clear about the other two regex changes. > I'll update the bug report accordingly. > > Yaron > > > >

Re: [PATCH] D12551: Fix use-auto-check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you! http://reviews.llvm.org/D12551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[clang-tools-extra] r246643 - [clang-tidy] Updated the check name in the doc.

Author: alexfh Date: Wed Sep 2 07:01:51 2015 New Revision: 246643 URL: http://llvm.org/viewvc/llvm-project?rev=246643&view=rev Log: [clang-tidy] Updated the check name in the doc. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-shrink-to-fit.rst Modified: clang-tools-ext

Re: clang-tidy unit tests

Looks like we need to call both ClangTidyContext::setASTContext, ClangTidyCheck::registerMatchers and ClangTidyContext::setCurrentFile in TestClangTidyAction::CreateASTConsumer. Maybe something else will need to move there as well. -- Alex On Wed, Sep 2, 2015 at 4:09 PM, Aaron Ballman wrote: >

Re: clang-tools-extra code owners

te > that somewhat? If so, I would nominate: > > Alexander Kornienko for clang-tidy > Peter Collingbourne for clang-query > Manuel Klimek for clang-rename, and clang-tools-extra as a whole > > I'm basing these nominations on who is actively maintain

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

alexfh added inline comments. Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:465 @@ +464,3 @@ + if (UsageSet.insert(U).second) { +Usages.push_back(U); +return true; Do you need both `Usages` and `UsageSet`? Comment at: clang-tidy/

[clang-tools-extra] r246854 - [clang-tidy] Fix add_new_check.py.

Author: alexfh Date: Fri Sep 4 09:56:57 2015 New Revision: 246854 URL: http://llvm.org/viewvc/llvm-project?rev=246854&view=rev Log: [clang-tidy] Fix add_new_check.py. This fixes the case where the check should be added at the end of the list of checks in CMakeLists.txt of the corresponding modul

[clang-tools-extra] r246856 - [clang-tidy] Fix llvm-include-order check on Windows.

Author: alexfh Date: Fri Sep 4 10:46:51 2015 New Revision: 246856 URL: http://llvm.org/viewvc/llvm-project?rev=246856&view=rev Log: [clang-tidy] Fix llvm-include-order check on Windows. IncludeDirectives struct used a StringRef that pointed to a stack variable (SmallString<128> FilenameBuffer fr

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a comment. Comment at: clang-tidy/modernize/LoopConvertUtils.h:211 @@ -210,3 +210,3 @@ /// \brief A class to encapsulate lowe

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

alexfh added a comment. Sorry for the long delay. This version looks significantly better. Thank you for the updates! Comment at: clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp:1 @@ +1,2 @@ +//===--- InconsistentDeclarationParameterNameCheck.cpp - +//clan

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

alexfh added a comment. > Now that I fixed all review issues, I think this version would be acceptable > for commit. @alexfh: do you agree? Almost. I've found a few more minor issues and also found out that the warnings could structured in a more useful way. See the inline comments. Thanks fo

Re: [PATCH] D12675: Avoid using rvalue references with trivially copyable types.

alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Looks good. http://reviews.llvm.org/D12675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

alexfh added inline comments. Comment at: clang-tidy/rename_check.py:53 @@ +52,3 @@ + return newFileName + +def getListOfFiles(clang_tidy_path): ClockMan wrote: > Not sure what you mean... I meant that after that patch the module file name can be more complex. H

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Do you have commit rights? If no, please have someone commit this for you. I won't be able to help with this soon, unfortunately. Repository: rL LLVM http://reviews.llvm.org/D1

Re: [PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

On 7 Oct 2015 19:24, "Aaron Ballman" wrote: > > On Tue, Oct 6, 2015 at 11:07 PM, Alexander Kornienko wrote: > > alexfh added a comment. > > > > It looks like potentially we're going to have tens of checks in this module. I wonder whether we should start o

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

On 6 Oct 2015 22:50, "Aaron Ballman" wrote: > > On Tue, Oct 6, 2015 at 8:56 AM, Piotr Zegar wrote: > > ClockMan abandoned this revision. > > ClockMan added a comment. > > > > As a 'corporation' in which I work has doubts that checks developed by my after work, but tested on copyright protected co

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

alexfh accepted this revision. alexfh added a comment. In http://reviews.llvm.org/D7639#276641, @LegalizeAdulthood wrote: > I mean, look at this review. I created it on Feb 13th 2015. It's been > getting ground through the review process for 8 months. Why can't we move > forward? Yes, I kn

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

alexfh added a comment. FYI, I had to update tests' RUN lines for some recent changes. I'm also going to move the check to the modernize module, where it belongs. http://reviews.llvm.org/D7639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r251475 - Add modernize-redundant-void-arg check to clang-tidy

Author: alexfh Date: Tue Oct 27 20:36:20 2015 New Revision: 251475 URL: http://llvm.org/viewvc/llvm-project?rev=251475&view=rev Log: Add modernize-redundant-void-arg check to clang-tidy This check for clang-tidy looks for function with zero arguments declared as (void) and removes the unnecessar

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rL251475: Add modernize-redundant-void-arg check to clang-tidy (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D7639?vs=37717&id=38617#toc Repository: rL LLVM http://reviews.llv

Re: [PATCH] D14145: modernize-use-default supports copy constructor and copy-assignment operator.

alexfh added inline comments. Comment at: test/clang-tidy/modernize-use-default.cpp:139 @@ +138,3 @@ + +struct O { + O() { Can we choose a different name for it, that does not resemble a digit? Comment at: test/clang-tidy/modernize-use-default.c

[PATCH] D14191: Make ArgumentAdjuster aware of the current file being processed.

alexfh created this revision. alexfh added a reviewer: klimek. alexfh added a subscriber: cfe-commits. Herald added a subscriber: klimek. This is needed to handle per-project configurations when adding extra arguments in clang-tidy for example. http://reviews.llvm.org/D14191 Files: include/cla

[PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh created this revision. alexfh added a reviewer: klimek. alexfh added a subscriber: cfe-commits. This patch depends on http://reviews.llvm.org/D14191 http://reviews.llvm.org/D14192 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOptions.h modular

Re: [PATCH] D14204: Fix crash in redundant-void-arg check.

alexfh added inline comments. Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:131 @@ -130,1 +130,3 @@ StringRef GrammarLocation) { + if (Range.getBegin().isMacroID() || Range.getEnd().isMacroID()) +return; What happens if instead you pass the

[PATCH] D14212: Make hasLHS and hasRHS matchers available for ArraySubscriptExpr

alexfh created this revision. alexfh added a reviewer: klimek. alexfh added a subscriber: cfe-commits. Herald added a subscriber: klimek. The hasBase and hasIndex don't tell anything about the position of the base and the index in the code, so we need hasLHS and hasRHS in some cases. http://revie

Re: [PATCH] D14204: Fix crash in redundant-void-arg check.

alexfh added a comment. In http://reviews.llvm.org/D14204#278833, @angelgarcia wrote: > Use Lexer::makeFileCharRange (and a few changes due to clang-format). > > It seems to work as well. Can you add a test where a void argument is removed in a macro (which would be the whole point of using th

Re: [PATCH] D14204: Fix crash in redundant-void-arg check.

alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. This revision is now accepted and ready to land. Thanks! Looks good! http://reviews.llvm.org/D14204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

Re: [PATCH] D14229: Remove unreachable that was reached in modernize-use-nullptr.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Comment at: test/clang-tidy/modernize-use-nullptr.cpp:191 @@ +190,3 @@ +char function(NoDef *p); +#define F(x) \ +(sizeof(function(x)) == 1) -

Re: [PATCH] D14238: Fix another crash in the redundant-void-arg check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thanks for the fix! LG http://reviews.llvm.org/D14238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [clang-tools-extra] r250824 - Apply modernize-use-default to clang-tools-extra.

On Tue, Oct 20, 2015 at 5:56 AM, Angel Garcia Gomez via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: angelgarcia > Date: Tue Oct 20 07:56:27 2015 > New Revision: 250824 > > URL: http://llvm.org/viewvc/llvm-project?rev=250824&view=rev > Log: > Apply modernize-use-default to clang-tool

Re: [PATCH] D14191: Make ArgumentAdjuster aware of the current file being processed.

alexfh added a comment. Ping. http://reviews.llvm.org/D14191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added a comment. Ping. http://reviews.llvm.org/D14192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r251842 - Make hasLHS and hasRHS matchers available for ArraySubscriptExpr

Author: alexfh Date: Mon Nov 2 16:23:21 2015 New Revision: 251842 URL: http://llvm.org/viewvc/llvm-project?rev=251842&view=rev Log: Make hasLHS and hasRHS matchers available for ArraySubscriptExpr Summary: The hasBase and hasIndex don't tell anything about the position of the base and the index

r251843 - Remove empty directories.

Author: alexfh Date: Mon Nov 2 16:24:28 2015 New Revision: 251843 URL: http://llvm.org/viewvc/llvm-project?rev=251843&view=rev Log: Remove empty directories. Removed: cfe/trunk/test/Driver/Inputs/mips_mti_linux/ ___ cfe-commits mailing list cfe-c

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

alexfh added a comment. Vadym, what's the state of this patch? http://reviews.llvm.org/D12031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Fri, Oct 9, 2015 at 12:13 PM, Aaron Ballman wrote: > On Fri, Oct 9, 2015 at 3:09 PM, Daniel Berlin wrote: > > dberlin added a subscriber: dberlin. > > > > > > Comment at: docs/clang-tidy/checks/cert-variadic-function-def.rst:13 > > @@ +12,2 @@ > > +`DCL50-CPP. Do not define a

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

alexfh added inline comments. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:22 @@ +21,3 @@ + bool IsTypeDependOnTemplateParameter = + false; // my first guess was type->getTypeClass () == 30 but it doesn't + // work in some cases. Could you please a

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

alexfh added inline comments. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:30 @@ +29,3 @@ +bool IsVariable = dyn_cast(Arg) != nullptr; +std::string message = "std::move of the "; +message += IsConstArg ? "const " : ""; alexfh wrote: > Plea

Re: [PATCH] D12473: [clang-tidy] Add old style function check

alexfh added a comment. Apparently, I forgot to submit the comments a looong time ago. Sorry for the delay. In http://reviews.llvm.org/D12473#236401, @alexfh wrote: > A high-level comment: > > It seems that the scope of the check is artificially made too narrow. The > check could actually look

r252066 - Removed mentions of clang-modernize, added a short description of clang-tidy.

Author: alexfh Date: Wed Nov 4 13:34:55 2015 New Revision: 252066 URL: http://llvm.org/viewvc/llvm-project?rev=252066&view=rev Log: Removed mentions of clang-modernize, added a short description of clang-tidy. Modified: cfe/trunk/docs/ClangTools.rst Modified: cfe/trunk/docs/ClangTools.rst U

r252068 - Fixed header levels.

Author: alexfh Date: Wed Nov 4 13:40:05 2015 New Revision: 252068 URL: http://llvm.org/viewvc/llvm-project?rev=252068&view=rev Log: Fixed header levels. Modified: cfe/trunk/docs/ClangTools.rst Modified: cfe/trunk/docs/ClangTools.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/C

r252069 - Fixed a link.

Author: alexfh Date: Wed Nov 4 13:42:17 2015 New Revision: 252069 URL: http://llvm.org/viewvc/llvm-project?rev=252069&view=rev Log: Fixed a link. Modified: cfe/trunk/docs/ClangTools.rst Modified: cfe/trunk/docs/ClangTools.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ClangToo

Re: [PATCH] D14191: Make ArgumentAdjuster aware of the current file being processed.

alexfh added a comment. Ping. http://reviews.llvm.org/D14191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added a comment. Ping. http://reviews.llvm.org/D14192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14191: Make ArgumentAdjuster aware of the current file being processed.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252134: Make ArgumentAdjuster aware of the current file being processed. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D14191?vs=38776&id=39303#toc http://reviews.llvm.org/D141

r252134 - Make ArgumentAdjuster aware of the current file being processed.

Author: alexfh Date: Wed Nov 4 20:19:53 2015 New Revision: 252134 URL: http://llvm.org/viewvc/llvm-project?rev=252134&view=rev Log: Make ArgumentAdjuster aware of the current file being processed. Summary: This is needed to handle per-project configurations when adding extra arguments in clang-t

[clang-tools-extra] r252138 - Accommodate interface change in r252134.

Author: alexfh Date: Wed Nov 4 20:30:21 2015 New Revision: 252138 URL: http://llvm.org/viewvc/llvm-project?rev=252138&view=rev Log: Accommodate interface change in r252134. Modified: clang-tools-extra/trunk/modularize/Modularize.cpp Modified: clang-tools-extra/trunk/modularize/Modularize.cp

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:89-93 @@ -86,1 +88,7 @@ + + /// \brief Add extra compilation arguments to the end of the list. + llvm::Optional ExtraArgs; + + /// \brief Add extra compilation arguments to the start of the list. + llvm::O

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh updated this revision to Diff 39376. alexfh marked an inline comment as done. alexfh added a comment. Addressed review comments. http://reviews.llvm.org/D14192 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOptions.h test/clang-tidy/custom-dia

[clang-tools-extra] r252207 - Refactor: Simplify boolean conditional return statements in clang-apply-replacements

Author: alexfh Date: Thu Nov 5 14:59:17 2015 New Revision: 252207 URL: http://llvm.org/viewvc/llvm-project?rev=252207&view=rev Log: Refactor: Simplify boolean conditional return statements in clang-apply-replacements Differential revision: http://reviews.llvm.org/D10025 Patch by Richard Thomso

Re: [PATCH] D10025: Refactor: Simplify boolean conditional return statements in clang-apply-replacements

alexfh closed this revision. alexfh added a comment. Committed revision 252207. http://reviews.llvm.org/D10025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

alexfh added a comment. Richard, what's the state of this patch? http://reviews.llvm.org/D8149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

alexfh added a comment. What's the state of this patch? http://reviews.llvm.org/D7982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9556: [clang-tidy] Support for Static Analyzer plugins (clang part)

alexfh added a comment. What's the state here? http://reviews.llvm.org/D9556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9556: [clang-tidy] Support for Static Analyzer plugins (clang part)

alexfh added a comment. http://reviews.llvm.org/D9555 depends on this patch. Are these two patches still interesting to someone? http://reviews.llvm.org/D9556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

alexfh added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:56 @@ +55,3 @@ +ArraySize = SizeArg.getAsIntegral(); + } + We can go for a local setting for now, and if we introduce global or module-wide options, w

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

alexfh added a subscriber: alexfh. alexfh added a comment. A peanut gallery comment. Comment at: clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.cpp:91 @@ +90,3 @@ + diag_builder << FixItHint::CreateReplacement(ParenRange, CastText); +} else + diag( ---

Re: [PATCH] D9556: [clang-tidy] Support for Static Analyzer plugins (clang part)

alexfh added a comment. In http://reviews.llvm.org/D9556#282718, @xazax.hun wrote: > Unfortunately I had no time to work on this patch, and after I did not finish > this the team I was working in took a different approach: running static > analyzer checker through clang and tidy checkers throug

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added a comment. PTAL http://reviews.llvm.org/D14192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r252248 - [clang-tidy] readability-named-parameter: don't complain about implicit parameters

Author: alexfh Date: Thu Nov 5 18:19:21 2015 New Revision: 252248 URL: http://llvm.org/viewvc/llvm-project?rev=252248&view=rev Log: [clang-tidy] readability-named-parameter: don't complain about implicit parameters Fixes http://llvm.org/PR24464. Modified: clang-tools-extra/trunk/clang-tid

r252256 - Refactor: simplify boolean conditional return statements in lib/Analysis

Author: alexfh Date: Thu Nov 5 19:08:38 2015 New Revision: 252256 URL: http://llvm.org/viewvc/llvm-project?rev=252256&view=rev Log: Refactor: simplify boolean conditional return statements in lib/Analysis Patch by Richard Thomson! Differential revision: http://reviews.llvm.org/D10008 Modified:

Re: [PATCH] D10008: Refactor: simplify boolean conditional return statements in lib/Analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rL252256: Refactor: simplify boolean conditional return statements in lib/Analysis (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D10008?vs=26486&id=39448#toc Repository: rL LLV

r252261 - Refactor: Simplify boolean conditional return statements in lib/ARCMigrate

Author: alexfh Date: Thu Nov 5 19:26:37 2015 New Revision: 252261 URL: http://llvm.org/viewvc/llvm-project?rev=252261&view=rev Log: Refactor: Simplify boolean conditional return statements in lib/ARCMigrate Patch by Richard Thomson! (+a couple of modifications to address comments) Differential

Re: [PATCH] D10009: Refactor: Simplify boolean conditional return statements in lib/ARCMigrate

This revision was automatically updated to reflect the committed changes. Closed by commit rL252261: Refactor: Simplify boolean conditional return statements in lib/ARCMigrate (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D10009?vs=26475&id=39450#toc Repository: rL L

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added inline comments. Comment at: clang-tidy/ClangTidy.cpp:382 @@ +381,3 @@ + const CommandLineArguments &Args, StringRef Filename) { +Context.setCurrentFile(Filename); +const ClangTidyOptions &Opts = Context.getOptions(); klimek wrote: > My c

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added inline comments. Comment at: clang-tidy/ClangTidy.cpp:382 @@ +381,3 @@ + const CommandLineArguments &Args, StringRef Filename) { +Context.setCurrentFile(Filename); +const ClangTidyOptions &Opts = Context.getOptions(); klimek wrote: > alex

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh updated this revision to Diff 39551. alexfh added a comment. Added ClangTidyContext::getOptionsForFile. http://reviews.llvm.org/D14192 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/ClangTidyOptions.c

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh updated this revision to Diff 39553. alexfh added a comment. Updated documentation comments. http://reviews.llvm.org/D14192 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/ClangTidyOptions.cpp clang-

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added a comment. PTAL Comment at: clang-tidy/ClangTidy.cpp:382 @@ +381,3 @@ + const CommandLineArguments &Args, StringRef Filename) { +ClangTidyOptions Opts = Context.getOptionsForFile(Filename); +CommandLineArguments AdjustedArgs; The interf

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a comment. Thank you for contribution! Comment at: test/clang-tidy/cppcoreguidelines-pro-type-cstyle-cast.cpp:14 @@ +13,3 @@ +

[clang-tools-extra] r252471 - [clang-tidy] Fix message style (capitalization, trailing period).

Author: alexfh Date: Mon Nov 9 09:53:28 2015 New Revision: 252471 URL: http://llvm.org/viewvc/llvm-project?rev=252471&view=rev Log: [clang-tidy] Fix message style (capitalization, trailing period). Modified: clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp clang

[clang-tools-extra] r252485 - Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

Author: alexfh Date: Mon Nov 9 10:28:11 2015 New Revision: 252485 URL: http://llvm.org/viewvc/llvm-project?rev=252485&view=rev Log: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files. Summary: This patch depends on http://reviews.llvm.org/D14191 Reviewer

r252488 - Adjust printQualifiedName to handle unscoped enums in a way similar to anonymous namespaces.

Author: alexfh Date: Mon Nov 9 10:45:17 2015 New Revision: 252488 URL: http://llvm.org/viewvc/llvm-project?rev=252488&view=rev Log: Adjust printQualifiedName to handle unscoped enums in a way similar to anonymous namespaces. Patch by Sterling Augustine! Differential revision: http://reviews.ll

Re: [PATCH] D14459: Adjust printQualifiedName to handle unscoped enums in a way similar to anonymous namespaces.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252488: Adjust printQualifiedName to handle unscoped enums in a way similar to… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D14459?vs=39605&id=39704#toc Repository: rL LLVM

[PATCH] D14501: Use "auto" when the type name is redundant

alexfh created this revision. alexfh added a reviewer: aaron.ballman. alexfh added a subscriber: cfe-commits. Use "auto" when the type name is redundant http://reviews.llvm.org/D14501 Files: lib/AST/Decl.cpp Index: lib/AST/Decl.cpp =

Re: r252488 - Adjust printQualifiedName to handle unscoped enums in a way similar to anonymous namespaces.

On Mon, Nov 9, 2015 at 8:50 AM, Aaron Ballman wrote: > On Mon, Nov 9, 2015 at 11:45 AM, Alexander Kornienko via cfe-commits > wrote: > > Author: alexfh > > Date: Mon Nov 9 10:45:17 2015 > > New Revision: 252488 > > > > URL: http://llvm.org/viewvc/llvm

r252494 - Use "auto" when the type name is redundant

Author: alexfh Date: Mon Nov 9 11:53:06 2015 New Revision: 252494 URL: http://llvm.org/viewvc/llvm-project?rev=252494&view=rev Log: Use "auto" when the type name is redundant Summary: Use "auto" when the type name is redundant Reviewers: aaron.ballman Subscribers: cfe-commits Differential Rev

<    3   4   5   6   7   8   9   10   11   12   >