[clang-tools-extra] r310587 - [clang-tidy] Updated docs and release notes for r310584

Author: alexfh Date: Thu Aug 10 05:54:05 2017 New Revision: 310587 URL: http://llvm.org/viewvc/llvm-project?rev=310587&view=rev Log: [clang-tidy] Updated docs and release notes for r310584 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/clang-tidy/chec

Re: [clang-tools-extra] r310584 - [clang-tidy] Add modernize-use-emplace.IgnoreImplicitConstructors option

Thanks for noticing this! Committed in r310587. On Thu, Aug 10, 2017 at 2:33 PM, Haojian Wu wrote: > I think you also need to add the doc for the option in > modernize-use-emplace.rst. > > On Thu, Aug 10, 2017 at 2:19 PM, Alexander Kornienko via cfe-commits < > cfe-commits@lis

Re: [clang-tools-extra] r310559 - [clang-tidy] Minor documentation improvement

On Thu, Aug 10, 2017 at 11:13 AM, Gabor Horvath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xazax > Date: Thu Aug 10 02:13:26 2017 > New Revision: 310559 > > URL: http://llvm.org/viewvc/llvm-project?rev=310559&view=rev > Log: > [clang-tidy] Minor documentation improvement > > Pa

Re: [clang-tools-extra] r310559 - [clang-tidy] Minor documentation improvement

There's also `C::x; // 2` below, so I'd add this comment back at least for consistency. On Thu, Aug 10, 2017 at 5:53 PM, Gábor Horváth wrote: > > > On 10 August 2017 at 17:40, Alexander Kornienko wrote: > >> >> >> On Thu, Aug 10, 2017 at 11:13 AM, Gabor

[clang-tools-extra] r311136 - [clang-tidy] Add modernize-use-equals-default.IgnoreMacros option

Author: alexfh Date: Thu Aug 17 16:07:59 2017 New Revision: 311136 URL: http://llvm.org/viewvc/llvm-project?rev=311136&view=rev Log: [clang-tidy] Add modernize-use-equals-default.IgnoreMacros option Added: clang-tools-extra/trunk/test/clang-tidy/modernize-use-equals-default-macros.cpp Modifi

[clang-tools-extra] r311651 - [clang-tidy] bugprone-undefined-memory-manipulation: include type into the message

Author: alexfh Date: Thu Aug 24 05:11:05 2017 New Revision: 311651 URL: http://llvm.org/viewvc/llvm-project?rev=311651&view=rev Log: [clang-tidy] bugprone-undefined-memory-manipulation: include type into the message Having the actual type in the message helps a lot understanding warnings in tem

Re: r310887 - [analyzer] Fix SimpleSValBuilder::simplifySVal

This commit causes http://llvm.org/PR34309. Could you take a look? On Mon, Aug 14, 2017 at 11:23 PM, Alexander Shaposhnikov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexshap > Date: Mon Aug 14 14:23:08 2017 > New Revision: 310887 > > URL: http://llvm.org/viewvc/llvm-project?

Re: [clang-tools-extra] r311654 - [clang-tidy] Add missing IgnoreMacros doc for modernize-use-equals-default.

Thank you! On Thu, Aug 24, 2017 at 3:45 PM, Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Thu Aug 24 06:45:18 2017 > New Revision: 311654 > > URL: http://llvm.org/viewvc/llvm-project?rev=311654&view=rev > Log: > [clang-tidy] Add missing IgnoreMacros doc

Re: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

o crash) because ‘c’ was set as type > dependent. The checks are probably run now since c’s type dependency > changed with this patch. The checks might need to be guarded better, but I > am not sure. I will take a look and get back to you ASAP. > > > > Elizabeth > > &

Re: [clang-tools-extra] d2c9c91 - Move from a long list of checkers to tables

[adding the list back] This list is one of the places that would be quite boring and error-prone to update manually. I'd strongly prefer to have an automatic way of updating it. Detecting whether a check has a fix might be not an easy task though. Maybe the script could use some simple heuristic t

Re: [clang-tools-extra] d2c9c91 - Move from a long list of checkers to tables

On Wed, Jan 8, 2020 at 2:45 PM Sylvestre Ledru wrote: > Le 08/01/2020 à 14:14, Alexander Kornienko a écrit : > > [adding the list back] > > > > This list is one of the places that would be quite boring and > error-prone to update manually. I'd strongly prefer

[clang-tools-extra] fdfe324 - [clang-tidy] IncludeInserter: allow <> in header name

Author: Alexander Kornienko Date: 2020-09-28T15:14:04+02:00 New Revision: fdfe324da195ebd9b9c691f006b0d6ccc64365e1 URL: https://github.com/llvm/llvm-project/commit/fdfe324da195ebd9b9c691f006b0d6ccc64365e1 DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] 4c5e0c7 - Remove references to the ast_type_traits namespace

Author: Alexander Kornienko Date: 2020-12-11T12:39:33+01:00 New Revision: 4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed URL: https://github.com/llvm/llvm-project/commit/4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed DIFF: https://github.com/llvm/llvm-project/commit

[clang] 9c49b0b - Remove the ast_type_traits namespace.

Author: Alexander Kornienko Date: 2020-12-15T02:16:12+01:00 New Revision: 9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479 URL: https://github.com/llvm/llvm-project/commit/9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479 DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] fe4715c - Remove old create(MainFile)?IncludeInsertion overloads

Author: Alexander Kornienko Date: 2020-10-09T15:24:57+02:00 New Revision: fe4715c47f9c02a83b339c12067f1d27a3115fe4 URL: https://github.com/llvm/llvm-project/commit/fe4715c47f9c02a83b339c12067f1d27a3115fe4 DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] 1968a61 - [clang-tidy] Fix IncludeInserter usage example in a comment.

Author: Alexander Kornienko Date: 2020-10-12T15:05:42+02:00 New Revision: 1968a6155fd5ef178598b204cc6a176719b99f2e URL: https://github.com/llvm/llvm-project/commit/1968a6155fd5ef178598b204cc6a176719b99f2e DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] cc175c2 - Support ObjC in IncludeInserter

Author: Alexander Kornienko Date: 2020-10-16T04:12:32+02:00 New Revision: cc175c2cc8e638462bab74e0781e06f9b6eb5017 URL: https://github.com/llvm/llvm-project/commit/cc175c2cc8e638462bab74e0781e06f9b6eb5017 DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] 37558fd - [clang-tidy] Add links to check docs in comments

Author: Alexander Kornienko Date: 2020-10-22T13:31:21+02:00 New Revision: 37558fd29ee0af2302c051b8e70543cfc3e7ca91 URL: https://github.com/llvm/llvm-project/commit/37558fd29ee0af2302c051b8e70543cfc3e7ca91 DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] dfd2374 - [clang-tidy] Remove unnecessary #ifdef

Author: Alexander Kornienko Date: 2021-01-28T15:00:07+01:00 New Revision: dfd2374ab6c393d675e7b4583bc279b2d7e9b51f URL: https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] dfd2374 - [clang-tidy] Remove unnecessary #ifdef

Author: Alexander Kornienko Date: 2021-01-28T15:00:07+01:00 New Revision: dfd2374ab6c393d675e7b4583bc279b2d7e9b51f URL: https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f DIFF: https://github.com/llvm/llvm-project/commit

[clang] e9533b8 - [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

Author: Bogdan Graur Date: 2021-07-13T15:54:31+02:00 New Revision: e9533b84920798cf9b35d26586a61bad0a1f9825 URL: https://github.com/llvm/llvm-project/commit/e9533b84920798cf9b35d26586a61bad0a1f9825 DIFF: https://github.com/llvm/llvm-project/commit/e9533b84920798cf9b35d26586a61bad0a1f9825.diff

[clang-tools-extra] 481079e - [NFC] Unify FIME with FIXME in comments

Author: Jinzheng Tu Date: 2021-03-10T14:00:51+01:00 New Revision: 481079e2841f1d7aafbbd627e7028bcc632a4ef7 URL: https://github.com/llvm/llvm-project/commit/481079e2841f1d7aafbbd627e7028bcc632a4ef7 DIFF: https://github.com/llvm/llvm-project/commit/481079e2841f1d7aafbbd627e7028bcc632a4ef7.diff L

[clang] e861610 - Revert "[TokenLexer][NFC] Rename the InstLoc to ExpandLoc"

Author: Alexander Kornienko Date: 2022-10-23T23:14:40+02:00 New Revision: e86161076e4a0633d7ab845037fe9443363a5a29 URL: https://github.com/llvm/llvm-project/commit/e86161076e4a0633d7ab845037fe9443363a5a29 DIFF: https://github.com/llvm/llvm-project/commit

[clang] e7656da - Revert "[Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation."

Author: Alexander Kornienko Date: 2022-10-23T23:14:40+02:00 New Revision: e7656daea8724ba1bed6eb7a4dc96498ce7d06c5 URL: https://github.com/llvm/llvm-project/commit/e7656daea8724ba1bed6eb7a4dc96498ce7d06c5 DIFF: https://github.com/llvm/llvm-project/commit

Re: [PATCH] D136565: [clang] Instantiate alias templates with sugar

Given the broad impact of this in our code I'm inclined to revert the patch to unblock us. The test case I have so far is still too large, but I hope to get something shareable tomorrow. On Tue, 8 Nov 2022, 04:03 Matheus Izvekov via Phabricator, < revi...@reviews.llvm.org> wrote: > mizvekov added

[clang-tools-extra] a5c18fc - Revert "[clang] Instantiate alias templates with sugar"

Author: Alexander Kornienko Date: 2022-11-08T17:19:54+01:00 New Revision: a5c18fcf6e7ffeea72aaf079477caf2ac1d641bc URL: https://github.com/llvm/llvm-project/commit/a5c18fcf6e7ffeea72aaf079477caf2ac1d641bc DIFF: https://github.com/llvm/llvm-project/commit

[clang] b7f4915 - Revert "Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas"

Author: Alexander Kornienko Date: 2023-09-01T12:53:24+02:00 New Revision: b7f4915644844fb9f32e8763922a070f5fe4fd29 URL: https://github.com/llvm/llvm-project/commit/b7f4915644844fb9f32e8763922a070f5fe4fd29 DIFF: https://github.com/llvm/llvm-project/commit

[clang] 38f5ab4 - Revert "[clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation"

Author: Alexander Kornienko Date: 2022-11-25T17:04:31+01:00 New Revision: 38f5ab4d44e3fa826006022aad377bb23ed357ca URL: https://github.com/llvm/llvm-project/commit/38f5ab4d44e3fa826006022aad377bb23ed357ca DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] b26c88e - [clang-tidy] Store all ranges in clang::tooling::Diagnostic

Author: Joe Turner Date: 2020-02-27T19:39:42+01:00 New Revision: b26c88e3c6e08f8f78ab4291bc85b5685241f493 URL: https://github.com/llvm/llvm-project/commit/b26c88e3c6e08f8f78ab4291bc85b5685241f493 DIFF: https://github.com/llvm/llvm-project/commit/b26c88e3c6e08f8f78ab4291bc85b5685241f493.diff LO

[clang-tools-extra] 071002f - [clang-tidy] Copy the Ranges field from the Diagnostic when creating the ClangTidyError

Author: Joe Turner Date: 2020-03-02T12:39:16+01:00 New Revision: 071002ffdb3f13fa3006618e7ee8277a75792df5 URL: https://github.com/llvm/llvm-project/commit/071002ffdb3f13fa3006618e7ee8277a75792df5 DIFF: https://github.com/llvm/llvm-project/commit/071002ffdb3f13fa3006618e7ee8277a75792df5.diff LO

[clang-tools-extra] aa0e92e - [clang-tidy] Use range-for for check registration. NFC

Author: Alexander Kornienko Date: 2019-11-26T16:34:23+01:00 New Revision: aa0e92e1f7069834852c08fdd32a92258e30555c URL: https://github.com/llvm/llvm-project/commit/aa0e92e1f7069834852c08fdd32a92258e30555c DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] c375dc2 - Revert "Fix llvm-namespace-comment for macro expansions"

Author: Alexander Kornienko Date: 2019-12-03T20:30:41+01:00 New Revision: c375dc230d16f451cf1c7e2868237da6ef7bc4cf URL: https://github.com/llvm/llvm-project/commit/c375dc230d16f451cf1c7e2868237da6ef7bc4cf DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] fac4e3c - [clang-tidy] Fix PR26274

Author: Alexander Kornienko Date: 2019-12-06T10:10:15+01:00 New Revision: fac4e3c5f8a018599cbd9363a735b1c13e8f8a05 URL: https://github.com/llvm/llvm-project/commit/fac4e3c5f8a018599cbd9363a735b1c13e8f8a05 DIFF: https://github.com/llvm/llvm-project/commit

Re: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

After this commit clang started generating assertion failures on valid code. There are tons of instances in our codebase. Here's a reduced test case: template class a { int c : b; void f() { if (c) ; } }; Please take a look. On Wed, Dec 4, 2019 at 12:39 AM Elizabeth Andrews via cf

[clang-tools-extra] 2b09390 - Fix naming style. NFC.

Author: Alexander Kornienko Date: 2019-12-12T17:00:57+01:00 New Revision: 2b09390c136247b42c1b54f42ce925e31d51062a URL: https://github.com/llvm/llvm-project/commit/2b09390c136247b42c1b54f42ce925e31d51062a DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] 65996c3 - [clang-tidy] Use early returns to make the code easier to read and potentially run faster

Author: Alexander Kornienko Date: 2019-12-12T17:00:57+01:00 New Revision: 65996c302a4472e597780c99bd834f9bf8978712 URL: https://github.com/llvm/llvm-project/commit/65996c302a4472e597780c99bd834f9bf8978712 DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] r328101 - [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

Author: alexfh Date: Wed Mar 21 07:39:24 2018 New Revision: 328101 URL: http://llvm.org/viewvc/llvm-project?rev=328101&view=rev Log: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique Summary: For a c++11 code, the clang-tidy rule "modernize-make-unique" should

Re: [clang-tools-extra] r327833 - [clang-tidy] New check bugprone-unused-return-value

On Mon, Mar 19, 2018 at 10:43 PM wrote: > This should be fixed by r327911. > Thanks! > > > Douglas Yung > > > > *From:* cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] *On > Behalf Of *Galina Kistanova via cfe-commits > *Sent:* Monday, March 19, 2018

[clang-tools-extra] r328199 - clang-tidy, modularize: return non-zero exit code on errors

Author: alexfh Date: Thu Mar 22 07:18:20 2018 New Revision: 328199 URL: http://llvm.org/viewvc/llvm-project?rev=328199&view=rev Log: clang-tidy, modularize: return non-zero exit code on errors When no inputs given, the tools should not only produce the help message, but also return a non-zero exi

r328495 - [clang-format] Wildcard expansion on Windows.

Author: alexfh Date: Mon Mar 26 06:54:17 2018 New Revision: 328495 URL: http://llvm.org/viewvc/llvm-project?rev=328495&view=rev Log: [clang-format] Wildcard expansion on Windows. Summary: Add support for wildcard expansion in command line arguments on Windows. See https://docs.microsoft.com/en-us

Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

This checker crashes on almost each file in our codebase. No test case yet, but here's a stack trace: clang::Type::getTypeClass clang::ReferenceType::classof llvm::isa_impl::doit llvm::isa_impl_cl::doit llvm::isa_impl_wrap::doit llvm::isa_impl_wrap::doit llvm::isa clang::Type::getAs clang::ASTConte

r328623 - Move a ref-counted pointer instead of copying it. NFC.

Author: alexfh Date: Tue Mar 27 07:02:06 2018 New Revision: 328623 URL: http://llvm.org/viewvc/llvm-project?rev=328623&view=rev Log: Move a ref-counted pointer instead of copying it. NFC. Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/trunk/lib/Tooling/Tooling.cpp URL: http://llv

Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

2018, at 10:54 AM, Alexander Kornienko > wrote: > > This checker crashes on almost each file in our codebase. No test case > yet, but here's a stack trace: > clang::Type::getTypeClass > clang::ReferenceType::classof > llvm::isa_impl::doit > llvm::isa_impl_cl::doit > llvm

[clang-tools-extra] r329182 - [clang-tidy] Rename -warnings-as-errors tests. NFC.

Author: alexfh Date: Wed Apr 4 05:40:00 2018 New Revision: 329182 URL: http://llvm.org/viewvc/llvm-project?rev=329182&view=rev Log: [clang-tidy] Rename -warnings-as-errors tests. NFC. The tests will be more discoverable with proper names. Added: clang-tools-extra/trunk/test/clang-tidy/warni

r329391 - Allow the creation of human-friendly ASTDumper to arbitrary output stream

Author: alexfh Date: Fri Apr 6 06:01:12 2018 New Revision: 329391 URL: http://llvm.org/viewvc/llvm-project?rev=329391&view=rev Log: Allow the creation of human-friendly ASTDumper to arbitrary output stream Summary: `ASTPrinter` allows setting the ouput to any O-Stream, but that printer creates

[clang-tools-extra] r329579 - [clang-tidy] Return non-zero exit code for clang errors.

Author: alexfh Date: Mon Apr 9 08:12:10 2018 New Revision: 329579 URL: http://llvm.org/viewvc/llvm-project?rev=329579&view=rev Log: [clang-tidy] Return non-zero exit code for clang errors. Summary: Updated tests broken by this change. Fixes https://bugs.llvm.org/show_bug.cgi?id=27628 Reviewers:

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

On Fri, Apr 6, 2018 at 10:42 PM Zinovy Nis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: zinovy.nis > Date: Fri Apr 6 13:39:23 2018 > New Revision: 329452 > > URL: http://llvm.org/viewvc/llvm-project?rev=329452&view=rev > Log: > [clang-tidy] Fix compilation for ParentVirtualCallC

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

urn bool(_M_pred(*__it)); } > ^ > /home/uweigand/sandbox/buildbot/clang-s390x-linux-multistage/llvm/tools/clang/tools/extra/clang-tidy/bugprone/ParentVirtualCallCheck.cpp:30:73: > note: candidate: clang::tidy::bugprone::isParentOf(const > clang::CXXRec

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

I totally get it, no worries. But if you have free cycles, it would be nice to brush this code up again. On Tue, Apr 10, 2018 at 5:32 PM Zinovy Nis wrote: > Looks you are right, but I was in hurry trying to fix build bot failures > ASAP. > > вт, 10 апр. 2018 г. в 18:28, Alexand

Re: r329784 - [Tooling] Optimize memory usage in InMemoryToolResults.

On Wed, Apr 11, 2018 at 10:16 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Wed Apr 11 01:13:07 2018 > New Revision: 329784 > ... > > == > --- cfe/trunk/include/clang/Tooling/E

[clang] 1812e13 - Revert "[clang] Add the check of membership for the issue #58674 and improve the lookup process"

Author: Alexander Kornienko Date: 2023-02-23T17:31:04+01:00 New Revision: 1812e13a3d6be9a838672ff74b3d9d383f5a83b5 URL: https://github.com/llvm/llvm-project/commit/1812e13a3d6be9a838672ff74b3d9d383f5a83b5 DIFF: https://github.com/llvm/llvm-project/commit

Re: [clang-tools-extra] r289656 - modernize-use-auto NFC fixes

For most loop changes here applying modernize-loop-convert would be better ;) On Wed, Dec 14, 2016 at 4:29 PM, Piotr Padlewski via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: prazek > Date: Wed Dec 14 09:29:23 2016 > New Revision: 289656 > > URL: http://llvm.org/viewvc/llvm-project

[clang-tools-extra] r290289 - [clang-tidy] Ignore `size() == 0` in the container implementation.

Author: alexfh Date: Wed Dec 21 17:44:23 2016 New Revision: 290289 URL: http://llvm.org/viewvc/llvm-project?rev=290289&view=rev Log: [clang-tidy] Ignore `size() == 0` in the container implementation. Modified: clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp clan

[clang-tools-extra] r290434 - [clang-tidy] Flag implicit conversion operators.

Author: alexfh Date: Fri Dec 23 09:03:12 2016 New Revision: 290434 URL: http://llvm.org/viewvc/llvm-project?rev=290434&view=rev Log: [clang-tidy] Flag implicit conversion operators. Modified: clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp clang-tools-extra/trunk/do

[clang-tools-extra] r290668 - [clang-tidy] google-explicit-constructor: ignore compiler-generated conversion operators.

Author: alexfh Date: Wed Dec 28 07:48:03 2016 New Revision: 290668 URL: http://llvm.org/viewvc/llvm-project?rev=290668&view=rev Log: [clang-tidy] google-explicit-constructor: ignore compiler-generated conversion operators. Modified: clang-tools-extra/trunk/clang-tidy/google/ExplicitConstruct

[clang-tools-extra] r290753 - [clang-tidy] google-explicit-constructor: ignore template instantiations

Author: alexfh Date: Fri Dec 30 07:25:03 2016 New Revision: 290753 URL: http://llvm.org/viewvc/llvm-project?rev=290753&view=rev Log: [clang-tidy] google-explicit-constructor: ignore template instantiations Modified: clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp cl

[clang-tools-extra] r290756 - [clang-tidy] google-explicit-constructor: ignore macros

Author: alexfh Date: Fri Dec 30 09:15:14 2016 New Revision: 290756 URL: http://llvm.org/viewvc/llvm-project?rev=290756&view=rev Log: [clang-tidy] google-explicit-constructor: ignore macros Modified: clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp clang-tools-extra/t

r290892 - [clang-tidy] Add check name to YAML export

Author: alexfh Date: Tue Jan 3 08:35:47 2017 New Revision: 290892 URL: http://llvm.org/viewvc/llvm-project?rev=290892&view=rev Log: [clang-tidy] Add check name to YAML export Add a field indicating the associated check for every replacement to the YAML report generated with the '-export-fixes' o

[clang-tools-extra] r290893 - [clang-tidy] Add check name to YAML export (clang-tools-extra part)

Author: alexfh Date: Tue Jan 3 08:36:13 2017 New Revision: 290893 URL: http://llvm.org/viewvc/llvm-project?rev=290893&view=rev Log: [clang-tidy] Add check name to YAML export (clang-tools-extra part) Add a field indicating the associated check for every replacement to the YAML report generated w

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of nits. Comment at: clang-rename/USRFinder.cpp:182 @@ -179,5 +181,3 @@ // We only want to search the decls that exist in the same file as the point. - au

Re: [PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

alexfh added inline comments. Comment at: clang-tidy/readability/ImplicitBoolCastCheck.h:25 @@ -24,3 +24,3 @@ public: ImplicitBoolCastCheck(StringRef Name, ClangTidyContext *Context) : ClangTidyCheck(Name, Context), BTW, could you move the constructor b

Re: [PATCH] D23533: [clang-tidy] Rewrite compilation database test to not require shell

alexfh added inline comments. Comment at: test/clang-tidy/clang-tidy-run-with-database.cpp:11 @@ -10,3 @@ -// RUN: echo '#include "header.h"' > %T/compilation-database-test/b/d.cpp -// RUN: sed 's|test_dir|%T/compilation-database-test|g' %S/Inputs/compilation-database/template.js

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:95-98 @@ +94,6 @@ +const QualType T = VD->getType(); +if (T->isPointerType() && !T->getPointeeType().isConstQualified())

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh added a comment. In https://reviews.llvm.org/D23455#515527, @rnk wrote: > In https://reviews.llvm.org/D23455#515486, @brad.king wrote: > > > > the feasibility of emitting 'arguments' instead of 'command' into the > > > JSON compilation database. > > > > > > CMake constructs the command li

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh added a comment. Adding Aaron, since he seems to have interest in Windows support for clang-tidy. https://reviews.llvm.org/D23455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:56 @@ +55,3 @@ + if (hasMacroID(ArraySubscriptE) || + !Result.SourceManager->isWrittenInSameFile(ArraySubscriptE->getLoc

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/LibASTMatchersReference.html:2774 @@ -2773,1 +2773,3 @@ +MatcherNamedDecl>hasExternalFormalLinkage +Matches N

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh added a comment. In https://reviews.llvm.org/D23455#516760, @zturner wrote: > In https://reviews.llvm.org/D23455#516753, @alexfh wrote: > > > In https://reviews.llvm.org/D23455#515527, @rnk wrote: > > > > > In https://reviews.llvm.org/D23455#515486, @brad.king wrote: > > > > > > > > the fe

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:28 @@ +27,3 @@ +llvm::APSInt BeginVal = EnumDec->enumerator_begin()->getInitVal(); +{ + const auto MinMaxVal = std::minmax_element

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:37 @@ +36,3 @@ +static bool areTypesCompatible(QualType Left, QualType Right) { + return getStrippedType(Left) == getStrippedType(Right

Re: [PATCH] D23543: Adapt to TraverseLambdaCapture interface change from D23204

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits. Comment at: unittests/Tooling/RecursiveASTVisitorTestExprVisitor.cpp:221 @@ +220,3 @@ + } + { +DeclRefExprVisitor Visitor; n

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + Prazek wrote: > aaron.ball

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/index.rst:344 @@ -343,4 +343,3 @@ verifies conformance of the code to a certain coding style, it probably deserves -a separate module and a directory in ``clang-

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

alexfh added inline comments. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:659 @@ +658,3 @@ + UseAfterMove Use; + if (finder.find(FunctionBody, MovingCall, MovedVariable, &Use)) { +emitDiagnostic(MovingCall, MovedVariable, Use, this, Result.Context); om

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

alexfh added a comment. In https://reviews.llvm.org/D23585#517942, @aaron.ballman wrote: > I've commit in r278926. (I can't close because @alexfh hasn't accepted yet; > Alex, can you accept & close?) Sure. Done. BTW, Phabricator can close revisions automatically on commit: http://llvm.org/do

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:32-33 @@ -31,1 +31,4 @@ + // Calling make_smart_ptr from within a member function of a type with a + // private or protected constructor would be ill-formed. + auto CanCallCtor = unless(has(i

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + Prazek wrote: > alexfh wro

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:29 @@ +28,3 @@ +/// Provides information about the evaluation order of (sub-)expressions within +/// a CFGBlock. +/// Please

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D23455#518312, @rnk wrote: > So, I actually went ahead and generated some MSYS makefiles and made a > compile_commands.json, and it doesn't work with clang-tidy. Yo

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh added a comment. In https://reviews.llvm.org/D23455#518317, @zturner wrote: > We could also provide a command line option to clang-tidy that lets the user > specify the command line syntax of the compilation database. It could choose > a smart default (i.e. what we do in this patch afte

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

alexfh added a comment. Full context diffs, please (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). https://reviews.llvm.org/D23618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/index.rst:343 @@ +342,3 @@ +are located in subdirectories of +``clang-tidy/ ``_. +

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Repository: rL LLVM https://reviews.llvm.org/D23596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[clang-tools-extra] r279049 - [clang-tidy docs] Fix build errors on Sphinx 1.4.5

Author: alexfh Date: Thu Aug 18 06:06:09 2016 New Revision: 279049 URL: http://llvm.org/viewvc/llvm-project?rev=279049&view=rev Log: [clang-tidy docs] Fix build errors on Sphinx 1.4.5 Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.r

[clang-tools-extra] r279050 - [clang-tidy docs] Fix formatting.

Author: alexfh Date: Thu Aug 18 06:10:52 2016 New Revision: 279050 URL: http://llvm.org/viewvc/llvm-project?rev=279050&view=rev Log: [clang-tidy docs] Fix formatting. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/mpi-type-mismatch.rst Modified: clang-tools-extra/trunk/docs/clang-t

[clang-tools-extra] r279051 - [clang-tidy docs] Minor fix

Author: alexfh Date: Thu Aug 18 06:12:03 2016 New Revision: 279051 URL: http://llvm.org/viewvc/llvm-project?rev=279051&view=rev Log: [clang-tidy docs] Minor fix Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/mpi-type-mismatch.rst Modified: clang-tools-extra/trunk/docs/clang-tidy/ch

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:104 @@ +103,3 @@ + const QualType T = Parm->getType(); + if (!T->isPointerType() || T->getPointeeType().isCo

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/USRFindingAction.cpp:69 @@ -69,2 +68,3 @@ } -USRs->insert(USRs->end(), USRSet.begin(), USRSet.end()); +USRs.insert(USRs.end(), USRSet.begin(), USRSet.end

Re: [PATCH] D23628: Fix unittests after windows command line parsing

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang-tools-extra] r279115 - [clang-tidy docs] Move option descriptions to the Options section

Author: alexfh Date: Thu Aug 18 13:43:47 2016 New Revision: 279115 URL: http://llvm.org/viewvc/llvm-project?rev=279115&view=rev Log: [clang-tidy docs] Move option descriptions to the Options section + random fixes Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-assert-side-effe

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. As discussed offline, since the functionality being added in this patch is only useful for tests, the related simplification of tests seems not worth the added complexity. https://

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/USRFindingAction.cpp:145 @@ +144,3 @@ + explicit NamedDeclFindingConsumer( + ArrayRef SymbolOffsets, + ArrayRef OldNames, What about the s

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:11 @@ -10,3 +10,3 @@ -The check can generate fixes after the option `GslHeader` has been set +The c

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

alexfh added a comment. Please rebase your patch, I've made some changes to some of these files. Comment at: docs/clang-tidy/checks/misc-misplaced-widening-cast.rst:39 @@ -34,3 +38,3 @@ Forgetting to place the cast at all is at least as dangerous and at least as -common as misp

[clang-tools-extra] r279442 - [clang-tidy docs] Further cleanup of options

Author: alexfh Date: Mon Aug 22 12:19:23 2016 New Revision: 279442 URL: http://llvm.org/viewvc/llvm-project?rev=279442&view=rev Log: [clang-tidy docs] Further cleanup of options Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-pro-type-member-init.rst clang-tool

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh accepted this revision. alexfh added a comment. LG. Thank you! https://reviews.llvm.org/D23343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a few nits. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:9 @@ -8,3 +8,3 @@ are out of bounds (for ``std::array``). For ou

<    1   2   3   4   5   6   7   8   9   10   >