[PATCH] D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes

AlexVlx updated this revision to Diff 122327. https://reviews.llvm.org/D39857 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/TargetInfo.cpp lib/Sema/SemaDeclAttr.cpp Index: lib/Sema/SemaDeclAttr.cpp =

[PATCH] D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes

AlexVlx updated this revision to Diff 123577. AlexVlx added a comment. Apologies for the delayed update. The new version tries to deal with two issues: 1. the non-compliant style identified by Aaron in various spots, hopefully this is correct now; 2. there was an issue with the existing logic, w

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 532470. AlexVlx added a comment. `clang-format` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 Files: clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 534380. AlexVlx added a comment. Fixed issue found via internal testing (thanks @yaxunl). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 Files: clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 534670. AlexVlx added a comment. Add missing test for `vtable` initializers on the `__device__` side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 Files: clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGe

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. In D153092#4448514 , @yaxunl wrote: > In D153092#4447445 , @AlexVlx wrote: > >> Fixed issue found via internal testing (thanks @yaxunl). > > Can we add a test to cover the regression found

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. In D153092#4452070 , @yaxunl wrote: > This could be a good chance to switch VT to constant address space instead of > global address space. AFAIK if a target has global addr space they usually > also has constant addr space sinc

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. Thank you @yaxunl. @rjmccall / @efriedma any input on this? I'd like to try landing it next week to unblock some additional work. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 __

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx updated this revision to Diff 523902. AlexVlx added a comment. Use `GetGlobalVarAddressSpace` everywhere. Added test, which I'm marking `XFAIL` for now since it turns out I'll need to fix the remaining vptr / vtable handling parts, yay. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4354742 , @rjmccall wrote: > Can you add a test? I think we have some in-tree targets which put globals > in a non-default address space. I've added the test (think we, i.e. AMDGPU, are the only ones doing this at th

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4357443 , @rjmccall wrote: > It's well-formed as IR, just not semantically valid, right? As long as it's > not actually crashing in the verifier, please test as much as you reasonably > can that's correct, like that

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx updated this revision to Diff 526692. AlexVlx added a comment. Updated the test to capture suggested VTT use cases (hopefully all). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150746/new/ https://reviews.llvm.org/D150746 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clang/te

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4357837 , @rjmccall wrote: > I see. Yes, in that case I think you're right that we can't test this yet — > only base-subobject ctors and dtors get VTT parameters, we only emit calls to > those from other ctors and dt

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4381758 , @rjmccall wrote: > The process is pretty lightweight; I'd recommend just doing it if you expect > to make more than one patch. But we don't have a policy against committing > patches for other people as lon

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1630-1632 +LangAS AS = CGM.GetGlobalVarAddressSpace(nullptr); +QualType Q = Context.getAddrSpaceQualType(Context.VoidPtrTy, AS); +QualType T = Context.getPointerType(Q); ya

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1630-1632 +LangAS AS = CGM.GetGlobalVarAddressSpace(nullptr); +QualType Q = Context.getAddrSpaceQualType(Context.VoidPtrTy, AS); +QualType T = Context.getPointerType(Q); Al

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG29663e2b8c4e: [clang][CodeGen] Account for VTT address space (authored by AlexVlx). Repository: rG LLVM Github Monorepo

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx created this revision. AlexVlx added reviewers: aaron.ballman, yaxunl. Herald added subscribers: arichardson, tpr. Herald added a project: All. AlexVlx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When lowering from a HLL that do

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx updated this revision to Diff 523019. AlexVlx added a comment. Corrected typo that was breaking the build; rewrote the AS-using branch to account for the (unsupported, but possible, I think?) case of typed pointers, which was showing up in some tests that haven't been ported to opaque po

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4349408 , @aaron.ballman wrote: > Thank you for the fix! Please be sure to add test coverage for the changes > and a release note for the fix. > > Adding the codegen code owners for review. FWIW, precommit CI is faili

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4350288 , @efriedma wrote: > At first glance, this seems like the wrong place to put this cast. If an > expression in the AST produces a pointer with generic pointer type, then > CodeGen should generate code for that

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4350716 , @rjmccall wrote: > Passing the VTT in the appropriate AS for global variables seems like the > right way to go — we do know that that argument will always be such a > pointer, so there's no point in converti

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx updated this revision to Diff 523400. AlexVlx added a comment. Reworked in accordance with review comments, correcting the embedded assumption about VTT being always in the generic AS. This ended up being slightly noisier than anticipated since functionality is spread out. CHANGES SINC

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx created this revision. AlexVlx added reviewers: rjmccall, efriedma, yaxunl. Herald added subscribers: arichardson, tpr. Herald added a project: All. AlexVlx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All data structures and val

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 532294. AlexVlx added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 Files: clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.cpp clan

<    1   2