r300981 - [PR32667] -Wdocumentation should allow @param/@returns for fields/variables

2017-04-21 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Apr 21 09:17:49 2017 New Revision: 300981 URL: http://llvm.org/viewvc/llvm-project?rev=300981&view=rev Log: [PR32667] -Wdocumentation should allow @param/@returns for fields/variables that have a function/block pointer type This commit improves the -Wdocumentation warni

r301180 - [index] The relation between the declarations in template specializations

2017-04-24 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon Apr 24 09:04:58 2017 New Revision: 301180 URL: http://llvm.org/viewvc/llvm-project?rev=301180&view=rev Log: [index] The relation between the declarations in template specializations that 'override' declarations in the base template should be recorded This can be used fo

r301310 - [index] Record the 'SpecializationOf' relation for function specializations

2017-04-25 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue Apr 25 09:22:29 2017 New Revision: 301310 URL: http://llvm.org/viewvc/llvm-project?rev=301310&view=rev Log: [index] Record the 'SpecializationOf' relation for function specializations rdar://31603531 Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/In

r301315 - [index] Index type source info for class specializations

2017-04-25 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue Apr 25 10:13:42 2017 New Revision: 301315 URL: http://llvm.org/viewvc/llvm-project?rev=301315&view=rev Log: [index] Index type source info for class specializations rdar://31758344 Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/Index/Core/index-sour

r301328 - [libclang] Check for a record declaration before a template specialization

2017-04-25 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue Apr 25 11:59:07 2017 New Revision: 301328 URL: http://llvm.org/viewvc/llvm-project?rev=301328&view=rev Log: [libclang] Check for a record declaration before a template specialization Fixes PR32539. Patch by Emilio Cobos Álvarez! Differential Revision: https://reviews.

r301400 - [AST] Look through attribute type locs when searching for function type

2017-04-26 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Apr 26 07:46:27 2017 New Revision: 301400 URL: http://llvm.org/viewvc/llvm-project?rev=301400&view=rev Log: [AST] Look through attribute type locs when searching for function type loc Prior to this commit -Wdocumentation crashed when checking the @returns command for de

r301402 - -Wdocumentation should not check the @returns command for Objective-C

2017-04-26 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Apr 26 08:09:28 2017 New Revision: 301402 URL: http://llvm.org/viewvc/llvm-project?rev=301402&view=rev Log: -Wdocumentation should not check the @returns command for Objective-C function/block pointer properties The commit r300981 allowed @param/@return commands for fun

r301409 - -Wunguarded-availability should support if (@available) checks in top-level

2017-04-26 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Apr 26 09:20:02 2017 New Revision: 301409 URL: http://llvm.org/viewvc/llvm-project?rev=301409&view=rev Log: -Wunguarded-availability should support if (@available) checks in top-level blocks and lambdas Prior to this commit Clang emitted the old "partial availability" w

r301532 - [ObjC] Disallow vector parameters and return values in Objective-C methods

2017-04-27 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Apr 27 05:43:48 2017 New Revision: 301532 URL: http://llvm.org/viewvc/llvm-project?rev=301532&view=rev Log: [ObjC] Disallow vector parameters and return values in Objective-C methods for iOS < 9 and OS X < 10.11 X86 targets This commit adds a new error that disallows me

r301542 - [libclang] Pass in the -fallow-editor-placeholders option

2017-04-27 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Apr 27 08:47:03 2017 New Revision: 301542 URL: http://llvm.org/viewvc/llvm-project?rev=301542&view=rev Log: [libclang] Pass in the -fallow-editor-placeholders option This will suppress any live diagnostics caused by editor placeholders in Xcode. rdar://31833579 Added:

r301635 - [index] Handle vector types in USR generator

2017-04-28 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Apr 28 04:46:36 2017 New Revision: 301635 URL: http://llvm.org/viewvc/llvm-project?rev=301635&view=rev Log: [index] Handle vector types in USR generator rdar://25339187 Modified: cfe/trunk/lib/Index/USRGeneration.cpp cfe/trunk/test/Index/usrs.cpp Modified: cfe

r301643 - [Sema] Avoid an invalid redefinition error that was presented for

2017-04-28 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Apr 28 07:30:05 2017 New Revision: 301643 URL: http://llvm.org/viewvc/llvm-project?rev=301643&view=rev Log: [Sema] Avoid an invalid redefinition error that was presented for of a function whose previous definition was typo-corrected rdar://28550928 Differential Revisio

r301647 - Use the -Wunknown-warning-option group for the "unknown warning group"

2017-04-28 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Apr 28 09:45:25 2017 New Revision: 301647 URL: http://llvm.org/viewvc/llvm-project?rev=301647&view=rev Log: Use the -Wunknown-warning-option group for the "unknown warning group" diagnostic in #pragma diagnostic This matches the warning group that's specified for the un

r302037 - DiagnosticsEngine should clear DelayedDiagID before reporting the

2017-05-03 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed May 3 10:41:16 2017 New Revision: 302037 URL: http://llvm.org/viewvc/llvm-project?rev=302037&view=rev Log: DiagnosticsEngine should clear DelayedDiagID before reporting the delayed diagnostic This avoids an infinite loop that was uncovered in one of our internal tests

r302046 - Revert r302037

2017-05-03 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed May 3 11:22:16 2017 New Revision: 302046 URL: http://llvm.org/viewvc/llvm-project?rev=302046&view=rev Log: Revert r302037 The commit caused the following two buildbot failures: Clang :: Misc/error-limit-multiple-notes.cpp Clang :: Misc/error-limit.c Removed:

r302136 - [Index] The relation between the declarations in template

2017-05-04 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu May 4 05:42:06 2017 New Revision: 302136 URL: http://llvm.org/viewvc/llvm-project?rev=302136&view=rev Log: [Index] The relation between the declarations in template specializations that 'override' declarations in the base template should use the 'specializationOf' relat

r302151 - DiagnosticsEngine should clear DelayedDiagID before reporting the

2017-05-04 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu May 4 08:56:51 2017 New Revision: 302151 URL: http://llvm.org/viewvc/llvm-project?rev=302151&view=rev Log: DiagnosticsEngine should clear DelayedDiagID before reporting the delayed diagnostic This fix avoids an infinite recursion that was uncovered in one of our intern

r302240 - [Driver] Add a "-mmacos_version_min" option that's an alias for

2017-05-05 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri May 5 09:52:48 2017 New Revision: 302240 URL: http://llvm.org/viewvc/llvm-project?rev=302240&view=rev Log: [Driver] Add a "-mmacos_version_min" option that's an alias for "-mmacosx_version_min" The option -mmacosx_version_min will still be the canonical option for now,

r302250 - [ObjC] Don't disallow vector parameters/return values in methods

2017-05-05 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri May 5 11:15:17 2017 New Revision: 302250 URL: http://llvm.org/viewvc/llvm-project?rev=302250&view=rev Log: [ObjC] Don't disallow vector parameters/return values in methods whose introduced version is lower than the allowed version. We should just rely on the target ver

r302253 - Add a fix-it for -Wunguarded-availability

2017-05-05 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri May 5 11:42:44 2017 New Revision: 302253 URL: http://llvm.org/viewvc/llvm-project?rev=302253&view=rev Log: Add a fix-it for -Wunguarded-availability This patch adds a fix-it for the -Wunguarded-availability warning. This fix-it is similar to the Swift one: it suggests

r302540 - Add support for pretty platform names to `@available`/

2017-05-09 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 9 10:34:46 2017 New Revision: 302540 URL: http://llvm.org/viewvc/llvm-project?rev=302540&view=rev Log: Add support for pretty platform names to `@available`/ `__builtin_available` This commit allows us to use the macOS/iOS/tvOS/watchOS platform names in `@available

r302545 - [CodeCompletion] Complete platform names in @available expressions

2017-05-09 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 9 11:05:04 2017 New Revision: 302545 URL: http://llvm.org/viewvc/llvm-project?rev=302545&view=rev Log: [CodeCompletion] Complete platform names in @available expressions rdar://32074504 Added: cfe/trunk/test/Index/complete-available.m Modified: cfe/trunk/i

r302632 - [index] Index simple dependent declaration references

2017-05-10 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed May 10 04:47:41 2017 New Revision: 302632 URL: http://llvm.org/viewvc/llvm-project?rev=302632&view=rev Log: [index] Index simple dependent declaration references This commit implements basic support for indexing of dependent declaration references. Now the indexer tries

r302689 - [AST] RecursiveASTVisitor should not crash on lambdas with type attributes

2017-05-10 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed May 10 11:21:00 2017 New Revision: 302689 URL: http://llvm.org/viewvc/llvm-project?rev=302689&view=rev Log: [AST] RecursiveASTVisitor should not crash on lambdas with type attributes rdar://31960860 Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h cf

r302796 - [CodeCompletion] NFC, extract a function that generates member

2017-05-11 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu May 11 08:41:00 2017 New Revision: 302796 URL: http://llvm.org/viewvc/llvm-project?rev=302796&view=rev Log: [CodeCompletion] NFC, extract a function that generates member completion results for records Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp Modified: cfe

r302797 - [CodeCompletion] Provide member completions for dependent expressions whose

2017-05-11 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu May 11 08:48:57 2017 New Revision: 302797 URL: http://llvm.org/viewvc/llvm-project?rev=302797&view=rev Log: [CodeCompletion] Provide member completions for dependent expressions whose type is a TemplateSpecializationType or InjectedClassNameType Fixes PR30847. Partially

r302918 - [index] Index template specialization arguments for function templats

2017-05-12 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri May 12 11:32:26 2017 New Revision: 302918 URL: http://llvm.org/viewvc/llvm-project?rev=302918&view=rev Log: [index] Index template specialization arguments for function templats Also ensure that class template specialization arguments are covered rdar://31812032 Modif

r303045 - [index] Avoid a crash that happens when looking up a dependent name

2017-05-15 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon May 15 05:20:39 2017 New Revision: 303045 URL: http://llvm.org/viewvc/llvm-project?rev=303045&view=rev Log: [index] Avoid a crash that happens when looking up a dependent name in a record that has no definition rdar://32194921 Modified: cfe/trunk/lib/Index/IndexBod

r303046 - [index] Store correct location for namespace nested name qualifiers

2017-05-15 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon May 15 05:41:04 2017 New Revision: 303046 URL: http://llvm.org/viewvc/llvm-project?rev=303046&view=rev Log: [index] Store correct location for namespace nested name qualifiers rdar://32195200 Modified: cfe/trunk/lib/Index/IndexTypeSourceInfo.cpp cfe/trunk/test/

r303048 - [index] Visit and store information about namespace alias declarations

2017-05-15 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon May 15 05:56:31 2017 New Revision: 303048 URL: http://llvm.org/viewvc/llvm-project?rev=303048&view=rev Log: [index] Visit and store information about namespace alias declarations rdar://32195226 Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/Index/C

r303068 - [index] References to fields from template instantiations should refer to

2017-05-15 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon May 15 09:26:22 2017 New Revision: 303068 URL: http://llvm.org/viewvc/llvm-project?rev=303068&view=rev Log: [index] References to fields from template instantiations should refer to fields in base templates rdar://32197158 Added: cfe/trunk/test/Index/Core/index-ins

r303156 - Fix PR 10758: Infinite recursion when dealing with copy-initialization

2017-05-16 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 16 05:23:58 2017 New Revision: 303156 URL: http://llvm.org/viewvc/llvm-project?rev=303156&view=rev Log: Fix PR 10758: Infinite recursion when dealing with copy-initialization This commit fixes a bug that's tracked by PR 10758 and duplicates like PR 30343. The bug ca

r303170 - [Sema] Avoid duplicate -Wunguarded-availability warnings in nested functions

2017-05-16 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 16 08:58:53 2017 New Revision: 303170 URL: http://llvm.org/viewvc/llvm-project?rev=303170&view=rev Log: [Sema] Avoid duplicate -Wunguarded-availability warnings in nested functions rdar://31862310 Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp cfe/trunk/test

r303192 - [index] Avoid another crash that happens when looking up a dependent name

2017-05-16 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 16 12:33:17 2017 New Revision: 303192 URL: http://llvm.org/viewvc/llvm-project?rev=303192&view=rev Log: [index] Avoid another crash that happens when looking up a dependent name in a record that has a base without a definition rdar://32224197 Modified: cfe/trun

r303246 - [Lexer] Ensure that the token is not an annotation token when

2017-05-17 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed May 17 06:08:36 2017 New Revision: 303246 URL: http://llvm.org/viewvc/llvm-project?rev=303246&view=rev Log: [Lexer] Ensure that the token is not an annotation token when retrieving the identifer info for an Objective-C keyword This commit fixes an assertion that's trigg

r303343 - [index] Record references to class receivers used in property references

2017-05-18 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu May 18 05:43:11 2017 New Revision: 303343 URL: http://llvm.org/viewvc/llvm-project?rev=303343&view=rev Log: [index] Record references to class receivers used in property references rdar://32250025 Modified: cfe/trunk/lib/Index/IndexBody.cpp cfe/trunk/test/Index

r303366 - [index] Avoid one more crash caused by infinite recursion that happens when

2017-05-18 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu May 18 13:06:07 2017 New Revision: 303366 URL: http://llvm.org/viewvc/llvm-project?rev=303366&view=rev Log: [index] Avoid one more crash caused by infinite recursion that happens when looking up a dependent name in a record that derives from itself rdar://32273000 Diff

r303555 - [index] 'using namespace' declarations in functions should record

2017-05-22 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon May 22 09:39:39 2017 New Revision: 303555 URL: http://llvm.org/viewvc/llvm-project?rev=303555&view=rev Log: [index] 'using namespace' declarations in functions should record the reference to the namespace rdar://32323190 Modified: cfe/trunk/lib/Index/IndexDecl.cpp

r303559 - [index] Visit the default argument values in function definitions

2017-05-22 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon May 22 10:17:44 2017 New Revision: 303559 URL: http://llvm.org/viewvc/llvm-project?rev=303559&view=rev Log: [index] Visit the default argument values in function definitions rdar://32323315 Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/Index/Core/i

r303563 - [index] Index the deleted functions

2017-05-22 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon May 22 10:42:45 2017 New Revision: 303563 URL: http://llvm.org/viewvc/llvm-project?rev=303563&view=rev Log: [index] Index the deleted functions rdar://32323386 Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/Index/Core/index-source.cpp Modified: cfe

r303568 - [index] Index the default template parameter values

2017-05-22 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon May 22 11:50:54 2017 New Revision: 303568 URL: http://llvm.org/viewvc/llvm-project?rev=303568&view=rev Log: [index] Index the default template parameter values rdar://32323724 Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/Index/Core/index-source.cp

r303646 - [index] The references to records from template instantiations should refer

2017-05-23 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 23 11:23:28 2017 New Revision: 303646 URL: http://llvm.org/viewvc/llvm-project?rev=303646&view=rev Log: [index] The references to records from template instantiations should refer to the pattern records in the base templates rdar://32325459 Modified: cfe/trunk/

r303647 - [index] The references to fields from nested records in template instantiations

2017-05-23 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 23 11:25:06 2017 New Revision: 303647 URL: http://llvm.org/viewvc/llvm-project?rev=303647&view=rev Log: [index] The references to fields from nested records in template instantiations should refer to the pattern fields in the nested records in the base templates rda

r303648 - [index] The references to type aliases and typedefs from template

2017-05-23 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 23 11:27:42 2017 New Revision: 303648 URL: http://llvm.org/viewvc/llvm-project?rev=303648&view=rev Log: [index] The references to type aliases and typedefs from template instantiations should refer to the pattern type aliases / typedefs in the base templates rdar://

r303650 - [index] The references to member enums from template instantiations should

2017-05-23 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 23 11:35:50 2017 New Revision: 303650 URL: http://llvm.org/viewvc/llvm-project?rev=303650&view=rev Log: [index] The references to member enums from template instantiations should refer to the pattern member enum in the base template rdar://32325459 Modified: cf

r303651 - [index] The references to enum constants from member enums that are

2017-05-23 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue May 23 11:47:01 2017 New Revision: 303651 URL: http://llvm.org/viewvc/llvm-project?rev=303651&view=rev Log: [index] The references to enum constants from member enums that are from template instantiations should refer to the enum constant in the pattern enum in the base

[PATCH] D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization

2016-10-18 Thread Alex Lorenz via cfe-commits
arphaman added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D25051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25719: [Sema] Fix PR30664

2016-10-18 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added a reviewer: rsmith. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes an assertion failure crash that happens when a constant record reference member is initialized using an empty ini

r284467 - [CodeCompletion][NFC] Extract a function that looks for block decl type locs.

2016-10-18 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue Oct 18 05:35:27 2016 New Revision: 284467 URL: http://llvm.org/viewvc/llvm-project?rev=284467&view=rev Log: [CodeCompletion][NFC] Extract a function that looks for block decl type locs. This commit extracts a new function named `findTypeLocationForBlockDecl` from the fu

[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

2016-10-18 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284467: [CodeCompletion][NFC] Extract a function that looks for block decl type locs. (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25519?vs=74520&id=74972#toc Repository:

r284468 - [CodeCompletion][NFC] Extract a function that formats block placeholders.

2016-10-18 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue Oct 18 05:38:58 2016 New Revision: 284468 URL: http://llvm.org/viewvc/llvm-project?rev=284468&view=rev Log: [CodeCompletion][NFC] Extract a function that formats block placeholders. This commit extracts a new function named `formatBlockPlaceholder` from the function `Fo

[PATCH] D25520: [CodeCompletion] Add block placeholders when completing member access for Objective-C block property setters

2016-10-18 Thread Alex Lorenz via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D25520#569389, @akyrtzi wrote: > > What do you think of the following possible priority heuristic > > SGTM. > > Changes LGTM. I'd also recommend that as a follow-up patch it would be great > to extend the setter completion to variables as w

r284472 - [CodeCompletion] Add a block property setter completion result

2016-10-18 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue Oct 18 05:55:01 2016 New Revision: 284472 URL: http://llvm.org/viewvc/llvm-project?rev=284472&view=rev Log: [CodeCompletion] Add a block property setter completion result This commit changes code completion results for Objective-C block properties: clang now suggests an

[PATCH] D25520: [CodeCompletion] Add block placeholders when completing member access for Objective-C block property setters

2016-10-18 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284472: [CodeCompletion] Add a block property setter completion result (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25520?vs=74528&id=74977#toc Repository: rL LLVM http

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

2016-10-19 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added reviewers: rjmccall, manmanren. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes an invalid `Winitializer-overrides` warning that's shown for a piece of code like this: template

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

2016-10-20 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added reviewers: dblaikie, majnemer. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch improves the mismatched destructor type error by detecting when the destructor call has used a '.' instead o

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

2016-10-20 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 75279. arphaman marked an inline comment as done. arphaman added a comment. The updated patch adds a comment to the modified code as request by Manman. Repository: rL LLVM https://reviews.llvm.org/D25777 Files: lib/Sema/TreeTransform.h test/SemaCXX/

[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

2016-10-20 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added a reviewer: manmanren. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch improves the '-Wformat' warnings by ensuring that the formatting checker can see through Objective-C message sends w

[PATCH] D25816: Use descriptive message if list initializer is incorrectly parenthesized.

2016-10-20 Thread Alex Lorenz via cfe-commits
arphaman added a comment. Thanks for working on this! I have a couple of comments: Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1762 def err_init_incomplete_type : Error<"initialization of incomplete type %0">; +def err_list_init_in_parens : Error<"list-initializer f

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

2016-10-21 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 75403. arphaman added a comment. The updated patch improves error handling and adds a test for the fixit. > If we issue a fixit we should recover as-if the code was written with the > fixit in. Does this code do that? (can we test it? I know we test some fi

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

2016-10-21 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 75405. arphaman added a comment. Fix a typo in the fixit test. Repository: rL LLVM https://reviews.llvm.org/D25817 Files: lib/Sema/SemaExprCXX.cpp test/CXX/special/class.dtor/p10-0x.cpp test/FixIt/fixit.cpp test/SemaCXX/pseudo-destructors.cpp I

[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

2016-10-21 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 75408. arphaman marked an inline comment as done. arphaman added a comment. The updated patch includes positive test cases. Repository: rL LLVM https://reviews.llvm.org/D25820 Files: lib/Sema/SemaChecking.cpp test/SemaObjC/format-strings-objc.m In

[PATCH] D25816: Use descriptive message if list initializer is incorrectly parenthesized.

2016-10-21 Thread Alex Lorenz via cfe-commits
arphaman added a subscriber: rsmith. arphaman added a comment. LGTM, I added Richard in case he has something to add. > I chose to retain current clang behavior and reject questionable code. GCC > patch that introduced this message explains using warning by some > uncertainty, 5 years passed, I

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

2016-10-21 Thread Alex Lorenz via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D25777#575564, @rjmccall wrote: > The fact that this bug only arises when performing a *second* instantiation > suggests that there's a deeper bug here, because template instantiation is > not supposed to modify the pattern AST. In this cas

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

2016-10-21 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 75414. arphaman added a comment. The updated patch addresses John's comment by modifying the `DesignatedInitExpr` re-creation logic. Repository: rL LLVM https://reviews.llvm.org/D25777 Files: lib/Sema/TreeTransform.h test/SemaCXX/designated-initial

r284959 - [Sema][TreeTransform] Re-create DesignatedInitExpr when a field designator

2016-10-24 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon Oct 24 04:33:32 2016 New Revision: 284959 URL: http://llvm.org/viewvc/llvm-project?rev=284959&view=rev Log: [Sema][TreeTransform] Re-create DesignatedInitExpr when a field designator has no field declaration. This commit fixes an invalid Winitializer-overrides warning t

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

2016-10-24 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rL284959: [Sema][TreeTransform] Re-create DesignatedInitExpr when a field designator (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D2

r284961 - [Sema] Formatting warnings should see through Objective-C message sends

2016-10-24 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon Oct 24 04:42:34 2016 New Revision: 284961 URL: http://llvm.org/viewvc/llvm-project?rev=284961&view=rev Log: [Sema] Formatting warnings should see through Objective-C message sends This commit improves the '-Wformat' warnings by ensuring that the formatting checker can s

[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

2016-10-24 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284961: [Sema] Formatting warnings should see through Objective-C message sends (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25820?vs=75408&id=75561#toc Repository: rL L

[PATCH] D25937: [Sema] -Wunused-variable warning for variables with array types should behave similarly to variables with scalar types

2016-10-25 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added reviewers: rjmccall, thakis. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch makes the `-Wunused-variable` warning behaviour more consistent: Now clang won't warn on variables with consta

[PATCH] D25942: Fix crash in implicit default constructor creation for a template record specialization that has a field declaration with an initializer expression

2016-10-25 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added reviewers: rjmccall, rsmith. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes a NULL pointer crash that happens when clang is trying to create an implicit default constructor for a s

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

2016-10-25 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 75712. arphaman added a comment. The updated patch addresses Richard's comment by making sure the fixit isn't emitted when the destructor call is invalid. Repository: rL LLVM https://reviews.llvm.org/D25817 Files: lib/Sema/SemaExprCXX.cpp test/CXX/

[PATCH] D25937: [Sema] -Wunused-variable warning for variables with array types should behave similarly to variables with scalar types

2016-10-26 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 75877. arphaman added a comment. The updated patch incorporates John's suggestions into code. Repository: rL LLVM https://reviews.llvm.org/D25937 Files: lib/Sema/SemaDecl.cpp test/SemaCXX/warn-everthing.cpp test/SemaCXX/warn-unused-variables.cpp

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

2016-10-26 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added reviewers: aaron.ballman, jordan_rose. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds an `objc_subclassing_restricted` attribute into clang. This attribute acts similarly to 'final'

[PATCH] D25995: Add documentation for transparent_union attribute

2016-10-26 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added a reviewer: aaron.ballman. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds a bit of documentation for the `transparent_union` attribute. Repository: rL LLVM https://reviews.llvm.

[PATCH] D16533: Bug 20796 - GCC's -Wstrict-prototypes warning not implemented in Clang

2016-10-27 Thread Alex Lorenz via cfe-commits
arphaman added a comment. Hi Paul, Are you planning to work on this patch? If not, can I take a shot at it? Cheers, Alex https://reviews.llvm.org/D16533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

r285289 - [Sema] -Wunused-variable warning for array variables should behave

2016-10-27 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Oct 27 08:30:51 2016 New Revision: 285289 URL: http://llvm.org/viewvc/llvm-project?rev=285289&view=rev Log: [Sema] -Wunused-variable warning for array variables should behave similarly to scalar variables. This commit makes the -Wunused-variable warning behaviour more c

[PATCH] D25937: [Sema] -Wunused-variable warning for variables with array types should behave similarly to variables with scalar types

2016-10-27 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285289: [Sema] -Wunused-variable warning for array variables should behave (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25937?vs=75877&id=76017#toc Repository: rL LLVM

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

2016-10-27 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 76019. arphaman marked 3 inline comments as done. arphaman added a comment. The updated patch adds documentation and modifies the diagnostic message. Repository: rL LLVM https://reviews.llvm.org/D25993 Files: include/clang/Basic/Attr.td include/clan

r285292 - Add documentation for the transparent_union attribute

2016-10-27 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Oct 27 08:51:30 2016 New Revision: 285292 URL: http://llvm.org/viewvc/llvm-project?rev=285292&view=rev Log: Add documentation for the transparent_union attribute Differential Revision: https://reviews.llvm.org/D25995 Modified: cfe/trunk/include/clang/Basic/Attr.td

[PATCH] D25995: Add documentation for transparent_union attribute

2016-10-27 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285292: Add documentation for the transparent_union attribute (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25995?vs=75905&id=76020#toc Repository: rL LLVM https://revie

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

2016-10-27 Thread Alex Lorenz via cfe-commits
arphaman added inline comments. Comment at: lib/Sema/SemaDeclObjC.cpp:3859 +// objc_subclassing_restricted attribute when it has that attribute as +// well (because of interfaces imported from Swift). Therefore we have +// to check if we can subclass in th

[PATCH] D25942: Fix crash in implicit default constructor creation for a template record specialization that has a field declaration with an initializer expression

2016-10-27 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 76029. arphaman marked an inline comment as done. arphaman added a comment. The updated patch follows Richard's explanation and fixes the problem by checking if `CTD` is a member specialization without irrelevant definition checks. Repository: rL LLVM

[PATCH] D25942: Fix crash in implicit default constructor creation for a template record specialization that has a field declaration with an initializer expression

2016-10-27 Thread Alex Lorenz via cfe-commits
arphaman added inline comments. Comment at: lib/AST/DeclCXX.cpp:1350 while (auto *NewCTD = CTD->getInstantiatedFromMemberTemplate()) { -if (NewCTD->isMemberSpecialization()) +if (NewCTD->isMemberSpecialization() || +!NewCTD->isThisDeclarationADe

[PATCH] D26034: [CodeCompletion] Block property setters: Use dynamic priority heuristic

2016-10-27 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added a reviewer: akyrtzi. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch implements a heuristic that I mentioned in https://reviews.llvm.org/D25520. When completing blocks properties that ret

r285391 - [Objective-C] Add objc_subclassing_restricted attribute

2016-10-28 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Oct 28 05:25:10 2016 New Revision: 285391 URL: http://llvm.org/viewvc/llvm-project?rev=285391&view=rev Log: [Objective-C] Add objc_subclassing_restricted attribute This patch adds an objc_subclassing_restricted attribute into clang. This attribute acts similarly to 'fin

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

2016-10-28 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285391: [Objective-C] Add objc_subclassing_restricted attribute (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25993?vs=76019&id=76175#toc Repository: rL LLVM https://rev

[PATCH] D25942: Fix crash in implicit default constructor creation for a template record specialization that has a field declaration with an initializer expression

2016-10-28 Thread Alex Lorenz via cfe-commits
arphaman abandoned this revision. arphaman added a comment. Abandoning since I discovered that another patch (https://reviews.llvm.org/D13419) that's currently in review fixes this issue. Repository: rL LLVM https://reviews.llvm.org/D25942 ___ c

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

2016-10-28 Thread Alex Lorenz via cfe-commits
arphaman added a comment. I just noticed that this patch fixes a template crash that I have a patch for at https://reviews.llvm.org/D25942. I will abandon my patch since this patch fixes the other issue. Would you mind adding the test case from my patch to this patch? It's available at https:/

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

2016-10-28 Thread Alex Lorenz via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D13419#581356, @loladiro wrote: > Hmm, the rebased version of this introduces new errors in > `test/Modules/cxx-templates.cpp`. That test didn't exist when I wrote this > code and I'm not familiar with templates. @rsmith could you take a loo

[PATCH] D26071: [CodeCompletion] Show block invocation result for block property setters

2016-10-28 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added reviewers: manmanren, akyrtzi. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch changes the code completion results for block property setters. Right now we code complete block property se

r285686 - [www] Fix a typo on the analyzer website

2016-11-01 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Tue Nov 1 06:12:41 2016 New Revision: 285686 URL: http://llvm.org/viewvc/llvm-project?rev=285686&view=rev Log: [www] Fix a typo on the analyzer website Modified: cfe/trunk/www/analyzer/annotations.html Modified: cfe/trunk/www/analyzer/annotations.html URL: http://llv

[PATCH] D26189: Add a note that points to the linkage specifier for the "must have C++ linkage" errors

2016-11-01 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added reviewers: rsmith, rjmccall. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch improves the "must have C++ linkage" error diagnostics for C++ by adding an additional note that points to the

[PATCH] D26189: Add a note that points to the linkage specifier for the "must have C++ linkage" errors

2016-11-01 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 76577. arphaman marked an inline comment as done. arphaman added a comment. The updated patch renames the note diagnostic to a more generic rename. Repository: rL LLVM https://reviews.llvm.org/D26189 Files: include/clang/AST/DeclBase.h include/clang

[PATCH] D26234: [Frontend] Add a predefined macro that describes the Objective-C bool type

2016-11-02 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added reviewers: bob.wilson, steven_wu. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds a new predefined macro named `__OBJC_BOOL_IS_BOOL` that describes the Objective-C boolean type: its

r285823 - Add a note that points to the linkage specifier for the C++ linkage errors

2016-11-02 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Nov 2 10:46:34 2016 New Revision: 285823 URL: http://llvm.org/viewvc/llvm-project?rev=285823&view=rev Log: Add a note that points to the linkage specifier for the C++ linkage errors This commit improves the "must have C++ linkage" error diagnostics that are emitted for

[PATCH] D26189: Add a note that points to the linkage specifier for the "must have C++ linkage" errors

2016-11-02 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285823: Add a note that points to the linkage specifier for the C++ linkage errors (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26189?vs=76577&id=76716#toc Repository: r

r285825 - Simplify the test case from r285289.

2016-11-02 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Nov 2 11:11:30 2016 New Revision: 285825 URL: http://llvm.org/viewvc/llvm-project?rev=285825&view=rev Log: Simplify the test case from r285289. This commit simplifies and clarifies the test code that was added in r285289. Suggested by David Blaikie. Modified: cf

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-11-02 Thread Alex Lorenz via cfe-commits
arphaman added a comment. I've tested this patch on OS X and these 4 tests that you've changed now fail. The `XFAIL: with_system_cxx_lib` lines don't have any effect on my system - these tests get invoked as expected by lit. Let me know if there's anything else I can do to help you. Repositor

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-11-02 Thread Alex Lorenz via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D25811#586053, @kparzysz wrote: > In https://reviews.llvm.org/D25811#586000, @arphaman wrote: > > > I've tested this patch on OS X and these 4 tests that you've changed now > > fail. > > > > The `XFAIL: with_system_cxx_lib` lines don't have a

<    1   2   3   4   5   6   7   >