Author: arphaman
Date: Fri Jan 20 09:38:58 2017
New Revision: 292615
URL: http://llvm.org/viewvc/llvm-project?rev=292615&view=rev
Log:
[Sema] Improve the error diagnostic for dot destructor calls on pointer objects
This commit improves the mismatched destructor type error by detecting when the
de
Author: arphaman
Date: Fri Jan 20 10:48:25 2017
New Revision: 292617
URL: http://llvm.org/viewvc/llvm-project?rev=292617&view=rev
Log:
[Frontend] The macro that describes the Objective-C bool type should
be defined for non Objective-C code as well
rdar://29794915
Differential Revision: https://r
Author: arphaman
Date: Mon Jan 23 11:23:23 2017
New Revision: 292805
URL: http://llvm.org/viewvc/llvm-project?rev=292805&view=rev
Log:
[Sema] UsingShadowDecl shouldn't be hidden by the UsingDecl that owns it
rdar://23454249
Differential Revision: https://reviews.llvm.org/D28514
Added:
cfe/t
Author: arphaman
Date: Tue Jan 24 08:15:08 2017
New Revision: 292932
URL: http://llvm.org/viewvc/llvm-project?rev=292932&view=rev
Log:
[CodeCompletion] Ensure that ObjC root class completes instance
methods from protocols and categories as well
Code completion results for class methods already in
Author: arphaman
Date: Mon Jan 30 05:37:18 2017
New Revision: 293475
URL: http://llvm.org/viewvc/llvm-project?rev=293475&view=rev
Log:
Revert "r293343 - [ubsan] Sanity-check shift amounts before truncation
(fixes PR27271)"
After r293343 clang fails to compile itself with -fsanitize=undefined (
ht
Author: arphaman
Date: Tue Jan 31 06:37:48 2017
New Revision: 293619
URL: http://llvm.org/viewvc/llvm-project?rev=293619&view=rev
Log:
Workaround new -Wshadow warning introduced by r293599
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp
Modified:
libcxx/
Author: arphaman
Date: Wed Feb 1 04:52:02 2017
New Revision: 293759
URL: http://llvm.org/viewvc/llvm-project?rev=293759&view=rev
Log:
Revert r293518 as it caused module linking error in clang-reorder-fields
This commit reverts "r293518 - [ASTMatchers] Sprinkle some constexpr on the
global matche
Author: arphaman
Date: Wed Feb 1 11:37:28 2017
New Revision: 293787
URL: http://llvm.org/viewvc/llvm-project?rev=293787&view=rev
Log:
[CodeGen][ObjC] Avoid asserting on block pointer types in
isPointerZeroInitializable
rdar://30111891
Added:
cfe/trunk/test/CodeGenObjC/block-ptr-type-crash.m
Author: arphaman
Date: Fri Feb 3 08:22:33 2017
New Revision: 294008
URL: http://llvm.org/viewvc/llvm-project?rev=294008&view=rev
Log:
[Sema][ObjC++] Typo correction should handle ivars and properties
After r260016 and r260017 disabled typo correction for ivars and properties
clang didn't report
Author: arphaman
Date: Tue Jun 27 03:35:30 2017
New Revision: 306392
URL: http://llvm.org/viewvc/llvm-project?rev=306392&view=rev
Log:
Recommit r306103: PR26195: Set correct NestedNameSpecifierLoc for the
dependent initializer
This commit fixes incorrect source positions of dependent c'tor initia
Author: arphaman
Date: Thu Jun 29 03:43:44 2017
New Revision: 306659
URL: http://llvm.org/viewvc/llvm-project?rev=306659&view=rev
Log:
[Tooling] FixedCompilationDatabase should be able to strip positional
arguments when `-fsyntax-only` is used
Previously, Clang failed to create a fixed compilatio
Author: arphaman
Date: Thu Jun 29 07:18:26 2017
New Revision: 306680
URL: http://llvm.org/viewvc/llvm-project?rev=306680&view=rev
Log:
Fix NSAPI constants to reflect the current state of
NSStringMethodKind/NSDictionaryMethodKind enums
Patch by Vladimir Voskresensky!
Differential Revision: https:
Author: arphaman
Date: Fri Jun 30 09:36:09 2017
New Revision: 306840
URL: http://llvm.org/viewvc/llvm-project?rev=306840&view=rev
Log:
[refactor] Move clang-rename into the clang repository
The core engine of clang-rename will be used for local and global renames in the
new refactoring engine, as
Author: arphaman
Date: Fri Jun 30 09:43:00 2017
New Revision: 306841
URL: http://llvm.org/viewvc/llvm-project?rev=306841&view=rev
Log:
Use add_clang_unittest in the CMakeLists.txt for the moved unittest
The unittest was moved in r306840
Modified:
cfe/trunk/unittests/Rename/CMakeLists.txt
Mo
Author: arphaman
Date: Fri Jun 30 09:58:36 2017
New Revision: 306843
URL: http://llvm.org/viewvc/llvm-project?rev=306843&view=rev
Log:
Move ClassReplacements.cpp test from clang-rename tests to the
clang-apply-replacements tests
The ClassReplacements.cpp test in the clang-rename tests uses
clang-
Author: arphaman
Date: Fri Jun 30 09:58:36 2017
New Revision: 306843
URL: http://llvm.org/viewvc/llvm-project?rev=306843&view=rev
Log:
Move ClassReplacements.cpp test from clang-rename tests to the
clang-apply-replacements tests
The ClassReplacements.cpp test in the clang-rename tests uses
clang-
Author: arphaman
Date: Fri Jun 30 10:15:48 2017
New Revision: 306844
URL: http://llvm.org/viewvc/llvm-project?rev=306844&view=rev
Log:
Attempt to fix the linkage error caused by r306840 on the mingw-RA-on-linux bot
Modified:
cfe/trunk/tools/clang-rename/CMakeLists.txt
Modified: cfe/trunk/too
Author: arphaman
Date: Mon Jul 3 03:12:24 2017
New Revision: 307014
URL: http://llvm.org/viewvc/llvm-project?rev=307014&view=rev
Log:
Add a fixit for -Wobjc-protocol-property-synthesis
rdar://32132756
Differential Revision: https://reviews.llvm.org/D34886
Added:
cfe/trunk/test/FixIt/fixit-
Author: arphaman
Date: Mon Jul 3 03:34:46 2017
New Revision: 307016
URL: http://llvm.org/viewvc/llvm-project?rev=307016&view=rev
Log:
[index] Remove 'implicit' role for message sends in implicit ObjC
property references
rdar://32375673
Modified:
cfe/trunk/lib/Index/IndexBody.cpp
cfe/tru
Author: arphaman
Date: Tue Jul 4 05:50:53 2017
New Revision: 307074
URL: http://llvm.org/viewvc/llvm-project?rev=307074&view=rev
Log:
[index] Index nested name qualifiers in a forward declaration of a
class template specialization
rdar://33122110
Modified:
cfe/trunk/lib/Index/IndexDecl.cpp
Author: arphaman
Date: Fri Jul 7 02:15:29 2017
New Revision: 307368
URL: http://llvm.org/viewvc/llvm-project?rev=307368&view=rev
Log:
[ObjC] Avoid the -Wunguarded-availability warnings for protocol
requirements in protocol/class/category declarations
The unguarded availability warnings in the pr
Author: arphaman
Date: Fri Jul 7 03:25:12 2017
New Revision: 307384
URL: http://llvm.org/viewvc/llvm-project?rev=307384&view=rev
Log:
[Frontend] Verify that the bitstream is not empty before reading
the serialised diagnostics
Clang should avoid calling report_fatal_error when the file with the s
Author: arphaman
Date: Fri Jul 7 03:41:19 2017
New Revision: 307388
URL: http://llvm.org/viewvc/llvm-project?rev=307388&view=rev
Log:
Recommit [driver][macOS] Pick the system version for the
deployment target if the SDK is newer than the system
This commit reverts the revert commit r305891. Now
Author: arphaman
Date: Tue Jul 11 02:39:23 2017
New Revision: 307638
URL: http://llvm.org/viewvc/llvm-project?rev=307638&view=rev
Log:
RecursiveASTVisitor should visit the nested name qualifiers in
a template specialisation
rdar://33123354
Differential Revision: https://reviews.llvm.org/D34981
Author: arphaman
Date: Tue Jul 11 03:18:35 2017
New Revision: 307642
URL: http://llvm.org/viewvc/llvm-project?rev=307642&view=rev
Log:
[ObjC] Check that a subscript methods is declared for a qualified id type
Objective-C subscript expressions report errors when a subscript method is not
declared
Author: arphaman
Date: Wed Jul 12 04:31:37 2017
New Revision: 307769
URL: http://llvm.org/viewvc/llvm-project?rev=307769&view=rev
Log:
[libclang] Support for querying whether an enum is scoped
This commit allows checking whether an enum declaration is scoped
through libclang and clang.cindex (Pyt
Author: arphaman
Date: Wed Jul 12 04:34:14 2017
New Revision: 307770
URL: http://llvm.org/viewvc/llvm-project?rev=307770&view=rev
Log:
Revert r307769 (Forgot to mention the name of the contributor).
Modified:
cfe/trunk/bindings/python/clang/cindex.py
cfe/trunk/bindings/python/tests/cindex
Author: arphaman
Date: Wed Jul 12 04:35:11 2017
New Revision: 307771
URL: http://llvm.org/viewvc/llvm-project?rev=307771&view=rev
Log:
[libclang] Support for querying whether an enum is scoped
This commit allows checking whether an enum declaration is scoped
through libclang and clang.cindex (Pyt
Author: arphaman
Date: Wed Jul 12 09:41:49 2017
New Revision: 307813
URL: http://llvm.org/viewvc/llvm-project?rev=307813&view=rev
Log:
[diagtool] Add a 'find-diagnostic-id' subcommand that converts a name of
the diagnostic to its enum value
This will be used by a script that invokes clang in a de
Author: arphaman
Date: Thu Jul 13 03:36:33 2017
New Revision: 307898
URL: http://llvm.org/viewvc/llvm-project?rev=307898&view=rev
Log:
[refactor][rename] Use a single base class for class that finds
a declaration at location and for class that searches for all occurrences of
a specific declaration
Author: arphaman
Date: Thu Jul 13 03:50:21 2017
New Revision: 307901
URL: http://llvm.org/viewvc/llvm-project?rev=307901&view=rev
Log:
[index] Objective-C method declarations and message sends with
an empty first selector piece should store the location of the first ':'
rdar://33188656
Modified:
Author: arphaman
Date: Thu Jul 13 04:06:22 2017
New Revision: 307903
URL: http://llvm.org/viewvc/llvm-project?rev=307903&view=rev
Log:
[ObjC] Pick a 'readwrite' property when synthesizing ambiguous
property and check for incompatible attributes
This commit changes the way ambiguous property synth
Author: arphaman
Date: Thu Jul 13 04:27:12 2017
New Revision: 307905
URL: http://llvm.org/viewvc/llvm-project?rev=307905&view=rev
Log:
Remove 'using namespace llvm' from the USRFinder.h header
This should fix the modules build
(http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules
Author: arphaman
Date: Thu Jul 13 05:49:22 2017
New Revision: 307908
URL: http://llvm.org/viewvc/llvm-project?rev=307908&view=rev
Log:
Remove another 'using namespace llvm' from the
RecursiveSymbolVisitor.h header
This should fix the modules build
(http://lab.llvm.org:8011/builders/clang-x86_64-l
Author: arphaman
Date: Thu Jul 13 09:35:59 2017
New Revision: 307923
URL: http://llvm.org/viewvc/llvm-project?rev=307923&view=rev
Log:
NFC, Cleanup the code for -Wdeprecated-implementations
and void capitalization of the warning message
rdar://22867595
Modified:
cfe/trunk/include/clang/Basic
Author: arphaman
Date: Thu Jul 13 09:37:11 2017
New Revision: 307924
URL: http://llvm.org/viewvc/llvm-project?rev=307924&view=rev
Log:
Extend -Wdeprecated-implementations to warn about unavailable methods
rdar://22867595
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/
Author: arphaman
Date: Tue Jul 18 10:23:51 2017
New Revision: 308327
URL: http://llvm.org/viewvc/llvm-project?rev=308327&view=rev
Log:
Add a warning for missing '#pragma pack (pop)' and suspicious uses
of '#pragma pack' in included files
This commit adds a new -Wpragma-pack warning. It warns in t
Author: arphaman
Date: Tue Jul 18 10:36:42 2017
New Revision: 308328
URL: http://llvm.org/viewvc/llvm-project?rev=308328&view=rev
Log:
Revert r308327
I forgot to test clang-tools-extra which is now failing.
Removed:
cfe/trunk/test/PCH/suspicious-pragma-pack.c
cfe/trunk/test/Sema/Inputs/p
Author: arphaman
Date: Wed Jul 19 04:30:41 2017
New Revision: 308441
URL: http://llvm.org/viewvc/llvm-project?rev=308441&view=rev
Log:
Recommit r308327: Add a warning for missing '#pragma pack (pop)'
and suspicious uses of '#pragma pack' in included files
This commit adds a new -Wpragma-pack warn
Author: arphaman
Date: Fri Jul 21 05:49:28 2017
New Revision: 308731
URL: http://llvm.org/viewvc/llvm-project?rev=308731&view=rev
Log:
[clang-diff] Add initial implementation
This is the first commit for the "Clang-based C/C++ diff tool" GSoC project.
ASTDiff is a new library that computes a str
Author: arphaman
Date: Fri Jul 21 05:57:40 2017
New Revision: 308733
URL: http://llvm.org/viewvc/llvm-project?rev=308733&view=rev
Log:
Fix tuple construction compiler error from r308731
Modified:
cfe/trunk/lib/Tooling/ASTDiff/ASTDiff.cpp
Modified: cfe/trunk/lib/Tooling/ASTDiff/ASTDiff.cpp
UR
Author: arphaman
Date: Fri Jul 21 06:04:57 2017
New Revision: 308734
URL: http://llvm.org/viewvc/llvm-project?rev=308734&view=rev
Log:
Fix another compiler error from r308731
std::pair in emplace back couldn't be constructed because SNodeId has an
explicit constructor. Not sure how this even comp
Author: arphaman
Date: Fri Jul 21 06:12:01 2017
New Revision: 308735
URL: http://llvm.org/viewvc/llvm-project?rev=308735&view=rev
Log:
Clang's tests should depend on clang-diff
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-p
Author: arphaman
Date: Fri Jul 21 06:18:51 2017
New Revision: 308737
URL: http://llvm.org/viewvc/llvm-project?rev=308737&view=rev
Log:
[clang-diff] Get rid of unused variable warnings in ASTDiff.cpp
Modified:
cfe/trunk/lib/Tooling/ASTDiff/ASTDiff.cpp
Modified: cfe/trunk/lib/Tooling/ASTDiff/A
Author: arphaman
Date: Wed Jul 26 05:20:57 2017
New Revision: 309106
URL: http://llvm.org/viewvc/llvm-project?rev=309106&view=rev
Log:
Recommit r308327 2nd time: Add a warning for missing
'#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files
The first recommit (r308441) cau
Author: arphaman
Date: Wed Jul 26 06:58:02 2017
New Revision: 309116
URL: http://llvm.org/viewvc/llvm-project?rev=309116&view=rev
Log:
unguarded availability: add a fixit for the "annotate '...'
with an availability attribute to silence" note
rdar://33539233
Differential Revision: https://review
Author: arphaman
Date: Wed Jan 31 13:59:02 2018
New Revision: 323921
URL: http://llvm.org/viewvc/llvm-project?rev=323921&view=rev
Log:
[PR32482] Fix bitfield layout for -mms-bitfield and pragma pack
The patch ensures that a new storage unit is created when the new bitfield's
size is wider than th
Author: arphaman
Date: Mon Feb 13 17:19:40 2017
New Revision: 295001
URL: http://llvm.org/viewvc/llvm-project?rev=295001&view=rev
Log:
[CodeCompletion] Code complete the missing C++11 keywords
This commit adds context sensitive code completion support for the C++11
keywords that currently don't h
Author: arphaman
Date: Mon Feb 13 17:35:59 2017
New Revision: 295003
URL: http://llvm.org/viewvc/llvm-project?rev=295003&view=rev
Log:
[CodeCompletion] Code complete the '__auto_type' keyword
rdar://29219185
Added:
cfe/trunk/test/CodeCompletion/auto_type.c
Modified:
cfe/trunk/lib/Sema/Se
Author: arphaman
Date: Wed Feb 15 17:24:15 2017
New Revision: 295256
URL: http://llvm.org/viewvc/llvm-project?rev=295256&view=rev
Log:
[Docs] Add missing space to an option doc
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
URL:
http:
Author: arphaman
Date: Thu Feb 16 17:15:36 2017
New Revision: 295381
URL: http://llvm.org/viewvc/llvm-project?rev=295381&view=rev
Log:
Use correct fix-it location for -Wblock-capture-autoreleasing
The '__autoreleasing' keyword should be inserted after the Objective-C pointer
type.
rdar://3012354
Author: arphaman
Date: Fri Feb 17 12:11:08 2017
New Revision: 295471
URL: http://llvm.org/viewvc/llvm-project?rev=295471&view=rev
Log:
[Docs] 'Limitations' should be a subsection
The 'Limitations' section in thedocumentation for
readability-misleading-indentation should be a subsection, as otherw
Author: arphaman
Date: Mon Feb 20 11:55:15 2017
New Revision: 295674
URL: http://llvm.org/viewvc/llvm-project?rev=295674&view=rev
Log:
[Sema][ObjC] perform-selector ARC check should see @selector in parens
Modified:
cfe/trunk/lib/Sema/SemaExprObjC.cpp
cfe/trunk/test/SemaObjC/arc-peformsel
Author: arphaman
Date: Wed Feb 22 17:18:49 2017
New Revision: 295903
URL: http://llvm.org/viewvc/llvm-project?rev=295903&view=rev
Log:
[ObjC][Modules] Don't perform property lookup in hidden class extensions
rdar://30603803
Modified:
cfe/trunk/lib/AST/DeclObjC.cpp
cfe/trunk/test/Modules/
Author: arphaman
Date: Thu Feb 23 17:41:50 2017
New Revision: 296040
URL: http://llvm.org/viewvc/llvm-project?rev=296040&view=rev
Log:
NFC, Add a test that ensure that we don't emit helper code in copy/dispose
routines for variables that are const-captured
This is a preparation commit that improv
Author: arphaman
Date: Thu Feb 23 18:09:30 2017
New Revision: 296048
URL: http://llvm.org/viewvc/llvm-project?rev=296048&view=rev
Log:
NFC, Add a test that ensures that we don't emit helper code in copy/dispose
routines for objects that are captured with the __unsafe_unretained
ownership qualifier
Author: arphaman
Date: Thu Feb 23 18:21:20 2017
New Revision: 296054
URL: http://llvm.org/viewvc/llvm-project?rev=296054&view=rev
Log:
NFC, Remove commented out block of code from CGBlocks.cpp
This is a preparation clean-up commit around the code that emits
block copy/dispose routines.
Modified:
Author: arphaman
Date: Fri Feb 24 11:45:16 2017
New Revision: 296140
URL: http://llvm.org/viewvc/llvm-project?rev=296140&view=rev
Log:
[Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma
in macro argument pre-expansion mode when skipping a function body
This commit fixes a
Author: arphaman
Date: Wed Mar 1 12:06:25 2017
New Revision: 296649
URL: http://llvm.org/viewvc/llvm-project?rev=296649&view=rev
Log:
Introduce an 'external_source_symbol' attribute that describes the origin
and the nature of a declaration
This commit adds an external_source_symbol attribute to
Author: arphaman
Date: Mon Mar 6 09:58:34 2017
New Revision: 297019
URL: http://llvm.org/viewvc/llvm-project?rev=297019&view=rev
Log:
[Sema][ObjC] Warn about 'performSelector' calls with selectors
that return record or vector types
The performSelector family of methods from Foundation use objc_m
Author: arphaman
Date: Mon Mar 6 10:23:04 2017
New Revision: 297023
URL: http://llvm.org/viewvc/llvm-project?rev=297023&view=rev
Log:
[CodeGen][Blocks] Refactor capture handling in code that generates
block copy/destroy routines
This is a preparation commit for work on merging unique block copy/
Author: arphaman
Date: Mon Mar 6 10:37:06 2017
New Revision: 297027
URL: http://llvm.org/viewvc/llvm-project?rev=297027&view=rev
Log:
[Docs] Add missing quotes to the language literal in the
external_source_symbol attribute docs
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified:
Author: arphaman
Date: Fri Mar 10 09:04:58 2017
New Revision: 297465
URL: http://llvm.org/viewvc/llvm-project?rev=297465&view=rev
Log:
Print nested name specifiers for typedefs and type aliases
Printing typedefs or type aliases using clang_getTypeSpelling() is missing the
namespace they are defin
Author: arphaman
Date: Mon Mar 13 06:17:41 2017
New Revision: 297614
URL: http://llvm.org/viewvc/llvm-project?rev=297614&view=rev
Log:
Add -iframeworkwithsysroot compiler option
This commit adds support for a new -iframeworkwithsysroot compiler option which
allows the user to specify a framework
Author: arphaman
Date: Mon Mar 13 10:43:42 2017
New Revision: 297628
URL: http://llvm.org/viewvc/llvm-project?rev=297628&view=rev
Log:
[CodeCompletion] Format block parameter placeholders in implicit property
setters using the block type information that's obtained from the property
rdar://126042
arphaman created this revision.
arphaman added reviewers: manmanren, mehdi_amini.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes an infinite loop that occurs when clang tries to iterate over
redeclaration of a method that was d
arphaman created this revision.
arphaman added reviewers: rnk, rsmith.
arphaman added subscribers: cfe-commits, lhames.
arphaman set the repository for this revision to rL LLVM.
This patch avoids the -Wshadow warning for parameters that shadow fields of
their enclosing record and that are defined
arphaman updated this revision to Diff 78004.
arphaman added a comment.
The updated patch fixes a copy-pasted comment.
Repository:
rL LLVM
https://reviews.llvm.org/D26672
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
arphaman updated this revision to Diff 78005.
arphaman added a comment.
Fixed an existing comment that now became partially invalid.
Repository:
rL LLVM
https://reviews.llvm.org/D26672
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/cla
arphaman added inline comments.
Comment at: lib/AST/DeclObjC.cpp:841
+return nullptr;
+ if (const auto *Ctx = cast(Redecl->getDeclContext()))
+if (Ctx->isInvalidDecl())
mehdi_amini wrote:
> Either you should use `dyn_cast`, or you should just `cast` but
arphaman added inline comments.
Comment at: lib/AST/DeclObjC.cpp:841
+return nullptr;
+ if (const auto *Ctx = cast(Redecl->getDeclContext()))
+if (Ctx->isInvalidDecl())
erik.pilkington wrote:
> arphaman wrote:
> > mehdi_amini wrote:
> > > Either you shou
arphaman updated this revision to Diff 78218.
arphaman marked 4 inline comments as done.
arphaman added a comment.
Addressed review comments by renaming the diagnostic and simplifying the name
and the use of the `expectIdentifier ` method.
Repository:
rL LLVM
https://reviews.llvm.org/D26503
arphaman added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:5405
+ // Objective-C++: Detect C++ keywords and try to prevent further errors
by
+ // treating these keyword as valid member names.
+ if (getLangOpts().ObjC1 && getLangOpts().CPlusPlus &&
---
arphaman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10304
CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
+ Expr *SE = nullptr;
+
NIT, but I think you don't need the extra variable and the `if (SE)` below if
you extract the co
arphaman added a comment.
Is it possible to add a test for this change? Maybe you could dump the AST and
check if the range is the one that you would expect (See
test/Misc/ast-dump-decl.cpp for an example).
https://reviews.llvm.org/D26849
___
cfe-
arphaman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10270
+static void setSrcAlign(Expr *SE, CharUnits &SrcAlign, ASTContext &Context) {
+ if (const auto *DRE = dyn_cast(SE))
I'm not sure if you can, since I don't really know `CharUnits`, but
Author: arphaman
Date: Mon Nov 21 05:05:15 2016
New Revision: 287529
URL: http://llvm.org/viewvc/llvm-project?rev=287529&view=rev
Log:
[Frontend] Add a predefined macro that describes the Objective-C bool type
This commit adds a new predefined macro named __OBJC_BOOL_IS_BOOL that describes
the Ob
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287529: [Frontend] Add a predefined macro that describes the
Objective-C bool type (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26234?vs=76680&id=78698#toc
Repository:
r
Author: arphaman
Date: Mon Nov 21 05:16:30 2016
New Revision: 287530
URL: http://llvm.org/viewvc/llvm-project?rev=287530&view=rev
Log:
[ObjC] Prevent infinite loops when iterating over redeclaration
of a method that was declared in an invalid interface
This commit fixes an infinite loop that occu
This revision was automatically updated to reflect the committed changes.
arphaman marked 6 inline comments as done.
Closed by commit rL287530: [ObjC] Prevent infinite loops when iterating over
redeclaration (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26664?vs=779
arphaman added a comment.
I managed to get rid of the extra function and simplify the check thanks to
suggestions from Erik.
Repository:
rL LLVM
https://reviews.llvm.org/D26664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
arphaman created this revision.
arphaman added reviewers: manmanren, bruno.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that the typo fixit for the `@try/@finally/@autoreleasepool
{ }` directive is shown only when we're pa
arphaman created this revision.
arphaman added reviewers: manmanren, ahatanak.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that Sema won't enter a C++ declarator context when the
current context is an Objective-C declarati
arphaman created this revision.
arphaman added reviewers: rsmith, mehdi_amini.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch handles more declarations in DeclContextPrinter to avoid crashes
when clang is given the `-print-decl-conte
arphaman created this revision.
arphaman added reviewers: rsmith, manmanren.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch teaches clang that it has to emit a warning when NULL is passed as
the 'expected' pointer parameter into an a
arphaman created this revision.
arphaman added reviewers: manmanren, akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that clang provides NS_DESIGNATED_INITIALIZER code
completion result for an initializer method with
Author: arphaman
Date: Wed Nov 23 10:28:34 2016
New Revision: 287771
URL: http://llvm.org/viewvc/llvm-project?rev=287771&view=rev
Log:
[CodeCompletion] Fix incorrect Objective-C block parameter formatting
This commit fixes an incorrectly formatted Objective-C block parameter
placeholder in a code
arphaman created this revision.
arphaman added reviewers: manmanren, akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch provides class property code completion results. It supports
explicit and implicit class properties, but the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287776: [Sema][Atomics] Treat expected pointer in compare
exchange atomics as _Nonnull (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26978?vs=78884&id=79107#toc
Repository:
Author: arphaman
Date: Wed Nov 23 10:57:03 2016
New Revision: 287776
URL: http://llvm.org/viewvc/llvm-project?rev=287776&view=rev
Log:
[Sema][Atomics] Treat expected pointer in compare exchange atomics as _Nonnull
This commit teaches clang that is has to emit a warning when NULL is passed
as the
Author: arphaman
Date: Thu Dec 1 06:14:38 2016
New Revision: 288334
URL: http://llvm.org/viewvc/llvm-project?rev=288334&view=rev
Log:
[ObjC] Avoid a @try/@finally/@autoreleasepool fixit when parsing an expression
This patch ensures that the typo fixit for the @try/@finally/@autoreleasepool {}
di
Author: arphaman
Date: Fri Dec 2 03:51:51 2016
New Revision: 288491
URL: http://llvm.org/viewvc/llvm-project?rev=288491&view=rev
Log:
[Frontend] Fix an issue where a quoted search path is incorrectly
removed as a duplicate header search path
The commit r126167 started passing the First index int
Author: arphaman
Date: Wed Dec 7 04:24:44 2016
New Revision: 288893
URL: http://llvm.org/viewvc/llvm-project?rev=288893&view=rev
Log:
[ObjC++] Don't enter a C++ declarator scope when the current context is
an Objective-C declaration
This commit ensures that Sema won't enter a C++ declarator scop
Author: arphaman
Date: Wed Dec 7 04:52:18 2016
New Revision: 288896
URL: http://llvm.org/viewvc/llvm-project?rev=288896&view=rev
Log:
Implement the -Wstrict-prototypes warning
This commit fixes PR20796. It implements the C only -Wstrict-prototypes warning.
Clang now emits a warning for function
Author: arphaman
Date: Thu Dec 8 08:46:05 2016
New Revision: 289055
URL: http://llvm.org/viewvc/llvm-project?rev=289055&view=rev
Log:
[Sema] Avoid "case value not in enumerated type" warning for C++11 opaque enums
This commit ensures that the switch warning "case value not in enumerated type"
is
Author: arphaman
Date: Thu Dec 8 09:09:40 2016
New Revision: 289058
URL: http://llvm.org/viewvc/llvm-project?rev=289058&view=rev
Log:
[CodeCompletion] Provide Objective-C class property completion results
This commit provides class property code completion results. It supports
explicit and impli
Author: arphaman
Date: Thu Dec 8 10:49:05 2016
New Revision: 289068
URL: http://llvm.org/viewvc/llvm-project?rev=289068&view=rev
Log:
[CodeCompletion][ObjC] Use a parameterized NSSet return type for
keyPathsForValuesAffecting* KVO completion results
rdar://23791701
Modified:
cfe/trunk/lib/S
Author: arphaman
Date: Wed Apr 19 10:52:11 2017
New Revision: 300712
URL: http://llvm.org/viewvc/llvm-project?rev=300712&view=rev
Log:
Add #pragma clang attribute support to the external_source_symbol attribute
Prior to this commit the external_source_symbol attribute wasn't supported by
#pragma
Author: arphaman
Date: Thu Apr 20 04:35:02 2017
New Revision: 300826
URL: http://llvm.org/viewvc/llvm-project?rev=300826&view=rev
Log:
Add #pragma clang attribute support to the availability attribute
rdar://31707804
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/lib/Sema/Sema
Author: arphaman
Date: Thu Apr 20 05:43:22 2017
New Revision: 300832
URL: http://llvm.org/viewvc/llvm-project?rev=300832&view=rev
Log:
[index] Record class template specializations using a new 'SpecializationOf'
relationship
rdar://31603531
Differential Revision: https://reviews.llvm.org/D32010
401 - 500 of 638 matches
Mail list logo
