Author: arphaman
Date: Tue Sep 12 05:48:37 2017
New Revision: 313025
URL: http://llvm.org/viewvc/llvm-project?rev=313025&view=rev
Log:
[refactor] add a refactoring action rule that returns symbol occurrences
Differential Revision: https://reviews.llvm.org/D36574
Modified:
cfe/trunk/include/c
Author: arphaman
Date: Tue Sep 12 06:03:42 2017
New Revision: 313027
URL: http://llvm.org/viewvc/llvm-project?rev=313027&view=rev
Log:
Fix GCC build error and warnings from r313025
Modified:
cfe/trunk/unittests/Tooling/RefactoringActionRulesTest.cpp
Modified: cfe/trunk/unittests/Tooling/Refa
Author: arphaman
Date: Thu Sep 14 03:06:52 2017
New Revision: 313244
URL: http://llvm.org/viewvc/llvm-project?rev=313244&view=rev
Log:
[refactor] add clang-refactor tool with initial testing support and
local-rename action
This commit introduces the clang-refactor tool alongside the local-rename
Author: arphaman
Date: Thu Sep 14 03:38:04 2017
New Revision: 313249
URL: http://llvm.org/viewvc/llvm-project?rev=313249&view=rev
Log:
Link clang-refactor with clangAST and clangLex
This is an attempt to fix http://bb.pgr.jp/builders/clang-i686-linux-RA/ after
r313244.
Modified:
cfe/trunk/to
Author: arphaman
Date: Thu Sep 14 03:46:29 2017
New Revision: 313252
URL: http://llvm.org/viewvc/llvm-project?rev=313252&view=rev
Log:
Link clang-refactor with clangFormat
This is an attempt to fix
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage after r313244.
Modified:
cfe/
Author: arphaman
Date: Thu Sep 14 06:16:14 2017
New Revision: 313260
URL: http://llvm.org/viewvc/llvm-project?rev=313260&view=rev
Log:
[refactor] Use CommonOptionsParser in clang-refactor
This commit ensures that CommonOptionsParser works with subcommands. This allows
clang-refactor to use the Co
Author: arphaman
Date: Thu Sep 14 08:10:39 2017
New Revision: 313266
URL: http://llvm.org/viewvc/llvm-project?rev=313266&view=rev
Log:
Fix Refactor/tool-test-support.c test on Windows by avoiding
the STDERR redirect
Modified:
cfe/trunk/test/Refactor/tool-test-support.c
Modified: cfe/trunk/te
Author: arphaman
Date: Mon Jun 3 15:59:17 2019
New Revision: 362459
URL: http://llvm.org/viewvc/llvm-project?rev=362459&view=rev
Log:
Add clang source minimizer that reduces source to directives
that might affect the dependency list for a compilation
This commit introduces a dependency directive
Author: arphaman
Date: Mon Jun 3 16:17:21 2019
New Revision: 362463
URL: http://llvm.org/viewvc/llvm-project?rev=362463&view=rev
Log:
Fix windows build for commit r362459
Modified:
cfe/trunk/lib/Lex/DependencyDirectivesSourceMinimizer.cpp
Modified: cfe/trunk/lib/Lex/DependencyDirectivesSour
Author: arphaman
Date: Mon Jun 10 16:32:42 2019
New Revision: 363009
URL: http://llvm.org/viewvc/llvm-project?rev=363009&view=rev
Log:
[Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer
in the compiler
The function SetUpDiagnosticLog that was called from createDiagnostics did
Author: arphaman
Date: Wed Jun 12 13:35:44 2019
New Revision: 363199
URL: http://llvm.org/viewvc/llvm-project?rev=363199&view=rev
Log:
[test] Reinstate the assignment to the diagnostic log in the unittest
from r363009
The diagnostic log is now set to "-" which forces it to use STDERR
instead of t
Author: arphaman
Date: Wed Jun 12 14:32:49 2019
New Revision: 363204
URL: http://llvm.org/viewvc/llvm-project?rev=363204&view=rev
Log:
[clang-scan-deps] initial outline of the tool that runs preprocessor to find
dependencies over a JSON compilation database
This commit introduces an outline for t
Author: arphaman
Date: Wed Jun 12 14:37:32 2019
New Revision: 363205
URL: http://llvm.org/viewvc/llvm-project?rev=363205&view=rev
Log:
NFC, fixup indentation in CMakeLists.txt from r363204 as requested
in the review.
I missed that review comment from https://reviews.llvm.org/D60233 in the
origin
Author: arphaman
Date: Wed Jun 12 14:45:28 2019
New Revision: 363207
URL: http://llvm.org/viewvc/llvm-project?rev=363207&view=rev
Log:
NFC, Update the ClangScanDeps.cpp file's license comment
The file ClangScanDeps.cpp from r363204 had the old outdated LLVM
license comment at the top of the file
Author: arphaman
Date: Wed Jun 12 14:52:36 2019
New Revision: 363208
URL: http://llvm.org/viewvc/llvm-project?rev=363208&view=rev
Log:
[clang-scan-deps] Include in ClangScanDeps.cpp to ensure it
builds on all platforms
Modified:
cfe/trunk/tools/clang-scan-deps/ClangScanDeps.cpp
Modified: cf
Author: arphaman
Date: Tue Jun 18 14:36:30 2019
New Revision: 363742
URL: http://llvm.org/viewvc/llvm-project?rev=363742&view=rev
Log:
[test] NFC, udpate clang-scan-deps tests to not use -c to avoid driver issues
when no integrated assembler is present
Caught by Douglas Yung.
Modified:
cfe/
Author: arphaman
Date: Wed Jun 19 10:07:36 2019
New Revision: 363840
URL: http://llvm.org/viewvc/llvm-project?rev=363840&view=rev
Log:
Unify DependencyFileGenerator class and DependencyCollector interface (NFCI)
Make DependencyFileGenerator a DependencyCollector as it was intended when
Dependency
Author: arphaman
Date: Fri Jul 12 15:29:44 2019
New Revision: 365969
URL: http://llvm.org/viewvc/llvm-project?rev=365969&view=rev
Log:
NFC: utils/perf-training: Python 3 compatibility for lit.cfg
The output of subprocess.check_output is now bytes. We need to decode it.
Modified:
cfe/trunk/ut
Author: arphaman
Date: Thu Jul 18 15:33:14 2019
New Revision: 366509
URL: http://llvm.org/viewvc/llvm-project?rev=366509&view=rev
Log:
[clang-scan-deps] Dependency directives source minimizer: handle #pragma once
We should re-emit `#pragma once` to ensure the preprocessor will
still honor it when
Author: arphaman
Date: Tue Jul 30 17:12:00 2019
New Revision: 367371
URL: http://llvm.org/viewvc/llvm-project?rev=367371&view=rev
Log:
NFCI, optimize layout of FileEntry
The reordering of the UID field makes the size of a
FileEntry 8 bytes smaller on 64bit platforms.
Modified:
cfe/trunk/incl
Author: arphaman
Date: Tue Aug 6 13:43:25 2019
New Revision: 368086
URL: http://llvm.org/viewvc/llvm-project?rev=368086&view=rev
Log:
[clang-scan-deps] Implementation of dependency scanner over minimized sources
This commit implements the fast dependency scanning mode in clang-scan-deps: the
pre
Author: arphaman
Date: Tue Aug 6 14:45:43 2019
New Revision: 368092
URL: http://llvm.org/viewvc/llvm-project?rev=368092&view=rev
Log:
fix clang-scan-deps test to match filepaths on Windows
Modified:
cfe/trunk/test/ClangScanDeps/header_stat_before_open.m
Modified: cfe/trunk/test/ClangScanDep
Author: arphaman
Date: Mon Aug 12 17:36:35 2019
New Revision: 368640
URL: http://llvm.org/viewvc/llvm-project?rev=368640&view=rev
Log:
clang-scan-deps: do not spawn threads when LLVM_ENABLE_THREADS is disabled
Modified:
cfe/trunk/test/ClangScanDeps/regular_cdb.cpp
cfe/trunk/tools/clang-sc
Author: arphaman
Date: Fri Jun 21 11:24:55 2019
New Revision: 364088
URL: http://llvm.org/viewvc/llvm-project?rev=364088&view=rev
Log:
[clang-scan-deps] print the dependencies to stdout
and remove the need to use -MD options in the CDB
Differential Revision: https://reviews.llvm.org/D63579
Modif
Author: arphaman
Date: Wed Jun 26 14:11:51 2019
New Revision: 364474
URL: http://llvm.org/viewvc/llvm-project?rev=364474&view=rev
Log:
[clang-scan-deps] Introduce the DependencyScanning library with the
thread worker code and better error handling
This commit extracts out the code that will power
Author: arphaman
Date: Wed Jul 3 11:01:32 2019
New Revision: 365065
URL: http://llvm.org/viewvc/llvm-project?rev=365065&view=rev
Log:
[clang-scan-deps] use `-Wno-error` when scanning for dependencies
Warnings can be promoted to errors.
But that shouldn't prevent us from getting the dependencies!
Author: arphaman
Date: Wed Jul 10 15:00:59 2019
New Revision: 365700
URL: http://llvm.org/viewvc/llvm-project?rev=365700&view=rev
Log:
[clang-scan-deps] Dependency directives source minimizer:
single quotes are not digit separators after a valid character literal prefix
The single quote character
Author: arphaman
Date: Mon Dec 17 11:19:15 2018
New Revision: 349380
URL: http://llvm.org/viewvc/llvm-project?rev=349380&view=rev
Log:
[darwin] parse the SDK settings from SDKSettings.json if it exists and
pass in the -target-sdk-version to the compiler and backend
This commit adds support for re
Author: arphaman
Date: Mon Dec 17 11:30:46 2018
New Revision: 349382
URL: http://llvm.org/viewvc/llvm-project?rev=349382&view=rev
Log:
[darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch`
is not specified
The -target option allows the user to specify the build target using LLVM
trip
Author: arphaman
Date: Mon Dec 17 12:25:41 2018
New Revision: 349388
URL: http://llvm.org/viewvc/llvm-project?rev=349388&view=rev
Log:
Fix build after r349380
Modified:
cfe/trunk/include/clang/Basic/TargetOptions.h
Modified: cfe/trunk/include/clang/Basic/TargetOptions.h
URL:
http://llvm.org
Author: arphaman
Date: Mon Dec 17 13:01:04 2018
New Revision: 349393
URL: http://llvm.org/viewvc/llvm-project?rev=349393&view=rev
Log:
Make test/Driver/darwin-sdk-version.c pass on hosts < macOS10.14
The test test/Driver/darwin-sdk-version.c from r349380 checks if the macOS
deployment target can
Author: arphaman
Date: Thu Dec 20 14:11:11 2018
New Revision: 349841
URL: http://llvm.org/viewvc/llvm-project?rev=349841&view=rev
Log:
[ObjC] Messages to 'self' in class methods that return 'instancetype' should
use the pointer to the class as the result type of the message
Prior to this commit,
Author: arphaman
Date: Fri Dec 21 11:33:09 2018
New Revision: 349942
URL: http://llvm.org/viewvc/llvm-project?rev=349942&view=rev
Log:
Remove stat cache chaining as it's no longer needed after PTH support has been
removed
Stat cache chaining was implemented for a StatListener in the PTH writer so
Author: arphaman
Date: Wed Jan 2 17:13:33 2019
New Revision: 350282
URL: http://llvm.org/viewvc/llvm-project?rev=350282&view=rev
Log:
[libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs
This change ensures that the libclang CXCursor represents the CoroutineBody
and the
Author: arphaman
Date: Wed Jan 2 17:30:50 2019
New Revision: 350283
URL: http://llvm.org/viewvc/llvm-project?rev=350283&view=rev
Log:
Fix incorrect column numbers in test from r350282.
After the test was reformatted using clang-format the numbers became invalid.
Modified:
cfe/trunk/test/Ind
Author: arphaman
Date: Tue Jan 8 14:32:51 2019
New Revision: 350666
URL: http://llvm.org/viewvc/llvm-project?rev=350666&view=rev
Log:
[libclang] Recommit r336590 with a fix for the memory leak in the test
The original commit had a memory leak in the test has a leak as it doesn't
dispose of the e
Author: arphaman
Date: Tue Jan 8 15:28:37 2019
New Revision: 350680
URL: http://llvm.org/viewvc/llvm-project?rev=350680&view=rev
Log:
[libclang] Fix the mismatched delete operator for ExprEvalResult
The '.stringVal' field in ExprEvalResult is allocated using new[],
but was freed using a regular
Author: arphaman
Date: Wed Jan 9 14:31:37 2019
New Revision: 350768
URL: http://llvm.org/viewvc/llvm-project?rev=350768&view=rev
Log:
[ObjC] Allow the use of implemented unavailable methods from within
the @implementation context
In Objective-C, it's common for some frameworks to mark some metho
Author: arphaman
Date: Wed Sep 11 13:40:31 2019
New Revision: 371656
URL: http://llvm.org/viewvc/llvm-project?rev=371656&view=rev
Log:
[clang-scan-deps] add skip excluded conditional preprocessor block
preprocessing optimization
This commit adds an optimization to clang-scan-deps and clang's pre
Author: arphaman
Date: Wed Sep 11 14:00:13 2019
New Revision: 371664
URL: http://llvm.org/viewvc/llvm-project?rev=371664&view=rev
Log:
[clang-scan-deps] cast Result to ErrorOr> explicitly to
avoid s390x-linux buildbot failure
Modified:
cfe/trunk/lib/Tooling/DependencyScanning/DependencyScann
Author: arphaman
Date: Thu Sep 12 11:03:24 2019
New Revision: 371751
URL: http://llvm.org/viewvc/llvm-project?rev=371751&view=rev
Log:
[clang-scan-deps] remove dots and dots dots from the reported file dependency
paths
This resolves differences observed on LLVM + Clang when running the compariso
Author: arphaman
Date: Thu Sep 12 12:00:32 2019
New Revision: 371759
URL: http://llvm.org/viewvc/llvm-project?rev=371759&view=rev
Log:
NFC, add missing cl::cat option category to clang-scan-deps options to ensure
they show up in -help
Modified:
cfe/trunk/tools/clang-scan-deps/ClangScanDeps.c
Author: arphaman
Date: Fri Sep 13 15:12:02 2019
New Revision: 371903
URL: http://llvm.org/viewvc/llvm-project?rev=371903&view=rev
Log:
[clang-scan-deps] Fix for headers having the same name as a directory
Scan deps tool crashes when called on a C++ file, containing an include
that has the same na
Author: arphaman
Date: Thu Sep 19 15:39:24 2019
New Revision: 372360
URL: http://llvm.org/viewvc/llvm-project?rev=372360&view=rev
Log:
Fix for stringized function-macro args continued across lines
In case of certain #define'd macros, there's a space just before line
continuation
that the minimiz
Author: arphaman
Date: Fri Sep 20 17:17:26 2019
New Revision: 372444
URL: http://llvm.org/viewvc/llvm-project?rev=372444&view=rev
Log:
[clang-scan-deps] strip the --serialize-diagnostics argument
This ensures that clang-scan-deps won't write out diagnostics when
scanning dependencies.
Added:
Author: arphaman
Date: Thu Sep 26 12:28:51 2019
New Revision: 373007
URL: http://llvm.org/viewvc/llvm-project?rev=373007&view=rev
Log:
[clang-scan-deps] Allow continuation line backslashes followed by whitespace
in the dependency source minimizer
Clang allows continuations that have whitespace be
Author: arphaman
Date: Wed Apr 25 15:23:26 2018
New Revision: 330878
URL: http://llvm.org/viewvc/llvm-project?rev=330878&view=rev
Log:
[driver][darwin] Do not infer -simulator environment for OS version env vars
with non-simulator SDKs
rdar://37955008
Modified:
cfe/trunk/lib/Driver/ToolChain
Author: arphaman
Date: Wed May 2 15:40:19 2018
New Revision: 331409
URL: http://llvm.org/viewvc/llvm-project?rev=331409&view=rev
Log:
[ObjC] The absence of ownership qualifiers on an ambiguous property leads
to synthesis of a valid property even when the selected protocol property
has ownership q
Author: arphaman
Date: Wed May 2 18:12:06 2018
New Revision: 331421
URL: http://llvm.org/viewvc/llvm-project?rev=331421&view=rev
Log:
[ObjC] Supress the 'implementing unavailable method' warning when
the method declaration is unavailable for an app extension platform
Rationale:
Classes are often
Author: arphaman
Date: Thu Jun 28 16:23:45 2018
New Revision: 335940
URL: http://llvm.org/viewvc/llvm-project?rev=335940&view=rev
Log:
[frontend] Don't include the C++ stdlib for -x assembler-with-cpp
The new C++ stdlib warning added in r335081 gets
triggered when compiling an assembly file with
Author: arphaman
Date: Thu Jul 5 15:51:11 2018
New Revision: 336396
URL: http://llvm.org/viewvc/llvm-project?rev=336396&view=rev
Log:
[Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin
The '%tu'/'%td' as formatting specifiers have been used to print out the
NSInteger/NSUInt
Author: arphaman
Date: Mon Jul 9 12:41:28 2018
New Revision: 336590
URL: http://llvm.org/viewvc/llvm-project?rev=336590&view=rev
Log:
[libclang] evalute compound statement cursors before trying to evaluate
the cursor like a declaration
This change fixes a bug in libclang in which it tries to eva
Author: arphaman
Date: Mon Jul 9 12:56:45 2018
New Revision: 336591
URL: http://llvm.org/viewvc/llvm-project?rev=336591&view=rev
Log:
[libclang] NFC, simplify clang_Cursor_Evaluate
Take advantage of early returns as suggested by Duncan in
https://reviews.llvm.org/D49051
Modified:
cfe/trunk/
Author: arphaman
Date: Tue Oct 8 15:42:44 2019
New Revision: 374127
URL: http://llvm.org/viewvc/llvm-project?rev=374127&view=rev
Log:
[clang-scan-deps] Improve string/character literal skipping
The existing string/character literal skipping code in the
dependency directives source minimizer has
Author: Alex Lorenz
Date: 2020-07-29T15:32:30-07:00
New Revision: dc22182d1f7489239388f7bdd04170573c0652a3
URL:
https://github.com/llvm/llvm-project/commit/dc22182d1f7489239388f7bdd04170573c0652a3
DIFF:
https://github.com/llvm/llvm-project/commit/dc22182d1f7489239388f7bdd04170573c0652a3.diff
L
Author: Alex Lorenz
Date: 2020-06-05T10:55:42-07:00
New Revision: 5eedf07ab999d0a8ba43f41e0c1012d8f6e62c11
URL:
https://github.com/llvm/llvm-project/commit/5eedf07ab999d0a8ba43f41e0c1012d8f6e62c11
DIFF:
https://github.com/llvm/llvm-project/commit/5eedf07ab999d0a8ba43f41e0c1012d8f6e62c11.diff
L
Author: Alex Lorenz
Date: 2020-06-23T15:14:26-07:00
New Revision: f724ce0d73eb3f85364e346a036588825bc47567
URL:
https://github.com/llvm/llvm-project/commit/f724ce0d73eb3f85364e346a036588825bc47567
DIFF:
https://github.com/llvm/llvm-project/commit/f724ce0d73eb3f85364e346a036588825bc47567.diff
L
Author: Alex Lorenz
Date: 2020-06-23T21:08:11-07:00
New Revision: 565603cc94d79a8d0de6df840fd53714899fb890
URL:
https://github.com/llvm/llvm-project/commit/565603cc94d79a8d0de6df840fd53714899fb890
DIFF:
https://github.com/llvm/llvm-project/commit/565603cc94d79a8d0de6df840fd53714899fb890.diff
L
Author: Alex Lorenz
Date: 2020-06-23T21:17:58-07:00
New Revision: 1a342ff3753d0354bab3d82fa8e493e21d50c79f
URL:
https://github.com/llvm/llvm-project/commit/1a342ff3753d0354bab3d82fa8e493e21d50c79f
DIFF:
https://github.com/llvm/llvm-project/commit/1a342ff3753d0354bab3d82fa8e493e21d50c79f.diff
L
Author: Alex Lorenz
Date: 2020-06-26T17:15:37-07:00
New Revision: 253988f0f400201adb094d0f81d2c0c3fac94f4f
URL:
https://github.com/llvm/llvm-project/commit/253988f0f400201adb094d0f81d2c0c3fac94f4f
DIFF:
https://github.com/llvm/llvm-project/commit/253988f0f400201adb094d0f81d2c0c3fac94f4f.diff
L
Author: Alex Lorenz
Date: 2020-06-26T17:15:37-07:00
New Revision: 2b00cacb2835d11cab6f71466604b7b1bdd46a8d
URL:
https://github.com/llvm/llvm-project/commit/2b00cacb2835d11cab6f71466604b7b1bdd46a8d
DIFF:
https://github.com/llvm/llvm-project/commit/2b00cacb2835d11cab6f71466604b7b1bdd46a8d.diff
L
Author: Alex Lorenz
Date: 2020-06-29T12:21:54-07:00
New Revision: f7a14514ee63dc2ab9558c50254efb8ac2ad7cc6
URL:
https://github.com/llvm/llvm-project/commit/f7a14514ee63dc2ab9558c50254efb8ac2ad7cc6
DIFF:
https://github.com/llvm/llvm-project/commit/f7a14514ee63dc2ab9558c50254efb8ac2ad7cc6.diff
L
Author: Alex Lorenz
Date: 2020-06-29T19:03:57-07:00
New Revision: 6792a6077889f1ce77a3aa55b3e4fd3f1eb4333b
URL:
https://github.com/llvm/llvm-project/commit/6792a6077889f1ce77a3aa55b3e4fd3f1eb4333b
DIFF:
https://github.com/llvm/llvm-project/commit/6792a6077889f1ce77a3aa55b3e4fd3f1eb4333b.diff
L
Author: Alex Lorenz
Date: 2020-06-29T20:13:41-07:00
New Revision: bb162dfe252a1abc15af411d8ba51dda63af306c
URL:
https://github.com/llvm/llvm-project/commit/bb162dfe252a1abc15af411d8ba51dda63af306c
DIFF:
https://github.com/llvm/llvm-project/commit/bb162dfe252a1abc15af411d8ba51dda63af306c.diff
L
Author: Alex Lorenz
Date: 2020-08-13T12:06:45-07:00
New Revision: c2807b2e56c05080354818c221ed4a35abd8a5c8
URL:
https://github.com/llvm/llvm-project/commit/c2807b2e56c05080354818c221ed4a35abd8a5c8
DIFF:
https://github.com/llvm/llvm-project/commit/c2807b2e56c05080354818c221ed4a35abd8a5c8.diff
L
Author: Alex Lorenz
Date: 2020-05-14T10:01:50-07:00
New Revision: 10b49315faa6338eaf52bb782e7c53644ad17dab
URL:
https://github.com/llvm/llvm-project/commit/10b49315faa6338eaf52bb782e7c53644ad17dab
DIFF:
https://github.com/llvm/llvm-project/commit/10b49315faa6338eaf52bb782e7c53644ad17dab.diff
L
Author: Alex Lorenz
Date: 2020-05-14T14:13:34-07:00
New Revision: 11d612ac99a621c762c2cc8f7bacbb8ae32d7fe9
URL:
https://github.com/llvm/llvm-project/commit/11d612ac99a621c762c2cc8f7bacbb8ae32d7fe9
DIFF:
https://github.com/llvm/llvm-project/commit/11d612ac99a621c762c2cc8f7bacbb8ae32d7fe9.diff
L
arphaman added inline comments.
Comment at: clang-refactor/core/SymbolIndexClient.h:31
@@ +30,3 @@
+} // end namespace refactor
+} // end namespace refactor
+
End namespace clang?
https://reviews.llvm.org/D24192
___
arphaman added inline comments.
Comment at: clang-refactor/driver/Driver.cpp:36
@@ +35,3 @@
+argv[1] = (llvm::Twine(argv[0]) + " " +
llvm::Twine(argv[1])).str().c_str();
+Manager.dispatch(Command, argc - 1, argv + 1);
+ } else {
Is there a particular rea
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This fixes PR 30274 by making sure that we skip the 'Using' and
'ConstructorUsingShadowDecl' declarations when evaluating the
'__
arphaman added a comment.
(Forgot to mention) This is a a fix for the regression introduced by r274049.
Repository:
rL LLVM
https://reviews.llvm.org/D24884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
arphaman abandoned this revision.
arphaman added a comment.
I just noticed that PR 30274 is actually a duplicate of PR 29087, which already
has a patch with a fix in review. This patch is now abandoned. Sorry about not
noticing the duplicate earlier.
Repository:
rL LLVM
https://reviews.llvm
arphaman added a subscriber: arphaman.
Comment at: clang-rename/RenamingAction.cpp:75
@@ +74,3 @@
+ // has been matched multiple times (which shouldn't happen in reality,
+ // need to fix that) or when it's a specific header. For now, just ingore
+ // there error th
arphaman created this revision.
arphaman added a reviewer: DmitryPolukhin.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes PR 30440 by initializing CXXNameMangler's FunctionTypeDepth in
the two constructors added in r274222 (The
arphaman created this revision.
arphaman added a reviewer: vsk.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a regression introduced in r262697 that changed the way the
coverage regions for switch are constructed. The PGO ins
Author: arphaman
Date: Tue Sep 27 18:30:36 2016
New Revision: 282554
URL: http://llvm.org/viewvc/llvm-project?rev=282554&view=rev
Log:
[Coverage] The coverage region for switch covers the code after the switch.
This patch fixes a regression introduced in r262697 that changed the way the
coverage
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282554: [Coverage] The coverage region for switch covers the
code after the switch. (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D24981?vs=72692&id=72733#toc
Repository:
arphaman added a comment.
Thanks for working on this, I have a couple of comments/questions:
- The current logic doesn't work correctly for a test case that's shown below:
class C2 {
void __attribute__((unused)) m4() { }
void __attribute__((unused)) m5();
};
The method 'm4' actually
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a bug that's tracked by PR 10758 and duplicates like PR 30343.
The bug causes clang to crash with a stack overflo
arphaman added a comment.
In https://reviews.llvm.org/D25040#556165, @vsk wrote:
> In https://reviews.llvm.org/D25040#556109, @arphaman wrote:
>
> > Thanks for working on this, I have a couple of comments/questions:
> >
> > - The current logic doesn't work correctly for a test case that's shown
arphaman created this revision.
arphaman added reviewers: aaron.ballman, rogfer01.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the packed member warning by showing the name of the
anonymous structure/union when it was def
arphaman removed rL LLVM as the repository for this revision.
arphaman updated this revision to Diff 73076.
arphaman added a comment.
I had to reuploaded the diff as Phabricator seemed to have removed the 'lib'
and 'test' paths prefixes from the filenames in the original diff.
https://reviews.l
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the displayed diagnostics when encountering a redefinition
of a function whose previous definition was typo-co
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that the AST printer outputs the correct C++ type for an
inheriting constructor using declaration.
For example
arphaman added a comment.
In https://reviews.llvm.org/D25131#558004, @rsmith wrote:
> Minor comment, otherwise LGTM.
This makes sense, thanks for pointing it out!
I'll update the comment when I commit.
Repository:
rL LLVM
https://reviews.llvm.org/D25131
_
Author: arphaman
Date: Mon Oct 3 07:12:03 2016
New Revision: 283102
URL: http://llvm.org/viewvc/llvm-project?rev=283102&view=rev
Log:
Fix PR 28885: Fix AST Printer output for the inherited constructor using
declarations.
This commit ensures that the correct record type is printed out for the
usi
Author: arphaman
Date: Mon Oct 3 07:17:56 2016
New Revision: 283104
URL: http://llvm.org/viewvc/llvm-project?rev=283104&view=rev
Log:
Revert r283102 (Typo in the phabricator link)
Modified:
cfe/trunk/lib/AST/DeclPrinter.cpp
cfe/trunk/test/SemaCXX/cxx11-ast-print.cpp
Modified: cfe/trunk/
Author: arphaman
Date: Mon Oct 3 07:22:17 2016
New Revision: 283105
URL: http://llvm.org/viewvc/llvm-project?rev=283105&view=rev
Log:
Fix PR 28885: Fix AST Printer output for the inherited constructor using
declarations.
This commit ensures that the correct record type is printed out for the
usi
arphaman set the repository for this revision to rL LLVM.
arphaman updated this revision to Diff 73338.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Update to the patch that follows Aaron's comments:
- Uses the explicit type name instead of auto.
- Expands the test by addi
arphaman created this revision.
arphaman added reviewers: rsmith, rjmccall.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a crash that happens because of an assertion failure in C mode
only. The assertion failure happens becau
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283102: Fix PR 28885: Fix AST Printer output for the
inherited constructor using (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25131?vs=73145&id=73410#toc
Repository:
rL
arphaman updated this revision to Diff 73460.
arphaman marked an inline comment as done.
arphaman added a comment.
Thanks for the response,
I updated the patch with a approach that you suggested - now
`Sema::CreateOverloadedBinOp` isn't called in C mode (I have an assertion for
this in `Sema::C
Author: arphaman
Date: Tue Oct 4 11:06:37 2016
New Revision: 283228
URL: http://llvm.org/viewvc/llvm-project?rev=283228&view=rev
Log:
[Sema] Format a comment line so that it fits 80 columns. NFC
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
arphaman added a comment.
Thanks for working on this!
This patch fixes a couple of our internal warnings that shouldn't be presented.
I included a code sample that reproduces our warnings, would you mind adding
some code to the test case that's similar to the sample below?
typedef str
arphaman added a comment.
In https://reviews.llvm.org/D23657#560938, @arphaman wrote:
> Btw, slightly off-topic, but I noticed that the declaration
> `DiagnoseMisalignedMembers` in the header has a doc comment that violates the
> 80 chars rule. I committed a fix in r283228.
I meant to say `Di
Author: arphaman
Date: Wed Oct 5 04:27:48 2016
New Revision: 283304
URL: http://llvm.org/viewvc/llvm-project?rev=283304&view=rev
Log:
[Sema] Packed member warning: Use the typedef name for anonymous structures
This commit improves the packed member warning by showing the name of the
anonymous st
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283304: [Sema] Packed member warning: Use the typedef name
for anonymous structures (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25106?vs=73338&id=73611#toc
Repository:
arphaman created this revision.
arphaman added a reviewer: aaron.ballman.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a crash that happens when clang is analyzing a
transparent_union attribute on a union which has a field wi
Author: arphaman
Date: Thu Oct 6 04:37:15 2016
New Revision: 283428
URL: http://llvm.org/viewvc/llvm-project?rev=283428&view=rev
Log:
Fix PR30440: Initialize FunctionTypeDepth in CXXNameMangler
This commit fixes PR 30440 by initializing CXXNameMangler's FunctionTypeDepth
in the two constructors
Author: arphaman
Date: Thu Oct 6 04:47:29 2016
New Revision: 283432
URL: http://llvm.org/viewvc/llvm-project?rev=283432&view=rev
Log:
[Sema] Fix PR30520: Handle incomplete field types in transparent_union unions
This commit fixes a crash that happens when clang is analyzing a
transparent_union a
101 - 200 of 638 matches
Mail list logo
