Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-04 Thread Alex L via cfe-commits
On 3 May 2017 at 22:23, Richard Smith wrote: > On 3 May 2017 at 07:29, Alex L wrote: > >> Hi Richard, >> >> This commit has caused an infinite loop in one of our internal libclang >> based tooling tests. It keeps repeating the following frames: >> >> frame #33528: 0x000109db2edf libclang

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-04 Thread Alex L via cfe-commits
On 4 May 2017 at 12:43, Alex L wrote: > > > On 3 May 2017 at 22:23, Richard Smith wrote: > >> On 3 May 2017 at 07:29, Alex L wrote: >> >>> Hi Richard, >>> >>> This commit has caused an infinite loop in one of our internal libclang >>> based tooling tests. It keeps repeating the following frames

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-04 Thread Alex L via cfe-commits
On 4 May 2017 at 12:52, Alex L wrote: > > > On 4 May 2017 at 12:43, Alex L wrote: > >> >> >> On 3 May 2017 at 22:23, Richard Smith wrote: >> >>> On 3 May 2017 at 07:29, Alex L wrote: >>> Hi Richard, This commit has caused an infinite loop in one of our internal libclang bas

Re: r302677 - [libclang] Introduce clang_Cursor_isExternalSymbol that provides info about decls marked with external_source_symbol attribute

2017-05-10 Thread Alex L via cfe-commits
On 10 May 2017 at 16:10, Argyrios Kyrtzidis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: akirtzidis > Date: Wed May 10 10:10:36 2017 > New Revision: 302677 > > URL: http://llvm.org/viewvc/llvm-project?rev=302677&view=rev > Log: > [libclang] Introduce clang_Cursor_isExternalSymbol

Re: r285289 - [Sema] -Wunused-variable warning for array variables should behave

2016-11-01 Thread Alex L via cfe-commits
On 31 October 2016 at 15:34, David Blaikie wrote: > > > On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: arphaman >> Date: Thu Oct 27 08:30:51 2016 >> New Revision: 285289 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=285289&view

Re: r285289 - [Sema] -Wunused-variable warning for array variables should behave

2016-11-01 Thread Alex L via cfe-commits
On 1 November 2016 at 10:13, Alex L wrote: > > On 31 October 2016 at 15:34, David Blaikie wrote: > >> >> >> On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: arphaman >>> Date: Thu Oct 27 08:30:51 2016 >>> New Revision: 285289 >>>

Re: r285289 - [Sema] -Wunused-variable warning for array variables should behave

2016-11-02 Thread Alex L via cfe-commits
On 1 November 2016 at 14:22, David Blaikie wrote: > > > On Tue, Nov 1, 2016 at 3:13 AM Alex L wrote: > >> On 31 October 2016 at 15:34, David Blaikie wrote: >> >> >> >> On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >> Author: arphaman >> D

Re: [PATCH] D25816: Use descriptive message if list initializer is incorrectly parenthesized.

2016-11-11 Thread Alex L via cfe-commits
I think you can go ahead and commit it, yes. Alex On 11 November 2016 at 05:28, Serge Pavlov wrote: > Is it OK to commit this patch? > > Thanks, > --Serge > > 2016-10-21 18:21 GMT+07:00 Alex Lorenz : > >> arphaman added a subscriber: rsmith. >> arphaman added a comment. >> >> LGTM, I added Rich

<    1   2