[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

2022-08-19 Thread Alecto Irene Perez via Phabricator via cfe-commits
alecto created this revision. alecto added reviewers: Richard, smith. Herald added a project: All. alecto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/57180 Given configuration: Separ

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

2022-08-21 Thread Alecto Irene Perez via Phabricator via cfe-commits
alecto updated this revision to Diff 454343. alecto added a comment. Revise based on feedback from Björn Schäpers We updated the version tag to 16 and positioned the DefinitionBLockSpacing field alphabetically. We also updated the documentation with `clang/docs/tools/dump_format_style.py` Repo

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

2022-08-21 Thread Alecto Irene Perez via Phabricator via cfe-commits
alecto added a comment. In D132256#3736076 , @HazardyKnusperkeks wrote: > Do we want to define the behavior of `MaxEmptyLinesToKeep < > DefinitionBlockSpacing`? Then we need tests for that! > Tests with `MaxEmptyLinesToKeep < DefinitionBlockSpacing` and

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

2022-08-22 Thread Alecto Irene Perez via Phabricator via cfe-commits
alecto added a comment. If possible I would like to error out if MaxEmptyLinesToKeep < DefinitionBlockSpacing, because that case is probably a mistake on the part of the user, and a failure would be better than clang-format silently doing something unexpected, but I'm not sure where to put the