[llvm] [clang] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

@@ -232,19 +232,19 @@ static Value *MakeBinaryAtomicValue( static Value *EmitNontemporalStore(CodeGenFunction &CGF, const CallExpr *E) { Value *Val = CGF.EmitScalarExpr(E->getArg(0)); - Value *Address = CGF.EmitScalarExpr(E->getArg(1)); + Address Addr = CGF.EmitPointerWith

[clang] [CodeGen] Emit a more accurate alignment for non-temporal loads/stores (PR #75675)

https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/75675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Disable missing definition warning on pure virtual functions (PR #74510)

ahatanak wrote: Any progress on this patch? As we discussed in https://github.com/llvm/llvm-project/issues/74016, we should make sure clang doesn't stop emitting the warning when the definition of a pure virtual function is actually needed. It seems to me that we shouldn't set `NeededForConst

[clang] 350d43f - Fix a bug where an extended vector of __fp16 was being converted to a

Author: Akira Hatanaka Date: 2022-03-24T18:06:10-07:00 New Revision: 350d43f1efd711d057cdb53decabb6f32491dff0 URL: https://github.com/llvm/llvm-project/commit/350d43f1efd711d057cdb53decabb6f32491dff0 DIFF: https://github.com/llvm/llvm-project/commit/350d43f1efd711d057cdb53decabb6f32491dff0.diff

[clang] aa4ea0e - [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in a couple

Author: Akira Hatanaka Date: 2022-03-11T09:30:31-08:00 New Revision: aa4ea0ee54411d12d17dd6261f64726913f15e16 URL: https://github.com/llvm/llvm-project/commit/aa4ea0ee54411d12d17dd6261f64726913f15e16 DIFF: https://github.com/llvm/llvm-project/commit/aa4ea0ee54411d12d17dd6261f64726913f15e16.diff

[clang] 818e72d - [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in

Author: Akira Hatanaka Date: 2022-03-22T18:39:16-07:00 New Revision: 818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db URL: https://github.com/llvm/llvm-project/commit/818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db DIFF: https://github.com/llvm/llvm-project/commit/818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db.diff

[clang] 3b578ae - [Driver] Call hasFlag instead of hasArg

Author: Akira Hatanaka Date: 2022-04-22T20:14:50-07:00 New Revision: 3b578ae9088caf08932dc7d18e87d2a17fb4f7a8 URL: https://github.com/llvm/llvm-project/commit/3b578ae9088caf08932dc7d18e87d2a17fb4f7a8 DIFF: https://github.com/llvm/llvm-project/commit/3b578ae9088caf08932dc7d18e87d2a17fb4f7a8.diff

[clang] a62868a - [libclang][ObjC] Inherit availability attribute from containing decls or

Author: Akira Hatanaka Date: 2022-07-19T09:17:39-07:00 New Revision: a62868aaeaac1c6464a3acbc90209458e4594338 URL: https://github.com/llvm/llvm-project/commit/a62868aaeaac1c6464a3acbc90209458e4594338 DIFF: https://github.com/llvm/llvm-project/commit/a62868aaeaac1c6464a3acbc90209458e4594338.diff

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

ahatanak wrote: Any other comments? Do the changes look good? https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Don't drop weak_import from a declaration that follows a declaration directly contained in a linkage-specification (PR #85886)

https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/85886 Only drop it if the declaration follows a definition. I believe this is what 33e022650adee965c65f9aea086ee74f3fd1bad5 was trying to do. rdar://61865848 >From 1ccbc2e2a3bdf127f5baeb22123c67428da4e656 Mon Sep 17

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -triple arm64-apple-ios -std=c++20 -emit-llvm -debug-info-kind=limited %s -o - | FileCheck %s ahatanak wrote: https://llvm.org/docs/TestingGuide.html#best-practices-for-regression-tests recommends we run a minimal set of pas

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 01/11] Add support for builtin_verbose_trap The builtin causes

[clang] Disable driver tests on macosx that are currently disabled on darwin (PR #85990)

https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/85990 macosx and darwin in triples are equivalent. rdar://124246653 >From 8a576b862aef20fd857ea4c9be8d1fdf7c0d8e4b Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Wed, 20 Mar 2024 11:57:03 -0700 Subject: [PATCH]

[clang] Disable driver tests on macosx that are currently disabled on darwin (PR #85990)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/85990 >From ae75aa6994ebc9d2daaa5fcc4cb18bd857214291 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Wed, 20 Mar 2024 11:57:03 -0700 Subject: [PATCH] Disable driver tests on macosx that are currently disabled on

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 01/12] Add support for builtin_verbose_trap The builtin causes

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -triple arm64-apple-ios -std=c++20 -emit-llvm -debug-info-kind=limited %s -o - | FileCheck %s ahatanak wrote: In that case, we can use `-disable-llvm-passes` or `-disable-llvm-optzns` to avoid running the llvm optimization p

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -3424,6 +3445,26 @@ llvm::DIMacroFile *CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent, return DBuilder.createTempMacroFile(Parent, Line, FName); } +llvm::DILocation *CGDebugInfo::CreateTrapFailureMessageFor( ahatanak wrote: @dwblaikie what d

[clang] Disable driver tests on macosx that are currently disabled on darwin (PR #85990)

https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/85990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Don't drop weak_import from a declaration that follows a declaration directly contained in a linkage-specification (PR #85886)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/85886 >From d39667c7e65c10babb478d8f8d54fecb66d90568 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 19 Mar 2024 15:50:00 -0700 Subject: [PATCH] [Sema] Don't drop weak_import from a declaration that follows

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -3379,6 +3379,60 @@ Query for this feature with ``__has_builtin(__builtin_debugtrap)``. Query for this feature with ``__has_builtin(__builtin_trap)``. +``__builtin_verbose_trap`` ahatanak wrote: It doesn't look like the existing builtins are in lexicogra

[clang] [llvm] Revert "[CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (#67454)" (PR #86674)

https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/86674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #86721)

https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/86721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (#86721)" (PR #86898)

https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/86898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #86923)

https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/86923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #86923)

ahatanak wrote: I plan to file a bug or notify the authors of the code of the potential bug once I have a better understanding of the problem. FYI, the code was crashing because the lvalue passed to `OpaqueValueMappingData::bind` had a larger alignment than the alignment of the type passed to

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

@@ -338,6 +409,69 @@ static QualType getCoroutineSuspendExprReturnType(const ASTContext &Ctx, } #endif +llvm::Function * +CodeGenFunction::generateAwaitSuspendWrapper(Twine const &CoroName, + Twine const &SuspendPointName, +

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #86923)

ahatanak wrote: Left a comment here: https://github.com/llvm/llvm-project/pull/79712/files#r1544153100 https://github.com/llvm/llvm-project/pull/86923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [coroutine] Fix type of an ImplicitParamDecl used in generateAwaitSuspendWrapper (PR #87134)

https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/87134 Use the correct type for AwaiterDecl instead of using `void *`. See the discussion here: https://github.com/llvm/llvm-project/pull/79712#discussion_r1544153100 >From 0f3f51dfe8a63c76c7d006511a8f329526123f54 Mon

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

@@ -338,6 +409,69 @@ static QualType getCoroutineSuspendExprReturnType(const ASTContext &Ctx, } #endif +llvm::Function * +CodeGenFunction::generateAwaitSuspendWrapper(Twine const &CoroName, + Twine const &SuspendPointName, +

[clang] [coroutine] Fix type of an ImplicitParamDecl used in generateAwaitSuspendWrapper (PR #87134)

ahatanak wrote: I don't have a test case yet. I'll see if I can come up with one. https://github.com/llvm/llvm-project/pull/87134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 44813fefa59b442abcc6cb23c2ac8d3f78e44efc Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 01/11] Add support for builtin_verbose_trap The builtin causes

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 44813fefa59b442abcc6cb23c2ac8d3f78e44efc Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 01/12] Add support for builtin_verbose_trap The builtin causes

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -3424,6 +3445,26 @@ llvm::DIMacroFile *CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent, return DBuilder.createTempMacroFile(Parent, Line, FName); } +llvm::DILocation *CGDebugInfo::CreateTrapFailureMessageFor( ahatanak wrote: @dwblaikie any co

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

ahatanak wrote: I'm not sure `extractRawPointerFromAddress` conveys the fact that the function might do code-gen instead of just returning some pointer. I wonder if there's a better name. `computeRawPointerFromAddress` `genRawPointerFromAddress` `generateRawPointerFromAddress` `codeGenRawPoint

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

ahatanak wrote: Maybe `emitRawPointerFromAddress` is better. I see a lot of functions starting with `emit` in CodeGen. https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

ahatanak wrote: ping https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -346,6 +348,15 @@ class CGDebugInfo { const FieldDecl *BitFieldDecl, const llvm::DIDerivedType *BitFieldDI, llvm::ArrayRef PreviousFieldsDI, const RecordDecl *RD); + // A cache that maps artificial inlined function names used for + // __builtin_verbose_trap to

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -3424,6 +3443,26 @@ llvm::DIMacroFile *CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent, return DBuilder.createTempMacroFile(Parent, Line, FName); } +llvm::DILocation * +CGDebugInfo::CreateTrapFailureMessageFor(llvm::DebugLoc TrapLocation, +

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -3424,6 +3443,26 @@ llvm::DIMacroFile *CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent, return DBuilder.createTempMacroFile(Parent, Line, FName); } +llvm::DILocation * +CGDebugInfo::CreateTrapFailureMessageFor(llvm::DebugLoc TrapLocation, +

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -triple arm64-apple-ios -std=c++20 -emit-llvm -debug-info-kind=limited %s -o - | FileCheck %s ahatanak wrote: Do we want to add a clang test? I thought we generally don't enable optimization in clang CodeGen tests because it

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -3452,6 +3452,18 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__builtin_trap: EmitTrapCall(Intrinsic::trap); return RValue::get(nullptr); + case Builtin::BI__builtin_verbose_trap: { +llvm::DILocation *Tra

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -triple arm64-apple-ios -std=c++20 -emit-llvm -debug-info-kind=limited %s -o - | FileCheck %s + +// CHECK-LABEL: define void @_Z2f0v() +// CHECK: call void @llvm.trap(), !dbg ![[LOC17:.*]] + +// CHECK-LABEL: define void @_Z2f1v() +// CHECK: ca

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/9] Add support for builtin_verbose_trap The builtin causes th

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/7] Add support for builtin_verbose_trap The builtin causes th

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/8] Add support for builtin_verbose_trap The builtin causes th

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/79230 The builtin causes the program to stop its execution abnormally and shows a human-readable description of the reason for the termination when a debugger is attached or in a symbolicated crash log. The motivati

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 92c9fccde29eec10c775fd86b9cf625987e7929d Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/2] Add support for builtin_verbose_trap The builtin causes th

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 92c9fccde29eec10c775fd86b9cf625987e7929d Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/3] Add support for builtin_verbose_trap The builtin causes th

[clang] Add option -fstdlib-hardening= (PR #78763)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/78763 >From 0d68286bd8b7206c5045062f65ccaf1c3fb54714 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Thu, 18 Jan 2024 16:20:41 -0800 Subject: [PATCH 1/5] Add option -fstdlib-hardening= The option allows users to

[clang] Add option -fstdlib-hardening= (PR #78763)

https://github.com/ahatanak edited https://github.com/llvm/llvm-project/pull/78763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -3416,6 +3437,27 @@ llvm::DIMacroFile *CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent, return DBuilder.createTempMacroFile(Parent, Line, FName); } +llvm::DILocation *CGDebugInfo::CreateTrapFailureMessageFor( +llvm::DebugLoc TrapLocation, StringRef Prefix,

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif ahatanak wrote: This just makes sure the builtin is supported unconditionally and doesn't depend on some featu

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -3416,6 +3437,27 @@ llvm::DIMacroFile *CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent, return DBuilder.createTempMacroFile(Parent, Line, FName); } +llvm::DILocation *CGDebugInfo::CreateTrapFailureMessageFor( +llvm::DebugLoc TrapLocation, StringRef Prefix,

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/3] Add support for builtin_verbose_trap The builtin causes th

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/4] Add support for builtin_verbose_trap The builtin causes th

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak edited https://github.com/llvm/llvm-project/pull/79230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/5] Add support for builtin_verbose_trap The builtin causes th

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,29 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[clang] Add support for builtin_verbose_trap (PR #79230)

@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[clang] Add support for builtin_verbose_trap (PR #79230)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/6] Add support for builtin_verbose_trap The builtin causes th

[clang] Add option -fstdlib-hardening= (PR #78763)

https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/78763 The option allows users to enable libc++ hardening, which was discussed in the following RFC: https://discourse.llvm.org/t/rfc-hardening-in-libc/73925 Users specifiy the hardening mode by passing one of the fo

[clang] Add option -fstdlib-hardening= (PR #78763)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/78763 >From 0d68286bd8b7206c5045062f65ccaf1c3fb54714 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Thu, 18 Jan 2024 16:20:41 -0800 Subject: [PATCH 1/2] Add option -fstdlib-hardening= The option allows users to

[clang] Add option -fstdlib-hardening= (PR #78763)

https://github.com/ahatanak edited https://github.com/llvm/llvm-project/pull/78763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add option -fstdlib-hardening= (PR #78763)

@@ -7730,6 +7730,14 @@ def source_date_epoch : Separate<["-"], "source-date-epoch">, } // let Visibility = [CC1Option] +def stdlib_hardening_EQ : Joined<["-"], "fstdlib-hardening=">, + Values<"none,fast,extensive,debug">, + NormalizedValues<["STDLIB_HARDENING_MODE_NONE",

[clang] Add option -fstdlib-hardening= (PR #78763)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/78763 >From 0d68286bd8b7206c5045062f65ccaf1c3fb54714 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Thu, 18 Jan 2024 16:20:41 -0800 Subject: [PATCH 1/3] Add option -fstdlib-hardening= The option allows users to

[clang] Add option -fstdlib-hardening= (PR #78763)

https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/78763 >From 0d68286bd8b7206c5045062f65ccaf1c3fb54714 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Thu, 18 Jan 2024 16:20:41 -0800 Subject: [PATCH 1/4] Add option -fstdlib-hardening= The option allows users to

r371276 - [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership

Author: ahatanak Date: Fri Sep 6 17:34:47 2019 New Revision: 371276 URL: http://llvm.org/viewvc/llvm-project?rev=371276&view=rev Log: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header r365985 stopped ma

r371275 - [Sema] Diagnose default-initialization, destruction, and copying of

Author: ahatanak Date: Fri Sep 6 17:34:43 2019 New Revision: 371275 URL: http://llvm.org/viewvc/llvm-project?rev=371275&view=rev Log: [Sema] Diagnose default-initialization, destruction, and copying of non-trivial C union types This recommits r365985, which was reverted because it broke a few pr

r309607 - [Driver] Allow users to silence the warning that is issued when the

Author: ahatanak Date: Mon Jul 31 12:16:40 2017 New Revision: 309607 URL: http://llvm.org/viewvc/llvm-project?rev=309607&view=rev Log: [Driver] Allow users to silence the warning that is issued when the deployment target is earlier than iOS 11 and the target is 32-bit. This is a follow-up to r306

r309633 - [Driver] Make sure the deployment target is earlier than iOS 11 when

Author: ahatanak Date: Mon Jul 31 15:19:34 2017 New Revision: 309633 URL: http://llvm.org/viewvc/llvm-project?rev=309633&view=rev Log: [Driver] Make sure the deployment target is earlier than iOS 11 when it is inferred from -isysroot. This fixes a change that was inadvertently introduced in r3096

r309636 - Silence warning -Wmissing-sysroot.

Author: ahatanak Date: Mon Jul 31 15:46:00 2017 New Revision: 309636 URL: http://llvm.org/viewvc/llvm-project?rev=309636&view=rev Log: Silence warning -Wmissing-sysroot. Modified: cfe/trunk/test/Driver/darwin-version.c Modified: cfe/trunk/test/Driver/darwin-version.c URL: http://llvm.org/vi

r309640 - Use -target instead of -arch in test case.

Author: ahatanak Date: Mon Jul 31 16:08:52 2017 New Revision: 309640 URL: http://llvm.org/viewvc/llvm-project?rev=309640&view=rev Log: Use -target instead of -arch in test case. Modified: cfe/trunk/test/Driver/darwin-version.c Modified: cfe/trunk/test/Driver/darwin-version.c URL: http://llv

r310006 - [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions.

Author: ahatanak Date: Thu Aug 3 16:55:42 2017 New Revision: 310006 URL: http://llvm.org/viewvc/llvm-project?rev=310006&view=rev Log: [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions. This commit fixes a bug where clang/llvm doesn't emit an unwind table for a function when it is mark

r310672 - [Sema][ObjC] Fix spurious -Wcast-qual warnings.

Author: ahatanak Date: Thu Aug 10 17:06:49 2017 New Revision: 310672 URL: http://llvm.org/viewvc/llvm-project?rev=310672&view=rev Log: [Sema][ObjC] Fix spurious -Wcast-qual warnings. We do not meaningfully track object const-ness of Objective-C object types. Silence the -Wcast-qual warning that i

Re: r309607 - [Driver] Allow users to silence the warning that is issued when the

Can we merge this to 5.0? > On Jul 31, 2017, at 12:16 PM, Akira Hatanaka via cfe-commits > wrote: > > Author: ahatanak > Date: Mon Jul 31 12:16:40 2017 > New Revision: 309607 > > URL: http://llvm.org/viewvc/llvm-project?rev=309607&view=rev > Log: > [Driver]

Re: r309607 - [Driver] Allow users to silence the warning that is issued when the

Forgot to mention there are three other patches that are needed to fix the bug introduced in r309607 (r309633, r309636 and r309640). > On Aug 10, 2017, at 5:25 PM, Akira Hatanaka via cfe-commits > wrote: > > Can we merge this to 5.0? > >> On Jul 31, 2017, at 12:16 PM, A

Re: r310006 - [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions.

Can we merge this one to 5.0 too? > On Aug 3, 2017, at 4:55 PM, Akira Hatanaka via cfe-commits > wrote: > > Author: ahatanak > Date: Thu Aug 3 16:55:42 2017 > New Revision: 310006 > > URL: http://llvm.org/viewvc/llvm-project?rev=310006&view=rev > Log: > [D

Re: r310672 - [Sema][ObjC] Fix spurious -Wcast-qual warnings.

Hans, is it okay to merge this to 5.0? > On Aug 10, 2017, at 5:06 PM, Akira Hatanaka via cfe-commits > wrote: > > Author: ahatanak > Date: Thu Aug 10 17:06:49 2017 > New Revision: 310672 > > URL: http://llvm.org/viewvc/llvm-project?rev=310672&view=rev > Log: >

r311397 - [Driver][Darwin] Do not pass -munwind-table if -fno-excpetions is

Author: ahatanak Date: Mon Aug 21 15:46:46 2017 New Revision: 311397 URL: http://llvm.org/viewvc/llvm-project?rev=311397&view=rev Log: [Driver][Darwin] Do not pass -munwind-table if -fno-excpetions is supplied. With this change, -fno-exceptions disables unwind tables unless -funwind-tables is sup

Re: r311397 - [Driver][Darwin] Do not pass -munwind-table if -fno-excpetions is

Hans, can this be merged to 5.0 too? This is a follow-up to r310006. Thanks. > On Aug 21, 2017, at 3:46 PM, Akira Hatanaka via cfe-commits > wrote: > > Author: ahatanak > Date: Mon Aug 21 15:46:46 2017 > New Revision: 311397 > > URL: http://llvm.org/viewvc/llvm-pro

Re: [libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

This change makes it impossible to change the visibility of operator+ with -fvisibility=hidden, which is not desirable on Darwin. For example: $ cat test.cpp #include using namespace std; string foo1(string s) { return "abc" + s; } $ clang++ test.cpp -fvisibility=hidden -c; nm -m -a test.o

Re: [libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

Ah I see. I think r309474 should fix our problem. Thanks for your quick response. > On Aug 22, 2017, at 6:28 PM, Shoaib Meenai wrote: > > The point of the extern template was to prevent that operator from being > defined in any other object files. The extern template wasn't taking effect > be

[clang] c6fd16a - Use FileCheck instead of grep

Author: Akira Hatanaka Date: 2020-01-06T15:50:23-08:00 New Revision: c6fd16af2be98b49d663285e3808ecde61bec614 URL: https://github.com/llvm/llvm-project/commit/c6fd16af2be98b49d663285e3808ecde61bec614 DIFF: https://github.com/llvm/llvm-project/commit/c6fd16af2be98b49d663285e3808ecde61bec614.diff

[clang] 20f005d - [CodeGen][ObjC] Push the properties of a protocol before pushing the

Author: Akira Hatanaka Date: 2020-01-06T16:16:02-08:00 New Revision: 20f005d25f488fa1dc69d6792700e014c6a5d165 URL: https://github.com/llvm/llvm-project/commit/20f005d25f488fa1dc69d6792700e014c6a5d165 DIFF: https://github.com/llvm/llvm-project/commit/20f005d25f488fa1dc69d6792700e014c6a5d165.diff

Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

> On Jan 7, 2020, at 2:45 PM, Ben D. Jones via Phabricator via cfe-commits > wrote: > > bendjones added a comment. > > In D70284#1752806 , @bendjones wrote: > >> Any additional thoughts @dexonsmith @erik.pilkington @ahatanak? > > > @dexonsmith @erik.p

[clang] 64bb582 - Fix the type of the invoke function in the block ABI documentation

Author: Akira Hatanaka Date: 2020-09-04T10:29:09-07:00 New Revision: 64bb582f4a07d7195a6e6a44a34d166a06f0f071 URL: https://github.com/llvm/llvm-project/commit/64bb582f4a07d7195a6e6a44a34d166a06f0f071 DIFF: https://github.com/llvm/llvm-project/commit/64bb582f4a07d7195a6e6a44a34d166a06f0f071.diff

[clang] 874b0a0 - [CodeGen] Mark calls to objc_autorelease as tail

Author: Akira Hatanaka Date: 2020-11-10T13:48:25-08:00 New Revision: 874b0a0b9db93f5d3350ffe6b5efda2d908415d0 URL: https://github.com/llvm/llvm-project/commit/874b0a0b9db93f5d3350ffe6b5efda2d908415d0 DIFF: https://github.com/llvm/llvm-project/commit/874b0a0b9db93f5d3350ffe6b5efda2d908415d0.diff

[clang] d9258a2 - Fix the data layout mangling specification for 'arm64-pc-win32-macho'

Author: Akira Hatanaka Date: 2020-11-10T18:52:12-08:00 New Revision: d9258a21f03811a9e231c2ec338822de84d55eef URL: https://github.com/llvm/llvm-project/commit/d9258a21f03811a9e231c2ec338822de84d55eef DIFF: https://github.com/llvm/llvm-project/commit/d9258a21f03811a9e231c2ec338822de84d55eef.diff

[clang] 21cf2e6 - Handle unknown OSes in DarwinTargetInfo::getExnObjectAlignment

Author: Akira Hatanaka Date: 2020-09-30T16:05:17-07:00 New Revision: 21cf2e6c263d7a50654653bce4e83ab463fae580 URL: https://github.com/llvm/llvm-project/commit/21cf2e6c263d7a50654653bce4e83ab463fae580 DIFF: https://github.com/llvm/llvm-project/commit/21cf2e6c263d7a50654653bce4e83ab463fae580.diff

[clang] b78045c - Add a C++ test case for https://reviews.llvm.org/D86854

Author: Akira Hatanaka Date: 2020-10-20T07:34:38-07:00 New Revision: b78045c2ce2dba9b43c0e48340c2a69e444386ec URL: https://github.com/llvm/llvm-project/commit/b78045c2ce2dba9b43c0e48340c2a69e444386ec DIFF: https://github.com/llvm/llvm-project/commit/b78045c2ce2dba9b43c0e48340c2a69e444386ec.diff

[clang] 3d349ed - [CodeGen][ObjC] Fix broken IR generated when there is a nil receiver

Author: Akira Hatanaka Date: 2021-01-21T17:38:46-08:00 New Revision: 3d349ed7e1108686271a09314dafaa356df4006d URL: https://github.com/llvm/llvm-project/commit/3d349ed7e1108686271a09314dafaa356df4006d DIFF: https://github.com/llvm/llvm-project/commit/3d349ed7e1108686271a09314dafaa356df4006d.diff

[clang] 53176c1 - [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV

Author: Akira Hatanaka Date: 2021-01-25T11:57:08-08:00 New Revision: 53176c168061d6f26dcf3ce4fa59288b7d67255e URL: https://github.com/llvm/llvm-project/commit/53176c168061d6f26dcf3ce4fa59288b7d67255e DIFF: https://github.com/llvm/llvm-project/commit/53176c168061d6f26dcf3ce4fa59288b7d67255e.diff

[clang] aade0ec - Fix the guaranteed alignment of memory returned by malloc/new on Darwin

Author: Akira Hatanaka Date: 2021-02-03T19:40:51-08:00 New Revision: aade0ec23b5986a9c478c4093d029a5db8a2c012 URL: https://github.com/llvm/llvm-project/commit/aade0ec23b5986a9c478c4093d029a5db8a2c012 DIFF: https://github.com/llvm/llvm-project/commit/aade0ec23b5986a9c478c4093d029a5db8a2c012.diff

[clang] 3fe3946 - [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly

Author: Akira Hatanaka Date: 2021-02-05T05:55:18-08:00 New Revision: 3fe3946d9a958b7af6130241996d9cfcecf559d4 URL: https://github.com/llvm/llvm-project/commit/3fe3946d9a958b7af6130241996d9cfcecf559d4 DIFF: https://github.com/llvm/llvm-project/commit/3fe3946d9a958b7af6130241996d9cfcecf559d4.diff

[clang] 2fbbb18 - Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly"

Author: Akira Hatanaka Date: 2021-02-05T06:00:05-08:00 New Revision: 2fbbb18c1dbeb124dfc3c2aebae97d4780ff9bd6 URL: https://github.com/llvm/llvm-project/commit/2fbbb18c1dbeb124dfc3c2aebae97d4780ff9bd6 DIFF: https://github.com/llvm/llvm-project/commit/2fbbb18c1dbeb124dfc3c2aebae97d4780ff9bd6.diff

<    1   2   3   4   5   6   7   8   9   10   >